From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02ECEC433E6 for ; Fri, 5 Feb 2021 05:59:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AB63A64E05 for ; Fri, 5 Feb 2021 05:59:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230406AbhBEF7h (ORCPT ); Fri, 5 Feb 2021 00:59:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56602 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230075AbhBEF7b (ORCPT ); Fri, 5 Feb 2021 00:59:31 -0500 Received: from mail-qk1-x72d.google.com (mail-qk1-x72d.google.com [IPv6:2607:f8b0:4864:20::72d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E3136C06178B for ; Thu, 4 Feb 2021 21:58:50 -0800 (PST) Received: by mail-qk1-x72d.google.com with SMTP id k193so5879960qke.6 for ; Thu, 04 Feb 2021 21:58:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=SZ0GQLJipF2hQIt0oYg/b3YND75QYohdSOPgCgGvmtI=; b=oPGsTQx7+FdG6LRGl1TD3o+RbriHfudMdPEUWdoVcGtiFVzJyADmDY4/qjjG1+UIcy wjKL99cqQfoIL+mWKhEojF7j3xy7b/FwNrgzFcnaC4VE2BI5tBDFbEYcfnximoQpd7Bo foetOy+pvkseCt44S1+fCOI+yg3iGoGzvmkUU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=SZ0GQLJipF2hQIt0oYg/b3YND75QYohdSOPgCgGvmtI=; b=jiL+KGOOpfrGW1ltdFIbtHerFqvI4licC166/ZbkwWxecR5OEcpSc6wgpUc8p4d0Fn E8d2JFyJRJZe/viA+Mc2WYePWPtZK+0e5EZfVC2HPyLbH9ceTuu3KZe0aY9HCSIlUYNL I24Shi0qT1mtAHVvbbWPQYtgf443ISh1B+uylUQt1VKlxFEIclQuMRfaaJTrHIf70YTB Dxn5fmW6Y6FD1d+h/BfMgnjA1RFJOIYxpZe36D16BTLKRGCCXXwLftN0rwR6/IQ/RjtO 9pn9Y5lRLKgamNCDS8CFFZTwVXbsRffTnntMKgdBhvEGT9Q8PzU3dCRN5vSSvWAwNZHk Ya+w== X-Gm-Message-State: AOAM533Gy0bS4sBGcd6YAnKZWo9i2sP6vCm0qxXtECKyFtUuH00r+Uvg JOrMVe17Xwai1FWWKM0c1S4sAjsDEQSGGdUJQECPpQ== X-Google-Smtp-Source: ABdhPJwYA73lftjBriOP+37YGUdH+MFOawlYakwpkyiHcFfBQsl9Chfbewfaer8b9y41czh2lCGjkNZ6cshLgPPsL0I= X-Received: by 2002:a37:73c3:: with SMTP id o186mr2728785qkc.194.1612504730031; Thu, 04 Feb 2021 21:58:50 -0800 (PST) MIME-Version: 1.0 References: <20210128060515.1732758-1-stevensd@google.com> In-Reply-To: From: David Stevens Date: Fri, 5 Feb 2021 14:58:38 +0900 Message-ID: Subject: Re: [PATCH v3 0/2] KVM: x86/mmu: Skip mmu_notifier changes when possible To: Paolo Bonzini Cc: Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , kvm@vger.kernel.org, open list , Marc Zyngier , James Morse , Julien Thierry , Suzuki K Poulose , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, Huacai Chen , Aleksandar Markovic , linux-mips@vger.kernel.org, Paul Mackerras , kvm-ppc@vger.kernel.org, Christian Borntraeger , Janosch Frank , David Hildenbrand , Cornelia Huck , Claudio Imbrenda , David Stevens Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org These patches might be responsible for some instability in one of our stress tests. I'll send an update once I figure out what's going on. Thanks, David On Thu, Jan 28, 2021 at 9:48 PM Paolo Bonzini wrote: > > On 28/01/21 07:05, David Stevens wrote: > > These patches reduce how often mmu_notifier updates block guest page > > faults. The primary benefit of this is the reduction in the likelihood > > of extreme latency when handling a page fault due to another thread > > having been preempted while modifying host virtual addresses. > > > > v2 -> v3: > > - Added patch to skip check for MMIO page faults > > - Style changes > > > > David Stevens (1): > > KVM: x86/mmu: Consider the hva in mmu_notifier retry > > > > Sean Christopherson (1): > > KVM: x86/mmu: Skip mmu_notifier check when handling MMIO page fault > > > > arch/powerpc/kvm/book3s_64_mmu_hv.c | 2 +- > > arch/powerpc/kvm/book3s_64_mmu_radix.c | 2 +- > > arch/x86/kvm/mmu/mmu.c | 16 ++++++++------ > > arch/x86/kvm/mmu/paging_tmpl.h | 7 ++++--- > > include/linux/kvm_host.h | 25 +++++++++++++++++++++- > > virt/kvm/kvm_main.c | 29 ++++++++++++++++++++++---- > > 6 files changed, 65 insertions(+), 16 deletions(-) > > > > Queued, thanks. > > Paolo > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70D44C433E6 for ; Fri, 5 Feb 2021 09:26:19 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id B524964FBE for ; Fri, 5 Feb 2021 09:26:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B524964FBE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvmarm-bounces@lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 37F8C4B3B9; Fri, 5 Feb 2021 04:26:18 -0500 (EST) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@chromium.org Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Y7SA0J9T5klV; Fri, 5 Feb 2021 04:26:17 -0500 (EST) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id E46294B38F; Fri, 5 Feb 2021 04:26:14 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 9264F4B309 for ; Fri, 5 Feb 2021 00:58:51 -0500 (EST) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0bMegk3tEyjZ for ; Fri, 5 Feb 2021 00:58:50 -0500 (EST) Received: from mail-qk1-f180.google.com (mail-qk1-f180.google.com [209.85.222.180]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id 58CE94B2C8 for ; Fri, 5 Feb 2021 00:58:50 -0500 (EST) Received: by mail-qk1-f180.google.com with SMTP id u20so5886996qku.7 for ; Thu, 04 Feb 2021 21:58:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=SZ0GQLJipF2hQIt0oYg/b3YND75QYohdSOPgCgGvmtI=; b=oPGsTQx7+FdG6LRGl1TD3o+RbriHfudMdPEUWdoVcGtiFVzJyADmDY4/qjjG1+UIcy wjKL99cqQfoIL+mWKhEojF7j3xy7b/FwNrgzFcnaC4VE2BI5tBDFbEYcfnximoQpd7Bo foetOy+pvkseCt44S1+fCOI+yg3iGoGzvmkUU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=SZ0GQLJipF2hQIt0oYg/b3YND75QYohdSOPgCgGvmtI=; b=QA0qJ3a9sOcjZLdDyhykimHdHLXeDastX7xU4T41GjjJNPniE9awu/33myfq3DKI+b PEyTsOlR+kRKDLbib/VWnsGZkBQpzll2KA/tr18P66W8ySyk6IrMrKmNx833EFYBi832 tqQOW0K4kjMoV4BvK3oTpoZRQE39W7zK3UExuV1v0Nk2/hn0B3QNv9md8mbGEAZCHB43 VdKK5mp+x+8lvnyLnEGm415OqwzbU0+XDLqhTCtEz+MF3UFR2tDhCsxjfuL8ldZzsyaA tkeKfFCmXi5uMB5xBd183tROyMLC1HnGJxsUp9iEmWQ7bs9t8rTDYY3R7D3B7ymZvqtu dNzQ== X-Gm-Message-State: AOAM531vNKiAUe5+WUKK+Sc0CRkbAXpVSFTtuLV/NOlhjHK8obxInHGw IZRwe780VdxAF5n2P1hCkxuQdCdLL5x8iRP0EfZrHQ== X-Google-Smtp-Source: ABdhPJwYA73lftjBriOP+37YGUdH+MFOawlYakwpkyiHcFfBQsl9Chfbewfaer8b9y41czh2lCGjkNZ6cshLgPPsL0I= X-Received: by 2002:a37:73c3:: with SMTP id o186mr2728785qkc.194.1612504730031; Thu, 04 Feb 2021 21:58:50 -0800 (PST) MIME-Version: 1.0 References: <20210128060515.1732758-1-stevensd@google.com> In-Reply-To: From: David Stevens Date: Fri, 5 Feb 2021 14:58:38 +0900 Message-ID: Subject: Re: [PATCH v3 0/2] KVM: x86/mmu: Skip mmu_notifier changes when possible To: Paolo Bonzini X-Mailman-Approved-At: Fri, 05 Feb 2021 04:26:13 -0500 Cc: Wanpeng Li , kvm@vger.kernel.org, David Hildenbrand , David Stevens , linux-mips@vger.kernel.org, Paul Mackerras , Claudio Imbrenda , kvmarm@lists.cs.columbia.edu, Janosch Frank , Marc Zyngier , Joerg Roedel , Huacai Chen , Christian Borntraeger , Aleksandar Markovic , kvm-ppc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Jim Mattson , Sean Christopherson , Cornelia Huck , open list , Vitaly Kuznetsov X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu These patches might be responsible for some instability in one of our stress tests. I'll send an update once I figure out what's going on. Thanks, David On Thu, Jan 28, 2021 at 9:48 PM Paolo Bonzini wrote: > > On 28/01/21 07:05, David Stevens wrote: > > These patches reduce how often mmu_notifier updates block guest page > > faults. The primary benefit of this is the reduction in the likelihood > > of extreme latency when handling a page fault due to another thread > > having been preempted while modifying host virtual addresses. > > > > v2 -> v3: > > - Added patch to skip check for MMIO page faults > > - Style changes > > > > David Stevens (1): > > KVM: x86/mmu: Consider the hva in mmu_notifier retry > > > > Sean Christopherson (1): > > KVM: x86/mmu: Skip mmu_notifier check when handling MMIO page fault > > > > arch/powerpc/kvm/book3s_64_mmu_hv.c | 2 +- > > arch/powerpc/kvm/book3s_64_mmu_radix.c | 2 +- > > arch/x86/kvm/mmu/mmu.c | 16 ++++++++------ > > arch/x86/kvm/mmu/paging_tmpl.h | 7 ++++--- > > include/linux/kvm_host.h | 25 +++++++++++++++++++++- > > virt/kvm/kvm_main.c | 29 ++++++++++++++++++++++---- > > 6 files changed, 65 insertions(+), 16 deletions(-) > > > > Queued, thanks. > > Paolo > _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 194D4C433DB for ; Fri, 5 Feb 2021 06:00:24 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B097860230 for ; Fri, 5 Feb 2021 06:00:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B097860230 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=T9QLVMkFQfV8nxeOVM7iHDKFOjvlE44grF/2Qpsv2yo=; b=klXRZkrxd8mYn5F0leGiYcq62 gHNzV7yaah10dTi19kGAQS8lxcIOsry20MNatQ8lSvjWa1HV6gcoR9eSIBDCIfc7QpMOMDhLPVAAZ IKe6AKpxKPqrTRBbzrBoiy3M6JV5bNLnHwY8y8lgp5U6c7ZsGQxUaVjw5M4IOm9PTEzKptggCIvUS G7lbNGLWYHYPvkKNyHkprw4omaTeefTL+Rl74ZqR/IdUzLyGf/wUjpUbXYpqQPWG5xDJnBaV/C7KK c5iEmXxAhB/4x8rggOCAgaB3p/aLcdDYtpTEQj3wzRFQq+5nkHXcVfvFDoUPiTYfk8nJYOYoO4tDz zOAfT28mw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l7u8w-0002Hq-Jm; Fri, 05 Feb 2021 05:58:58 +0000 Received: from mail-qk1-x734.google.com ([2607:f8b0:4864:20::734]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l7u8t-0002HP-LQ for linux-arm-kernel@lists.infradead.org; Fri, 05 Feb 2021 05:58:56 +0000 Received: by mail-qk1-x734.google.com with SMTP id l27so5861928qki.9 for ; Thu, 04 Feb 2021 21:58:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=SZ0GQLJipF2hQIt0oYg/b3YND75QYohdSOPgCgGvmtI=; b=oPGsTQx7+FdG6LRGl1TD3o+RbriHfudMdPEUWdoVcGtiFVzJyADmDY4/qjjG1+UIcy wjKL99cqQfoIL+mWKhEojF7j3xy7b/FwNrgzFcnaC4VE2BI5tBDFbEYcfnximoQpd7Bo foetOy+pvkseCt44S1+fCOI+yg3iGoGzvmkUU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=SZ0GQLJipF2hQIt0oYg/b3YND75QYohdSOPgCgGvmtI=; b=i4n9znXuJur6b2m93RTUvvTRHm0UqpPtOCq9O3K9JIisiWkre+fzlYmuqj7eqfQRpS N4faTlrdk88uODyVaH7BRtxJ9r/3Lz+ys472uVwELZEXTJ7TNhPB1r3ocV2X+iY5cBej 7qFm2dzMYMWq1dgV8r9Ewslpn2u2gWmyvK9LFw4e4d8mE3H5UQRqRoG8licHWvKNVQQF cOIKN8DUVwXTGaYiVN4IkipIBvSVvFqVYq/d8DkVS+Z447gLHgGBDzpCDzX14BHjnOwa tJRVJmSKZBG7XurKY3/PClx7EtkGhXP7iOKvgrHJr+Tryedt9j7mBvxMYovtXlVZc8KD 1jHA== X-Gm-Message-State: AOAM533D5w8JLCyFRvjAf1lU4w5ZARA2aErQZ5vlTu2y93rL0aIGQHQi gMtKDRxyH2+uCUvPU90Mq9v1og2uzRrm080aJ898jQ== X-Google-Smtp-Source: ABdhPJwYA73lftjBriOP+37YGUdH+MFOawlYakwpkyiHcFfBQsl9Chfbewfaer8b9y41czh2lCGjkNZ6cshLgPPsL0I= X-Received: by 2002:a37:73c3:: with SMTP id o186mr2728785qkc.194.1612504730031; Thu, 04 Feb 2021 21:58:50 -0800 (PST) MIME-Version: 1.0 References: <20210128060515.1732758-1-stevensd@google.com> In-Reply-To: From: David Stevens Date: Fri, 5 Feb 2021 14:58:38 +0900 Message-ID: Subject: Re: [PATCH v3 0/2] KVM: x86/mmu: Skip mmu_notifier changes when possible To: Paolo Bonzini X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210205_005855_749643_C0ADC017 X-CRM114-Status: GOOD ( 14.43 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Wanpeng Li , kvm@vger.kernel.org, David Hildenbrand , David Stevens , linux-mips@vger.kernel.org, Paul Mackerras , Claudio Imbrenda , kvmarm@lists.cs.columbia.edu, Janosch Frank , Marc Zyngier , Joerg Roedel , Huacai Chen , Christian Borntraeger , Aleksandar Markovic , Julien Thierry , Suzuki K Poulose , kvm-ppc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Jim Mattson , Sean Christopherson , Cornelia Huck , open list , James Morse , Vitaly Kuznetsov Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org These patches might be responsible for some instability in one of our stress tests. I'll send an update once I figure out what's going on. Thanks, David On Thu, Jan 28, 2021 at 9:48 PM Paolo Bonzini wrote: > > On 28/01/21 07:05, David Stevens wrote: > > These patches reduce how often mmu_notifier updates block guest page > > faults. The primary benefit of this is the reduction in the likelihood > > of extreme latency when handling a page fault due to another thread > > having been preempted while modifying host virtual addresses. > > > > v2 -> v3: > > - Added patch to skip check for MMIO page faults > > - Style changes > > > > David Stevens (1): > > KVM: x86/mmu: Consider the hva in mmu_notifier retry > > > > Sean Christopherson (1): > > KVM: x86/mmu: Skip mmu_notifier check when handling MMIO page fault > > > > arch/powerpc/kvm/book3s_64_mmu_hv.c | 2 +- > > arch/powerpc/kvm/book3s_64_mmu_radix.c | 2 +- > > arch/x86/kvm/mmu/mmu.c | 16 ++++++++------ > > arch/x86/kvm/mmu/paging_tmpl.h | 7 ++++--- > > include/linux/kvm_host.h | 25 +++++++++++++++++++++- > > virt/kvm/kvm_main.c | 29 ++++++++++++++++++++++---- > > 6 files changed, 65 insertions(+), 16 deletions(-) > > > > Queued, thanks. > > Paolo > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Stevens Date: Fri, 05 Feb 2021 05:58:38 +0000 Subject: Re: [PATCH v3 0/2] KVM: x86/mmu: Skip mmu_notifier changes when possible Message-Id: List-Id: References: <20210128060515.1732758-1-stevensd@google.com> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Paolo Bonzini Cc: Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , kvm@vger.kernel.org, open list , Marc Zyngier , James Morse , Julien Thierry , Suzuki K Poulose , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, Huacai Chen , Aleksandar Markovic , linux-mips@vger.kernel.org, Paul Mackerras , kvm-ppc@vger.kernel.org, Christian Borntraeger , Janosch Frank , David Hildenbrand , Cornelia Huck , Claudio Imbrenda , David Stevens These patches might be responsible for some instability in one of our stress tests. I'll send an update once I figure out what's going on. Thanks, David On Thu, Jan 28, 2021 at 9:48 PM Paolo Bonzini wrote: > > On 28/01/21 07:05, David Stevens wrote: > > These patches reduce how often mmu_notifier updates block guest page > > faults. The primary benefit of this is the reduction in the likelihood > > of extreme latency when handling a page fault due to another thread > > having been preempted while modifying host virtual addresses. > > > > v2 -> v3: > > - Added patch to skip check for MMIO page faults > > - Style changes > > > > David Stevens (1): > > KVM: x86/mmu: Consider the hva in mmu_notifier retry > > > > Sean Christopherson (1): > > KVM: x86/mmu: Skip mmu_notifier check when handling MMIO page fault > > > > arch/powerpc/kvm/book3s_64_mmu_hv.c | 2 +- > > arch/powerpc/kvm/book3s_64_mmu_radix.c | 2 +- > > arch/x86/kvm/mmu/mmu.c | 16 ++++++++------ > > arch/x86/kvm/mmu/paging_tmpl.h | 7 ++++--- > > include/linux/kvm_host.h | 25 +++++++++++++++++++++- > > virt/kvm/kvm_main.c | 29 ++++++++++++++++++++++---- > > 6 files changed, 65 insertions(+), 16 deletions(-) > > > > Queued, thanks. > > Paolo >