From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNWANTED_LANGUAGE_BODY, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB375C433B4 for ; Thu, 13 May 2021 09:38:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AC3CC61285 for ; Thu, 13 May 2021 09:38:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232697AbhEMJjL (ORCPT ); Thu, 13 May 2021 05:39:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34542 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232709AbhEMJjF (ORCPT ); Thu, 13 May 2021 05:39:05 -0400 Received: from mail-pf1-x42d.google.com (mail-pf1-x42d.google.com [IPv6:2607:f8b0:4864:20::42d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BF989C061574 for ; Thu, 13 May 2021 02:37:55 -0700 (PDT) Received: by mail-pf1-x42d.google.com with SMTP id v191so21167994pfc.8 for ; Thu, 13 May 2021 02:37:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=UK11emBimp2j7VDS60FsY4XS6s+jsxh4WvF3e9ihaL0=; b=bTRL8PCmF1zR+sOAQgqj+65KCF99UaaO10WnRQXi2xNSucbyVk/3mRz9uG+L2YRtVv LHuyA7VFIQliVXsbwO8bOL/7fGYT3CLiaJm3UdVP1HvocOzEvOq0zxj8kHcl7ja9F7JO VX2EUG4hJvxb+FmB7C4uE6+yMhksBTi8vffUlN671xOj32qP8QfeqbSJU03p8X/xha3t qv0b2k3WGLlonfaXW+Vn0b0R3K/cvjWYp42KUOUGr3+tq3tOqGaDo8BIS+39l4CASwI8 35dcPI4y1oyV5X9k5fx8dTmFJia9+vzRMoCB8AiaxiGcrblmxge4Dxktm/KhihUJFyIR /nDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=UK11emBimp2j7VDS60FsY4XS6s+jsxh4WvF3e9ihaL0=; b=P08D0njXGh59c0OV6x71mobljZLCH/y+4YUw3o1/gmWFt+zzXP80n1ReG0+20DZ5eE gDO+XGUbI2LFYZkEW8MX0f1ERhb18eFugvvHCG1hIRy+bIboZ67wllO+WYBUJqGEV0Ex LJGHnyXN99UF7mrpW/rUtACwmAW0HE1NtnaaOu/0HOAhWKcdLC2ib8vDjcSDtFvDvkRt oF3JnCLxWVrUqf0w7wba/VRqXn4G9WOjxIHX+lvpWXdK70c2tX7V+Z1DRvkcBjvUByyf CfbHgCV6cqBJROuwFqL5G4KMy4z/xJVc0vWwuywhaJl9ozJJrQV86qjuMrok/c30bqMo fs1A== X-Gm-Message-State: AOAM532Bh1hZ+a47GU80W/hGgHD8a/1p5Z8HIwZNe6oWduqPQmdJB4ls IkNOSmQnPSKRY4SJ9Uz/Ab/VKNsU2pvtleoBDsVy67Z5khKaYA== X-Google-Smtp-Source: ABdhPJz6233+qvlYevbBcOMreUeHzbiOcEVuTVvkHGYYiFVy60jPOfm7ZdHmJZFKMTy6MQsiTJK3LNJ0qGw62R6i75o= X-Received: by 2002:a62:8389:0:b029:27d:28f4:d583 with SMTP id h131-20020a6283890000b029027d28f4d583mr40172120pfe.33.1620898675232; Thu, 13 May 2021 02:37:55 -0700 (PDT) MIME-Version: 1.0 References: <20210513051920.29320-1-rdunlap@infradead.org> In-Reply-To: <20210513051920.29320-1-rdunlap@infradead.org> From: Oliver Glitta Date: Thu, 13 May 2021 11:37:44 +0200 Message-ID: Subject: Re: [PATCH -mm] slub: STACKDEPOT: rename save_stack_trace() To: Randy Dunlap Cc: LKML , Andrew Morton , Linux Memory Management List Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org =C5=A1t 13. 5. 2021 o 7:19 Randy Dunlap nap=C3=ADsa= l(a): > > save_stack_trace() already exists, so change the one in > CONFIG_STACKDEPOT to be save_stack_depot_trace(). > > Fixes this build error: > > ../mm/slub.c:607:29: error: conflicting types for =E2=80=98save_stack_tra= ce=E2=80=99 > static depot_stack_handle_t save_stack_trace(gfp_t flags) > ^~~~~~~~~~~~~~~~ > In file included from ../include/linux/page_ext.h:6:0, > from ../include/linux/mm.h:25, > from ../mm/slub.c:13: > ../include/linux/stacktrace.h:86:13: note: previous declaration of =E2=80= =98save_stack_trace=E2=80=99 was here > extern void save_stack_trace(struct stack_trace *trace); > ^~~~~~~~~~~~~~~~ > > from this patch in mmotm: > Subject: mm/slub: use stackdepot to save stack trace in objects > > > Signed-off-by: Randy Dunlap Acked-by: Oliver Glitta I run it with CONFIG_ARCH_STACKWALK set on, so it didn't show this error. Thank you for your fix. > Cc: Oliver Glitta > Cc: Andrew Morton > Cc: linux-mm@kvack.org > --- > mm/slub.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > --- mmotm-2021-0512-2146.orig/mm/slub.c > +++ mmotm-2021-0512-2146/mm/slub.c > @@ -604,7 +604,7 @@ static struct track *get_track(struct km > } > > #ifdef CONFIG_STACKDEPOT > -static depot_stack_handle_t save_stack_trace(gfp_t flags) > +static depot_stack_handle_t save_stack_depot_trace(gfp_t flags) > { > unsigned long entries[TRACK_ADDRS_COUNT]; > depot_stack_handle_t handle; > @@ -623,7 +623,7 @@ static void set_track(struct kmem_cache > > if (addr) { > #ifdef CONFIG_STACKDEPOT > - p->handle =3D save_stack_trace(GFP_KERNEL); > + p->handle =3D save_stack_depot_trace(GFP_KERNEL); > #endif > p->addr =3D addr; > p->cpu =3D smp_processor_id(); From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNWANTED_LANGUAGE_BODY, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2CE95C433ED for ; Thu, 13 May 2021 09:37:58 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C4D9061432 for ; Thu, 13 May 2021 09:37:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C4D9061432 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 684746B006E; Thu, 13 May 2021 05:37:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 65A716B0070; Thu, 13 May 2021 05:37:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 522ED6B0071; Thu, 13 May 2021 05:37:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0130.hostedemail.com [216.40.44.130]) by kanga.kvack.org (Postfix) with ESMTP id 2407B6B006E for ; Thu, 13 May 2021 05:37:57 -0400 (EDT) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id AE3A6A8DE for ; Thu, 13 May 2021 09:37:56 +0000 (UTC) X-FDA: 78135706152.03.D2BB427 Received: from mail-pg1-f181.google.com (mail-pg1-f181.google.com [209.85.215.181]) by imf24.hostedemail.com (Postfix) with ESMTP id 971B9A0003AF for ; Thu, 13 May 2021 09:37:41 +0000 (UTC) Received: by mail-pg1-f181.google.com with SMTP id t193so8270947pgb.4 for ; Thu, 13 May 2021 02:37:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=UK11emBimp2j7VDS60FsY4XS6s+jsxh4WvF3e9ihaL0=; b=bTRL8PCmF1zR+sOAQgqj+65KCF99UaaO10WnRQXi2xNSucbyVk/3mRz9uG+L2YRtVv LHuyA7VFIQliVXsbwO8bOL/7fGYT3CLiaJm3UdVP1HvocOzEvOq0zxj8kHcl7ja9F7JO VX2EUG4hJvxb+FmB7C4uE6+yMhksBTi8vffUlN671xOj32qP8QfeqbSJU03p8X/xha3t qv0b2k3WGLlonfaXW+Vn0b0R3K/cvjWYp42KUOUGr3+tq3tOqGaDo8BIS+39l4CASwI8 35dcPI4y1oyV5X9k5fx8dTmFJia9+vzRMoCB8AiaxiGcrblmxge4Dxktm/KhihUJFyIR /nDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=UK11emBimp2j7VDS60FsY4XS6s+jsxh4WvF3e9ihaL0=; b=UhQufsx6uFKybD5AtPC0NJkkboMquTi2CEs3t9XQzP1qb9IvqhY3gaBpkkZCix/gpG HjSVvHLrhpOqxZJg0bJu3sSBRojwCztoAG7hfjx9w990+tF2FLEvGcrztN8vAjBZsHrr MtoL+lL/1C57ldYhvdjkybzfYPBuiIoPvJ9yNr32UzwcblWHqrgrhx+bVz009lQfIyFG MyLOCzGGL2qiMsfOlDVVi12eBvgWVLGAvlfgl/6VK8ir2yFXm90j44nURqd0B6Uw0t5U wUH0yNIghzEldXnRUSvOVU1jhrpeT5u6ILPjE67WzYtyAuzVyARM8USQWsamPpcqCY6D yWVQ== X-Gm-Message-State: AOAM531JH8+5KDduRm8zQyypOhEcqP48ZDoxgtFpquZ3PsRyUo7NDqUH HCeWZM4SAU0Axgig3dqogYO5UXBHwg7AXmS9fL4= X-Google-Smtp-Source: ABdhPJz6233+qvlYevbBcOMreUeHzbiOcEVuTVvkHGYYiFVy60jPOfm7ZdHmJZFKMTy6MQsiTJK3LNJ0qGw62R6i75o= X-Received: by 2002:a62:8389:0:b029:27d:28f4:d583 with SMTP id h131-20020a6283890000b029027d28f4d583mr40172120pfe.33.1620898675232; Thu, 13 May 2021 02:37:55 -0700 (PDT) MIME-Version: 1.0 References: <20210513051920.29320-1-rdunlap@infradead.org> In-Reply-To: <20210513051920.29320-1-rdunlap@infradead.org> From: Oliver Glitta Date: Thu, 13 May 2021 11:37:44 +0200 Message-ID: Subject: Re: [PATCH -mm] slub: STACKDEPOT: rename save_stack_trace() To: Randy Dunlap Cc: LKML , Andrew Morton , Linux Memory Management List Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=bTRL8PCm; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf24.hostedemail.com: domain of glittao@gmail.com designates 209.85.215.181 as permitted sender) smtp.mailfrom=glittao@gmail.com X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 971B9A0003AF X-Stat-Signature: x9pb61nngcfz3i7eyefibfez57643ews Received-SPF: none (gmail.com>: No applicable sender policy available) receiver=imf24; identity=mailfrom; envelope-from=""; helo=mail-pg1-f181.google.com; client-ip=209.85.215.181 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1620898661-339933 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: =C5=A1t 13. 5. 2021 o 7:19 Randy Dunlap nap=C3=ADsa= l(a): > > save_stack_trace() already exists, so change the one in > CONFIG_STACKDEPOT to be save_stack_depot_trace(). > > Fixes this build error: > > ../mm/slub.c:607:29: error: conflicting types for =E2=80=98save_stack_tra= ce=E2=80=99 > static depot_stack_handle_t save_stack_trace(gfp_t flags) > ^~~~~~~~~~~~~~~~ > In file included from ../include/linux/page_ext.h:6:0, > from ../include/linux/mm.h:25, > from ../mm/slub.c:13: > ../include/linux/stacktrace.h:86:13: note: previous declaration of =E2=80= =98save_stack_trace=E2=80=99 was here > extern void save_stack_trace(struct stack_trace *trace); > ^~~~~~~~~~~~~~~~ > > from this patch in mmotm: > Subject: mm/slub: use stackdepot to save stack trace in objects > > > Signed-off-by: Randy Dunlap Acked-by: Oliver Glitta I run it with CONFIG_ARCH_STACKWALK set on, so it didn't show this error. Thank you for your fix. > Cc: Oliver Glitta > Cc: Andrew Morton > Cc: linux-mm@kvack.org > --- > mm/slub.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > --- mmotm-2021-0512-2146.orig/mm/slub.c > +++ mmotm-2021-0512-2146/mm/slub.c > @@ -604,7 +604,7 @@ static struct track *get_track(struct km > } > > #ifdef CONFIG_STACKDEPOT > -static depot_stack_handle_t save_stack_trace(gfp_t flags) > +static depot_stack_handle_t save_stack_depot_trace(gfp_t flags) > { > unsigned long entries[TRACK_ADDRS_COUNT]; > depot_stack_handle_t handle; > @@ -623,7 +623,7 @@ static void set_track(struct kmem_cache > > if (addr) { > #ifdef CONFIG_STACKDEPOT > - p->handle =3D save_stack_trace(GFP_KERNEL); > + p->handle =3D save_stack_depot_trace(GFP_KERNEL); > #endif > p->addr =3D addr; > p->cpu =3D smp_processor_id();