All of lore.kernel.org
 help / color / mirror / Atom feed
From: Zhu Yanjun <zyjzyj2000@gmail.com>
To: Guoqing Jiang <guoqing.jiang@linux.dev>
Cc: syzbot <syzbot+eba589d8f49c73d356da@syzkaller.appspotmail.com>,
	jgg@ziepe.ca, leon@kernel.org, linux-kernel@vger.kernel.org,
	linux-rdma@vger.kernel.org, netdev@vger.kernel.org,
	syzkaller-bugs@googlegroups.com
Subject: Re: [syzbot] [rdma?] INFO: trying to register non-static key in skb_dequeue (2)
Date: Tue, 23 May 2023 13:55:34 +0800	[thread overview]
Message-ID: <CAD=hENfRW7stx0c_uTh6KXwLwovv3wA9q-hKA6Xz6UNcEPYcNA@mail.gmail.com> (raw)
In-Reply-To: <63b9f740-3762-2ec0-9750-eb8709c886a5@linux.dev>

On Tue, May 23, 2023 at 1:50 PM Guoqing Jiang <guoqing.jiang@linux.dev> wrote:
>
>
>
> On 5/23/23 12:29, Zhu Yanjun wrote:
> > On Tue, May 23, 2023 at 12:10 PM Guoqing Jiang <guoqing.jiang@linux.dev> wrote:
> >>
> >>
> >> On 5/23/23 12:02, Zhu Yanjun wrote:
> >>> On Tue, May 23, 2023 at 11:47 AM Zhu Yanjun <zyjzyj2000@gmail.com> wrote:
> >>>> On Tue, May 23, 2023 at 10:26 AM Guoqing Jiang <guoqing.jiang@linux.dev> wrote:
> >>>>>
> >>>>> On 5/23/23 10:13, syzbot wrote:
> >>>>>> Hello,
> >>>>>>
> >>>>>> syzbot tried to test the proposed patch but the build/boot failed:
> >>>>>>
> >>>>>> failed to apply patch:
> >>>>>> checking file drivers/infiniband/sw/rxe/rxe_qp.c
> >>>>>> patch: **** unexpected end of file in patch
> >>>> This is not the root cause. The fix is not good.
> >>> This problem is about "INFO: trying to register non-static key. The
> >>> code is fine but needs lockdep annotation, or maybe"
> > This warning is from "lock is not initialized". This is a
> > use-before-initialized problem.
>
> Right, and it also applies to qp->sq.queue which is set to NULL while do
> cleanup
> still de-reference it.
>
> > The correct fix is to initialize the lock that is complained before it is used.
>
> The thing is it can't be initialized due to error, so I guess you want
> to always init them
> even for error cases.

The complaining is about "spinlock is not initialized".

Zhu Yanjun

>
> Guoqing

  reply	other threads:[~2023-05-23  5:55 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-03  8:37 [syzbot] [rdma?] INFO: trying to register non-static key in skb_dequeue (2) syzbot
2023-05-18  9:20 ` syzbot
2023-05-23  2:07   ` Guoqing Jiang
2023-05-23  2:13     ` syzbot
2023-05-23  2:25       ` Guoqing Jiang
2023-05-23  2:55         ` syzbot
2023-05-23  3:47         ` Zhu Yanjun
2023-05-23  3:58           ` Guoqing Jiang
2023-05-23  4:02           ` Zhu Yanjun
2023-05-23  4:10             ` Guoqing Jiang
2023-05-23  4:29               ` Zhu Yanjun
2023-05-23  5:08                 ` Zhu Yanjun
2023-05-23  5:18                   ` Zhu Yanjun
2023-05-23  5:44                     ` Guoqing Jiang
2023-05-23  5:52                       ` Zhu Yanjun
2023-05-23  5:56                         ` Guoqing Jiang
2023-05-23  6:04                           ` Zhu Yanjun
2023-05-23  5:50                 ` Guoqing Jiang
2023-05-23  5:55                   ` Zhu Yanjun [this message]
2023-05-23  6:00                     ` Guoqing Jiang
2023-05-23  6:07                       ` Zhu Yanjun
2023-05-23  6:11                         ` Guoqing Jiang
2023-05-23  6:40                           ` Zhu Yanjun
     [not found] <20230518112255.4516-1-hdanton@sina.com>
2023-05-18 11:44 ` syzbot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAD=hENfRW7stx0c_uTh6KXwLwovv3wA9q-hKA6Xz6UNcEPYcNA@mail.gmail.com' \
    --to=zyjzyj2000@gmail.com \
    --cc=guoqing.jiang@linux.dev \
    --cc=jgg@ziepe.ca \
    --cc=leon@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=syzbot+eba589d8f49c73d356da@syzkaller.appspotmail.com \
    --cc=syzkaller-bugs@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.