From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98319C388F7 for ; Fri, 13 Nov 2020 09:27:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 56FB02145D for ; Fri, 13 Nov 2020 09:27:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="nZ0r/koc" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726299AbgKMJ1d (ORCPT ); Fri, 13 Nov 2020 04:27:33 -0500 Received: from mail.kernel.org ([198.145.29.99]:48642 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726160AbgKMJ1c (ORCPT ); Fri, 13 Nov 2020 04:27:32 -0500 Received: from mail-oi1-f173.google.com (mail-oi1-f173.google.com [209.85.167.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id EE6EE2224D for ; Fri, 13 Nov 2020 09:27:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1605259652; bh=OIM03Fej0Qv7ys4fG+OsO5oPdBvHvBk4pQGuvEDfeY4=; h=In-Reply-To:References:From:Date:Subject:To:Cc:From; b=nZ0r/kocNVEoHSptb4nNkyMSdwCC+Ve7UACrpO1YY63cnNC2l2vZ20RRRJ/ElEVfd aRUBNveb8zW5bSazIWL+KJWw32nw9VQ1t5qAA6oyxhgpoM6o20PJgwkE6Q7N/+PL45 xmDOffz34cWzMZYunLOLJ7ymzhyokKCStC7A+3wI= Received: by mail-oi1-f173.google.com with SMTP id t16so9701887oie.11 for ; Fri, 13 Nov 2020 01:27:31 -0800 (PST) X-Gm-Message-State: AOAM532tzWHDT43cmZSeAKOC/MDRcukTS3NUFS8k5QIL8Vn2fNDtbzAp Q0fgR9fscQenCQkNNHnxVraWsvCw6HKt5PahR1MbEQ== X-Google-Smtp-Source: ABdhPJwUx3S73L9XUE7mVfp7hH73qWmdFgeySdKDNxGnovyGciPUTZWyy2UDCaldkGC4ad9qA374P5Lx1TFP8OSAbMk= X-Received: by 2002:aca:3a04:: with SMTP id h4mr810472oia.42.1605259651226; Fri, 13 Nov 2020 01:27:31 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Fri, 13 Nov 2020 09:27:30 +0000 MIME-Version: 1.0 In-Reply-To: <20201113091116.1102450-1-steen.hegelund@microchip.com> References: <20201113091116.1102450-1-steen.hegelund@microchip.com> From: Antoine Tenart Date: Fri, 13 Nov 2020 09:27:30 +0000 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH net v2] net: phy: mscc: remove non-MACSec compatible phy To: "David S. Miller" , Andrew Lunn , Bryan Whitehead , Heiner Kallweit , Jakub Kicinski , Russell King , Steen Hegelund Cc: Microchip UNG Driver List , John Haechten , Netdev List , Linux Kernel List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Steen Hegelund (2020-11-13 10:11:16) > Selecting VSC8575 as a MACSec PHY was not correct > > The relevant datasheet can be found here: > - VSC8575: https://www.microchip.com/wwwproducts/en/VSC8575 > > History: > v1 -> v2: > - Corrected the sha in the "Fixes:" tag > > Fixes: 1bbe0ecc2a1a ("net: phy: mscc: macsec initialization") > Signed-off-by: Steen Hegelund Reviewed-by: Antoine Tenart Small comment: you can put the commit history after the --- so it doesn't end-up in the commit log (except when it's relevant, which isn't the case here). I don't think that's a blocker though. Thanks Steen! Antoine > --- > drivers/net/phy/mscc/mscc_macsec.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/net/phy/mscc/mscc_macsec.c b/drivers/net/phy/mscc/mscc_macsec.c > index 1d4c012194e9..72292bf6c51c 100644 > --- a/drivers/net/phy/mscc/mscc_macsec.c > +++ b/drivers/net/phy/mscc/mscc_macsec.c > @@ -981,7 +981,6 @@ int vsc8584_macsec_init(struct phy_device *phydev) > > switch (phydev->phy_id & phydev->drv->phy_id_mask) { > case PHY_ID_VSC856X: > - case PHY_ID_VSC8575: > case PHY_ID_VSC8582: > case PHY_ID_VSC8584: > INIT_LIST_HEAD(&vsc8531->macsec_flows); > -- > 2.29.2 >