All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gaurav Poothia <gaurav.poothia@gmail.com>
To: Mike Galbraith <umgwanakikbuti@gmail.com>
Cc: linux-kernel@vger.kernel.org, peterz@infradead.org, mingo@redhat.com
Subject: Re: Question about group scheduler cpu shares
Date: Thu, 21 Jul 2016 20:24:07 -0700	[thread overview]
Message-ID: <CADDfC=p-kyGbOzZWJQaaHhshB35NtwZig0ok9HRiWkhBritfBA@mail.gmail.com> (raw)
In-Reply-To: <1469155888.3862.26.camel@gmail.com>

Thanks Mike.
So if I understand you right - tasks on interior nodes get their
weight from task's nice level and not from some cpu.share setting.
Two followups:
1.What is the function that translates from various nice levels to
weight i.e. nice(0) == 1024 how to translate for other levels
2.How does that work when an interior node has multiple tasks? So if I
added tasks E and F with difference nice levels to Group 1 task list
how would the math work?

Appreciate the help -thanks!

On Thu, Jul 21, 2016 at 7:51 PM, Mike Galbraith
<umgwanakikbuti@gmail.com> wrote:
> On Thu, 2016-07-21 at 18:18 -0700, Gaurav Poothia wrote:
>
>> > ROOT
>> > >
>> > + -Group1(3072)
>> > >    |
>> > >   +- A(2048)
>> > >    |
>> > >    +- B(1024)
>> > >
>> > +- Group2(2048)
>> >      |
>> >      +-C(1024)
>> >      |
>> >      +-D(1024)
>> >
>
>> > Say I add a task E to Group1's task list (note that is an interior aka
>> > non-leaf node)
>> > How does the CPU split change between A, B and E.
>> > AFAICT there is no cgroup cpu subsystem knob to weight tasks on an
>> > interior node against the tasks in that node's children
>
> A, B and E are all entities with a weight, so just plug E into your
> graph.  Its weight is determined by nice level, which is what cgroups
> should have done instead of inventing shares IMHO.  1024 == nice(0).
>
>         -Mike



-- 
Kiva.org - Loans That Change Lives

  reply	other threads:[~2016-07-22  3:24 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-21 19:03 Question about group scheduler cpu shares Gaurav Poothia
2016-07-22  1:18 ` Gaurav Poothia
2016-07-22  2:51   ` Mike Galbraith
2016-07-22  3:24     ` Gaurav Poothia [this message]
2016-07-22  4:19       ` Mike Galbraith

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CADDfC=p-kyGbOzZWJQaaHhshB35NtwZig0ok9HRiWkhBritfBA@mail.gmail.com' \
    --to=gaurav.poothia@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=umgwanakikbuti@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.