From mboxrd@z Thu Jan 1 00:00:00 1970 From: Siwei Liu Subject: Re: Re: [Qemu-devel] [PATCH v3 0/3] Use of unique identifier for pairing virtio and passthrough devices... Date: Tue, 10 Jul 2018 17:07:37 -0700 Message-ID: References: <20180629221907.3662-1-venu.busireddy@oracle.com> <20180702161404.GA2339@rkaganb.sw.ru> <449f1449-ddf6-cd95-976c-14d04d8d503a@oracle.com> <20180703095825.GC30904@rkaganb.sw.ru> <20180709130035.GA6271@rkaganb.sw.ru> <9136094e-a510-4201-7c71-d1c49226fa5f@oracle.com> <20180710045101-mutt-send-email-mst@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Cc: si-wei liu , Roman Kagan , Venu Busireddy , Marcel Apfelbaum , virtio-dev@lists.oasis-open.org, qemu-devel@nongnu.org, "Samudrala, Sridhar" , Alexander Duyck , Netdev To: "Michael S. Tsirkin" Return-path: Sender: List-Post: List-Help: List-Unsubscribe: List-Subscribe: In-Reply-To: <20180710045101-mutt-send-email-mst@kernel.org> List-Id: netdev.vger.kernel.org On Mon, Jul 9, 2018 at 6:54 PM, Michael S. Tsirkin wrote: > On Mon, Jul 09, 2018 at 06:11:53PM -0700, si-wei liu wrote: >> The plan is to enable group ID based matching in the first place rather than >> match by MAC, the latter of which is fragile and problematic. > > It isn't all that fragile - hyperv used same for a while, so if someone > posts working patches with QEMU support but before this grouping stuff, > I'll happily apply them. I wouldn't box the solution to very limited scenario just because of matching by MAC, the benefit of having generic group ID in the first place is that we save the effort of maintaining legacy MAC based pairing that just adds complexity anyway. Currently the VF's MAC address cannot be changed by either PF or by the guest user is a severe limitation due to this. The other use case is that PT device than VF would generally have different MAC than the standby virtio. We shouldn't limit itself to VF specific scenario from the very beginning. It's just small piece of QEMU code to add in, why not? > >> I have made >> the Linux side changes and will get it posted once the QEMU discussion for >> grouping is finalized. > > Go ahead but at this point I think we need to see actual QEMU support at > least for the basic functionality before we merge more code Linux-side. The VFIO visibility work is being worked on. We'll post patches when it's ready. Thanks, -Siwei > > -- > MST > > --------------------------------------------------------------------- > To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org > For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org > From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55287) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fd2fU-000762-H5 for qemu-devel@nongnu.org; Tue, 10 Jul 2018 20:07:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fd2fT-0006MU-Fo for qemu-devel@nongnu.org; Tue, 10 Jul 2018 20:07:40 -0400 Received: from mail-it0-x241.google.com ([2607:f8b0:4001:c0b::241]:51455) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fd2fT-0006MA-Ab for qemu-devel@nongnu.org; Tue, 10 Jul 2018 20:07:39 -0400 Received: by mail-it0-x241.google.com with SMTP id g4-v6so1234758iti.1 for ; Tue, 10 Jul 2018 17:07:39 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <20180710045101-mutt-send-email-mst@kernel.org> References: <20180629221907.3662-1-venu.busireddy@oracle.com> <20180702161404.GA2339@rkaganb.sw.ru> <449f1449-ddf6-cd95-976c-14d04d8d503a@oracle.com> <20180703095825.GC30904@rkaganb.sw.ru> <20180709130035.GA6271@rkaganb.sw.ru> <9136094e-a510-4201-7c71-d1c49226fa5f@oracle.com> <20180710045101-mutt-send-email-mst@kernel.org> From: Siwei Liu Date: Tue, 10 Jul 2018 17:07:37 -0700 Message-ID: Content-Type: text/plain; charset="UTF-8" Subject: Re: [Qemu-devel] [virtio-dev] Re: [PATCH v3 0/3] Use of unique identifier for pairing virtio and passthrough devices... List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: si-wei liu , Roman Kagan , Venu Busireddy , Marcel Apfelbaum , virtio-dev@lists.oasis-open.org, qemu-devel@nongnu.org, "Samudrala, Sridhar" , Alexander Duyck , Netdev On Mon, Jul 9, 2018 at 6:54 PM, Michael S. Tsirkin wrote: > On Mon, Jul 09, 2018 at 06:11:53PM -0700, si-wei liu wrote: >> The plan is to enable group ID based matching in the first place rather than >> match by MAC, the latter of which is fragile and problematic. > > It isn't all that fragile - hyperv used same for a while, so if someone > posts working patches with QEMU support but before this grouping stuff, > I'll happily apply them. I wouldn't box the solution to very limited scenario just because of matching by MAC, the benefit of having generic group ID in the first place is that we save the effort of maintaining legacy MAC based pairing that just adds complexity anyway. Currently the VF's MAC address cannot be changed by either PF or by the guest user is a severe limitation due to this. The other use case is that PT device than VF would generally have different MAC than the standby virtio. We shouldn't limit itself to VF specific scenario from the very beginning. It's just small piece of QEMU code to add in, why not? > >> I have made >> the Linux side changes and will get it posted once the QEMU discussion for >> grouping is finalized. > > Go ahead but at this point I think we need to see actual QEMU support at > least for the basic functionality before we merge more code Linux-side. The VFIO visibility work is being worked on. We'll post patches when it's ready. Thanks, -Siwei > > -- > MST > > --------------------------------------------------------------------- > To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org > For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: virtio-dev-return-4672-cohuck=redhat.com@lists.oasis-open.org Sender: List-Post: List-Help: List-Unsubscribe: List-Subscribe: Received: from lists.oasis-open.org (oasis-open.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id C61F5985B2A for ; Wed, 11 Jul 2018 00:07:39 +0000 (UTC) MIME-Version: 1.0 In-Reply-To: <20180710045101-mutt-send-email-mst@kernel.org> References: <20180629221907.3662-1-venu.busireddy@oracle.com> <20180702161404.GA2339@rkaganb.sw.ru> <449f1449-ddf6-cd95-976c-14d04d8d503a@oracle.com> <20180703095825.GC30904@rkaganb.sw.ru> <20180709130035.GA6271@rkaganb.sw.ru> <9136094e-a510-4201-7c71-d1c49226fa5f@oracle.com> <20180710045101-mutt-send-email-mst@kernel.org> From: Siwei Liu Date: Tue, 10 Jul 2018 17:07:37 -0700 Message-ID: Content-Type: text/plain; charset="UTF-8" Subject: Re: [virtio-dev] Re: [Qemu-devel] [PATCH v3 0/3] Use of unique identifier for pairing virtio and passthrough devices... To: "Michael S. Tsirkin" Cc: si-wei liu , Roman Kagan , Venu Busireddy , Marcel Apfelbaum , virtio-dev@lists.oasis-open.org, qemu-devel@nongnu.org, "Samudrala, Sridhar" , Alexander Duyck , Netdev List-ID: On Mon, Jul 9, 2018 at 6:54 PM, Michael S. Tsirkin wrote: > On Mon, Jul 09, 2018 at 06:11:53PM -0700, si-wei liu wrote: >> The plan is to enable group ID based matching in the first place rather than >> match by MAC, the latter of which is fragile and problematic. > > It isn't all that fragile - hyperv used same for a while, so if someone > posts working patches with QEMU support but before this grouping stuff, > I'll happily apply them. I wouldn't box the solution to very limited scenario just because of matching by MAC, the benefit of having generic group ID in the first place is that we save the effort of maintaining legacy MAC based pairing that just adds complexity anyway. Currently the VF's MAC address cannot be changed by either PF or by the guest user is a severe limitation due to this. The other use case is that PT device than VF would generally have different MAC than the standby virtio. We shouldn't limit itself to VF specific scenario from the very beginning. It's just small piece of QEMU code to add in, why not? > >> I have made >> the Linux side changes and will get it posted once the QEMU discussion for >> grouping is finalized. > > Go ahead but at this point I think we need to see actual QEMU support at > least for the basic functionality before we merge more code Linux-side. The VFIO visibility work is being worked on. We'll post patches when it's ready. Thanks, -Siwei > > -- > MST > > --------------------------------------------------------------------- > To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org > For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org > --------------------------------------------------------------------- To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org