From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E4B1C43381 for ; Fri, 29 Mar 2019 09:18:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 154BB21773 for ; Fri, 29 Mar 2019 09:18:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YosOUnj+" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728796AbfC2JSa (ORCPT ); Fri, 29 Mar 2019 05:18:30 -0400 Received: from mail-qk1-f194.google.com ([209.85.222.194]:42839 "EHLO mail-qk1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727387AbfC2JSa (ORCPT ); Fri, 29 Mar 2019 05:18:30 -0400 Received: by mail-qk1-f194.google.com with SMTP id b74so908266qkg.9 for ; Fri, 29 Mar 2019 02:18:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=D00/6HjIEgiLsPwtF1TGCpcflPZ0EvHxsRhP3C40Hxo=; b=YosOUnj+wKAEZa+mf4VTZQylENR4xcFSrt0HrytEcFsMhOf9rrOmCCYZQ9UadA2mCP P6FDbLL7VceTxpLRHhefr8xFZKkrZLJ3hguV+XIt+sI4StwbOQjW1PODeBwgIifFWD3t 0l+btvanptNIGx4ZfapNr5iAvjnCcXhCVAsINTswZjHId0Y1FI0m6j8uhS5O8RUrkHzG C4LjWk/MRIR4RB+a9bZ3ttyy4nslDjRAoCKS7x0G73RpELsSMjqurO6IMAw++nGSO0y1 Gi8WYf5MD48a2khKXjkHB2yJ95I08PoF0x5cm0NdEXo3xBztYKcF3cphsDUHH5nLFZX5 gE6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=D00/6HjIEgiLsPwtF1TGCpcflPZ0EvHxsRhP3C40Hxo=; b=IpE96j4DAx1WkTIwylGtEoLWybHtKxokBJ108sCTK7qxeAeEuOogw2lCbmFuGRXXcV xCpLjk1Hvk2ga8Fy7N+QiPhjlZV9KhwwYrXr/X4WMth2HvNAaGFOy2sZFzkPbPMnO2CD MODTM2r+nhvLgRqkpRBOvLOy9wHIENomMAHLTrhu2GCpnmhnxELt/HK+bnID5dOtgP+z feTfIKmiHTjOWRbg/Pt/Kj2C+87Ua5ScGl08Te7YHGeOSKp7dnu8AZSZoxYQidRax3C6 HkkW5jIBl+acNuBT1agbCVkpwj/gXOD9A3PdvcGpAo9M1S3xvM2+nTrqAAF1QaCaw8l6 gNGw== X-Gm-Message-State: APjAAAUWrvu7LosYZ+MZcd9AvNjk44awOqRL8n4ot4NM0Oc12ppJXqDy L4GBcGHMQVv6KlaSiGlNFdhLYbsGWhbvllf2qabYVg== X-Google-Smtp-Source: APXvYqxFcQ+S/MzbZxd8eXyUOQzKQyI0kjIa+kB8iYyNRVNXCj6Q8mqCbPMm+AE/4AtoOBNnPVfjwfFbA/oCXRyOiZI= X-Received: by 2002:a37:494c:: with SMTP id w73mr38073032qka.335.1553851109262; Fri, 29 Mar 2019 02:18:29 -0700 (PDT) MIME-Version: 1.0 References: <20190318050022.7833-1-jencce.kernel@gmail.com> In-Reply-To: <20190318050022.7833-1-jencce.kernel@gmail.com> From: Murphy Zhou Date: Fri, 29 Mar 2019 17:18:17 +0800 Message-ID: Subject: Re: [PATCH] vfs: return EINVAL instead of ENOENT when missing source To: Linux-Fsdevel Content-Type: text/plain; charset="UTF-8" Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org Ping on this one? Thanks! On Mon, Mar 18, 2019 at 1:39 PM Murphy Zhou wrote: > > mount(2) with a NULL source device would return ENOENT instead of EINVAL > after this commit: > > commit f3a09c92018a91ad0981146a4ac59414f814d801 > Author: Al Viro > Date: Sun Dec 23 18:55:56 2018 -0500 > > introduce fs_context methods > > Change the return value to be compatible with the old behaviour. > > This was caught by LTP mount02[1]. This testcase is calling mount(2) with a > NULL device name and expecting EINVAL to PASS but now we are getting ENOENT. > > [1] https://github.com/linux-test-project/ltp/blob/master/testcases/kernel/syscalls/mount/mount02.c > > Signed-off-by: Murphy Zhou > --- > fs/super.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/super.c b/fs/super.c > index 583a0124bc39..48e51f13a4ba 100644 > --- a/fs/super.c > +++ b/fs/super.c > @@ -1469,7 +1469,7 @@ int vfs_get_tree(struct fs_context *fc) > > if (fc->fs_type->fs_flags & FS_REQUIRES_DEV && !fc->source) { > errorf(fc, "Filesystem requires source device"); > - return -ENOENT; > + return -EINVAL; > } > > if (fc->root) > -- > 2.21.0 >