From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3951CC4360F for ; Thu, 4 Apr 2019 08:39:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EF5B520820 for ; Thu, 4 Apr 2019 08:39:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RODSUKxl" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726563AbfDDIjg (ORCPT ); Thu, 4 Apr 2019 04:39:36 -0400 Received: from mail-qt1-f193.google.com ([209.85.160.193]:37276 "EHLO mail-qt1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725914AbfDDIjg (ORCPT ); Thu, 4 Apr 2019 04:39:36 -0400 Received: by mail-qt1-f193.google.com with SMTP id z16so2281454qtn.4 for ; Thu, 04 Apr 2019 01:39:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=CXi1cXQKWQmz4UwjhhHOqrjeUs+lRTB4IYKf0RFW+F0=; b=RODSUKxlHKDkGcyNERn39d4NFRePVcqEcS01OItVi7gaLzcoiNjd0SjWoRR3tm6Cld TwzbSKPFjf08FFfSaIJuJevtr17fbu1KPRDu2HbqQVPpvI5Isf93zHZ+Sw7SuYaXQfrR luJNmM0f0qiK/ODoBIuZ1Itk4tleLe/UN6NAbfy30goxTOwMrccFoMcGhzfLhOZcfC5E Vzj9M3rTlAPm7Zxe7uZ1+8Bj8DEX/rVEGS/23EydCxMC9En5PcGxzwwtEx5Mrp0RWGsr 7WLe3RYVj2unVFHMpFamcHDCu2NCG+GxdCkSHZ2lbTHAPQhlevQ5SkRDe07YVyqL1TJ/ K6gw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=CXi1cXQKWQmz4UwjhhHOqrjeUs+lRTB4IYKf0RFW+F0=; b=GOfTHN/4r1/+Kx83ujDA1onzuXAb0N1AnhVyYqlPy+L7iXYSrHI1xDLYXv9a3+ax8x hxbNa6wM6uXNvo2PVZZg2cHPvZ79Ed0GTzQQ6SJYq/+epaenDh1DUli+xnjBmXziRkml hyQFar45Y8Nvq3FbR2YAMcAK3klRrMVz7lzVwTH5zKYa1lml59D2IsZrM7u5Pa8ZLuaQ YB89KLZ6LAZ+KntgzjtqnRSB4hAtfCQ4qxJCpO8p2ACbsRSV+QzM5fqYdPZ3NjZgypgm QwwlxbAbI5N7T2xqvKrjcSjuHw2ClNi3nZiA+I6p7pokNTPRW/zHFUjt24DCq04ni6Rz pNcQ== X-Gm-Message-State: APjAAAWwXz7qq0wSe7SnPxcJWe8yacVn1jVBMo+oE658HQi9knAVRrPK KnsSviEGUe67B6uTD25Whe06nNm4Aw8tRdV0mmCTCg== X-Google-Smtp-Source: APXvYqxViiFFQyXc1XUNvEPdP0jZ53h2aFucom1yXjvlIb2oklfp7iZiatweDLObjT+UnEvplz43bQLHdCMHiJmSLBA= X-Received: by 2002:ac8:21bc:: with SMTP id 57mr3987324qty.51.1554367174543; Thu, 04 Apr 2019 01:39:34 -0700 (PDT) MIME-Version: 1.0 References: <20190318050022.7833-1-jencce.kernel@gmail.com> In-Reply-To: <20190318050022.7833-1-jencce.kernel@gmail.com> From: Murphy Zhou Date: Thu, 4 Apr 2019 16:39:22 +0800 Message-ID: Subject: Re: [PATCH] vfs: return EINVAL instead of ENOENT when missing source To: Linux-Fsdevel , Alexander Viro Content-Type: text/plain; charset="UTF-8" Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org Hi AL, what do you think, ;) On Mon, Mar 18, 2019 at 1:39 PM Murphy Zhou wrote: > > mount(2) with a NULL source device would return ENOENT instead of EINVAL > after this commit: > > commit f3a09c92018a91ad0981146a4ac59414f814d801 > Author: Al Viro > Date: Sun Dec 23 18:55:56 2018 -0500 > > introduce fs_context methods > > Change the return value to be compatible with the old behaviour. > > This was caught by LTP mount02[1]. This testcase is calling mount(2) with a > NULL device name and expecting EINVAL to PASS but now we are getting ENOENT. > > [1] https://github.com/linux-test-project/ltp/blob/master/testcases/kernel/syscalls/mount/mount02.c > > Signed-off-by: Murphy Zhou > --- > fs/super.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/super.c b/fs/super.c > index 583a0124bc39..48e51f13a4ba 100644 > --- a/fs/super.c > +++ b/fs/super.c > @@ -1469,7 +1469,7 @@ int vfs_get_tree(struct fs_context *fc) > > if (fc->fs_type->fs_flags & FS_REQUIRES_DEV && !fc->source) { > errorf(fc, "Filesystem requires source device"); > - return -ENOENT; > + return -EINVAL; > } > > if (fc->root) > -- > 2.21.0 >