From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-23.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 009BBC433E9 for ; Thu, 18 Feb 2021 18:58:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B0C8A64EB8 for ; Thu, 18 Feb 2021 18:58:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232673AbhBRS6Y (ORCPT ); Thu, 18 Feb 2021 13:58:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52466 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233356AbhBRRLp (ORCPT ); Thu, 18 Feb 2021 12:11:45 -0500 Received: from mail-il1-x12c.google.com (mail-il1-x12c.google.com [IPv6:2607:f8b0:4864:20::12c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8AAA0C061788 for ; Thu, 18 Feb 2021 09:11:05 -0800 (PST) Received: by mail-il1-x12c.google.com with SMTP id q9so2116245ilo.1 for ; Thu, 18 Feb 2021 09:11:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=8yQ/zWxObiX2rUkRsp1l9aOlKO2P0V1q6ExJ8fYc9VI=; b=BSxAOJZzCE6YdIymgI/nnZwgXE5GvvgbV1mpoo8Z8diaoejwUpfHDrusjQuth1K+/l xRaf7RSj1RTJYAv3X5Tec78RSlZbNCeWyYc+oqPZteOj9pA1Ee2UmqkXZVpBECnkRrfs OOT5NunbqV/ZGuvrg8DHAI7J1s1v2ZzTUK02edp0NQMNI6ZwcCiw/GvlX2C0LOTeABTA nPxbI5bP9NBR1LVYCCBLYiNYWVKz0AernT4fBwnlw24ZHwWc33Y69waKVaB1rXpqv9Qb NzbwF5CMrHEQBsiNbVh28khFJpRzGwl8z5HjRJ5HnmLlGtjMDupfpjiNSLJcz8LD7M7k QnSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=8yQ/zWxObiX2rUkRsp1l9aOlKO2P0V1q6ExJ8fYc9VI=; b=LHLCVc02Q5GIQBvOsr9d4CSHov8MlLn6gBWWWB+vvxmxYKbfX0ubm+aoMmEvgebr5v ymQZ0dzKsCrgOovHUk1q7u44u4MYy6qlc8Dgg85lJzCyPdcsATn5nst25ggHVVWaYE7T Ly2LqueKnEYK/t4zT4HqPJ66fN7ZTIRkxH/tCemqiLExSk35d4GnHlaHAIGV/ACTC8s7 I1kvGjJ11rfwL9Na8wBwjgUiNmYCmYLJKMUFgX3s3L8OGyF3FSzyAfNQyfkhmUsOsuE2 VoBRV6wxH2kdOGFpoM5F9tNQ05kh/3vdZzoTGtoW2SOvJ5vdMVC7/z+rlHZAabG2G7Sg y7rw== X-Gm-Message-State: AOAM532WSPD2q3lNgywRbvXBMhYvT/s6mFrD2cg1/ItK2WOOilvlHxaS JwLwj7JKAZX4VYbGal0x+CyuV3oSEwDaV5hYhmfiBQ== X-Google-Smtp-Source: ABdhPJxEtfoENyAGsiLWovEpocXc51k4nYXe4wiW3+m+FLWcg9jEl5tgQgHwo97gzNCS0b9N3HVzK+E5z+mKUQGvut8= X-Received: by 2002:a92:ad0a:: with SMTP id w10mr72733ilh.235.1613668263832; Thu, 18 Feb 2021 09:11:03 -0800 (PST) MIME-Version: 1.0 References: <20210218122546.3546582-1-gmouse@google.com> In-Reply-To: <20210218122546.3546582-1-gmouse@google.com> From: Benjamin Fair Date: Thu, 18 Feb 2021 09:10:26 -0800 Message-ID: Subject: Re: [PATCH] ARM: dts: nuvoton: Fix flash layout To: Anton Kachalov Cc: Avi Fishman , Tomer Maimon , Tali Perry , Patrick Venture , Nancy Yuen , Rob Herring , OpenBMC Maillist , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 18 Feb 2021 at 04:42, wrote: > > From: "Anton D. Kachalov" > > This change satisfy OpenBMC requirements for flash layout. > > Signed-off-by: Anton D. Kachalov > --- > arch/arm/boot/dts/nuvoton-npcm750-evb.dts | 28 +++++++---------------- > 1 file changed, 8 insertions(+), 20 deletions(-) > > diff --git a/arch/arm/boot/dts/nuvoton-npcm750-evb.dts b/arch/arm/boot/dts/nuvoton-npcm750-evb.dts > index bd1eb6ee380f..741c1fee8552 100644 > --- a/arch/arm/boot/dts/nuvoton-npcm750-evb.dts > +++ b/arch/arm/boot/dts/nuvoton-npcm750-evb.dts > @@ -182,8 +182,8 @@ bbuboot2@80000 { > reg = <0x0080000 0x80000>; > read-only; > }; > - envparam@100000 { > - label = "env-param"; > + ubootenv@100000 { > + label = "u-boot-env"; > reg = <0x0100000 0x40000>; > read-only; > }; > @@ -195,25 +195,13 @@ kernel@200000 { > label = "kernel"; > reg = <0x0200000 0x400000>; > }; > - rootfs@600000 { > - label = "rootfs"; > - reg = <0x0600000 0x700000>; > + rofs@780000 { > + label = "rofs"; > + reg = <0x0780000 0x1680000>; > }; > - spare1@D00000 { > - label = "spare1"; > - reg = <0x0D00000 0x200000>; > - }; > - spare2@0F00000 { > - label = "spare2"; > - reg = <0x0F00000 0x200000>; > - }; > - spare3@1100000 { > - label = "spare3"; > - reg = <0x1100000 0x200000>; > - }; > - spare4@1300000 { > - label = "spare4"; > - reg = <0x1300000 0x0>; > + rwfs@1e00000 { > + label = "rwfs"; > + reg = <0x1e00000 0x200000>; > }; I recommend just including the openbmc-flash-layout.dtsi file here instead since that contains the common flash layout for most OpenBMC systems. > }; > }; > -- > 2.30.0.478.g8a0d178c01-goog > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C44EC433DB for ; Thu, 18 Feb 2021 17:11:34 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 02E7F64E2F for ; Thu, 18 Feb 2021 17:11:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 02E7F64E2F Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4DhLpX3xM1z3bP7 for ; Fri, 19 Feb 2021 04:11:32 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20161025 header.b=BSxAOJZz; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=google.com (client-ip=2607:f8b0:4864:20::131; helo=mail-il1-x131.google.com; envelope-from=benjaminfair@google.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20161025 header.b=BSxAOJZz; dkim-atps=neutral Received: from mail-il1-x131.google.com (mail-il1-x131.google.com [IPv6:2607:f8b0:4864:20::131]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4DhLp65qlmz30L4 for ; Fri, 19 Feb 2021 04:11:08 +1100 (AEDT) Received: by mail-il1-x131.google.com with SMTP id o15so2098594ilt.6 for ; Thu, 18 Feb 2021 09:11:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=8yQ/zWxObiX2rUkRsp1l9aOlKO2P0V1q6ExJ8fYc9VI=; b=BSxAOJZzCE6YdIymgI/nnZwgXE5GvvgbV1mpoo8Z8diaoejwUpfHDrusjQuth1K+/l xRaf7RSj1RTJYAv3X5Tec78RSlZbNCeWyYc+oqPZteOj9pA1Ee2UmqkXZVpBECnkRrfs OOT5NunbqV/ZGuvrg8DHAI7J1s1v2ZzTUK02edp0NQMNI6ZwcCiw/GvlX2C0LOTeABTA nPxbI5bP9NBR1LVYCCBLYiNYWVKz0AernT4fBwnlw24ZHwWc33Y69waKVaB1rXpqv9Qb NzbwF5CMrHEQBsiNbVh28khFJpRzGwl8z5HjRJ5HnmLlGtjMDupfpjiNSLJcz8LD7M7k QnSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=8yQ/zWxObiX2rUkRsp1l9aOlKO2P0V1q6ExJ8fYc9VI=; b=eo0Gnc4VKGMFmNdjPuqT6XRT0R5KrSS1wok5bGAdcgGnVZhvmQ03NjgFrRzXr2q9rD 6/oTfclpqlR7WldEhm8ctbl7Bp0MEPYhG0kdNxk1zbpjiwtlT1gEe1TXhlEvLOIJi7hg 4NqAbE9ez2vwYrJ7F2lzN2NBCjg91HTHg1gQhwIZ0qup6EzxK69/xoPxN30uGoMyRTzi L12nZGsYK4KB6nWjFoeYwnyjhz841zGjiN57Yjxg/DXY9ycuOU1M/a/CT6TKVLUr0N4U Y1Dg0a1jhbj2xW2BJj4TNA1iLmrEV0eH9VZqpR1C2p1lsZfBf3ebwz7Ll5P3WYP30vqO hBsQ== X-Gm-Message-State: AOAM532pW4QIU4mZEdpANTE6l+yXGOVF1YuB52vHR6KWNMdN79S8Dqgr 1w9fi2wMa7/F+6g+uTpSR2E3JpxiXz409sMFR3sg8A== X-Google-Smtp-Source: ABdhPJxEtfoENyAGsiLWovEpocXc51k4nYXe4wiW3+m+FLWcg9jEl5tgQgHwo97gzNCS0b9N3HVzK+E5z+mKUQGvut8= X-Received: by 2002:a92:ad0a:: with SMTP id w10mr72733ilh.235.1613668263832; Thu, 18 Feb 2021 09:11:03 -0800 (PST) MIME-Version: 1.0 References: <20210218122546.3546582-1-gmouse@google.com> In-Reply-To: <20210218122546.3546582-1-gmouse@google.com> From: Benjamin Fair Date: Thu, 18 Feb 2021 09:10:26 -0800 Message-ID: Subject: Re: [PATCH] ARM: dts: nuvoton: Fix flash layout To: Anton Kachalov Content-Type: text/plain; charset="UTF-8" X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Tomer Maimon , Avi Fishman , Patrick Venture , OpenBMC Maillist , linux-kernel@vger.kernel.org, Tali Perry , Rob Herring Errors-To: openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org Sender: "openbmc" On Thu, 18 Feb 2021 at 04:42, wrote: > > From: "Anton D. Kachalov" > > This change satisfy OpenBMC requirements for flash layout. > > Signed-off-by: Anton D. Kachalov > --- > arch/arm/boot/dts/nuvoton-npcm750-evb.dts | 28 +++++++---------------- > 1 file changed, 8 insertions(+), 20 deletions(-) > > diff --git a/arch/arm/boot/dts/nuvoton-npcm750-evb.dts b/arch/arm/boot/dts/nuvoton-npcm750-evb.dts > index bd1eb6ee380f..741c1fee8552 100644 > --- a/arch/arm/boot/dts/nuvoton-npcm750-evb.dts > +++ b/arch/arm/boot/dts/nuvoton-npcm750-evb.dts > @@ -182,8 +182,8 @@ bbuboot2@80000 { > reg = <0x0080000 0x80000>; > read-only; > }; > - envparam@100000 { > - label = "env-param"; > + ubootenv@100000 { > + label = "u-boot-env"; > reg = <0x0100000 0x40000>; > read-only; > }; > @@ -195,25 +195,13 @@ kernel@200000 { > label = "kernel"; > reg = <0x0200000 0x400000>; > }; > - rootfs@600000 { > - label = "rootfs"; > - reg = <0x0600000 0x700000>; > + rofs@780000 { > + label = "rofs"; > + reg = <0x0780000 0x1680000>; > }; > - spare1@D00000 { > - label = "spare1"; > - reg = <0x0D00000 0x200000>; > - }; > - spare2@0F00000 { > - label = "spare2"; > - reg = <0x0F00000 0x200000>; > - }; > - spare3@1100000 { > - label = "spare3"; > - reg = <0x1100000 0x200000>; > - }; > - spare4@1300000 { > - label = "spare4"; > - reg = <0x1300000 0x0>; > + rwfs@1e00000 { > + label = "rwfs"; > + reg = <0x1e00000 0x200000>; > }; I recommend just including the openbmc-flash-layout.dtsi file here instead since that contains the common flash layout for most OpenBMC systems. > }; > }; > -- > 2.30.0.478.g8a0d178c01-goog >