From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rodrigo Siqueira Subject: Re: [PATCH 01/10] drm/vkms: Fix crc worker races Date: Wed, 12 Jun 2019 10:33:11 -0300 Message-ID: References: <20190606222751.32567-1-daniel.vetter@ffwll.ch> <20190606222751.32567-2-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-ua1-x942.google.com (mail-ua1-x942.google.com [IPv6:2607:f8b0:4864:20::942]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4051189240 for ; Wed, 12 Jun 2019 13:33:22 +0000 (UTC) Received: by mail-ua1-x942.google.com with SMTP id o19so5890171uap.13 for ; Wed, 12 Jun 2019 06:33:22 -0700 (PDT) In-Reply-To: <20190606222751.32567-2-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Vetter Cc: Shayenne Moura , Haneen Mohammed , DRI Development , Daniel Vetter List-Id: dri-devel@lists.freedesktop.org T24gVGh1LCBKdW4gNiwgMjAxOSBhdCA3OjI4IFBNIERhbmllbCBWZXR0ZXIgPGRhbmllbC52ZXR0 ZXJAZmZ3bGwuY2g+IHdyb3RlOgo+Cj4gVGhlIGlzc3VlIHdlIGhhdmUgaXMgdGhhdCB0aGUgY3Jj IHdvcmtlciBtaWdodCBmYWxsIGJlaGluZC4gV2UndmUKPiB0cmllZCB0byBoYW5kbGUgdGhpcyBi eSB0cmFja2luZyBib3RoIHRoZSBlYXJsaWVzdCBmcmFtZSBmb3Igd2hpY2ggaXQKPiBzdGlsbCBu ZWVkcyB0byBjb21wdXRlIGEgY3JjLCBhbmQgdGhlIGxhc3Qgb25lLiBQbHVzIHdoZW4gdGhlCj4g Y3J0Y19zdGF0ZSBjaGFuZ2VzLCB3ZSBoYXZlIGEgbmV3IHdvcmsgaXRlbSwgd2hpY2ggYXJlIGFs bCBydW4gaW4KPiBvcmRlciBkdWUgdG8gdGhlIG9yZGVyZWQgd29ya3F1ZXVlIHdlIGFsbG9jYXRl IGZvciBlYWNoIHZrbXMgY3J0Yy4KPgo+IFRyb3VibGUgaXMgdGhlcmUncyBiZWVuIGEgZmV3IHNt YWxsIGlzc3VlcyBpbiB0aGUgY3VycmVudCBjb2RlOgo+IC0gd2UgbmVlZCB0byBjYXB0dXJlIGZy YW1lX2VuZCBpbiB0aGUgdmJsYW5rIGhydGltZXIsIG5vdCBpbiB0aGUKPiAgIHdvcmtlci4gVGhl IHdvcmtlciBtaWdodCBydW4gbXVjaCBsYXRlciwgYW5kIHRoZW4gd2UgZ2VuZXJhdGUgYSBsb3QK PiAgIG9mIGNyYyBmb3Igd2hpY2ggdGhlcmUncyBhbHJlYWR5IGEgZGlmZmVyZW50IHdvcmtlciBx dWV1ZWQgdXAuCj4gLSBmcmFtZSBudW1iZXIgbWlnaHQgYmUgMCwgc28gY3JlYXRlIGEgbmV3IGNy Y19wZW5kaW5nIGJvb2xlYW4gdG8KPiAgIHRyYWNrIHRoaXMgd2l0aG91dCBjb25mdXNpb24uCj4g LSB3ZSBuZWVkIHRvIGF0b21pY2FsbHkgZ3JhYiBmcmFtZV9zdGFydC9lbmQgYW5kIGNsZWFyIGl0 LCBzbyBkbyB0aGF0Cj4gICBhbGwgaW4gb25lIGdvLiBUaGlzIGlzIG5vdCBnb2luZyB0byBjcmVh dGUgYSBuZXcgcmFjZSwgYmVjYXVzZSBpZiB3ZQo+ICAgcmFjZSB3aXRoIHRoZSBocnRpbWVyIHRo ZW4gb3VyIHdvcmsgd2lsbCBiZSByZS1ydW4uCj4gLSBvbmx5IHJhY2UgdGhhdCBjYW4gaGFwcGVu IGlzIHRoZSBmb2xsb3dpbmc6Cj4gICAxLiB3b3JrZXIgc3RhcnRzCj4gICAyLiBocnRpbWVyIHJ1 bnMgYW5kIHVwZGF0ZXMgZnJhbWVfZW5kCj4gICAzLiB3b3JrZXIgZ3JhYnMgZnJhbWVfc3RhcnQv ZW5kLCBhbHJlYWR5IHJlYWRpbmcgdGhlIG5ldyBmcmFtZV9lbmQsCj4gICBhbmQgY2xlYXJzIGNy Y19wZW5kaW5nCj4gICA0LiBocnRpbWVyIGNhbGxzIHF1ZXVlX3dvcmsoKQo+ICAgNS4gd29ya2Vy IGNvbXBsZXRlcwo+ICAgNi4gd29ya2VyIGdldHMgIHJlLXJ1biwgY3JjX3BlbmRpbmcgaXMgZmFs c2UKPiAgIEV4cGxhaW4gdGhpcyBjYXNlIGEgYml0IGJldHRlciBieSByZXdvcmRpbmcgdGhlIGNv bW1lbnQuCj4KPiB2MjogRGVtb3RlIHdhcm5pbmcgbGV2ZWwgb3V0cHV0IHRvIGRlYnVnIHdoZW4g d2UgZmFpbCB0byByZXF1ZXVlLCB0aGlzCj4gaXMgZXhwZWN0ZWQgdW5kZXIgaGlnaCBsb2FkIHdo ZW4gdGhlIGNyYyB3b3JrZXIgY2FuJ3QgcXVpdGUga2VlcCB1cC4KPgo+IENjOiBTaGF5ZW5uZSBN b3VyYSA8c2hheWVubmVsdXptb3VyYUBnbWFpbC5jb20+Cj4gQ2M6IFJvZHJpZ28gU2lxdWVpcmEg PHJvZHJpZ29zaXF1ZWlyYW1lbG9AZ21haWwuY29tPgo+IFNpZ25lZC1vZmYtYnk6IERhbmllbCBW ZXR0ZXIgPGRhbmllbC52ZXR0ZXJAaW50ZWwuY29tPgo+IENjOiBIYW5lZW4gTW9oYW1tZWQgPGhh bW9oYW1tZWQuc2FAZ21haWwuY29tPgo+IENjOiBEYW5pZWwgVmV0dGVyIDxkYW5pZWxAZmZ3bGwu Y2g+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS92a21zL3ZrbXNfY3JjLmMgIHwgMjcgKysrKysr KysrKysrKy0tLS0tLS0tLS0tLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS92a21zL3ZrbXNfY3J0Yy5j IHwgIDkgKysrKysrKy0tCj4gIGRyaXZlcnMvZ3B1L2RybS92a21zL3ZrbXNfZHJ2LmggIHwgIDIg KysKPiAgMyBmaWxlcyBjaGFuZ2VkLCAyMiBpbnNlcnRpb25zKCspLCAxNiBkZWxldGlvbnMoLSkK Pgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vdmttcy92a21zX2NyYy5jIGIvZHJpdmVy cy9ncHUvZHJtL3ZrbXMvdmttc19jcmMuYwo+IGluZGV4IGQ3YjQwOWEzYzBmOC4uNjY2MDNkYTYz NGZlIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS92a21zL3ZrbXNfY3JjLmMKPiArKysg Yi9kcml2ZXJzL2dwdS9kcm0vdmttcy92a21zX2NyYy5jCj4gQEAgLTE2NiwxNiArMTY2LDI0IEBA IHZvaWQgdmttc19jcmNfd29ya19oYW5kbGUoc3RydWN0IHdvcmtfc3RydWN0ICp3b3JrKQo+ICAg ICAgICAgc3RydWN0IGRybV9wbGFuZSAqcGxhbmU7Cj4gICAgICAgICB1MzIgY3JjMzIgPSAwOwo+ ICAgICAgICAgdTY0IGZyYW1lX3N0YXJ0LCBmcmFtZV9lbmQ7Cj4gKyAgICAgICBib29sIGNyY19w ZW5kaW5nOwo+ICAgICAgICAgdW5zaWduZWQgbG9uZyBmbGFnczsKPgo+ICAgICAgICAgc3Bpbl9s b2NrX2lycXNhdmUoJm91dC0+c3RhdGVfbG9jaywgZmxhZ3MpOwo+ICAgICAgICAgZnJhbWVfc3Rh cnQgPSBjcnRjX3N0YXRlLT5mcmFtZV9zdGFydDsKPiAgICAgICAgIGZyYW1lX2VuZCA9IGNydGNf c3RhdGUtPmZyYW1lX2VuZDsKPiArICAgICAgIGNyY19wZW5kaW5nID0gY3J0Y19zdGF0ZS0+Y3Jj X3BlbmRpbmc7Cj4gKyAgICAgICBjcnRjX3N0YXRlLT5mcmFtZV9zdGFydCA9IDA7Cj4gKyAgICAg ICBjcnRjX3N0YXRlLT5mcmFtZV9lbmQgPSAwOwo+ICsgICAgICAgY3J0Y19zdGF0ZS0+Y3JjX3Bl bmRpbmcgPSBmYWxzZTsKPiAgICAgICAgIHNwaW5fdW5sb2NrX2lycXJlc3RvcmUoJm91dC0+c3Rh dGVfbG9jaywgZmxhZ3MpOwo+Cj4gLSAgICAgICAvKiBfdmJsYW5rX2hhbmRsZSgpIGhhc24ndCB1 cGRhdGVkIGZyYW1lX3N0YXJ0IHlldCAqLwo+IC0gICAgICAgaWYgKCFmcmFtZV9zdGFydCB8fCBm cmFtZV9zdGFydCA9PSBmcmFtZV9lbmQpCj4gLSAgICAgICAgICAgICAgIGdvdG8gb3V0Owo+ICsg ICAgICAgLyoKPiArICAgICAgICAqIFdlIHJhY2VkIHdpdGggdGhlIHZibGFuayBocnRpbWVyIGFu ZCBwcmV2aW91cyB3b3JrIGFscmVhZHkgY29tcHV0ZWQKPiArICAgICAgICAqIHRoZSBjcmMsIG5v dGhpbmcgdG8gZG8uCj4gKyAgICAgICAgKi8KPiArICAgICAgIGlmICghY3JjX3BlbmRpbmcpCj4g KyAgICAgICAgICAgICAgIHJldHVybjsKCkkgdGhpbmsgdGhpcyBjb25kaXRpb24gaXMgbm90IHJl YWNoYWJsZSBiZWNhdXNlIGNyY19wZW5kaW5nIHdpbGwgYmUKZmlsbGVkIHdpdGggdHJ1ZSBpbiBg dmttc192Ymxhbmtfc2ltdWxhdGUoKWAgd2hpY2ggaW4gdHVybiBzY2hlZHVsZQp0aGUgZnVuY3Rp b24gYHZrbXNfY3JjX3dvcmtfaGFuZGxlKClgLiBKdXN0IGZvciBjaGVja2luZywgSSB0cmllZCB0 bwpyZWFjaCB0aGlzIGNvbmRpdGlvbiBieSBydW5uaW5nIGttc19mbGlwLCBrbXNfcGlwZV9jcmNf YmFzaWMsIGFuZAprbXNfY3Vyc29yX2NyYyB3aXRoIHR3byBkaWZmZXJlbnQgVk0gc2V0dXBzWzFd LCBidXQgSSBjb3VsZG4ndCByZWFjaAppdC4gV2hhdCBkbyB5b3UgdGhpbms/CgpbMV0gUWVtdSBw YXJhbWV0ZXJzClZNMTogLW0gMUcgLXNtcCBjb3Jlcz0yLGNwdXM9MgpWTTI6IC1lbmFibGUta3Zt IC1tIDJHIC1zbXAgY29yZXM9NCxjcHVzPTQKCj4gICAgICAgICBkcm1fZm9yX2VhY2hfcGxhbmUo cGxhbmUsICZ2ZGV2LT5kcm0pIHsKPiAgICAgICAgICAgICAgICAgc3RydWN0IHZrbXNfcGxhbmVf c3RhdGUgKnZwbGFuZV9zdGF0ZTsKPiBAQCAtMTk2LDIwICsyMDQsMTEgQEAgdm9pZCB2a21zX2Ny Y193b3JrX2hhbmRsZShzdHJ1Y3Qgd29ya19zdHJ1Y3QgKndvcmspCj4gICAgICAgICBpZiAocHJp bWFyeV9jcmMpCj4gICAgICAgICAgICAgICAgIGNyYzMyID0gX3ZrbXNfZ2V0X2NyYyhwcmltYXJ5 X2NyYywgY3Vyc29yX2NyYyk7Cj4KPiAtICAgICAgIGZyYW1lX2VuZCA9IGRybV9jcnRjX2FjY3Vy YXRlX3ZibGFua19jb3VudChjcnRjKTsKPiAtCj4gLSAgICAgICAvKiBxdWV1ZV93b3JrIGNhbiBm YWlsIHRvIHNjaGVkdWxlIGNyY193b3JrOyBhZGQgY3JjIGZvcgo+IC0gICAgICAgICogbWlzc2lu ZyBmcmFtZXMKPiArICAgICAgIC8qCj4gKyAgICAgICAgKiBUaGUgd29ya2VyIGNhbiBmYWxsIGJl aGluZCB0aGUgdmJsYW5rIGhydGltZXIsIG1ha2Ugc3VyZSB3ZSBjYXRjaCB1cC4KPiAgICAgICAg ICAqLwo+ICAgICAgICAgd2hpbGUgKGZyYW1lX3N0YXJ0IDw9IGZyYW1lX2VuZCkKPiAgICAgICAg ICAgICAgICAgZHJtX2NydGNfYWRkX2NyY19lbnRyeShjcnRjLCB0cnVlLCBmcmFtZV9zdGFydCsr LCAmY3JjMzIpOwoKSSB3YW50IHRvIHRha2UgdGhpcyBvcHBvcnR1bml0eSB0byBhc2sgYWJvdXQg dGhpcyB3aGlsZTsgSXQncyBub3QKcmVhbGx5IHNwZWNpZmljIHRvIHRoaXMgcGF0Y2guCgpJIGhh dmUgdG8gYWRtaXQgdGhhdCBJIG5ldmVyIGZ1bGx5IGdvdCB0aGUgaWRlYSBiZWhpbmQgdGhpcyAn d2hpbGUnOwppdCBsb29rcyBsaWtlIHRoYXQgd2UganVzdCBmaWxsIG91dCB0aGUgbWlzc2VkIGZy YW1lcyB3aXRoIGEgcmVwZWF0ZWQKdmFsdWUuIEZXSVUsIGBkcm1fY3J0Y19hZGRfY3JjX2VudHJ5 KClgIHdpbGwgYWRkIGFuIGVudHJ5IHdpdGggdGhlIENSQwppbmZvcm1hdGlvbiBmb3IgYSBmcmFt ZSwgYnV0IGluIHRoaXMgY2FzZSwgd2UgYXJlIGFkZGluZyB0aGUgc2FtZSBDUkMKZm9yIGEgZGlm ZmVyZW50IHNldCBvZiBmcmFtZXMuIEkgYWdyZWUgdGhhdCBuZWFyIGZyYW1lIGhhcyBhIHNpbWls YXIKQ1JDIHZhbHVlLCBidXQgY291bGQgd2UgcmVseSBvbiB0aGlzIGFsbCB0aGUgdGltZT8gV2hh dCBjb3VsZCBoYXBwZW4KaWYgd2UgaGF2ZSBhIGdyZWF0IGRpZmZlcmVuY2UgZnJvbSB0aGUgZnJh bWVfc3RhcnQgYW5kIGZyYW1lX2VuZD8KCj4gLQo+IC1vdXQ6Cj4gLSAgICAgICAvKiB0byBhdm9p ZCB1c2luZyB0aGUgc2FtZSB2YWx1ZSBmb3IgZnJhbWUgbnVtYmVyIGFnYWluICovCj4gLSAgICAg ICBzcGluX2xvY2tfaXJxc2F2ZSgmb3V0LT5zdGF0ZV9sb2NrLCBmbGFncyk7Cj4gLSAgICAgICBj cnRjX3N0YXRlLT5mcmFtZV9lbmQgPSBmcmFtZV9lbmQ7Cj4gLSAgICAgICBjcnRjX3N0YXRlLT5m cmFtZV9zdGFydCA9IDA7Cj4gLSAgICAgICBzcGluX3VubG9ja19pcnFyZXN0b3JlKCZvdXQtPnN0 YXRlX2xvY2ssIGZsYWdzKTsKPiAgfQo+Cj4gIHN0YXRpYyBpbnQgdmttc19jcmNfcGFyc2Vfc291 cmNlKGNvbnN0IGNoYXIgKnNyY19uYW1lLCBib29sICplbmFibGVkKQo+IGRpZmYgLS1naXQgYS9k cml2ZXJzL2dwdS9kcm0vdmttcy92a21zX2NydGMuYyBiL2RyaXZlcnMvZ3B1L2RybS92a21zL3Zr bXNfY3J0Yy5jCj4gaW5kZXggMWJiZTA5OWI3ZGI4Li5jNzI3ZDg0ODZlOTcgMTAwNjQ0Cj4gLS0t IGEvZHJpdmVycy9ncHUvZHJtL3ZrbXMvdmttc19jcnRjLmMKPiArKysgYi9kcml2ZXJzL2dwdS9k cm0vdmttcy92a21zX2NydGMuYwo+IEBAIC0zMCwxMyArMzAsMTggQEAgc3RhdGljIGVudW0gaHJ0 aW1lcl9yZXN0YXJ0IHZrbXNfdmJsYW5rX3NpbXVsYXRlKHN0cnVjdCBocnRpbWVyICp0aW1lcikK PiAgICAgICAgICAgICAgICAgICogaGFzIHJlYWQgdGhlIGRhdGEKPiAgICAgICAgICAgICAgICAg ICovCj4gICAgICAgICAgICAgICAgIHNwaW5fbG9jaygmb3V0cHV0LT5zdGF0ZV9sb2NrKTsKPiAt ICAgICAgICAgICAgICAgaWYgKCFzdGF0ZS0+ZnJhbWVfc3RhcnQpCj4gKyAgICAgICAgICAgICAg IGlmICghc3RhdGUtPmNyY19wZW5kaW5nKQo+ICAgICAgICAgICAgICAgICAgICAgICAgIHN0YXRl LT5mcmFtZV9zdGFydCA9IGZyYW1lOwo+ICsgICAgICAgICAgICAgICBlbHNlCj4gKyAgICAgICAg ICAgICAgICAgICAgICAgRFJNX0RFQlVHX0RSSVZFUigiY3JjIHdvcmtlciBmYWxsaW5nIGJlaGlu ZCwgZnJhbWVfc3RhcnQ6ICVsbHUsIGZyYW1lX2VuZDogJWxsdVxuIiwKPiArICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIHN0YXRlLT5mcmFtZV9zdGFydCwgZnJhbWUpOwo+ ICsgICAgICAgICAgICAgICBzdGF0ZS0+ZnJhbWVfZW5kID0gZnJhbWU7Cj4gKyAgICAgICAgICAg ICAgIHN0YXRlLT5jcmNfcGVuZGluZyA9IHRydWU7Cj4gICAgICAgICAgICAgICAgIHNwaW5fdW5s b2NrKCZvdXRwdXQtPnN0YXRlX2xvY2spOwo+Cj4gICAgICAgICAgICAgICAgIHJldCA9IHF1ZXVl X3dvcmsob3V0cHV0LT5jcmNfd29ya3EsICZzdGF0ZS0+Y3JjX3dvcmspOwo+ICAgICAgICAgICAg ICAgICBpZiAoIXJldCkKPiAtICAgICAgICAgICAgICAgICAgICAgICBEUk1fV0FSTigiZmFpbGVk IHRvIHF1ZXVlIHZrbXNfY3JjX3dvcmtfaGFuZGxlIik7Cj4gKyAgICAgICAgICAgICAgICAgICAg ICAgRFJNX0RFQlVHX0RSSVZFUigidmttc19jcmNfd29ya19oYW5kbGUgYWxyZWFkeSBxdWV1ZWRc biIpOwo+ICAgICAgICAgfQo+Cj4gICAgICAgICBzcGluX3VubG9jaygmb3V0cHV0LT5sb2NrKTsK PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL3ZrbXMvdmttc19kcnYuaCBiL2RyaXZlcnMv Z3B1L2RybS92a21zL3ZrbXNfZHJ2LmgKPiBpbmRleCA4MWYxY2ZiZWI5MzYuLjNjN2UwNmIxOWVm ZCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vdmttcy92a21zX2Rydi5oCj4gKysrIGIv ZHJpdmVycy9ncHUvZHJtL3ZrbXMvdmttc19kcnYuaAo+IEBAIC01Niw2ICs1Niw4IEBAIHN0cnVj dCB2a21zX3BsYW5lX3N0YXRlIHsKPiAgc3RydWN0IHZrbXNfY3J0Y19zdGF0ZSB7Cj4gICAgICAg ICBzdHJ1Y3QgZHJtX2NydGNfc3RhdGUgYmFzZTsKPiAgICAgICAgIHN0cnVjdCB3b3JrX3N0cnVj dCBjcmNfd29yazsKPiArCj4gKyAgICAgICBib29sIGNyY19wZW5kaW5nOwo+ICAgICAgICAgdTY0 IGZyYW1lX3N0YXJ0Owo+ICAgICAgICAgdTY0IGZyYW1lX2VuZDsKPiAgfTsKPiAtLQo+IDIuMjAu MQo+CgoKLS0gCgpSb2RyaWdvIFNpcXVlaXJhCmh0dHBzOi8vc2lxdWVpcmEudGVjaApfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGlu ZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVl ZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWw=