From: Austin Kim <austindh.kim@gmail.com>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] xfs: Use WARN_ON rather than BUG() for bailout mount-operation
Date: Thu, 29 Aug 2019 06:30:43 +0900 [thread overview]
Message-ID: <CADLLry50iDrEfDrL3kZP_gku6jnO23qi5VVyuFY3g2BubWg0ww@mail.gmail.com> (raw)
In-Reply-To: <20190828151411.GC1037350@magnolia>
Dear Mr. Darrick J. Wong
Thanks for reviewing patch. BTW, I have a question for you.
Do I have to update the patch again with 'a space before the brace'?
Or could I just wait for the patch to be imported?
It would be thankful if you give me a feedback.
BR,
Guillermo Austin Kim
2019년 8월 29일 (목) 오전 12:14, Darrick J. Wong <darrick.wong@oracle.com>님이 작성:
>
> On Wed, Aug 28, 2019 at 03:47:49PM +0900, Austin Kim wrote:
> > If the CONFIG_BUG is enabled, BUG() is executed and then system is crashed.
> > However, the bailout for mount is no longer proceeding.
> >
> > For this reason, using WARN_ON rather than BUG() could prevent this situation.
> > ---
> > fs/xfs/xfs_mount.c | 3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/fs/xfs/xfs_mount.c b/fs/xfs/xfs_mount.c
> > index 322da69..10fe000 100644
> > --- a/fs/xfs/xfs_mount.c
> > +++ b/fs/xfs/xfs_mount.c
> > @@ -213,8 +213,7 @@ xfs_initialize_perag(
> > goto out_hash_destroy;
> >
> > spin_lock(&mp->m_perag_lock);
> > - if (radix_tree_insert(&mp->m_perag_tree, index, pag)) {
> > - BUG();
> > + if (WARN_ON(radix_tree_insert(&mp->m_perag_tree, index, pag))){
>
> Need a space before the brace.
>
> Will fix on import,
> Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
>
> --D
>
> > spin_unlock(&mp->m_perag_lock);
> > radix_tree_preload_end();
> > error = -EEXIST;
> > --
> > 2.6.2
> >
next prev parent reply other threads:[~2019-08-28 21:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-28 6:47 [PATCH] xfs: Use WARN_ON rather than BUG() for bailout mount-operation Austin Kim
2019-08-28 15:14 ` Darrick J. Wong
2019-08-28 21:30 ` Austin Kim [this message]
2019-08-28 21:51 ` Darrick J. Wong
2019-08-29 7:56 ` Christoph Hellwig
2019-08-29 12:59 ` Austin Kim
2019-08-29 15:58 ` Darrick J. Wong
2019-08-29 15:01 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADLLry50iDrEfDrL3kZP_gku6jnO23qi5VVyuFY3g2BubWg0ww@mail.gmail.com \
--to=austindh.kim@gmail.com \
--cc=darrick.wong@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.