All of lore.kernel.org
 help / color / mirror / Atom feed
From: Austin Kim <austindh.kim@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: tj@kernel.org, neilb@suse.de, linux-kernel@vger.kernel.org,
	김동현 <austin.kim@lge.com>
Subject: Re: [PATCH] kernfs: move return value check after kmalloc()
Date: Fri, 21 May 2021 15:55:23 +0900	[thread overview]
Message-ID: <CADLLry5J5GqB_Rw7n0aKcWgYPJZDOQP89mvyWT-GnB8KAiQrBA@mail.gmail.com> (raw)
In-Reply-To: <YKc5jLVhw8+Oy165@kroah.com>

2021년 5월 21일 (금) 오후 1:39, Greg KH <gregkh@linuxfoundation.org>님이 작성:
>
> On Fri, May 21, 2021 at 03:55:25AM +0100, Austin Kim wrote:
> > With 414985ae23c0 ("sysfs, kernfs: move file core code to fs/kernfs/file.c"),
> > 'return -ENOMEM' is executed when kmalloc() returns NULL.
> >
> > Since 'commit 4ef67a8c95f3 ("sysfs/kernfs: make read requests on pre-alloc
> > files use the buffer.")', 'return -ENOMEM' statement is not properly located.
> >
> > Fix it by moving 'return -ENOMEM' after return from kmalloc().
> >
> > Fixes: 4ef67a8c95f3 ("sysfs/kernfs: make read requests on pre-alloc files use the buffer.")
> > Signed-off-by: Austin Kim <austindh.kim@gmail.com>
[...]
>
> Like Neil said, I don't see the "bug" you are fixing here.  What is
> currently wrong with the existing code?

I just found something to improve a little, which has nothing to do with 'Bug'.
(of->prealloc_buf is allocated ahead of kernfs_file_read_iter().)

Should be cautious of adding 'Fixes' tag.

Thanks

>
> thanks,
>
> greg k-h

  reply	other threads:[~2021-05-21  6:57 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-21  2:55 [PATCH] kernfs: move return value check after kmalloc() Austin Kim
2021-05-21  3:28 ` NeilBrown
2021-05-21  4:39 ` Greg KH
2021-05-21  6:55   ` Austin Kim [this message]
2021-05-21 12:15     ` David Laight
2021-05-21 12:55 ` David Laight

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CADLLry5J5GqB_Rw7n0aKcWgYPJZDOQP89mvyWT-GnB8KAiQrBA@mail.gmail.com \
    --to=austindh.kim@gmail.com \
    --cc=austin.kim@lge.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=neilb@suse.de \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.