All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/msm/dpu: remove unused variable cmd_enc
@ 2021-05-21  4:16 ` Austin Kim
  0 siblings, 0 replies; 4+ messages in thread
From: Austin Kim @ 2021-05-21  4:16 UTC (permalink / raw)
  To: robdclark, sean, airlied, daniel, angelogioacchino.delregno,
	dmitry.baryshkov
  Cc: linux-arm-msm, dri-devel, freedreno, linux-kernel, autindh.kim,
	kernel-team

After the call to to_dpu_encoder_phys_cmd() is made,
'cmd_enc' is not used. Where to_dpu_encoder_phys_cmd() is simply replaced with
container_of(x, struct dpu_encoder_phys_cmd, base) by compiler.

So it had better remove W=1 kernel build warning(s):

  drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c: In function
 ‘dpu_encoder_phys_cmd_wait_for_commit_done’:
  drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c:688:31: warning:
  variable ‘cmd_enc’ set but not used

Signed-off-by: Austin Kim <austindh.kim@gmail.com>
---
 drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c
index b2be39b9144e..088900841bf8 100644
--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c
+++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c
@@ -685,10 +685,6 @@ static int dpu_encoder_phys_cmd_wait_for_tx_complete(
 static int dpu_encoder_phys_cmd_wait_for_commit_done(
 		struct dpu_encoder_phys *phys_enc)
 {
-	struct dpu_encoder_phys_cmd *cmd_enc;
-
-	cmd_enc = to_dpu_encoder_phys_cmd(phys_enc);
-
 	/* only required for master controller */
 	if (!dpu_encoder_phys_cmd_is_master(phys_enc))
 		return 0;
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread
* [PATCH] drm/msm/dpu: remove unused variable cmd_enc
@ 2021-05-21  4:16 ` Austin Kim
  0 siblings, 0 replies; 4+ messages in thread
From: Austin Kim @ 2021-05-21  4:16 UTC (permalink / raw)
  To: robdclark, sean, airlied, daniel, angelogioacchino.delregno,
	dmitry.baryshkov
  Cc: autindh.kim, linux-arm-msm, linux-kernel, dri-devel, kernel-team,
	freedreno

After the call to to_dpu_encoder_phys_cmd() is made,
'cmd_enc' is not used. Where to_dpu_encoder_phys_cmd() is simply replaced with
container_of(x, struct dpu_encoder_phys_cmd, base) by compiler.

So it had better remove W=1 kernel build warning(s):

  drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c: In function
 ‘dpu_encoder_phys_cmd_wait_for_commit_done’:
  drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c:688:31: warning:
  variable ‘cmd_enc’ set but not used

Signed-off-by: Austin Kim <austindh.kim@gmail.com>
---
 drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c
index b2be39b9144e..088900841bf8 100644
--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c
+++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c
@@ -685,10 +685,6 @@ static int dpu_encoder_phys_cmd_wait_for_tx_complete(
 static int dpu_encoder_phys_cmd_wait_for_commit_done(
 		struct dpu_encoder_phys *phys_enc)
 {
-	struct dpu_encoder_phys_cmd *cmd_enc;
-
-	cmd_enc = to_dpu_encoder_phys_cmd(phys_enc);
-
 	/* only required for master controller */
 	if (!dpu_encoder_phys_cmd_is_master(phys_enc))
 		return 0;
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH] drm/msm/dpu: remove unused variable cmd_enc
  2021-05-21  4:16 ` Austin Kim
@ 2021-05-27  3:00   ` Austin Kim
  -1 siblings, 0 replies; 4+ messages in thread
From: Austin Kim @ 2021-05-27  3:00 UTC (permalink / raw)
  To: robdclark, sean, airlied, Daniel Vetter,
	angelogioacchino.delregno, dmitry.baryshkov
  Cc: linux-arm-msm, dri-devel, freedreno, linux-kernel,
	김동현

2021년 5월 21일 (금) 오후 1:16, Austin Kim <austindh.kim@gmail.com>님이 작성:
>
> After the call to to_dpu_encoder_phys_cmd() is made,
> 'cmd_enc' is not used. Where to_dpu_encoder_phys_cmd() is simply replaced with
> container_of(x, struct dpu_encoder_phys_cmd, base) by compiler.
>
> So it had better remove W=1 kernel build warning(s):
>
>   drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c: In function
>  ‘dpu_encoder_phys_cmd_wait_for_commit_done’:
>   drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c:688:31: warning:
>   variable ‘cmd_enc’ set but not used
>
> Signed-off-by: Austin Kim <austindh.kim@gmail.com>
> ---
>  drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c | 4 ----
>  1 file changed, 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c
> index b2be39b9144e..088900841bf8 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c
> @@ -685,10 +685,6 @@ static int dpu_encoder_phys_cmd_wait_for_tx_complete(
>  static int dpu_encoder_phys_cmd_wait_for_commit_done(
>                 struct dpu_encoder_phys *phys_enc)
>  {
> -       struct dpu_encoder_phys_cmd *cmd_enc;
> -
> -       cmd_enc = to_dpu_encoder_phys_cmd(phys_enc);
> -
>         /* only required for master controller */
>         if (!dpu_encoder_phys_cmd_is_master(phys_enc))
>                 return 0;
> --
> 2.20.1
>

If you are available, would you please review this patch.

BR,
Austin Kim

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] drm/msm/dpu: remove unused variable cmd_enc
@ 2021-05-27  3:00   ` Austin Kim
  0 siblings, 0 replies; 4+ messages in thread
From: Austin Kim @ 2021-05-27  3:00 UTC (permalink / raw)
  To: robdclark, sean, airlied, Daniel Vetter,
	angelogioacchino.delregno, dmitry.baryshkov
  Cc: linux-arm-msm, freedreno, linux-kernel, dri-devel,
	김동현

2021년 5월 21일 (금) 오후 1:16, Austin Kim <austindh.kim@gmail.com>님이 작성:
>
> After the call to to_dpu_encoder_phys_cmd() is made,
> 'cmd_enc' is not used. Where to_dpu_encoder_phys_cmd() is simply replaced with
> container_of(x, struct dpu_encoder_phys_cmd, base) by compiler.
>
> So it had better remove W=1 kernel build warning(s):
>
>   drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c: In function
>  ‘dpu_encoder_phys_cmd_wait_for_commit_done’:
>   drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c:688:31: warning:
>   variable ‘cmd_enc’ set but not used
>
> Signed-off-by: Austin Kim <austindh.kim@gmail.com>
> ---
>  drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c | 4 ----
>  1 file changed, 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c
> index b2be39b9144e..088900841bf8 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c
> @@ -685,10 +685,6 @@ static int dpu_encoder_phys_cmd_wait_for_tx_complete(
>  static int dpu_encoder_phys_cmd_wait_for_commit_done(
>                 struct dpu_encoder_phys *phys_enc)
>  {
> -       struct dpu_encoder_phys_cmd *cmd_enc;
> -
> -       cmd_enc = to_dpu_encoder_phys_cmd(phys_enc);
> -
>         /* only required for master controller */
>         if (!dpu_encoder_phys_cmd_is_master(phys_enc))
>                 return 0;
> --
> 2.20.1
>

If you are available, would you please review this patch.

BR,
Austin Kim

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-05-27  3:00 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-21  4:16 [PATCH] drm/msm/dpu: remove unused variable cmd_enc Austin Kim
2021-05-21  4:16 ` Austin Kim
2021-05-27  3:00 ` Austin Kim
2021-05-27  3:00   ` Austin Kim

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.