All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Paweł Wiejacha" <pawel.wiejacha@rtbhouse.com>
To: Song Liu <song@kernel.org>
Cc: Guoqing Jiang <jgq516@gmail.com>, Christoph Hellwig <hch@lst.de>,
	linux-raid <linux-raid@vger.kernel.org>,
	Artur Paszkiewicz <artur.paszkiewicz@intel.com>
Subject: Re: [PATCH V2 0/7] md: io stats accounting
Date: Thu, 27 May 2021 16:09:51 +0200	[thread overview]
Message-ID: <CADLTsw3sbcODQYQKvA0dTBqw2sEuqKzoosPt0vwzD3j36HZQPA@mail.gmail.com> (raw)
In-Reply-To: <CAPhsuW7FuNz_stvmvPSYsSypDxJadFEUFZ6Bq1U517EK7N25Og@mail.gmail.com>

On Mon, 24 May 2021 at 08:04, Song Liu <song@kernel.org> wrote:
>
> On Thu, May 20, 2021 at 5:56 PM Guoqing Jiang <jgq516@gmail.com> wrote:
> >
> > V2 changes:
> >
> > 1. add accounting_bio to md_personality.
> > 2. cleanup in case bioset_integrity_create fails.
> > 3. use bio_end_io_acct.
> > 4. remove patch for enable io accounting for multipath.
> > 5. add one patch to rename print_msg.
> > 6. add one patch to deprecate linear, multipath and faulty.
> >
> > Artur Paszkiewicz (1):
> >   md: the latest try for improve io stats accounting
> >
> > Guoqing Jiang (6):
> >   md: revert io stats accounting
> >   md: add accounting_bio for raid0 and raid5
> >   md/raid1: rename print_msg with r1bio_existed
> >   md/raid1: enable io accounting
> >   md/raid10: enable io accounting
> >   md: mark some personalities as deprecated
>
> Thanks Guoqing! This version looks great to me. No need to send v3 for
> those two minor comments.
>
> Artur and Christoph, could you please share your comments on this version
> and/or reply with your Reviewed-by tag?
>
> Pawel, could you please run your tests with this set? Note that, the test should
> be run after setting
>    echo 1 > /sys/block/mdXXX/queue/iostats

I've been testing this patchset for a while (with md iostats enabled)
and no double fault occurred.

Thanks!
Paweł Wiejacha

> Thanks,
> Song
>
> >

      reply	other threads:[~2021-05-27 14:10 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-21  0:55 [PATCH V2 0/7] md: io stats accounting Guoqing Jiang
2021-05-21  0:55 ` [PATCH V2 1/7] md: revert " Guoqing Jiang
2021-05-21  0:55 ` [PATCH V2 2/7] md: add accounting_bio for raid0 and raid5 Guoqing Jiang
2021-05-24  5:48   ` Song Liu
2021-05-24  8:45   ` Christoph Hellwig
2021-05-21  0:55 ` [PATCH V2 3/7] md: the latest try for improve io stats accounting Guoqing Jiang
2021-05-21  7:32   ` Artur Paszkiewicz
2021-05-21  7:43     ` Guoqing Jiang
2021-05-21  0:55 ` [PATCH V2 4/7] md/raid1: rename print_msg with r1bio_existed Guoqing Jiang
2021-05-21  0:55 ` [PATCH V2 5/7] md/raid1: enable io accounting Guoqing Jiang
2021-05-21  0:55 ` [PATCH V2 6/7] md/raid10: " Guoqing Jiang
2021-05-21  0:55 ` [PATCH V2 7/7] md: mark some personalities as deprecated Guoqing Jiang
2021-05-21  8:00 ` [UPDATE PATCH V2 3/7] md: the latest try for improve io stats accounting Guoqing Jiang
2021-05-24  5:49   ` Song Liu
2021-05-24  6:04 ` [PATCH V2 0/7] md: " Song Liu
2021-05-27 14:09   ` Paweł Wiejacha [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CADLTsw3sbcODQYQKvA0dTBqw2sEuqKzoosPt0vwzD3j36HZQPA@mail.gmail.com \
    --to=pawel.wiejacha@rtbhouse.com \
    --cc=artur.paszkiewicz@intel.com \
    --cc=hch@lst.de \
    --cc=jgq516@gmail.com \
    --cc=linux-raid@vger.kernel.org \
    --cc=song@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.