All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jay Rolette <rolette@infinite.io>
To: Andriy Berestovskyy <aber@semihalf.com>
Cc: DPDK <dev@dpdk.org>, "Richardson, Bruce" <bruce.richardson@intel.com>
Subject: Re: Couple of PMD questions
Date: Wed, 20 Apr 2016 07:45:21 -0500	[thread overview]
Message-ID: <CADNuJVqLHjq7f-Zg=8Si_X4q=0w76TTyX7u1x8VcsM6uaB3=Ew@mail.gmail.com> (raw)
In-Reply-To: <CAOysbxosz8vLq682U0q7fmeQqkVHzpuS-reUpBS+XycnBiRFag@mail.gmail.com>

On Wed, Apr 20, 2016 at 4:35 AM, Andriy Berestovskyy <aber@semihalf.com>
wrote:

> Hi Jay,
>
> On Tue, Apr 19, 2016 at 10:16 PM, Jay Rolette <rolette@infinite.io> wrote:
> > Should the driver error out in that case instead of only "sort of"
> working?
>
> +1, we hit the same issue. Error or log message would help.
>
> > If I support a max frame size of 9216 bytes (exactly a 1K multiple to
> make
> > the NIC happy), then max_rx_pkt_len is going to be 9216 and
> data_room_size
> > will be 9216 + RTE_PKTMBUF_HEADROOM.
>
> Try to set max_rx_pkt_len <= 9K - 8 and mempool element size to 9K +
> headroom + size of structures.
>

Thanks, Andriy. That makes sense given how the code + NIC are working.


> > Is that check correct?
>
> Datasheet says:
> The MFS does not include the 4 bytes of the VLAN header. Packets with
> VLAN header can be as large as MFS + 4. When double VLAN is enabled,
> the device adds 8 to the MFS for any packets.
>

Gotcha. Hopefully we can get the docs and example code up to where app
developers don't need to crawl through driver source and NIC datasheets.
That or have rte_pktmbuf_pool_create() take care of that sort of detail
automatically. :-)

Jay


Regards,
> Andriy
>

      reply	other threads:[~2016-04-20 12:45 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-19 20:16 Couple of PMD questions Jay Rolette
2016-04-20  9:10 ` Bruce Richardson
2016-04-20 12:22   ` Jay Rolette
2016-04-20 14:05     ` Bruce Richardson
2016-04-20 15:47       ` Jay Rolette
2016-04-21  9:13         ` Andriy Berestovskyy
2016-04-21 10:54         ` Bruce Richardson
2016-04-20  9:35 ` Andriy Berestovskyy
2016-04-20 12:45   ` Jay Rolette [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CADNuJVqLHjq7f-Zg=8Si_X4q=0w76TTyX7u1x8VcsM6uaB3=Ew@mail.gmail.com' \
    --to=rolette@infinite.io \
    --cc=aber@semihalf.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.