From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, HTML_MESSAGE,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 658CEC433FE for ; Fri, 11 Dec 2020 22:52:27 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1E9F52065D for ; Fri, 11 Dec 2020 22:52:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1E9F52065D Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:55218 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1knrGz-00020F-UL for qemu-devel@archiver.kernel.org; Fri, 11 Dec 2020 17:52:25 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:34952) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1knqe0-0006NC-Ph for qemu-devel@nongnu.org; Fri, 11 Dec 2020 17:12:08 -0500 Received: from mail-ua1-x930.google.com ([2607:f8b0:4864:20::930]:42229) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1knqdv-0008Jl-Hd for qemu-devel@nongnu.org; Fri, 11 Dec 2020 17:12:06 -0500 Received: by mail-ua1-x930.google.com with SMTP id n18so3357602ual.9 for ; Fri, 11 Dec 2020 14:12:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=9+uHv4Wm+iKl9lLbvgWgdhvc6TGd5i1tZxe9mRrn3bY=; b=pJxJKP4+0lg46afX28JDwTvcQn/SZLAuRjkUgv6+BYifGpHVZdj9UnbEsjwYhwRfzE Q/W6a8kvPZIoBiHRalBRPRQXL8HOpHYmzzV26WZKDpzjrON0B9BDzRKIKzCa5Ug/xhYK HX7BrTgEmqXQ4CculxDdS2z58pwJvDMyC3Sx2yr2rWyZYYtwBma60DPWoMSmkwekmYag eDQb+5+PMHVyx+Hfc8uMyAxpswUrA6VsMXsy5hBw56aRIc3O4xqRZjPb6oAcFMCNQ4HN EiuXiuYKOYk8WmO+U/Eum6o9ucSOgmW4EEnsrtLlUQ05rh1nLDtT3yOv+N+yM23GhrIk teoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=9+uHv4Wm+iKl9lLbvgWgdhvc6TGd5i1tZxe9mRrn3bY=; b=QPIXVrNL9UmqA53jY5rNV6hpQZ9cLVm6UlZqBJyGA9t1mIqzaNfNPf5I9DF8EfD4iM oz7wmyRrkedvLJN0K9eq36z1us4MZ0jDljqK3A/p+XltPKXAcytSOjT2Y5+sZFt1XMTn 3xGYX1KnpxLKtkPZ4219ts9jwjOUm/SlAOi47Q3W2k6F1bgPgBkEluUzrD7GIX8Z59i6 DXZkDP1EEkua7kPXetJrqAIiqlahq6iFXpVEPI7Kd4Z9h0Z+JsBj4eN0ZqWzDHqASeXa ZsdwpvNcNMM2fRC1GbAiJ8JesV8sC4QpDdOV/NHdsBGmGDvkxwd8y9U3g74GQHmZPxu3 QRUA== X-Gm-Message-State: AOAM531ddjeVzPeY9WClOWmmz/1p3uv+H67A4lwDVj/Wv43PYHmtSYKo o6QH0NOaOQ3X9tiRCy7i7ijZGzuZA4lsk1eWtzl9y7xqMYE/9Q== X-Google-Smtp-Source: ABdhPJz++UEbeLIh7PgNyEjvZZaZ8V2qXysZc3PhKhv2VDrtx68mgdJH/6GrpUqL1bLpV3nTuUPMAQAvkGh0kj9TZbs= X-Received: by 2002:ab0:5909:: with SMTP id n9mr14651551uad.3.1607724721609; Fri, 11 Dec 2020 14:12:01 -0800 (PST) MIME-Version: 1.0 From: Doug Evans Date: Fri, 11 Dec 2020 14:11:25 -0800 Message-ID: Subject: checkpatch.pl block comment detection fail To: QEMU Developers Content-Type: multipart/alternative; boundary="000000000000ee0e5905b637943c" Received-SPF: pass client-ip=2607:f8b0:4864:20::930; envelope-from=dje@google.com; helo=mail-ua1-x930.google.com X-Spam_score_int: -175 X-Spam_score: -17.6 X-Spam_bar: ----------------- X-Spam_report: (-17.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_MED=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, ENV_AND_HDR_SPF_MATCH=-0.5, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, USER_IN_DEF_DKIM_WL=-7.5, USER_IN_DEF_SPF_WL=-7.5 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --000000000000ee0e5905b637943c Content-Type: text/plain; charset="UTF-8" Hi. The coding style docs don't specify this as being bad: foo(/*bar=*/true); which improves readability at the call site. It's not a style to be used liberally, but sometimes it's helpful. Alas checkpatch.pl claims this is a block comment. Would it be ok if I try to fix checkpatch.pl to treat this as ok? --000000000000ee0e5905b637943c Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi.=

=
The coding style doc= s don't specify this as being bad:

foo(/*bar=3D*/true);

which improves readability at the call site.
It's not a style to be used li= berally, but sometimes it's helpful.

Alas checkpatch.pl cla= ims this is a block comment.

Would it be ok if I try to fix checkpa= tch.pl to treat this as ok?

--000000000000ee0e5905b637943c--