From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-20.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, HTML_MESSAGE,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52DC7C49361 for ; Fri, 18 Jun 2021 16:05:42 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CE730613D1 for ; Fri, 18 Jun 2021 16:05:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CE730613D1 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:52792 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1luH00-0008B3-QI for qemu-devel@archiver.kernel.org; Fri, 18 Jun 2021 12:05:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48958) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1luGwz-00043Q-5T for qemu-devel@nongnu.org; Fri, 18 Jun 2021 12:02:33 -0400 Received: from mail-ua1-x92f.google.com ([2607:f8b0:4864:20::92f]:45825) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1luGww-00052B-2V for qemu-devel@nongnu.org; Fri, 18 Jun 2021 12:02:32 -0400 Received: by mail-ua1-x92f.google.com with SMTP id v17so3540307uar.12 for ; Fri, 18 Jun 2021 09:02:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Gqyez8wd0LcYx2GgUpXYthsMzgYssd9EDnzuB8WiDlQ=; b=MfuNyvA3evcN1sEx+veeWi7T43zVCPkTRU+MIP3696DnVyRtNdylUXn5dFm8YvWC94 X0hgkFEhCtzX777BvwlXHdsKBra2ukNQTJTE2vMEa4VNBr8MP2EQzEiFWqfux3HhyMhk 9EBCWNABSeV+8K8wdTx2gYwtCEf1W1ipTn0Lr0fXewQQUGx7uWO3VY5OHgmCJu8RcNS8 sQ93C1pTNeK7WCBHw6HqWad2cvt0SHkrQDv8q1RJd5XOSFjPCY+BJL87THuTPqF4Ijqg pxydm0AnnfvME2xLmyR0IgoJSInSrs0E1y8Czw4SalYvY5Q2WXVzeBXzLtclseaJqiqE kFRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Gqyez8wd0LcYx2GgUpXYthsMzgYssd9EDnzuB8WiDlQ=; b=DvBrUBupGeIHG6Ry2H+0EeG+kU3Cl7o+txF4V6/ywEnYQr9J7NWYHMg804AMt2dpwl eWP6AToh6ApQv+l/2F/fCU/Da4oHBGOMBxwbOEML5yo3KapWlU/THXc5EEhDlk/Q2rn3 khsqmy6IXq74RFEelwzhG9nfHQamLmjfLTclbERRdyKEF6OnqMI3bsLiQ6SWesAQVgxU wOj6v+ehF6/Im1Q0dDhKZEkceP5bVx6bwPAEoVdxw8XtYY6XZTWWJHuKBYTlb2TeRDZL BsWRR1fgBpUOo9+YTpPBL1NbgJnwVmDh7/yDclacAtwgBM2AKiBeM/6xeEWMBkSOc2hH sAIg== X-Gm-Message-State: AOAM532vbo16osxznfw8+S2Fmfxf3nQq7ReVA3kN5xpNpA56PVpLteDw vY3f1sAnP+57hyFJzLYSgfznHyVh0k7m8WeRrzEFZw== X-Google-Smtp-Source: ABdhPJxcGqNoCDNKeQhBME3rd6vYqiSgXOapyhZ5cq6iFRHMVoVNeoJkrhccMbODQN8YcB0lecX1rBztT9655OW7wNw= X-Received: by 2002:a9f:374c:: with SMTP id a12mr13006416uae.91.1624032146889; Fri, 18 Jun 2021 09:02:26 -0700 (PDT) MIME-Version: 1.0 References: <20210529185522.78816-1-marcandre.lureau@redhat.com> <20210529185522.78816-2-marcandre.lureau@redhat.com> In-Reply-To: <20210529185522.78816-2-marcandre.lureau@redhat.com> From: Doug Evans Date: Fri, 18 Jun 2021 09:01:50 -0700 Message-ID: Subject: Re: [PULL 1/2] Update libslirp to v4.5.0 To: =?UTF-8?B?TWFyYy1BbmRyw6kgTHVyZWF1?= Cc: Peter Maydell , QEMU Developers , Samuel Thibault Content-Type: multipart/alternative; boundary="000000000000389f7805c50c739a" Received-SPF: pass client-ip=2607:f8b0:4864:20::92f; envelope-from=dje@google.com; helo=mail-ua1-x92f.google.com X-Spam_score_int: -175 X-Spam_score: -17.6 X-Spam_bar: ----------------- X-Spam_report: (-17.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_MED=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, ENV_AND_HDR_SPF_MATCH=-0.5, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, USER_IN_DEF_DKIM_WL=-7.5, USER_IN_DEF_SPF_WL=-7.5 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --000000000000389f7805c50c739a Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi. Does anything more need to be done here? I just checked and I don't see this patch in the tree yet but it could have been due to pilot error. On Sat, May 29, 2021 at 11:55 AM wrote: > From: Marc-Andr=C3=A9 Lureau > > Switch from stable-4.2 branch to upstream v4.5.0 release. > > ## [4.5.0] - 2021-05-18 > > ### Added > > - IPv6 forwarding. !62 !75 !77 > - slirp_neighbor_info() to dump the ARP/NDP tables. !71 > > ### Changed > > - Lazy guest address resolution for IPv6. !81 > - Improve signal handling when spawning a child. !61 > - Set macOS deployment target to macOS 10.4. !72 > - slirp_add_hostfwd: Ensure all error paths set errno. !80 > - More API documentation. > > ### Fixed > > - Assertion failure on unspecified IPv6 address. !86 > - Disable polling for PRI on MacOS, fixing some closing streams issues. > !73 > - Various memory leak fixes on fastq/batchq. !68 > - Memory leak on IPv6 fast-send. !67 > - Slow socket response on Windows. !64 > - Misc build and code cleanups. !60 !63 !76 !79 !84 > > ## [4.4.0] - 2020-12-02 > > ### Added > > - udp, udp6, icmp: handle TTL value. !48 > - Enable forwarding ICMP errors. !49 > - Add DNS resolving for iOS. !54 > > ### Changed > > - Improve meson subproject() support. !53 > - Removed Makefile-based build system. !56 > > ### Fixed > > - socket: consume empty packets. !55 > - check pkt_len before reading protocol header (CVE-2020-29129). !57 > - ip_stripoptions use memmove (fixes undefined behaviour). !47 > - various Coverity-related changes/fixes. > > ## [4.3.1] - 2020-07-08 > > ### Changed > > - A silent truncation could occur in `slirp_fmt()`, which will now print= a > critical message. See also #22. > > ### Fixed > > - CVE-2020-10756 - Drop bogus IPv6 messages that could lead to data > leakage. > See !44 and !42. > - Fix win32 builds by using the SLIRP_PACKED definition. > - Various coverity scan errors fixed. !41 > - Fix new GCC warnings. !43 > > ## [4.3.0] - 2020-04-22 > > ### Added > > - `SLIRP_VERSION_STRING` macro, with the git sha suffix when building > from git > - `SlirpConfig.disable_dns`, to disable DNS redirection #16 > > ### Changed > > - `slirp_version_string()` now has the git sha suffix when building form > git > - Limit DNS redirection to port 53 #16 > > ### Fixed > > - Fix build regression with mingw & NetBSD > - Fix use-afte-free in `ip_reass()` (CVE-2020-1983) > > Signed-off-by: Marc-Andr=C3=A9 Lureau > Reviewed-by: Doug Evans > --- > slirp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/slirp b/slirp > index 8f43a99191..a62890e711 160000 > --- a/slirp > +++ b/slirp > @@ -1 +1 @@ > -Subproject commit 8f43a99191afb47ca3f3c6972f6306209f367ece > +Subproject commit a62890e71126795ca593affa747f669bed88e89c > -- > 2.29.0 > > > --000000000000389f7805c50c739a Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi.= Does anything more need to be done here?
I just checked and I don't see this patch in= the tree yet but it could have been due to pilot error.

On Sat, May 2= 9, 2021 at 11:55 AM <marc= andre.lureau@redhat.com> wrote:
From: Marc-Andr=C3=A9 Lureau <marcandre.lureau@redhat.com>

Switch from stable-4.2 branch to upstream v4.5.0 release.

## [4.5.0] - 2021-05-18

### Added

=C2=A0- IPv6 forwarding. !62 !75 !77
=C2=A0- slirp_neighbor_info() to dump the ARP/NDP tables. !71

### Changed

=C2=A0- Lazy guest address resolution for IPv6. !81
=C2=A0- Improve signal handling when spawning a child. !61
=C2=A0- Set macOS deployment target to macOS 10.4. !72
=C2=A0- slirp_add_hostfwd: Ensure all error paths set errno. !80
=C2=A0- More API documentation.

### Fixed

=C2=A0- Assertion failure on unspecified IPv6 address. !86
=C2=A0- Disable polling for PRI on MacOS, fixing some closing streams issue= s. !73
=C2=A0- Various memory leak fixes on fastq/batchq. !68
=C2=A0- Memory leak on IPv6 fast-send. !67
=C2=A0- Slow socket response on Windows. !64
=C2=A0- Misc build and code cleanups. !60 !63 !76 !79 !84

## [4.4.0] - 2020-12-02

### Added

=C2=A0- udp, udp6, icmp: handle TTL value. !48
=C2=A0- Enable forwarding ICMP errors. !49
=C2=A0- Add DNS resolving for iOS. !54

### Changed

=C2=A0- Improve meson subproject() support. !53
=C2=A0- Removed Makefile-based build system. !56

### Fixed

=C2=A0- socket: consume empty packets. !55
=C2=A0- check pkt_len before reading protocol header (CVE-2020-29129). !57<= br> =C2=A0- ip_stripoptions use memmove (fixes undefined behaviour). !47
=C2=A0- various Coverity-related changes/fixes.

## [4.3.1] - 2020-07-08

### Changed

=C2=A0- A silent truncation could occur in `slirp_fmt()`, which will now pr= int a
=C2=A0 =C2=A0critical message. See also #22.

### Fixed

=C2=A0- CVE-2020-10756 - Drop bogus IPv6 messages that could lead to data l= eakage.
=C2=A0 =C2=A0See !44 and !42.
=C2=A0- Fix win32 builds by using the SLIRP_PACKED definition.
=C2=A0- Various coverity scan errors fixed. !41
=C2=A0- Fix new GCC warnings. !43

## [4.3.0] - 2020-04-22

### Added

=C2=A0- `SLIRP_VERSION_STRING` macro, with the git sha suffix when building= from git
=C2=A0- `SlirpConfig.disable_dns`, to disable DNS redirection #16

### Changed

=C2=A0- `slirp_version_string()` now has the git sha suffix when building f= orm git
=C2=A0- Limit DNS redirection to port 53 #16

### Fixed

=C2=A0- Fix build regression with mingw & NetBSD
=C2=A0- Fix use-afte-free in `ip_reass()` (CVE-2020-1983)

Signed-off-by: Marc-Andr=C3=A9 Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Doug Evans <dje@google.com>
---
=C2=A0slirp | 2 +-
=C2=A01 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/slirp b/slirp
index 8f43a99191..a62890e711 160000
--- a/slirp
+++ b/slirp
@@ -1 +1 @@
-Subproject commit 8f43a99191afb47ca3f3c6972f6306209f367ece
+Subproject commit a62890e71126795ca593affa747f669bed88e89c
--
2.29.0


--000000000000389f7805c50c739a--