From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0439C433E1 for ; Wed, 8 Jul 2020 23:46:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BAB4720720 for ; Wed, 8 Jul 2020 23:46:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="lcLaSajD" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726174AbgGHXqu (ORCPT ); Wed, 8 Jul 2020 19:46:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51844 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726129AbgGHXqt (ORCPT ); Wed, 8 Jul 2020 19:46:49 -0400 Received: from mail-lj1-x244.google.com (mail-lj1-x244.google.com [IPv6:2a00:1450:4864:20::244]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C97BBC061A0B for ; Wed, 8 Jul 2020 16:46:47 -0700 (PDT) Received: by mail-lj1-x244.google.com with SMTP id e4so276450ljn.4 for ; Wed, 08 Jul 2020 16:46:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=hNVOm+zljioPYiyCEKhVRUSifVw9+Rq4lrANP+/QLBY=; b=lcLaSajDl3PXHLI0IsixId3ctDcJw/wcCMiK5LmAriZFBPjCqkHzrpB5Wr8RE5ku3r jUWEGuzjjFwKK+MoTRT33yCbdQgTQwKFWb/UnbSfHe2j9OUtBiKy4DK8qeLKCpRc+9Wj Bzun1SbvUp06+5xggjiRZELJWnHnhk59in1ncmMWss/+VxfsOQxB1i07p/3CscAo4Vbr QjdH83dDvnirLejbklIErYxD/G1RzjIG34SvWUSpq6cQtuEaY7S7Q8EIA2lIqnunGSmj pdQe99/xvr+rhtnFuHZvy68oV0FkHeMRCItVNOqykDmMRzv+6icK/e4Zz3KUbgNWAVXS LFTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=hNVOm+zljioPYiyCEKhVRUSifVw9+Rq4lrANP+/QLBY=; b=QmNcps7xJZopempDrkilgrcCx4cXWMeZNPZH0lsgmY80wMwxFWG7PZx38/C6LlC2QB kIZ0zdKSrIzJ42gaBcBHC+3Ye0F/HQdJRAxgBFqX1byYVicwKaNN0xCYu2JVgCjSOyY2 Smed1J3M3It+a1CT5+AlHwjJ+Y8H2RKWWEy4fkf3d36scNl2C3G/FEgKh+yWBr/BBxhg VQRWNfRvrLdXJdERJMGdgofDk/eUnz2pwmGUvWwEatNRJVEH8zf8lvuMrehrZNKmf7+7 +rMnJnMnxGqGh6ntmFKmL6g0+bao8hdGZrfPxme3lWf/5rHtyNg7Nrow8vVy/M6QMwCq bblA== X-Gm-Message-State: AOAM531UQf8OSuaQGKmQ3cmouiG0r0kduFkppSOOLjV4AUAqxtQjYt6b OE059VBmY99JoJAVwa6RiSGTBv0tsHtO55VAUlA5sQ== X-Google-Smtp-Source: ABdhPJxQopmgjC6jnaMAt/WQPRrVXt1aN4OhHEolRLPsjEpEaz9Q/mPmsN9bvmri8KaSrr7ODM5XB1eWwNM+XDZ6cAM= X-Received: by 2002:a05:651c:1106:: with SMTP id d6mr6280417ljo.214.1594252006292; Wed, 08 Jul 2020 16:46:46 -0700 (PDT) MIME-Version: 1.0 References: <20200708131424.18729-1-masahisa.kojima@linaro.org> <20200708162017.GB549022@linux.intel.com> In-Reply-To: From: Masahisa Kojima Date: Thu, 9 Jul 2020 08:46:35 +0900 Message-ID: Subject: Re: [PATCH v3 0/2] synquacer: add TPM support To: Jarkko Sakkinen Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, ardb@kernel.org, devicetree , linux-integrity@vger.kernel.org, peterhuewe@gmx.de, jgg@ziepe.ca Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jarkko, > Hi Jakko, I apologize for mis-spelling of your name. Same mistake also appears in my another reply to "[PATCH v3 1/2] tpm: tis: add support for MMIO TPM on SynQuacer" On Thu, 9 Jul 2020 at 08:34, Masahisa Kojima wrote: > > Hi Jakko, > > > Overally the code looks great. You've run it through checkpatch.pl? > > Yes, I have run checkpatch.pl and removed errors. > > Regards, > Masahisa > > On Thu, 9 Jul 2020 at 01:20, Jarkko Sakkinen > wrote: > > > > On Wed, Jul 08, 2020 at 10:14:22PM +0900, Masahisa Kojima wrote: > > > This adds support for driving the TPM on Socionext SynQuacer platform > > > using the driver for a memory mapped TIS frame. > > > > > > v3: > > > - prepare new module to handle TPM MMIO access on SynQuacer platform > > > > > > v2: > > > - don't use read/write_bytes() to implement read/write16/32 since that uses > > > the wrong address > > > > > > Cc: jarkko.sakkinen@linux.intel.com > > > Cc: linux-arm-kernel@lists.infradead.org > > > Cc: ardb@kernel.org > > > Cc: devicetree@vger.kernel.org > > > Cc: linux-integrity@vger.kernel.org > > > Cc: linux-kernel@vger.kernel.org > > > Cc: peterhuewe@gmx.de > > > Cc: jgg@ziepe.ca > > > > > > Masahisa Kojima (2): > > > tpm: tis: add support for MMIO TPM on SynQuacer > > > dt-bindings: Add SynQucer TPM MMIO as a trivial device > > > > > > .../devicetree/bindings/trivial-devices.yaml | 2 + > > > drivers/char/tpm/Kconfig | 12 ++ > > > drivers/char/tpm/Makefile | 1 + > > > drivers/char/tpm/tpm_tis_synquacer.c | 196 ++++++++++++++++++ > > > 4 files changed, 211 insertions(+) > > > create mode 100644 drivers/char/tpm/tpm_tis_synquacer.c > > > > > > -- > > > 2.20.1 > > > > > > > Overally the code looks great. You've run it through checkpatch.pl? > > > > /Jarkko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D9EAC433E0 for ; Wed, 8 Jul 2020 23:48:25 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E4DDF20720 for ; Wed, 8 Jul 2020 23:48:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="qwLCuI3j"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="lcLaSajD" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E4DDF20720 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=YDaPq572kQ0wswLqr9Su+xHXqq/Ix90meSXTKeIeWY4=; b=qwLCuI3jsRdb/wTAqKn2uITYR ar2QmkYDnhDJ9PbA6IKOgHici/FN9gkVLqxDM+/hRVgxSwmNxFA9meisJMsAPKoqRv4zmhz505ieL aM78VygcNShZmHLm/vcQ6Sxs5P1MBu5EnBSW3JTdMgcXmTpZ3AbkaSN3jCcV/bv2asK3wxlg3Moqh T2byGfsWMS4ceckQjS+mmHrsBv2h5DmdtS1Gf3QoNOGGiRJMNUTwcHgMblZk+6bU8RvJV6KjCxfsS fOV8MmD7WcFfAt2RC0h58Wprm3DWB3muzatR7BlEBbqLFP0mpffZdYCTtBwirJfP3qBECNX0A4vQ3 6LX/OvAxw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jtJm5-0008G2-MZ; Wed, 08 Jul 2020 23:46:49 +0000 Received: from mail-lj1-x244.google.com ([2a00:1450:4864:20::244]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jtJm3-0008Fd-Lq for linux-arm-kernel@lists.infradead.org; Wed, 08 Jul 2020 23:46:48 +0000 Received: by mail-lj1-x244.google.com with SMTP id h19so231927ljg.13 for ; Wed, 08 Jul 2020 16:46:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=hNVOm+zljioPYiyCEKhVRUSifVw9+Rq4lrANP+/QLBY=; b=lcLaSajDl3PXHLI0IsixId3ctDcJw/wcCMiK5LmAriZFBPjCqkHzrpB5Wr8RE5ku3r jUWEGuzjjFwKK+MoTRT33yCbdQgTQwKFWb/UnbSfHe2j9OUtBiKy4DK8qeLKCpRc+9Wj Bzun1SbvUp06+5xggjiRZELJWnHnhk59in1ncmMWss/+VxfsOQxB1i07p/3CscAo4Vbr QjdH83dDvnirLejbklIErYxD/G1RzjIG34SvWUSpq6cQtuEaY7S7Q8EIA2lIqnunGSmj pdQe99/xvr+rhtnFuHZvy68oV0FkHeMRCItVNOqykDmMRzv+6icK/e4Zz3KUbgNWAVXS LFTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=hNVOm+zljioPYiyCEKhVRUSifVw9+Rq4lrANP+/QLBY=; b=g8vBtzvh+zXTj76n8qxBbvIjrU7nH0ktiF9kb0eaMpfw8VwfCKv3cW6D3+fRckNfcJ D94/ZMWBt8QyB18UD5Ki+2rdDyWqKkBRwoTlnN02idFUdkrC35ADKJoMkaDZptM3WJt5 IhKlxfej2Zqg8bqRPXz09iBrzNeOz5WaFTRSZEmtnO3SC8NlMzo68oFylrgUEZm8wfNm NxEVn/YGZKZXWdJ0iZeajEBOy1ZBN7jGurL26pbtxsd1Ey5Ky4Dj79WP2IupjUTipBxo ggbGM3HXs2mM/1RMFl/m5HXj6WoTCTPtlt+oTAuUckNN6A6Njg7XOgAVwjL6h4dWxWvC 6cyQ== X-Gm-Message-State: AOAM5338ryX9v2zCysonWwhRSJJ9vBHwzJ1XjwDCYe9Jqsp5crFZJ52W 0M/6nwaCwTvfmH91zuxxTKY+OoX7y+S8YWaPPVM6Mw== X-Google-Smtp-Source: ABdhPJxQopmgjC6jnaMAt/WQPRrVXt1aN4OhHEolRLPsjEpEaz9Q/mPmsN9bvmri8KaSrr7ODM5XB1eWwNM+XDZ6cAM= X-Received: by 2002:a05:651c:1106:: with SMTP id d6mr6280417ljo.214.1594252006292; Wed, 08 Jul 2020 16:46:46 -0700 (PDT) MIME-Version: 1.0 References: <20200708131424.18729-1-masahisa.kojima@linaro.org> <20200708162017.GB549022@linux.intel.com> In-Reply-To: From: Masahisa Kojima Date: Thu, 9 Jul 2020 08:46:35 +0900 Message-ID: Subject: Re: [PATCH v3 0/2] synquacer: add TPM support To: Jarkko Sakkinen X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200708_194647_750333_EA91E117 X-CRM114-Status: GOOD ( 18.58 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree , linux-kernel@vger.kernel.org, ardb@kernel.org, jgg@ziepe.ca, peterhuewe@gmx.de, linux-integrity@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Jarkko, > Hi Jakko, I apologize for mis-spelling of your name. Same mistake also appears in my another reply to "[PATCH v3 1/2] tpm: tis: add support for MMIO TPM on SynQuacer" On Thu, 9 Jul 2020 at 08:34, Masahisa Kojima wrote: > > Hi Jakko, > > > Overally the code looks great. You've run it through checkpatch.pl? > > Yes, I have run checkpatch.pl and removed errors. > > Regards, > Masahisa > > On Thu, 9 Jul 2020 at 01:20, Jarkko Sakkinen > wrote: > > > > On Wed, Jul 08, 2020 at 10:14:22PM +0900, Masahisa Kojima wrote: > > > This adds support for driving the TPM on Socionext SynQuacer platform > > > using the driver for a memory mapped TIS frame. > > > > > > v3: > > > - prepare new module to handle TPM MMIO access on SynQuacer platform > > > > > > v2: > > > - don't use read/write_bytes() to implement read/write16/32 since that uses > > > the wrong address > > > > > > Cc: jarkko.sakkinen@linux.intel.com > > > Cc: linux-arm-kernel@lists.infradead.org > > > Cc: ardb@kernel.org > > > Cc: devicetree@vger.kernel.org > > > Cc: linux-integrity@vger.kernel.org > > > Cc: linux-kernel@vger.kernel.org > > > Cc: peterhuewe@gmx.de > > > Cc: jgg@ziepe.ca > > > > > > Masahisa Kojima (2): > > > tpm: tis: add support for MMIO TPM on SynQuacer > > > dt-bindings: Add SynQucer TPM MMIO as a trivial device > > > > > > .../devicetree/bindings/trivial-devices.yaml | 2 + > > > drivers/char/tpm/Kconfig | 12 ++ > > > drivers/char/tpm/Makefile | 1 + > > > drivers/char/tpm/tpm_tis_synquacer.c | 196 ++++++++++++++++++ > > > 4 files changed, 211 insertions(+) > > > create mode 100644 drivers/char/tpm/tpm_tis_synquacer.c > > > > > > -- > > > 2.20.1 > > > > > > > Overally the code looks great. You've run it through checkpatch.pl? > > > > /Jarkko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel