From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68FBAC432BE for ; Mon, 2 Aug 2021 22:44:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4A0A060238 for ; Mon, 2 Aug 2021 22:44:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233116AbhHBWoy (ORCPT ); Mon, 2 Aug 2021 18:44:54 -0400 Received: from mail-qt1-f170.google.com ([209.85.160.170]:36626 "EHLO mail-qt1-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231126AbhHBWow (ORCPT ); Mon, 2 Aug 2021 18:44:52 -0400 Received: by mail-qt1-f170.google.com with SMTP id w10so12793764qtj.3; Mon, 02 Aug 2021 15:44:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=pZpEUuMrd4GatuNwSTb1C/8V/y6Tmj4WRl8BBaTN31A=; b=YR9yEPPIk08sI3US8+XqoaWvrCTQrDon6z3R0QlLl69ZziWp4ni0omi451a+5lRsGw q2qtPrentbuoAh6wuIS5kfzmYYS8dCWgY784l79veZs7nJMJrZN9/WS9Y92Ka5loZK/q uGhbmobkrB+lKB780Im1KQHh6zLbZ0pRyj7J2L08MEzUK/SqsEKCrAl472kmOIGqoqXH eCosEaoqX3CJY6IdJJbJ3T0wnU5RU6ou/MWhZkRUIQad+KP6OeDd5hGvdPY2B4eAamNM e5nIYHwW9BBI7zEEHWu04ThnApX0IfVTad6Ofnp+jCeCSFW64PZGp027ZjhwRA4MdQk4 rCig== X-Gm-Message-State: AOAM533co0zYYXXqCGF0KFK36RLTKuzZtqY9n665oSu8Ueak/y1eZCxe 55t9pJXy//X8Qo4Nnvu8sfl29oXN5TQ= X-Google-Smtp-Source: ABdhPJzmttkq5ye43bf7BNv43Qo+i3AZHFslVgMz2Za2LoZ1duNU+Dv9TrRFxX4lhXprC4qGs8MWuw== X-Received: by 2002:ac8:4545:: with SMTP id z5mr16357832qtn.198.1627944281739; Mon, 02 Aug 2021 15:44:41 -0700 (PDT) Received: from mail-qv1-f48.google.com (mail-qv1-f48.google.com. [209.85.219.48]) by smtp.gmail.com with ESMTPSA id o63sm6757558qkf.4.2021.08.02.15.44.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 02 Aug 2021 15:44:40 -0700 (PDT) Received: by mail-qv1-f48.google.com with SMTP id em4so4848284qvb.0; Mon, 02 Aug 2021 15:44:40 -0700 (PDT) X-Received: by 2002:ad4:58cb:: with SMTP id dh11mr18599135qvb.29.1627944280772; Mon, 02 Aug 2021 15:44:40 -0700 (PDT) MIME-Version: 1.0 References: <1627927742-8675-1-git-send-email-raagjadav@gmail.com> In-Reply-To: <1627927742-8675-1-git-send-email-raagjadav@gmail.com> From: Li Yang Date: Mon, 2 Aug 2021 17:44:29 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] arm64: dts: ls1046a: fix eeprom entries To: Raag Jadav Cc: Shawn Guo , Rob Herring , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , lkml Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 2, 2021 at 1:10 PM Raag Jadav wrote: > > ls1046afrwy and ls1046ardb boards have CAT24C04[1] and CAT24C05[2] > eeproms respectively. Both are 4Kb (512 bytes) in size. These part names are from onsemi instead of atmel. Are there same part names from atmel which are also compatible with the onsemi parts? If we want to use onsemi only part names, probably we will need two compatible strings with the first one from onsemi and the second from atmel. Although the binding doesn't support onsemi prefix yet. > Remove multi-address entries, as we have auto-rollover support > in at24 driver. The device tree should describe hardware instead of matching how driver deal with it. Is the board really using a single chip or multiple chips here? > > [1] https://www.onsemi.com/pdf/datasheet/cat24c01-d.pdf > [2] https://www.onsemi.com/pdf/datasheet/cat24c03-d.pdf > > Signed-off-by: Raag Jadav > --- > arch/arm64/boot/dts/freescale/fsl-ls1046a-frwy.dts | 8 +------- > arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts | 7 +------ > 2 files changed, 2 insertions(+), 13 deletions(-) > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a-frwy.dts b/arch/arm64/boot/dts/freescale/fsl-ls1046a-frwy.dts > index db3d303..83afe21 100644 > --- a/arch/arm64/boot/dts/freescale/fsl-ls1046a-frwy.dts > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a-frwy.dts > @@ -83,15 +83,9 @@ > }; > > eeprom@52 { > - compatible = "atmel,24c512"; > + compatible = "atmel,24c04"; > reg = <0x52>; > }; > - > - eeprom@53 { > - compatible = "atmel,24c512"; > - reg = <0x53>; > - }; > - > }; > }; > }; > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts b/arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts > index 60acdf0..d220f98 100644 > --- a/arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts > @@ -59,14 +59,9 @@ > }; > > eeprom@52 { > - compatible = "atmel,24c512"; > + compatible = "atmel,24c04"; > reg = <0x52>; > }; > - > - eeprom@53 { > - compatible = "atmel,24c512"; > - reg = <0x53>; > - }; > }; > > &i2c3 { > -- > 2.7.4 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29C54C4338F for ; Mon, 2 Aug 2021 22:46:29 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D50286052B for ; Mon, 2 Aug 2021 22:46:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org D50286052B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nxp.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8EMlPCW2JiJ+OIYOLTFHgLYmT9YV/1nOc3ofkf+MF4g=; b=z+cJp/2cez96bj PblELlfInQZsIasfqdk1qljBfuf2ZdI37GxDmCxrc3aQ1y8ARR7ZlNIcQi3Re+ZqDDu0tEZjz/WfE DQMuELGOyyB9P1Lb5buyE+hXjOUPK0Ysa1o56194W2/JsW1cRh4j0avRIaZfLisdlFmsnbmZtRJEJ z2u1p9UfBkAIeOBVFgr8I379/pUtBN/ElAbwV8O8HzlB/dBf5ntTK/sGCNA9rRqWvMeZsQDo86gsA YrKWT0ggwKg+n1O2v3vPmhuVJESb53wJjMfKP8au4WQV7rV1RvV3vhCVQvWbbsAiqufIgLV2d5Ue9 omav9qPl9auxP66wRbuQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mAgfv-000VQZ-EK; Mon, 02 Aug 2021 22:44:47 +0000 Received: from mail-qt1-f174.google.com ([209.85.160.174]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mAgfr-000VPk-N1 for linux-arm-kernel@lists.infradead.org; Mon, 02 Aug 2021 22:44:45 +0000 Received: by mail-qt1-f174.google.com with SMTP id h27so12762993qtu.9 for ; Mon, 02 Aug 2021 15:44:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=pZpEUuMrd4GatuNwSTb1C/8V/y6Tmj4WRl8BBaTN31A=; b=YYdkL62hb3RTuR4r3CJ3euoekRPE2+8d+UAhPGVSQlJYFpRJ4+02X+hK6uuLfJagha Jj0EztMM2w9MMv+9MBHg8vWMw/ZJ6ctvvCD1aiSK+x1oCDsHF7CD7cEZXIkBWaxwLgg8 tO06oBuDvNNmBTQAHbj1q7h/qV3k9tnKcLx6WmyInvC4j9tSGtOM7wv+KSYiWbx67Nsw ljdc+6zIKkHhfkCb6IzW8qHMTcuM9FAzGNvclslA87uo31LE3ZnBANd+herrzncacEIB uyUYiWVWqtAHJEzED8vGumG0uiy26V3IKWqZKlySlDmML2caV4Z3p1oAZhMMCmKfJnbc K+3w== X-Gm-Message-State: AOAM531kC8ktTYIhIAfMs2eoL8ds6RD+bLI2fNdIXJjr2MPjvIC+ps6l y5qx2hmqQNqOigpOt7P4D5BZwu9BM3E= X-Google-Smtp-Source: ABdhPJxjZBjywoc6P7XITXWrrM2KTYYGiIlT9BmOwomv7LIdA3o9jK7rvkVWIZpgJNa7NECe1sgKuw== X-Received: by 2002:ac8:4401:: with SMTP id j1mr16092621qtn.137.1627944281836; Mon, 02 Aug 2021 15:44:41 -0700 (PDT) Received: from mail-qv1-f54.google.com (mail-qv1-f54.google.com. [209.85.219.54]) by smtp.gmail.com with ESMTPSA id x7sm5066155qtw.24.2021.08.02.15.44.40 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 02 Aug 2021 15:44:41 -0700 (PDT) Received: by mail-qv1-f54.google.com with SMTP id d17so9671221qvn.13 for ; Mon, 02 Aug 2021 15:44:40 -0700 (PDT) X-Received: by 2002:ad4:58cb:: with SMTP id dh11mr18599135qvb.29.1627944280772; Mon, 02 Aug 2021 15:44:40 -0700 (PDT) MIME-Version: 1.0 References: <1627927742-8675-1-git-send-email-raagjadav@gmail.com> In-Reply-To: <1627927742-8675-1-git-send-email-raagjadav@gmail.com> From: Li Yang Date: Mon, 2 Aug 2021 17:44:29 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] arm64: dts: ls1046a: fix eeprom entries To: Raag Jadav Cc: Shawn Guo , Rob Herring , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , lkml X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210802_154443_800364_8856EA41 X-CRM114-Status: GOOD ( 20.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Aug 2, 2021 at 1:10 PM Raag Jadav wrote: > > ls1046afrwy and ls1046ardb boards have CAT24C04[1] and CAT24C05[2] > eeproms respectively. Both are 4Kb (512 bytes) in size. These part names are from onsemi instead of atmel. Are there same part names from atmel which are also compatible with the onsemi parts? If we want to use onsemi only part names, probably we will need two compatible strings with the first one from onsemi and the second from atmel. Although the binding doesn't support onsemi prefix yet. > Remove multi-address entries, as we have auto-rollover support > in at24 driver. The device tree should describe hardware instead of matching how driver deal with it. Is the board really using a single chip or multiple chips here? > > [1] https://www.onsemi.com/pdf/datasheet/cat24c01-d.pdf > [2] https://www.onsemi.com/pdf/datasheet/cat24c03-d.pdf > > Signed-off-by: Raag Jadav > --- > arch/arm64/boot/dts/freescale/fsl-ls1046a-frwy.dts | 8 +------- > arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts | 7 +------ > 2 files changed, 2 insertions(+), 13 deletions(-) > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a-frwy.dts b/arch/arm64/boot/dts/freescale/fsl-ls1046a-frwy.dts > index db3d303..83afe21 100644 > --- a/arch/arm64/boot/dts/freescale/fsl-ls1046a-frwy.dts > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a-frwy.dts > @@ -83,15 +83,9 @@ > }; > > eeprom@52 { > - compatible = "atmel,24c512"; > + compatible = "atmel,24c04"; > reg = <0x52>; > }; > - > - eeprom@53 { > - compatible = "atmel,24c512"; > - reg = <0x53>; > - }; > - > }; > }; > }; > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts b/arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts > index 60acdf0..d220f98 100644 > --- a/arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts > @@ -59,14 +59,9 @@ > }; > > eeprom@52 { > - compatible = "atmel,24c512"; > + compatible = "atmel,24c04"; > reg = <0x52>; > }; > - > - eeprom@53 { > - compatible = "atmel,24c512"; > - reg = <0x53>; > - }; > }; > > &i2c3 { > -- > 2.7.4 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel