From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A33DC352A5 for ; Mon, 10 Feb 2020 19:48:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 64DDD20715 for ; Mon, 10 Feb 2020 19:48:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727577AbgBJTs2 (ORCPT ); Mon, 10 Feb 2020 14:48:28 -0500 Received: from mail-oi1-f172.google.com ([209.85.167.172]:42560 "EHLO mail-oi1-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727003AbgBJTs2 (ORCPT ); Mon, 10 Feb 2020 14:48:28 -0500 Received: by mail-oi1-f172.google.com with SMTP id j132so10370966oih.9; Mon, 10 Feb 2020 11:48:27 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=cRFAgHTjcpru4Yh3cmh88ozwK6oz4DRfN4/AXw7tuCc=; b=FkBgNkfb1vKrksM2KmB5EvzuRqrsTVNhhZGV3hwVDFUWFX4jzETCFSU/FNdsWZoh/H DU6ENvSS9Z0psONgo8Puc1w2LTVG/T52tHsRUpuMkKxGVoDrG9hyNDwxbDPwoMRZBywG y22WwKOLb9xw4/SOotLBd13wSvA5VcgNichBIjfY85suSWEh8mU7y8zeHcehq5pkV66d mUPqOxzMPnNBp1vzLIIFnHmbNHuhTP7JsVFV9SgsFQjvg49AGmGDp75VyFOoAr+73JyW 9SL7wHaoYI194HFUpG2oNSYsjE4nM/xTMiuVLSMfg8fDRofcLeO3Q3iNX21juZydemnk MI9g== X-Gm-Message-State: APjAAAX/HIP/EOZtZLEEdcyNxh8ZHK012WL3swWpbO22nrTsu4LQTzqI i1IPKuhLAKlYojVYlAZWAot819kFVqc= X-Google-Smtp-Source: APXvYqxz2YnkuCkbNDnyYSLmdm2eFbVIaeblL6OSBhWfjzGPCfeMRteB2Zrg9xj19t9L35u9sPm/vA== X-Received: by 2002:a05:6808:611:: with SMTP id y17mr444497oih.146.1581364106617; Mon, 10 Feb 2020 11:48:26 -0800 (PST) Received: from mail-ot1-f53.google.com (mail-ot1-f53.google.com. [209.85.210.53]) by smtp.gmail.com with ESMTPSA id q6sm373450otn.73.2020.02.10.11.48.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 10 Feb 2020 11:48:26 -0800 (PST) Received: by mail-ot1-f53.google.com with SMTP id b18so7656822otp.0; Mon, 10 Feb 2020 11:48:25 -0800 (PST) X-Received: by 2002:a05:6830:1184:: with SMTP id u4mr2168328otq.221.1581364105459; Mon, 10 Feb 2020 11:48:25 -0800 (PST) MIME-Version: 1.0 References: <20191120034451.30102-1-Zhiqiang.Hou@nxp.com> <20200110153347.GA29372@e121166-lin.cambridge.arm.com> <20200210152257.GD25745@shell.armlinux.org.uk> In-Reply-To: From: Li Yang Date: Mon, 10 Feb 2020 13:48:14 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCHv9 00/12] PCI: Recode Mobiveil driver and add PCIe Gen4 driver for NXP Layerscape SoCs To: Olof Johansson , Laurentiu Tudor Cc: Russell King - ARM Linux admin , "Z.q. Hou" , "bhelgaas@google.com" , "mark.rutland@arm.com" , "devicetree@vger.kernel.org" , Lorenzo Pieralisi , "m.karthikeyan@mobiveil.co.in" , "arnd@arndb.de" , "linux-pci@vger.kernel.org" , "l.subrahmanya@mobiveil.co.in" , "will.deacon@arm.com" , "linux-kernel@vger.kernel.org" , "M.h. Lian" , "robh+dt@kernel.org" , Mingkai Hu , "catalin.marinas@arm.com" , Xiaowei Bao , "andrew.murray@arm.com" , "shawnguo@kernel.org" , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 10, 2020 at 12:41 PM Li Yang wrote: > > On Mon, Feb 10, 2020 at 9:32 AM Olof Johansson wrote: > > > > On Mon, Feb 10, 2020 at 4:23 PM Russell King - ARM Linux admin > > wrote: > > > > > > On Mon, Feb 10, 2020 at 04:12:30PM +0100, Olof Johansson wrote: > > > > On Thu, Feb 6, 2020 at 11:57 AM Z.q. Hou wrote: > > > > > > > > > > Hi Olof, > > > > > > > > > > Thanks a lot for your comments! > > > > > And sorry for my delay respond! > > > > > > > > Actually, they apply with only minor conflicts on top of current -next. > > > > > > > > Bjorn, any chance we can get you to pick these up pretty soon? They > > > > enable full use of a promising ARM developer system, the SolidRun > > > > HoneyComb, and would be quite valuable for me and others to be able to > > > > use with mainline or -next without any additional patches applied -- > > > > which this patchset achieves. > > > > > > > > I know there are pending revisions based on feedback. I'll leave it up > > > > to you and others to determine if that can be done with incremental > > > > patches on top, or if it should be fixed before the initial patchset > > > > is applied. But all in all, it's holding up adaption by me and surely > > > > others of a very interesting platform -- I'm looking to replace my > > > > aging MacchiatoBin with one of these and would need PCIe/NVMe to work > > > > before I do. > > > > > > If you're going to be using NVMe, make sure you use a power-fail safe > > > version; I've already had one instance where ext4 failed to mount > > > because of a corrupted journal using an XPG SX8200 after the Honeycomb > > > Serror'd, and then I powered it down after a few hours before later > > > booting it back up. > > > > > > EXT4-fs (nvme0n1p2): INFO: recovery required on readonly filesystem > > > EXT4-fs (nvme0n1p2): write access will be enabled during recovery > > > JBD2: journal transaction 80849 on nvme0n1p2-8 is corrupt. > > > EXT4-fs (nvme0n1p2): error loading journal > > > > Hmm, using btrfs on mine, not sure if the exposure is similar or not. > > > > Do you know if the SErr was due to a known issue and/or if it's > > something that's fixed in production silicon? > > > > (I still can't enable SMMU since across a warm reboot it fails > > *completely*, with nothing coming up and working. NXP folks, you > > listening? :) > > This is a known issue about DPAA2 MC bus not working well with SMMU > based IO mapping. Adding Laurentiu to the chain who has been looking > into this issue. Forgot to mention that you can workaround the issue by setting CONFIG_ARM_SMMU_DISABLE_BYPASS_BY_DEFAULT=n or adding "arm-smmu.disable_bypass=0" to boot parameters. Regards, Leo From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CCBE4C35254 for ; Mon, 10 Feb 2020 19:48:41 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8456C20838 for ; Mon, 10 Feb 2020 19:48:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="CnT+Onfl" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8456C20838 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nxp.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=gvsz0JkXV8qiFU/fGdOJmp8a1OBBQFwI0lIEsiZ7W5Y=; b=CnT+OnflcUy9l/ tsa8khY7u/MGcjKzgYthV+oLNtGto/ryuQdmwTrzx/upM9GZjT0pG73RtibZtTaTdv65wjyJNB5+Z M4B3ZuFutP2I/AoVnN6y7NRlaTtioorlNnSDsfO9JtgG35X3meF/XSGLI8VwOojp6+KNUeMOV4fSD lQv/Bc5b4UY556ddWKUVQgJuPh7Pwzd7APnkuP1aBAD3y59iWz9kW7XpBhH0tgmHDgVIvIJYMuler Hb73sAR1jkpArvWscrvLEN314nZFeTnJT7TXkRFvJrT4bRJuCknXHud+zG/mOPbpwfoeb8ib6+d2v wSbSu/72Xx0rc5m35rCg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j1F2n-0004vH-5q; Mon, 10 Feb 2020 19:48:33 +0000 Received: from mail-ot1-f42.google.com ([209.85.210.42]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j1F2j-0004u1-Ng for linux-arm-kernel@lists.infradead.org; Mon, 10 Feb 2020 19:48:31 +0000 Received: by mail-ot1-f42.google.com with SMTP id h9so7596100otj.11 for ; Mon, 10 Feb 2020 11:48:27 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=cRFAgHTjcpru4Yh3cmh88ozwK6oz4DRfN4/AXw7tuCc=; b=dUvt3MK16lWGRuTMDOa0p180la4T4p/4Q2l+FJs3zWOb0rHe3OkSWyDD9TiJahfqOV C0WsWKcjbAfSD3G4+6jaqXIVLjChcBP48UXsQw3HKDotKZO93cmucLR1xEKUXsyddZ/2 CK9TAgTK317sSHE6zCNfQ+ZM6OrBHvuasPIbombV7WFhldaQMs6t8E+AXgb80CxqvMrW HUC3Wcf5+bnDNLNGVUJjLhryFKniHPjWScvLdR4yOX0D7yQO1RHV+KPhbzZ/bDeT2jQZ yDk6EyPcoTozNC2YEpBgyVVOpH8KgBljbMJzLEISXgfTtMqBR22elHhIyIKu/D0CZVPa MV7Q== X-Gm-Message-State: APjAAAXa7bX2o1qwpZ3fHSmkXBkGhTV3W8TzdwrarZaxntXcPeBW8Ild zVc80GR6VGNdcYHJBn96tpTKfUBspA8= X-Google-Smtp-Source: APXvYqywmifBQxsvve7ns76PJksj2zClGIa8U7VWX7DA7WmNIVglSf8m3NtvceTRtd4j3KvKNNCIXA== X-Received: by 2002:a9d:7386:: with SMTP id j6mr2257148otk.336.1581364106683; Mon, 10 Feb 2020 11:48:26 -0800 (PST) Received: from mail-ot1-f45.google.com (mail-ot1-f45.google.com. [209.85.210.45]) by smtp.gmail.com with ESMTPSA id c12sm404535oic.27.2020.02.10.11.48.25 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 10 Feb 2020 11:48:26 -0800 (PST) Received: by mail-ot1-f45.google.com with SMTP id r16so7661703otd.2 for ; Mon, 10 Feb 2020 11:48:25 -0800 (PST) X-Received: by 2002:a05:6830:1184:: with SMTP id u4mr2168328otq.221.1581364105459; Mon, 10 Feb 2020 11:48:25 -0800 (PST) MIME-Version: 1.0 References: <20191120034451.30102-1-Zhiqiang.Hou@nxp.com> <20200110153347.GA29372@e121166-lin.cambridge.arm.com> <20200210152257.GD25745@shell.armlinux.org.uk> In-Reply-To: From: Li Yang Date: Mon, 10 Feb 2020 13:48:14 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCHv9 00/12] PCI: Recode Mobiveil driver and add PCIe Gen4 driver for NXP Layerscape SoCs To: Olof Johansson , Laurentiu Tudor X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200210_114829_772002_3F0E949D X-CRM114-Status: GOOD ( 26.89 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "mark.rutland@arm.com" , "devicetree@vger.kernel.org" , Lorenzo Pieralisi , "arnd@arndb.de" , "m.karthikeyan@mobiveil.co.in" , "linux-pci@vger.kernel.org" , "Z.q. Hou" , "l.subrahmanya@mobiveil.co.in" , "will.deacon@arm.com" , Russell King - ARM Linux admin , "linux-kernel@vger.kernel.org" , "M.h. Lian" , "robh+dt@kernel.org" , Xiaowei Bao , "catalin.marinas@arm.com" , "bhelgaas@google.com" , "andrew.murray@arm.com" , "shawnguo@kernel.org" , Mingkai Hu , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Feb 10, 2020 at 12:41 PM Li Yang wrote: > > On Mon, Feb 10, 2020 at 9:32 AM Olof Johansson wrote: > > > > On Mon, Feb 10, 2020 at 4:23 PM Russell King - ARM Linux admin > > wrote: > > > > > > On Mon, Feb 10, 2020 at 04:12:30PM +0100, Olof Johansson wrote: > > > > On Thu, Feb 6, 2020 at 11:57 AM Z.q. Hou wrote: > > > > > > > > > > Hi Olof, > > > > > > > > > > Thanks a lot for your comments! > > > > > And sorry for my delay respond! > > > > > > > > Actually, they apply with only minor conflicts on top of current -next. > > > > > > > > Bjorn, any chance we can get you to pick these up pretty soon? They > > > > enable full use of a promising ARM developer system, the SolidRun > > > > HoneyComb, and would be quite valuable for me and others to be able to > > > > use with mainline or -next without any additional patches applied -- > > > > which this patchset achieves. > > > > > > > > I know there are pending revisions based on feedback. I'll leave it up > > > > to you and others to determine if that can be done with incremental > > > > patches on top, or if it should be fixed before the initial patchset > > > > is applied. But all in all, it's holding up adaption by me and surely > > > > others of a very interesting platform -- I'm looking to replace my > > > > aging MacchiatoBin with one of these and would need PCIe/NVMe to work > > > > before I do. > > > > > > If you're going to be using NVMe, make sure you use a power-fail safe > > > version; I've already had one instance where ext4 failed to mount > > > because of a corrupted journal using an XPG SX8200 after the Honeycomb > > > Serror'd, and then I powered it down after a few hours before later > > > booting it back up. > > > > > > EXT4-fs (nvme0n1p2): INFO: recovery required on readonly filesystem > > > EXT4-fs (nvme0n1p2): write access will be enabled during recovery > > > JBD2: journal transaction 80849 on nvme0n1p2-8 is corrupt. > > > EXT4-fs (nvme0n1p2): error loading journal > > > > Hmm, using btrfs on mine, not sure if the exposure is similar or not. > > > > Do you know if the SErr was due to a known issue and/or if it's > > something that's fixed in production silicon? > > > > (I still can't enable SMMU since across a warm reboot it fails > > *completely*, with nothing coming up and working. NXP folks, you > > listening? :) > > This is a known issue about DPAA2 MC bus not working well with SMMU > based IO mapping. Adding Laurentiu to the chain who has been looking > into this issue. Forgot to mention that you can workaround the issue by setting CONFIG_ARM_SMMU_DISABLE_BYPASS_BY_DEFAULT=n or adding "arm-smmu.disable_bypass=0" to boot parameters. Regards, Leo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel