All of lore.kernel.org
 help / color / mirror / Atom feed
From: Li Yang <leoyang.li@nxp.com>
To: Ioana Ciornei <ioana.ciornei@nxp.com>
Cc: Laurentiu Tudor <laurentiu.tudor@nxp.com>,
	Roy Pledge <Roy.Pledge@nxp.com>,
	lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/3] bus: fsl-mc: remove explicit device_link_del
Date: Thu, 15 Aug 2019 18:13:07 -0500	[thread overview]
Message-ID: <CADRPPNQDRhocXmpA08rEBqpFBrm1ub9z3+r74GNcMs6bqUL8OA@mail.gmail.com> (raw)
In-Reply-To: <1562165800-30721-2-git-send-email-ioana.ciornei@nxp.com>

On Wed, Jul 3, 2019 at 9:58 AM Ioana Ciornei <ioana.ciornei@nxp.com> wrote:
>
> Starting with commit 72175d4ea4c4 ("driver core: Make driver core own
> stateful device links") stateful device links are owned by the driver
> core and should not be explicitly removed on device unbind. Delete all
> device_link_del appearances from the fsl-mc bus.
>
> Signed-off-by: Ioana Ciornei <ioana.ciornei@nxp.com>

Hi Laurentiu,

What do you think of this patches?  I can take it through fsl/soc if
you can ACK it.

Regards,
Leo

> ---
>  drivers/bus/fsl-mc/fsl-mc-allocator.c | 1 -
>  drivers/bus/fsl-mc/mc-io.c            | 1 -
>  2 files changed, 2 deletions(-)
>
> diff --git a/drivers/bus/fsl-mc/fsl-mc-allocator.c b/drivers/bus/fsl-mc/fsl-mc-allocator.c
> index 8ad77246f322..cc7bb900f524 100644
> --- a/drivers/bus/fsl-mc/fsl-mc-allocator.c
> +++ b/drivers/bus/fsl-mc/fsl-mc-allocator.c
> @@ -330,7 +330,6 @@ void fsl_mc_object_free(struct fsl_mc_device *mc_adev)
>
>         fsl_mc_resource_free(resource);
>
> -       device_link_del(mc_adev->consumer_link);
>         mc_adev->consumer_link = NULL;
>  }
>  EXPORT_SYMBOL_GPL(fsl_mc_object_free);
> diff --git a/drivers/bus/fsl-mc/mc-io.c b/drivers/bus/fsl-mc/mc-io.c
> index 3ae574a58cce..d9629fc13a15 100644
> --- a/drivers/bus/fsl-mc/mc-io.c
> +++ b/drivers/bus/fsl-mc/mc-io.c
> @@ -255,7 +255,6 @@ void fsl_mc_portal_free(struct fsl_mc_io *mc_io)
>         fsl_destroy_mc_io(mc_io);
>         fsl_mc_resource_free(resource);
>
> -       device_link_del(dpmcp_dev->consumer_link);
>         dpmcp_dev->consumer_link = NULL;
>  }
>  EXPORT_SYMBOL_GPL(fsl_mc_portal_free);
> --
> 1.9.1
>

  reply	other threads:[~2019-08-15 23:13 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-03 14:56 [PATCH 0/3] soc: fsl: dpio: small fixes Ioana Ciornei
2019-07-03 14:56 ` [PATCH 1/3] bus: fsl-mc: remove explicit device_link_del Ioana Ciornei
2019-08-15 23:13   ` Li Yang [this message]
2019-08-16  6:02     ` Laurentiu Tudor
2019-08-16 19:54       ` Li Yang
2019-07-03 14:56 ` [PATCH 2/3] soc: fsl: dpio: remove explicit device_link_remove Ioana Ciornei
2019-08-15 23:17   ` Li Yang
2019-07-03 14:56 ` [PATCH 3/3] soc: fsl: FSL_MC_DPIO selects directly FSL_GUTS Ioana Ciornei
2019-08-15 23:09   ` Li Yang
2019-08-16 14:56     ` Roy Pledge
2019-08-16 17:03       ` Li Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CADRPPNQDRhocXmpA08rEBqpFBrm1ub9z3+r74GNcMs6bqUL8OA@mail.gmail.com \
    --to=leoyang.li@nxp.com \
    --cc=Roy.Pledge@nxp.com \
    --cc=ioana.ciornei@nxp.com \
    --cc=laurentiu.tudor@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.