From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82694C17440 for ; Fri, 8 Nov 2019 23:48:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5F7B020865 for ; Fri, 8 Nov 2019 23:48:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728124AbfKHXs5 (ORCPT ); Fri, 8 Nov 2019 18:48:57 -0500 Received: from mail-ot1-f66.google.com ([209.85.210.66]:42544 "EHLO mail-ot1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726231AbfKHXs5 (ORCPT ); Fri, 8 Nov 2019 18:48:57 -0500 Received: by mail-ot1-f66.google.com with SMTP id b16so6687474otk.9 for ; Fri, 08 Nov 2019 15:48:56 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=XMVjsfRFCMgyyIBo6SJuyhGa3vmCkYAAcBk1J2DsBuY=; b=YOypcbEulcKRFNEeo74kAHj0uxzm2uvzEGicVDq789QS7jwPDKYLe6iejRXiN5RS14 AS3tmmfmlkd6JibhHlSHzABdbSZwptFAF8AkImt13JGhC20vzYaEs9NDCz4oZPvEHT3L fvTsomaJVL/+D9gigwM5OCTRykq4/j+Sb6J6aigwNxV7tRcq27L071+Cc3IBu1/LNIY6 43+H29zQx7JbxXl7m12GLqF6XZDUxiiAvHZD6QFtm6PfaUwLkumW/O1IhFPxcAg0XDa8 P/BCODwIeN5VyLN4SpXyNID83UQhDHO6+ISQ4lQHS8l64fltjYVX1yTRU+mGwMXVRmML NDFQ== X-Gm-Message-State: APjAAAUVc3fLXcAqbH5bML+mSYOjSuuxxBdQoZB8Ye1NAXkp21etU3/4 0GOID/cAD/pL4wNnW2dkafBbqgmW9CE= X-Google-Smtp-Source: APXvYqzfLa/na2KkCHcTsUpnCUBcHYiWwMmVFytQYAe3IU0LMQuGz0c+e5thdD/3/Ex+jy3pSzCTaA== X-Received: by 2002:a9d:458a:: with SMTP id x10mr10711707ote.365.1573256935749; Fri, 08 Nov 2019 15:48:55 -0800 (PST) Received: from mail-ot1-f46.google.com (mail-ot1-f46.google.com. [209.85.210.46]) by smtp.gmail.com with ESMTPSA id y14sm2342622otk.20.2019.11.08.15.48.54 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 08 Nov 2019 15:48:55 -0800 (PST) Received: by mail-ot1-f46.google.com with SMTP id 94so6677695oty.8 for ; Fri, 08 Nov 2019 15:48:54 -0800 (PST) X-Received: by 2002:a05:6830:17c2:: with SMTP id p2mr11400428ota.74.1573256934498; Fri, 08 Nov 2019 15:48:54 -0800 (PST) MIME-Version: 1.0 References: <20191108130123.6839-1-linux@rasmusvillemoes.dk> <20191108130123.6839-48-linux@rasmusvillemoes.dk> In-Reply-To: <20191108130123.6839-48-linux@rasmusvillemoes.dk> From: Li Yang Date: Fri, 8 Nov 2019 17:48:43 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v4 47/47] soc: fsl: qe: remove PPC32 dependency from CONFIG_QUICC_ENGINE To: Rasmus Villemoes Cc: Qiang Zhao , Christophe Leroy , linuxppc-dev , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , lkml , Scott Wood Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 8, 2019 at 7:05 AM Rasmus Villemoes wrote: > > There are also ARM and ARM64 based SOCs with a QUICC Engine, and the > core QE code as well as net/wan/fsl_ucc_hdlc and tty/serial/ucc_uart > has now been modified to not rely on ppcisms. > > So extend the architectures that can select QUICC_ENGINE, and add the > rather modest requirements of OF && HAS_IOMEM. > > The core code as well as the ucc_uart driver has been tested on an > LS1021A (arm), and it has also been tested that the QE code still > works on an mpc8309 (ppc). > > Signed-off-by: Rasmus Villemoes > --- > drivers/soc/fsl/qe/Kconfig | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/soc/fsl/qe/Kconfig b/drivers/soc/fsl/qe/Kconfig > index cfa4b2939992..f1974f811572 100644 > --- a/drivers/soc/fsl/qe/Kconfig > +++ b/drivers/soc/fsl/qe/Kconfig > @@ -5,7 +5,8 @@ > > config QUICC_ENGINE > bool "QUICC Engine (QE) framework support" > - depends on FSL_SOC && PPC32 > + depends on OF && HAS_IOMEM > + depends on PPC32 || ARM || ARM64 || COMPILE_TEST Can you also add PPC64? It is also used on some PPC64 platforms (QorIQ T series). > select GENERIC_ALLOCATOR > select CRC32 > help > -- > 2.23.0 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1ED03C17441 for ; Fri, 8 Nov 2019 23:51:09 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 868A020865 for ; Fri, 8 Nov 2019 23:51:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 868A020865 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nxp.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 478xqY4TRrzF7fh for ; Sat, 9 Nov 2019 10:51:05 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=209.85.210.67; helo=mail-ot1-f67.google.com; envelope-from=pku.leo@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=fail (p=none dis=none) header.from=nxp.com Received: from mail-ot1-f67.google.com (mail-ot1-f67.google.com [209.85.210.67]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 478xn63NqvzF3qw for ; Sat, 9 Nov 2019 10:48:58 +1100 (AEDT) Received: by mail-ot1-f67.google.com with SMTP id t4so6720613otr.1 for ; Fri, 08 Nov 2019 15:48:58 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=XMVjsfRFCMgyyIBo6SJuyhGa3vmCkYAAcBk1J2DsBuY=; b=Nk3vy/i0ZctKSrZDaQ3b64Po1Y0puQ3QQhjo9MIbphV4ldppTxNEZ/7Nc3pvqex7rB 4xnCO+b6V2DvdxBOvFfZFhTMI1I/vbCHOgyYhmscrpZGxgQj0Jf2Y3xVCya0cDKluzYi 0eBGabrLnnGtIcp0oRwhnyjdmDQsMRBc5CidoGZncf2BcDDCrsrnrXNux74VTayxoA85 dVtTp1CZ6bLb9cmQFv1On6430A0QQklK8ERmnxkuHYqbfCf05VQY8D0UZYZinr/2Pp1w th6bh3wyYpdl+1btzHFeUNC3ntMI2cIYitxHIHo+srchU4o4ClmZhUu/dTs7jOpkjd4q +39A== X-Gm-Message-State: APjAAAUBymtt+YrKssRjZgBD4WSOrj4o6ps05fX5GokwrPPTrbfZL8vM hNwvZSN4VhKfQeyved16NUc16O9LudQ= X-Google-Smtp-Source: APXvYqwsZ+qLHxHdgL2cYYEvqRX3SKANfuXV9NF5IGRTa4GC1iUFPO0PMb6O8a4zNu+EBfT9bVJXNw== X-Received: by 2002:a05:6830:224c:: with SMTP id t12mr10500742otd.299.1573256935564; Fri, 08 Nov 2019 15:48:55 -0800 (PST) Received: from mail-ot1-f49.google.com (mail-ot1-f49.google.com. [209.85.210.49]) by smtp.gmail.com with ESMTPSA id j8sm2447169otj.42.2019.11.08.15.48.54 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 08 Nov 2019 15:48:55 -0800 (PST) Received: by mail-ot1-f49.google.com with SMTP id z6so6706294otb.2 for ; Fri, 08 Nov 2019 15:48:54 -0800 (PST) X-Received: by 2002:a05:6830:17c2:: with SMTP id p2mr11400428ota.74.1573256934498; Fri, 08 Nov 2019 15:48:54 -0800 (PST) MIME-Version: 1.0 References: <20191108130123.6839-1-linux@rasmusvillemoes.dk> <20191108130123.6839-48-linux@rasmusvillemoes.dk> In-Reply-To: <20191108130123.6839-48-linux@rasmusvillemoes.dk> From: Li Yang Date: Fri, 8 Nov 2019 17:48:43 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v4 47/47] soc: fsl: qe: remove PPC32 dependency from CONFIG_QUICC_ENGINE To: Rasmus Villemoes Content-Type: text/plain; charset="UTF-8" X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: lkml , Scott Wood , linuxppc-dev , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , Qiang Zhao Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Fri, Nov 8, 2019 at 7:05 AM Rasmus Villemoes wrote: > > There are also ARM and ARM64 based SOCs with a QUICC Engine, and the > core QE code as well as net/wan/fsl_ucc_hdlc and tty/serial/ucc_uart > has now been modified to not rely on ppcisms. > > So extend the architectures that can select QUICC_ENGINE, and add the > rather modest requirements of OF && HAS_IOMEM. > > The core code as well as the ucc_uart driver has been tested on an > LS1021A (arm), and it has also been tested that the QE code still > works on an mpc8309 (ppc). > > Signed-off-by: Rasmus Villemoes > --- > drivers/soc/fsl/qe/Kconfig | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/soc/fsl/qe/Kconfig b/drivers/soc/fsl/qe/Kconfig > index cfa4b2939992..f1974f811572 100644 > --- a/drivers/soc/fsl/qe/Kconfig > +++ b/drivers/soc/fsl/qe/Kconfig > @@ -5,7 +5,8 @@ > > config QUICC_ENGINE > bool "QUICC Engine (QE) framework support" > - depends on FSL_SOC && PPC32 > + depends on OF && HAS_IOMEM > + depends on PPC32 || ARM || ARM64 || COMPILE_TEST Can you also add PPC64? It is also used on some PPC64 platforms (QorIQ T series). > select GENERIC_ALLOCATOR > select CRC32 > help > -- > 2.23.0 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60688C17441 for ; Fri, 8 Nov 2019 23:49:02 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 34A68215EA for ; Fri, 8 Nov 2019 23:49:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Pb9NdG4D" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 34A68215EA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nxp.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3f7M55Ua3bgUavQhVmJdHQT5jv1td0sRQl7JxGEkJ2o=; b=Pb9NdG4DL3KnLe 0ksPajdONVcn/OHkdrABuxIT3vTahrhfhVtgtWa/BycthQXcU0YXVOClVyYvsGbt9zUhxqfBzC5+g on1Nn9/g/4z/MN29OzqOYPyE2ZXc4TMF5bJmL/JJSQtfvvwsIi9FXRzxc5BrT87Swe+dZ1NeAQxo7 4iolgtAVHtaUPYP33ncCc87IdFmv62Cnyh7Hk+P3Sp/kdJYIzUI+JF8aWi4yqmimJCd/UVB0ZsB75 iOimLDaNCOnlUUTNdGnakKuCDhAMuMl/Nf5sndxMRnonS/LOB753cHKZar0FyB+yCJKq4AISMGXtv MIrQnEOOkP3axx2l0pyg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iTDzw-0007dm-9d; Fri, 08 Nov 2019 23:49:00 +0000 Received: from mail-oi1-f195.google.com ([209.85.167.195]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iTDzt-0007d1-4y for linux-arm-kernel@lists.infradead.org; Fri, 08 Nov 2019 23:48:58 +0000 Received: by mail-oi1-f195.google.com with SMTP id a14so6805712oid.5 for ; Fri, 08 Nov 2019 15:48:56 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=XMVjsfRFCMgyyIBo6SJuyhGa3vmCkYAAcBk1J2DsBuY=; b=HCIFi+2QMkA+Zp4aMbkYUahdsyAdljT+1o6cHu2Upw3BEkQdVQPqCWWU91fmobcRrH CREvQDinMXxIq04EMADAKRD3N3VFM0958vakt51ci7VzPaNscnWf/BzFw7kKROiTrhxG KZrWJJ20qmZR2jZHg3VwZJ/NEEUVS/cXXFMgjaoIvlzxsv8KP/jAVG7CnNMoPT8FS+OP LuxyRJbNguQ5Cvat1Chm5h+yA98J5lXY0gLG4/Gs/3bd68v+0FN9/SHkE0cyulUb3a3O fZ92m/SA2nvULP5CahQ1tXxzdoiWfS7svGZeHL59wexWZarkbZpLaJtqj6Cnw+jpNf1f uj+Q== X-Gm-Message-State: APjAAAXEL7WSZ5j8NA4h8ZGcB3fIDAfL2cnVBUvgJfmqa1UMcANZCTY7 tpdL9l6frfwyq0moD3/AjvCoXvXMENI= X-Google-Smtp-Source: APXvYqzJ562Hfx7q1GRQ7zK+RGsCAt1R3k86GIVjgNFqFgTxfTAq2dc8dTZODeYBNWUfZyOG5Cj/ew== X-Received: by 2002:aca:6c1:: with SMTP id 184mr11913514oig.84.1573256935637; Fri, 08 Nov 2019 15:48:55 -0800 (PST) Received: from mail-ot1-f50.google.com (mail-ot1-f50.google.com. [209.85.210.50]) by smtp.gmail.com with ESMTPSA id z20sm2391710otk.22.2019.11.08.15.48.54 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 08 Nov 2019 15:48:55 -0800 (PST) Received: by mail-ot1-f50.google.com with SMTP id t4so6720567otr.1 for ; Fri, 08 Nov 2019 15:48:54 -0800 (PST) X-Received: by 2002:a05:6830:17c2:: with SMTP id p2mr11400428ota.74.1573256934498; Fri, 08 Nov 2019 15:48:54 -0800 (PST) MIME-Version: 1.0 References: <20191108130123.6839-1-linux@rasmusvillemoes.dk> <20191108130123.6839-48-linux@rasmusvillemoes.dk> In-Reply-To: <20191108130123.6839-48-linux@rasmusvillemoes.dk> From: Li Yang Date: Fri, 8 Nov 2019 17:48:43 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v4 47/47] soc: fsl: qe: remove PPC32 dependency from CONFIG_QUICC_ENGINE To: Rasmus Villemoes X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191108_154857_193358_E0DBDCDB X-CRM114-Status: GOOD ( 17.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Christophe Leroy , lkml , Scott Wood , linuxppc-dev , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , Qiang Zhao Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Nov 8, 2019 at 7:05 AM Rasmus Villemoes wrote: > > There are also ARM and ARM64 based SOCs with a QUICC Engine, and the > core QE code as well as net/wan/fsl_ucc_hdlc and tty/serial/ucc_uart > has now been modified to not rely on ppcisms. > > So extend the architectures that can select QUICC_ENGINE, and add the > rather modest requirements of OF && HAS_IOMEM. > > The core code as well as the ucc_uart driver has been tested on an > LS1021A (arm), and it has also been tested that the QE code still > works on an mpc8309 (ppc). > > Signed-off-by: Rasmus Villemoes > --- > drivers/soc/fsl/qe/Kconfig | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/soc/fsl/qe/Kconfig b/drivers/soc/fsl/qe/Kconfig > index cfa4b2939992..f1974f811572 100644 > --- a/drivers/soc/fsl/qe/Kconfig > +++ b/drivers/soc/fsl/qe/Kconfig > @@ -5,7 +5,8 @@ > > config QUICC_ENGINE > bool "QUICC Engine (QE) framework support" > - depends on FSL_SOC && PPC32 > + depends on OF && HAS_IOMEM > + depends on PPC32 || ARM || ARM64 || COMPILE_TEST Can you also add PPC64? It is also used on some PPC64 platforms (QorIQ T series). > select GENERIC_ALLOCATOR > select CRC32 > help > -- > 2.23.0 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel