From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v5,2/6] dmaengine: fsl-qdma: Add qDMA controller driver for Layerscape SoCs From: Li Yang Message-Id: Date: Tue, 12 Jun 2018 11:32:10 -0500 To: Vinod Cc: Wen He , "dmaengine@vger.kernel.org" , Rob Herring , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Jiafei Pan , Jiaheng Fan List-ID: T24gTW9uLCBKdW4gMTEsIDIwMTggYXQgMTE6MDAgUE0sIFZpbm9kIDx2a291bEBrZXJuZWwub3Jn PiB3cm90ZToKPiBPbiAwNS0wNi0xOCwgMTI6MjQsIExpIFlhbmcgd3JvdGU6Cj4+IE9uIFR1ZSwg SnVuIDUsIDIwMTggYXQgMTE6MzAgQU0sIFZpbm9kIDx2a291bEBrZXJuZWwub3JnPiB3cm90ZToK Pj4gPiBPbiAwNC0wNi0xOCwgMDk6NTMsIFdlbiBIZSB3cm90ZToKPj4gPgo+PiA+Pgo+PiA+PiA+ ID4gKy8vIFNQRFgtTGljZW5zZS1JZGVudGlmaWVyOiBHUEwtMi4wCj4+ID4+ID4gPiArLy8gQ29w eXJpZ2h0IDIwMTggTlhQCj4+ID4+ID4KPj4gPj4gPiBJIGtub3cgdGhlIFNQRFggdGFnIGlzIHJl Y29tbWVuZGVkIHRvIGJlIHRoZSAxc3QgbGluZSwgYnV0IGNvcHlyaWdodCBub3JtYWxseQo+PiA+ PiA+IGdvZXMgYmVsb3cgdGhlIGZpbGUgZGVzY3JpcHRpb24gbm90IGFib3ZlLgo+PiA+Cj4+ID4g SSBkbyBub3QgdGhpbmsgdGhhdCBpcyBzcGVjaWZpZWQgYW55d2hlcmUuLiBjYW4geW91IHBvaW50 IGl0Pwo+Pgo+PiBOby4gIEl0IGlzIG5vdCBkb2N1bWVudGVkLiAgQnV0IHRoZSBtYWpvcml0eSBv ZiB0aGUgc291cmNlIGZpbGVzIGluCj4+IExpbnV4IGFyZSB1c2luZyB0aGlzIGhlYWRlciBmb3Jt YXQgbGlrZSBiZWxvdywgc28gSSBhc3N1bWUgaXQgaXMKPj4gc29tZXRoaW5nIGxpa2UgYSBjb252 ZW50aW9uLgo+Pgo+PiAvKgo+PiAgKiB7ZmlsZW5hbWUgLS19IGZpbGUgZGVzY3JpcHRpb24KPj4g ICoKPj4gICogQ29weXJpZ2h0IC4uLgo+PiAgKgo+PiAgKiBMaWNlbnNlIC4uLgo+PiAgKi8KPj4K Pj4gVGhlIERvY3VtZW50YXRpb24vcHJvY2Vzcy9saWNlbnNlLXJ1bGVzLnJzdCBvbmx5IG1lbnRp b25lZCBhYm91dCB0aGUKPj4gcmVxdWlyZW1lbnQgZm9yIFNQRFggdGFncy4gIFNvIEkgdGhpbmsg d2Ugc2hvdWxkIGtlZXAgdGhlIGZvcm1hdCBmb3IKPj4gb3RoZXIgcGFydCBvZiB0aGUgaGVhZGVy Lgo+Cj4gQW5kIExpbnVzIHNhaWQgdGhpcyBodHRwczovL2xrbWwub3JnL2xrbWwvMjAxNy8xMS8y NS8xMzMKClRoYW5rcyBmb3IgdGhlIGluZm9ybWF0aW9uLiAgSXQgaXMgbmV3IHRvIG1lLiAgU28g cHJvYmFibHkgd2UgY2FuIGtlZXAKdGhlIG9yaWdpbmFsIHRlbXBsYXRlIGJ1dCBqdXN0IGNoYW5n ZSAqIGJhc2VkIGNvbW1lbnQgdG8gLy8gYmFzZWQKY29tbWVudCwgbGlrZToKCi8vIFNQRFgtTGlj ZW5zZS1JZGVudGlmaWVyOiAuLi4KLy8KLy8ge2ZpbGVuYW1lIC0tfSBmaWxlIGRlc2NyaXB0aW9u Ci8vCi8vIENvcHlyaWdodCAuLi4uCgpSZWdhcmRzLApMZW8KLS0tClRvIHVuc3Vic2NyaWJlIGZy b20gdGhpcyBsaXN0OiBzZW5kIHRoZSBsaW5lICJ1bnN1YnNjcmliZSBkbWFlbmdpbmUiIGluCnRo ZSBib2R5IG9mIGEgbWVzc2FnZSB0byBtYWpvcmRvbW9Admdlci5rZXJuZWwub3JnCk1vcmUgbWFq b3Jkb21vIGluZm8gYXQgIGh0dHA6Ly92Z2VyLmtlcm5lbC5vcmcvbWFqb3Jkb21vLWluZm8uaHRt bAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: MIME-Version: 1.0 In-Reply-To: <20180612040031.GI2452@vkoul-mobl> References: <20180525111920.24498-1-wen.he_1@nxp.com> <20180525111920.24498-2-wen.he_1@nxp.com> <20180605163043.GX16230@vkoul-mobl> <20180612040031.GI2452@vkoul-mobl> From: Li Yang Date: Tue, 12 Jun 2018 11:32:10 -0500 Message-ID: Subject: Re: [v5 2/6] dmaengine: fsl-qdma: Add qDMA controller driver for Layerscape SoCs Content-Type: text/plain; charset="UTF-8" To: Vinod Cc: Wen He , "dmaengine@vger.kernel.org" , Rob Herring , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Jiafei Pan , Jiaheng Fan List-ID: On Mon, Jun 11, 2018 at 11:00 PM, Vinod wrote: > On 05-06-18, 12:24, Li Yang wrote: >> On Tue, Jun 5, 2018 at 11:30 AM, Vinod wrote: >> > On 04-06-18, 09:53, Wen He wrote: >> > >> >> >> >> > > +// SPDX-License-Identifier: GPL-2.0 >> >> > > +// Copyright 2018 NXP >> >> > >> >> > I know the SPDX tag is recommended to be the 1st line, but copyright normally >> >> > goes below the file description not above. >> > >> > I do not think that is specified anywhere.. can you point it? >> >> No. It is not documented. But the majority of the source files in >> Linux are using this header format like below, so I assume it is >> something like a convention. >> >> /* >> * {filename --} file description >> * >> * Copyright ... >> * >> * License ... >> */ >> >> The Documentation/process/license-rules.rst only mentioned about the >> requirement for SPDX tags. So I think we should keep the format for >> other part of the header. > > And Linus said this https://lkml.org/lkml/2017/11/25/133 Thanks for the information. It is new to me. So probably we can keep the original template but just change * based comment to // based comment, like: // SPDX-License-Identifier: ... // // {filename --} file description // // Copyright .... Regards, Leo