From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 006FEC432C3 for ; Fri, 15 Nov 2019 05:44:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CC5962072B for ; Fri, 15 Nov 2019 05:44:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727032AbfKOFoe (ORCPT ); Fri, 15 Nov 2019 00:44:34 -0500 Received: from mail-oi1-f195.google.com ([209.85.167.195]:47023 "EHLO mail-oi1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725774AbfKOFoe (ORCPT ); Fri, 15 Nov 2019 00:44:34 -0500 Received: by mail-oi1-f195.google.com with SMTP id n14so7591450oie.13; Thu, 14 Nov 2019 21:44:33 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/3uU+eY5BtMdRnLX2UOVt6iN0KOpw7AZZyEPeGfnQp4=; b=DvBPhJ5hNSIVVXhVsiHAcd2uqINIue4JNpb0Fhkx5aNxr6mGgdBqnUzxyBfXhz+Vvb quSerUMzMVeUUcdunWCoyQb6rYyQ7WzsjBWQwg8ymO+Lt75x2mmbZ22SGT0GEFXaa5n2 xM/MoXMhhY/+UxziqCVhSaEk0TN668cWRFagcL4uWFUGVawa+5en/ONLOp6DnYWaOmyK qfGfGCzulmqVAoIMCRXUmHk/rqD4PA9monIx1VScdx6K2FBx6T/+CbyVlS4GmDOuEbHJ H0nxb7TUj9xwL/hiVtrYhOKDBMANV8OCYZisu5qqgDgoQzx6mdKgdIb0YxkOkkNCHnQ7 RBkw== X-Gm-Message-State: APjAAAV/cvjHy5O5OMcKf1K5cVflbJiWIdDWgzu4hQP4gCWgDUCY0s7C lAlnlbaHY3czkJ1r39LBnz0Ydbw8 X-Google-Smtp-Source: APXvYqyP7mM2B2YHL3qUad4bdKQIAVScMQ4K9L2oTb5HfN5+3hzlEknxB5ROuK9a6JDUu5IYtDyg4w== X-Received: by 2002:aca:ef8b:: with SMTP id n133mr6184321oih.11.1573796673163; Thu, 14 Nov 2019 21:44:33 -0800 (PST) Received: from mail-oi1-f180.google.com (mail-oi1-f180.google.com. [209.85.167.180]) by smtp.gmail.com with ESMTPSA id u1sm2568821otk.33.2019.11.14.21.44.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 14 Nov 2019 21:44:32 -0800 (PST) Received: by mail-oi1-f180.google.com with SMTP id m193so7650728oig.0; Thu, 14 Nov 2019 21:44:32 -0800 (PST) X-Received: by 2002:a54:451a:: with SMTP id l26mr6675985oil.154.1573796672412; Thu, 14 Nov 2019 21:44:32 -0800 (PST) MIME-Version: 1.0 References: <20191108130123.6839-1-linux@rasmusvillemoes.dk> <20191108130123.6839-47-linux@rasmusvillemoes.dk> In-Reply-To: From: Li Yang Date: Thu, 14 Nov 2019 23:44:21 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v4 46/47] net: ethernet: freescale: make UCC_GETH explicitly depend on PPC32 To: Timur Tabi Cc: Rasmus Villemoes , Qiang Zhao , Christophe Leroy , linuxppc-dev , linux-arm-kernel , lkml , Scott Wood , netdev Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 14, 2019 at 10:37 PM Timur Tabi wrote: > > On Fri, Nov 8, 2019 at 7:04 AM Rasmus Villemoes > wrote: > > > > Currently, QUICC_ENGINE depends on PPC32, so this in itself does not > > change anything. In order to allow removing the PPC32 dependency from > > QUICC_ENGINE and avoid allmodconfig build failures, add this explicit > > dependency. > > Can you add an explanation why we don't want ucc_geth on non-PowerPC platforms? I think it is because the QE Ethernet was never integrated in any non-PowerPC SoC and most likely will not be in the future. We probably can make it compile for other architectures for general code quality but it is not a priority. Regards, Leo From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F08FC432C3 for ; Fri, 15 Nov 2019 05:47:02 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id ECED9206D8 for ; Fri, 15 Nov 2019 05:47:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ECED9206D8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nxp.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 47DnRS1GK2zF5k5 for ; Fri, 15 Nov 2019 16:47:00 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=209.85.167.194; helo=mail-oi1-f194.google.com; envelope-from=pku.leo@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=fail (p=none dis=none) header.from=nxp.com Received: from mail-oi1-f194.google.com (mail-oi1-f194.google.com [209.85.167.194]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 47DnNk0jPVzF78x for ; Fri, 15 Nov 2019 16:44:37 +1100 (AEDT) Received: by mail-oi1-f194.google.com with SMTP id a14so7637684oid.5 for ; Thu, 14 Nov 2019 21:44:37 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/3uU+eY5BtMdRnLX2UOVt6iN0KOpw7AZZyEPeGfnQp4=; b=E+7RsZC2JgKnqsKjJVn45juXuIRORpndt2FJsDB9IEKZJ7Uovllki3+s5AoHYoSBl7 82XHCHeUdoN3to75tFQDdqe88vBfuUWFw5kXP7qclLvzzqXLFmC34/xHt/gQEq7iHdhy cAFkOI9b6FRLb18Sgs//aCcQg9bGJJA4Qrq1WEe/IR2+sDMhqRiUDBnOJLMI/dX7GcVO 00fkLjBFJSosUOdYn+Z1ohbqAWFCQ3UURAUSQBvpu3jCDrHqm4TuUh3e3IEWerLer6/B TW1kQgrQHRHtBdOKp9O2UraRQyNBNmsGW+W47UeVgubdykuOMnG8T7QX86HKjlS+JcMD +7uQ== X-Gm-Message-State: APjAAAVj+HpBloxEwfKp7kLHIPg8Fq0SsyJnc4lCjDc1KVyJGNph/qwH RqY7yXvHn78p4Bqb5gZXXzq0d5ZB X-Google-Smtp-Source: APXvYqwke/p2q65QD6D3IQYzdVRRE6+WsUkLy6b9/2ogDITA3MJ9y5DgT6Lb4invTRUweFQYDd1o3A== X-Received: by 2002:aca:4f4f:: with SMTP id d76mr6659928oib.167.1573796673284; Thu, 14 Nov 2019 21:44:33 -0800 (PST) Received: from mail-oi1-f178.google.com (mail-oi1-f178.google.com. [209.85.167.178]) by smtp.gmail.com with ESMTPSA id z2sm2623904otp.2.2019.11.14.21.44.32 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 14 Nov 2019 21:44:32 -0800 (PST) Received: by mail-oi1-f178.google.com with SMTP id i185so7622249oif.9 for ; Thu, 14 Nov 2019 21:44:32 -0800 (PST) X-Received: by 2002:a54:451a:: with SMTP id l26mr6675985oil.154.1573796672412; Thu, 14 Nov 2019 21:44:32 -0800 (PST) MIME-Version: 1.0 References: <20191108130123.6839-1-linux@rasmusvillemoes.dk> <20191108130123.6839-47-linux@rasmusvillemoes.dk> In-Reply-To: From: Li Yang Date: Thu, 14 Nov 2019 23:44:21 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v4 46/47] net: ethernet: freescale: make UCC_GETH explicitly depend on PPC32 To: Timur Tabi Content-Type: text/plain; charset="UTF-8" X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: netdev , Rasmus Villemoes , lkml , Scott Wood , linuxppc-dev , linux-arm-kernel , Qiang Zhao Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Thu, Nov 14, 2019 at 10:37 PM Timur Tabi wrote: > > On Fri, Nov 8, 2019 at 7:04 AM Rasmus Villemoes > wrote: > > > > Currently, QUICC_ENGINE depends on PPC32, so this in itself does not > > change anything. In order to allow removing the PPC32 dependency from > > QUICC_ENGINE and avoid allmodconfig build failures, add this explicit > > dependency. > > Can you add an explanation why we don't want ucc_geth on non-PowerPC platforms? I think it is because the QE Ethernet was never integrated in any non-PowerPC SoC and most likely will not be in the future. We probably can make it compile for other architectures for general code quality but it is not a priority. Regards, Leo From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A841FC432C3 for ; Fri, 15 Nov 2019 05:44:40 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 73F542072B for ; Fri, 15 Nov 2019 05:44:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="SMT5rkwd" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 73F542072B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nxp.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=WTLZtyyz1fMQCaTLBoC2BPR4/AQ/nm35QB2fSROjkWw=; b=SMT5rkwdPG3j5U ODAjZfzl0kLJ9RCwpX5ZcumHIXOUXBi8qHW8G7V1EakNyTyjzyorfm9gBmKHhup6B6X8AvakjmuYV RcYv1HoFgdNbNMJEqSYAdsQDAGHhxwmTYu6pAgDcsILVFJcxyT9mrdJCsfe18DJGOEwIIwB7OxLCi pbWRQHufrxPpkxg+ypAk9sNQceN8l1WGhV1gb4sBnl/I995kX/2nuIKguVSRzg6o4BVG8U6HJ6XjF LigYvodQD/NUw+Y+zyR6Og8manKZ9Dyw8hLpL/5eaeodkvcbRmgrnx8T3fVIVBlnz867+Qk4YzlBq 5gfVSh7fLHRlQJwUHxXA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iVUPO-0006Cg-U2; Fri, 15 Nov 2019 05:44:38 +0000 Received: from mail-oi1-f193.google.com ([209.85.167.193]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iVUPL-0006Bw-AD for linux-arm-kernel@lists.infradead.org; Fri, 15 Nov 2019 05:44:36 +0000 Received: by mail-oi1-f193.google.com with SMTP id l202so7663630oig.1 for ; Thu, 14 Nov 2019 21:44:34 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/3uU+eY5BtMdRnLX2UOVt6iN0KOpw7AZZyEPeGfnQp4=; b=DgW6lvFf8sYJqGuA4UarhGy7tJLrcw56gQYf1FR9zkx4fvLsA55wT6NrcQ8U9vcAPz 1PLzuSY37TfR7CEf5x6opQei8MWx/O7Kh58NmAyXkHWzRzpmEXscCKoxKcW4Ipoiwt9k 4xXck8jNi2zHm/+99/P76D8Q5m2ru6n2H8OEZKn3OLXI47mqPc2PYT82UhsHDyaBPy3I BY0N6CElSM8GhKH+0Vh1kAdoaCDp7YuK31TdVb8vaCvqJ1tc2rbpCUOsxgwicjr0NCiR zccZuasnbrCEFFPuJ58/bBQKQVVibTsHGxNTcNSQ7Dp7mljsG+lYwAaP3ryARXCbuFg9 t8lQ== X-Gm-Message-State: APjAAAXU7AaduP2JL+UJQBX1gi4FVQWnKUrQj6G9Ll+3Bxlgph4fA5pY wxetMhqassPT+a8ThY/n+fk4Eb6t X-Google-Smtp-Source: APXvYqwS2n/f32MPZ0M8sMvFAmsfhYqv0I8T752zHZxQnGZJZzWta4L5uFywMgS0KI4gu07eP0GrfQ== X-Received: by 2002:aca:cdd6:: with SMTP id d205mr6681906oig.9.1573796673224; Thu, 14 Nov 2019 21:44:33 -0800 (PST) Received: from mail-oi1-f170.google.com (mail-oi1-f170.google.com. [209.85.167.170]) by smtp.gmail.com with ESMTPSA id 47sm2611235otu.37.2019.11.14.21.44.32 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 14 Nov 2019 21:44:32 -0800 (PST) Received: by mail-oi1-f170.google.com with SMTP id e9so7620303oif.8 for ; Thu, 14 Nov 2019 21:44:32 -0800 (PST) X-Received: by 2002:a54:451a:: with SMTP id l26mr6675985oil.154.1573796672412; Thu, 14 Nov 2019 21:44:32 -0800 (PST) MIME-Version: 1.0 References: <20191108130123.6839-1-linux@rasmusvillemoes.dk> <20191108130123.6839-47-linux@rasmusvillemoes.dk> In-Reply-To: From: Li Yang Date: Thu, 14 Nov 2019 23:44:21 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v4 46/47] net: ethernet: freescale: make UCC_GETH explicitly depend on PPC32 To: Timur Tabi X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191114_214435_353682_16A2D604 X-CRM114-Status: GOOD ( 11.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Christophe Leroy , netdev , Rasmus Villemoes , lkml , Scott Wood , linuxppc-dev , linux-arm-kernel , Qiang Zhao Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Nov 14, 2019 at 10:37 PM Timur Tabi wrote: > > On Fri, Nov 8, 2019 at 7:04 AM Rasmus Villemoes > wrote: > > > > Currently, QUICC_ENGINE depends on PPC32, so this in itself does not > > change anything. In order to allow removing the PPC32 dependency from > > QUICC_ENGINE and avoid allmodconfig build failures, add this explicit > > dependency. > > Can you add an explanation why we don't want ucc_geth on non-PowerPC platforms? I think it is because the QE Ethernet was never integrated in any non-PowerPC SoC and most likely will not be in the future. We probably can make it compile for other architectures for general code quality but it is not a priority. Regards, Leo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel