From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37C30C432C0 for ; Wed, 20 Nov 2019 17:59:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 109EA20679 for ; Wed, 20 Nov 2019 17:59:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728027AbfKTR7t (ORCPT ); Wed, 20 Nov 2019 12:59:49 -0500 Received: from mail-ot1-f67.google.com ([209.85.210.67]:37756 "EHLO mail-ot1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727442AbfKTR7s (ORCPT ); Wed, 20 Nov 2019 12:59:48 -0500 Received: by mail-ot1-f67.google.com with SMTP id d5so393810otp.4 for ; Wed, 20 Nov 2019 09:59:47 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=zBB9OsnBCrlScEEQaEUduHBYkfuZALzvxczmYt/dJsU=; b=pc6KYITr55wk4fIuuuVxbZoQJq2MyolGgD5/wpYGI/zQUtSgjQYggQfJT6cL4U7V/L 4oe8BBXiYpeA+N8BK8gel1M0B0qYtku9mBSMjQHRFEoAD/1TAg2EFE3ji1sNO91AwhZE Z5SvB0Spg+YCOkvqXsXR00Dp7A4LAF7aW1xLscACCzsOn3Y3PGOKgO4hG7otc3TWaNY4 tbJvUB8tnWw6xuOo/boDUm0PhRTP7WjLBDd3221SIVJvpOxRndUZkCdJPWkzNPbUYk38 mmtg+3I2GrMlN4yPAsHmdLSnj/nIpi+vdn9PG7r6MVJ7BDFVnj4PeLwg7n7Ozq4WqQbD JRDQ== X-Gm-Message-State: APjAAAVlPW+63vcMy83V2olpsJJ89XAipQrfkLr8VPS/Nddqt5ZNHtXz uP4fuc5GdoxZNwc7xfUGbZyKa6lh X-Google-Smtp-Source: APXvYqzgyX8+wGptCdurAvWhRC2tBLrufmFLmBMrjTrUNQQMIvDDZlBrEpdQZtFUWmxFVbVr1Yb8nw== X-Received: by 2002:a9d:4003:: with SMTP id m3mr3209204ote.50.1574272787102; Wed, 20 Nov 2019 09:59:47 -0800 (PST) Received: from mail-ot1-f43.google.com (mail-ot1-f43.google.com. [209.85.210.43]) by smtp.gmail.com with ESMTPSA id 9sm252248oiq.33.2019.11.20.09.59.46 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 20 Nov 2019 09:59:46 -0800 (PST) Received: by mail-ot1-f43.google.com with SMTP id r24so336992otk.12 for ; Wed, 20 Nov 2019 09:59:46 -0800 (PST) X-Received: by 2002:a9d:173:: with SMTP id 106mr3009123otu.205.1574272785900; Wed, 20 Nov 2019 09:59:45 -0800 (PST) MIME-Version: 1.0 References: <20191118112324.22725-1-linux@rasmusvillemoes.dk> <20191118112324.22725-14-linux@rasmusvillemoes.dk> In-Reply-To: <20191118112324.22725-14-linux@rasmusvillemoes.dk> From: Li Yang Date: Wed, 20 Nov 2019 11:59:34 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v5 13/48] powerpc/83xx: remove mpc83xx_ipic_and_qe_init_IRQ To: Rasmus Villemoes , Scott Wood Cc: Qiang Zhao , Christophe Leroy , linuxppc-dev , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , lkml , Timur Tabi Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 18, 2019 at 5:29 AM Rasmus Villemoes wrote: Hi Scott, What do you think of the PowerPC related changes(patch 13,14)? Can we have you ACK and merge the series from soc tree? Regards, Leo > > This is now exactly the same as mpc83xx_ipic_init_IRQ, so just use > that directly. > > Signed-off-by: Rasmus Villemoes > --- > arch/powerpc/platforms/83xx/km83xx.c | 2 +- > arch/powerpc/platforms/83xx/misc.c | 7 ------- > arch/powerpc/platforms/83xx/mpc832x_mds.c | 2 +- > arch/powerpc/platforms/83xx/mpc832x_rdb.c | 2 +- > arch/powerpc/platforms/83xx/mpc836x_mds.c | 2 +- > arch/powerpc/platforms/83xx/mpc836x_rdk.c | 2 +- > arch/powerpc/platforms/83xx/mpc83xx.h | 5 ----- > 7 files changed, 5 insertions(+), 17 deletions(-) > > diff --git a/arch/powerpc/platforms/83xx/km83xx.c b/arch/powerpc/platforms/83xx/km83xx.c > index 5c6227f7bc37..3d89569e9e71 100644 > --- a/arch/powerpc/platforms/83xx/km83xx.c > +++ b/arch/powerpc/platforms/83xx/km83xx.c > @@ -177,7 +177,7 @@ define_machine(mpc83xx_km) { > .name = "mpc83xx-km-platform", > .probe = mpc83xx_km_probe, > .setup_arch = mpc83xx_km_setup_arch, > - .init_IRQ = mpc83xx_ipic_and_qe_init_IRQ, > + .init_IRQ = mpc83xx_ipic_init_IRQ, > .get_irq = ipic_get_irq, > .restart = mpc83xx_restart, > .time_init = mpc83xx_time_init, > diff --git a/arch/powerpc/platforms/83xx/misc.c b/arch/powerpc/platforms/83xx/misc.c > index 6935a5b9fbd1..1d8306eb2958 100644 > --- a/arch/powerpc/platforms/83xx/misc.c > +++ b/arch/powerpc/platforms/83xx/misc.c > @@ -88,13 +88,6 @@ void __init mpc83xx_ipic_init_IRQ(void) > ipic_set_default_priority(); > } > > -#ifdef CONFIG_QUICC_ENGINE > -void __init mpc83xx_ipic_and_qe_init_IRQ(void) > -{ > - mpc83xx_ipic_init_IRQ(); > -} > -#endif /* CONFIG_QUICC_ENGINE */ > - > static const struct of_device_id of_bus_ids[] __initconst = { > { .type = "soc", }, > { .compatible = "soc", }, > diff --git a/arch/powerpc/platforms/83xx/mpc832x_mds.c b/arch/powerpc/platforms/83xx/mpc832x_mds.c > index 1c73af104d19..6fa5402ebf20 100644 > --- a/arch/powerpc/platforms/83xx/mpc832x_mds.c > +++ b/arch/powerpc/platforms/83xx/mpc832x_mds.c > @@ -101,7 +101,7 @@ define_machine(mpc832x_mds) { > .name = "MPC832x MDS", > .probe = mpc832x_sys_probe, > .setup_arch = mpc832x_sys_setup_arch, > - .init_IRQ = mpc83xx_ipic_and_qe_init_IRQ, > + .init_IRQ = mpc83xx_ipic_init_IRQ, > .get_irq = ipic_get_irq, > .restart = mpc83xx_restart, > .time_init = mpc83xx_time_init, > diff --git a/arch/powerpc/platforms/83xx/mpc832x_rdb.c b/arch/powerpc/platforms/83xx/mpc832x_rdb.c > index 87f68ca06255..622c625d5ce4 100644 > --- a/arch/powerpc/platforms/83xx/mpc832x_rdb.c > +++ b/arch/powerpc/platforms/83xx/mpc832x_rdb.c > @@ -219,7 +219,7 @@ define_machine(mpc832x_rdb) { > .name = "MPC832x RDB", > .probe = mpc832x_rdb_probe, > .setup_arch = mpc832x_rdb_setup_arch, > - .init_IRQ = mpc83xx_ipic_and_qe_init_IRQ, > + .init_IRQ = mpc83xx_ipic_init_IRQ, > .get_irq = ipic_get_irq, > .restart = mpc83xx_restart, > .time_init = mpc83xx_time_init, > diff --git a/arch/powerpc/platforms/83xx/mpc836x_mds.c b/arch/powerpc/platforms/83xx/mpc836x_mds.c > index 5b484da9533e..219a83ab6c00 100644 > --- a/arch/powerpc/platforms/83xx/mpc836x_mds.c > +++ b/arch/powerpc/platforms/83xx/mpc836x_mds.c > @@ -208,7 +208,7 @@ define_machine(mpc836x_mds) { > .name = "MPC836x MDS", > .probe = mpc836x_mds_probe, > .setup_arch = mpc836x_mds_setup_arch, > - .init_IRQ = mpc83xx_ipic_and_qe_init_IRQ, > + .init_IRQ = mpc83xx_ipic_init_IRQ, > .get_irq = ipic_get_irq, > .restart = mpc83xx_restart, > .time_init = mpc83xx_time_init, > diff --git a/arch/powerpc/platforms/83xx/mpc836x_rdk.c b/arch/powerpc/platforms/83xx/mpc836x_rdk.c > index b7119e443920..b4aac2cde849 100644 > --- a/arch/powerpc/platforms/83xx/mpc836x_rdk.c > +++ b/arch/powerpc/platforms/83xx/mpc836x_rdk.c > @@ -41,7 +41,7 @@ define_machine(mpc836x_rdk) { > .name = "MPC836x RDK", > .probe = mpc836x_rdk_probe, > .setup_arch = mpc836x_rdk_setup_arch, > - .init_IRQ = mpc83xx_ipic_and_qe_init_IRQ, > + .init_IRQ = mpc83xx_ipic_init_IRQ, > .get_irq = ipic_get_irq, > .restart = mpc83xx_restart, > .time_init = mpc83xx_time_init, > diff --git a/arch/powerpc/platforms/83xx/mpc83xx.h b/arch/powerpc/platforms/83xx/mpc83xx.h > index d343f6ce2599..f37d04332fc7 100644 > --- a/arch/powerpc/platforms/83xx/mpc83xx.h > +++ b/arch/powerpc/platforms/83xx/mpc83xx.h > @@ -72,11 +72,6 @@ extern int mpc837x_usb_cfg(void); > extern int mpc834x_usb_cfg(void); > extern int mpc831x_usb_cfg(void); > extern void mpc83xx_ipic_init_IRQ(void); > -#ifdef CONFIG_QUICC_ENGINE > -extern void mpc83xx_ipic_and_qe_init_IRQ(void); > -#else > -#define mpc83xx_ipic_and_qe_init_IRQ mpc83xx_ipic_init_IRQ > -#endif /* CONFIG_QUICC_ENGINE */ > > #ifdef CONFIG_PCI > extern void mpc83xx_setup_pci(void); > -- > 2.23.0 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50263C432C3 for ; Wed, 20 Nov 2019 18:02:19 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 02A3F20643 for ; Wed, 20 Nov 2019 18:02:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 02A3F20643 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nxp.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 47J9WX2WHnzDqvV for ; Thu, 21 Nov 2019 05:02:16 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=209.85.167.194; helo=mail-oi1-f194.google.com; envelope-from=pku.leo@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=fail (p=none dis=none) header.from=nxp.com Received: from mail-oi1-f194.google.com (mail-oi1-f194.google.com [209.85.167.194]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 47J9Sl3pXLzDqmY for ; Thu, 21 Nov 2019 04:59:49 +1100 (AEDT) Received: by mail-oi1-f194.google.com with SMTP id s71so550562oih.11 for ; Wed, 20 Nov 2019 09:59:49 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=zBB9OsnBCrlScEEQaEUduHBYkfuZALzvxczmYt/dJsU=; b=B92Pf2bDtIUvVHhLQeFGHgh5OcCRBoTDJwB/UvlLshrqnvQRTuCxY/Nb8xAuIXJ1Yw 4fDiteD2lf0dRYcfrpCJc9xY082/kd2DxprFc0SfEMRY+6GOFcFX/+7+r6JRRUYQCUrP i88Q7dILWLE1PpVuEimKQRwMpY11G2TflMh+LkLkT8m1dpzEMaTSXwQ4Yh0P0hxOLkm2 RqRP4RlNip9vIUjOGwOLWwmEsDWY1d9PZfOmlVm2mT756I0XZp0lK2M/cn/eaLdZ0dQp hqmddNy7CbtzCvpdQHejy0mlZP73eDk8H5huaz8DVaBe11pMkhUmAQAQCqJmBfGmPLn8 NoIQ== X-Gm-Message-State: APjAAAWjgkf6XYpEDC7n7bCgnDYqrMUJ/6z20eqe1Aj8QvIpoa7pLSSR MkCBH6nUEx2KgHk+G6NMxP2W4181 X-Google-Smtp-Source: APXvYqwSNtVSKEvrO6xc0KMVueYpoGGnZn4Wh7CE4G3w5k4/7vC2L0XAr2LQZH4YnH1WPcmEYlyyVQ== X-Received: by 2002:aca:5441:: with SMTP id i62mr3793818oib.42.1574272787182; Wed, 20 Nov 2019 09:59:47 -0800 (PST) Received: from mail-ot1-f45.google.com (mail-ot1-f45.google.com. [209.85.210.45]) by smtp.gmail.com with ESMTPSA id q3sm8566383oti.49.2019.11.20.09.59.46 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 20 Nov 2019 09:59:46 -0800 (PST) Received: by mail-ot1-f45.google.com with SMTP id z25so386641oti.5 for ; Wed, 20 Nov 2019 09:59:46 -0800 (PST) X-Received: by 2002:a9d:173:: with SMTP id 106mr3009123otu.205.1574272785900; Wed, 20 Nov 2019 09:59:45 -0800 (PST) MIME-Version: 1.0 References: <20191118112324.22725-1-linux@rasmusvillemoes.dk> <20191118112324.22725-14-linux@rasmusvillemoes.dk> In-Reply-To: <20191118112324.22725-14-linux@rasmusvillemoes.dk> From: Li Yang Date: Wed, 20 Nov 2019 11:59:34 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v5 13/48] powerpc/83xx: remove mpc83xx_ipic_and_qe_init_IRQ To: Rasmus Villemoes , Scott Wood Content-Type: text/plain; charset="UTF-8" X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Timur Tabi , lkml , linuxppc-dev , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , Qiang Zhao Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Mon, Nov 18, 2019 at 5:29 AM Rasmus Villemoes wrote: Hi Scott, What do you think of the PowerPC related changes(patch 13,14)? Can we have you ACK and merge the series from soc tree? Regards, Leo > > This is now exactly the same as mpc83xx_ipic_init_IRQ, so just use > that directly. > > Signed-off-by: Rasmus Villemoes > --- > arch/powerpc/platforms/83xx/km83xx.c | 2 +- > arch/powerpc/platforms/83xx/misc.c | 7 ------- > arch/powerpc/platforms/83xx/mpc832x_mds.c | 2 +- > arch/powerpc/platforms/83xx/mpc832x_rdb.c | 2 +- > arch/powerpc/platforms/83xx/mpc836x_mds.c | 2 +- > arch/powerpc/platforms/83xx/mpc836x_rdk.c | 2 +- > arch/powerpc/platforms/83xx/mpc83xx.h | 5 ----- > 7 files changed, 5 insertions(+), 17 deletions(-) > > diff --git a/arch/powerpc/platforms/83xx/km83xx.c b/arch/powerpc/platforms/83xx/km83xx.c > index 5c6227f7bc37..3d89569e9e71 100644 > --- a/arch/powerpc/platforms/83xx/km83xx.c > +++ b/arch/powerpc/platforms/83xx/km83xx.c > @@ -177,7 +177,7 @@ define_machine(mpc83xx_km) { > .name = "mpc83xx-km-platform", > .probe = mpc83xx_km_probe, > .setup_arch = mpc83xx_km_setup_arch, > - .init_IRQ = mpc83xx_ipic_and_qe_init_IRQ, > + .init_IRQ = mpc83xx_ipic_init_IRQ, > .get_irq = ipic_get_irq, > .restart = mpc83xx_restart, > .time_init = mpc83xx_time_init, > diff --git a/arch/powerpc/platforms/83xx/misc.c b/arch/powerpc/platforms/83xx/misc.c > index 6935a5b9fbd1..1d8306eb2958 100644 > --- a/arch/powerpc/platforms/83xx/misc.c > +++ b/arch/powerpc/platforms/83xx/misc.c > @@ -88,13 +88,6 @@ void __init mpc83xx_ipic_init_IRQ(void) > ipic_set_default_priority(); > } > > -#ifdef CONFIG_QUICC_ENGINE > -void __init mpc83xx_ipic_and_qe_init_IRQ(void) > -{ > - mpc83xx_ipic_init_IRQ(); > -} > -#endif /* CONFIG_QUICC_ENGINE */ > - > static const struct of_device_id of_bus_ids[] __initconst = { > { .type = "soc", }, > { .compatible = "soc", }, > diff --git a/arch/powerpc/platforms/83xx/mpc832x_mds.c b/arch/powerpc/platforms/83xx/mpc832x_mds.c > index 1c73af104d19..6fa5402ebf20 100644 > --- a/arch/powerpc/platforms/83xx/mpc832x_mds.c > +++ b/arch/powerpc/platforms/83xx/mpc832x_mds.c > @@ -101,7 +101,7 @@ define_machine(mpc832x_mds) { > .name = "MPC832x MDS", > .probe = mpc832x_sys_probe, > .setup_arch = mpc832x_sys_setup_arch, > - .init_IRQ = mpc83xx_ipic_and_qe_init_IRQ, > + .init_IRQ = mpc83xx_ipic_init_IRQ, > .get_irq = ipic_get_irq, > .restart = mpc83xx_restart, > .time_init = mpc83xx_time_init, > diff --git a/arch/powerpc/platforms/83xx/mpc832x_rdb.c b/arch/powerpc/platforms/83xx/mpc832x_rdb.c > index 87f68ca06255..622c625d5ce4 100644 > --- a/arch/powerpc/platforms/83xx/mpc832x_rdb.c > +++ b/arch/powerpc/platforms/83xx/mpc832x_rdb.c > @@ -219,7 +219,7 @@ define_machine(mpc832x_rdb) { > .name = "MPC832x RDB", > .probe = mpc832x_rdb_probe, > .setup_arch = mpc832x_rdb_setup_arch, > - .init_IRQ = mpc83xx_ipic_and_qe_init_IRQ, > + .init_IRQ = mpc83xx_ipic_init_IRQ, > .get_irq = ipic_get_irq, > .restart = mpc83xx_restart, > .time_init = mpc83xx_time_init, > diff --git a/arch/powerpc/platforms/83xx/mpc836x_mds.c b/arch/powerpc/platforms/83xx/mpc836x_mds.c > index 5b484da9533e..219a83ab6c00 100644 > --- a/arch/powerpc/platforms/83xx/mpc836x_mds.c > +++ b/arch/powerpc/platforms/83xx/mpc836x_mds.c > @@ -208,7 +208,7 @@ define_machine(mpc836x_mds) { > .name = "MPC836x MDS", > .probe = mpc836x_mds_probe, > .setup_arch = mpc836x_mds_setup_arch, > - .init_IRQ = mpc83xx_ipic_and_qe_init_IRQ, > + .init_IRQ = mpc83xx_ipic_init_IRQ, > .get_irq = ipic_get_irq, > .restart = mpc83xx_restart, > .time_init = mpc83xx_time_init, > diff --git a/arch/powerpc/platforms/83xx/mpc836x_rdk.c b/arch/powerpc/platforms/83xx/mpc836x_rdk.c > index b7119e443920..b4aac2cde849 100644 > --- a/arch/powerpc/platforms/83xx/mpc836x_rdk.c > +++ b/arch/powerpc/platforms/83xx/mpc836x_rdk.c > @@ -41,7 +41,7 @@ define_machine(mpc836x_rdk) { > .name = "MPC836x RDK", > .probe = mpc836x_rdk_probe, > .setup_arch = mpc836x_rdk_setup_arch, > - .init_IRQ = mpc83xx_ipic_and_qe_init_IRQ, > + .init_IRQ = mpc83xx_ipic_init_IRQ, > .get_irq = ipic_get_irq, > .restart = mpc83xx_restart, > .time_init = mpc83xx_time_init, > diff --git a/arch/powerpc/platforms/83xx/mpc83xx.h b/arch/powerpc/platforms/83xx/mpc83xx.h > index d343f6ce2599..f37d04332fc7 100644 > --- a/arch/powerpc/platforms/83xx/mpc83xx.h > +++ b/arch/powerpc/platforms/83xx/mpc83xx.h > @@ -72,11 +72,6 @@ extern int mpc837x_usb_cfg(void); > extern int mpc834x_usb_cfg(void); > extern int mpc831x_usb_cfg(void); > extern void mpc83xx_ipic_init_IRQ(void); > -#ifdef CONFIG_QUICC_ENGINE > -extern void mpc83xx_ipic_and_qe_init_IRQ(void); > -#else > -#define mpc83xx_ipic_and_qe_init_IRQ mpc83xx_ipic_init_IRQ > -#endif /* CONFIG_QUICC_ENGINE */ > > #ifdef CONFIG_PCI > extern void mpc83xx_setup_pci(void); > -- > 2.23.0 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0AF74C432C0 for ; Wed, 20 Nov 2019 17:59:56 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D3D6C20679 for ; Wed, 20 Nov 2019 17:59:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="UPM4NPE2" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D3D6C20679 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nxp.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=RvKCG/jaXLdVIDyGZhCFN8TzQujeh+s2lT8wfq+dHLw=; b=UPM4NPE2tJ/1VN wYWuIRKwpGu658gP9V/v0O2Y7sjGp1ZoInO/aM81RPtiBp4CglQhUYU5UuCs0i+Gu7l7f3cmd7jH3 PawjbitcO5RHKFFtX1dEalU1ufz8yUFKxXZ1GQEItxjr2v3ErY/Ti9q+uB+6OOWsE1MSEZ0Q8JNTO CZFhXNwL20Gf8uA4T9BbJ0wTCQsI0MXD0qNC2dX/GI5zEw0e2ZVOm7y2LKQmIzb4uIep6wBvNhZw3 4n1NIjbmp8YoDXi2dMDCF/NBUcx2oVZVoBmUSMvN6xROnGP43J+y76cTgvZlhTIyxA9tZ7PsUZoW9 FI1N9n4AVmQs6vHupDXA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iXUGf-0005Ct-Q5; Wed, 20 Nov 2019 17:59:53 +0000 Received: from mail-oi1-f195.google.com ([209.85.167.195]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iXUGb-0005BH-Mp for linux-arm-kernel@lists.infradead.org; Wed, 20 Nov 2019 17:59:51 +0000 Received: by mail-oi1-f195.google.com with SMTP id e9so569913oif.8 for ; Wed, 20 Nov 2019 09:59:47 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=zBB9OsnBCrlScEEQaEUduHBYkfuZALzvxczmYt/dJsU=; b=QZmG6fJIEawZFwO2ikpCkKgCYXeV/H4i1gj+SbdNDHgzLT3ptG5vjGx8nbYmAwIFp6 PGG1aVeOfZLE9S1zDIFNaykCeflfn7k40meZcBh6A1RojS2nIRpVhX3NdjM0E8GScgGA NLRjhqqd5xQw0ZeMmgWFxl49W/uBoSglziv+w3Ft+gJklYdQ5gDkZDBeRwd0VFQFt/J3 Pal16io46kCx+m2rlLcp5mgSFec6dnc7QQRe1CgAr9gNexGwsBuHHiwTyLbkPJ+IslpM 6Qa/xfwuVfjeOlD7IoLKh464/+jKtdbnV7O3N69hVTN51MKveexYk9aRgfFt85qvN+un vezg== X-Gm-Message-State: APjAAAUb9KC6DGmkLfXRZq6xDP7YuYWoOux9B+9O+03MMek/wHrux92R vgrajX0jwSvTvaWsQg5uylQHgH1M X-Google-Smtp-Source: APXvYqyzJPo1qJZLglE4RCJw40eTk7pYnB/z+FD6l+MRZyu+0ctR1uZFVKy0RQyoqc/x1BGjoH5NWQ== X-Received: by 2002:aca:4c14:: with SMTP id z20mr3991892oia.76.1574272787021; Wed, 20 Nov 2019 09:59:47 -0800 (PST) Received: from mail-ot1-f44.google.com (mail-ot1-f44.google.com. [209.85.210.44]) by smtp.gmail.com with ESMTPSA id 202sm8512070oii.39.2019.11.20.09.59.46 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 20 Nov 2019 09:59:46 -0800 (PST) Received: by mail-ot1-f44.google.com with SMTP id l14so352831oti.10 for ; Wed, 20 Nov 2019 09:59:46 -0800 (PST) X-Received: by 2002:a9d:173:: with SMTP id 106mr3009123otu.205.1574272785900; Wed, 20 Nov 2019 09:59:45 -0800 (PST) MIME-Version: 1.0 References: <20191118112324.22725-1-linux@rasmusvillemoes.dk> <20191118112324.22725-14-linux@rasmusvillemoes.dk> In-Reply-To: <20191118112324.22725-14-linux@rasmusvillemoes.dk> From: Li Yang Date: Wed, 20 Nov 2019 11:59:34 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v5 13/48] powerpc/83xx: remove mpc83xx_ipic_and_qe_init_IRQ To: Rasmus Villemoes , Scott Wood X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191120_095950_128463_3600CB82 X-CRM114-Status: GOOD ( 14.48 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Christophe Leroy , Timur Tabi , lkml , linuxppc-dev , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , Qiang Zhao Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Nov 18, 2019 at 5:29 AM Rasmus Villemoes wrote: Hi Scott, What do you think of the PowerPC related changes(patch 13,14)? Can we have you ACK and merge the series from soc tree? Regards, Leo > > This is now exactly the same as mpc83xx_ipic_init_IRQ, so just use > that directly. > > Signed-off-by: Rasmus Villemoes > --- > arch/powerpc/platforms/83xx/km83xx.c | 2 +- > arch/powerpc/platforms/83xx/misc.c | 7 ------- > arch/powerpc/platforms/83xx/mpc832x_mds.c | 2 +- > arch/powerpc/platforms/83xx/mpc832x_rdb.c | 2 +- > arch/powerpc/platforms/83xx/mpc836x_mds.c | 2 +- > arch/powerpc/platforms/83xx/mpc836x_rdk.c | 2 +- > arch/powerpc/platforms/83xx/mpc83xx.h | 5 ----- > 7 files changed, 5 insertions(+), 17 deletions(-) > > diff --git a/arch/powerpc/platforms/83xx/km83xx.c b/arch/powerpc/platforms/83xx/km83xx.c > index 5c6227f7bc37..3d89569e9e71 100644 > --- a/arch/powerpc/platforms/83xx/km83xx.c > +++ b/arch/powerpc/platforms/83xx/km83xx.c > @@ -177,7 +177,7 @@ define_machine(mpc83xx_km) { > .name = "mpc83xx-km-platform", > .probe = mpc83xx_km_probe, > .setup_arch = mpc83xx_km_setup_arch, > - .init_IRQ = mpc83xx_ipic_and_qe_init_IRQ, > + .init_IRQ = mpc83xx_ipic_init_IRQ, > .get_irq = ipic_get_irq, > .restart = mpc83xx_restart, > .time_init = mpc83xx_time_init, > diff --git a/arch/powerpc/platforms/83xx/misc.c b/arch/powerpc/platforms/83xx/misc.c > index 6935a5b9fbd1..1d8306eb2958 100644 > --- a/arch/powerpc/platforms/83xx/misc.c > +++ b/arch/powerpc/platforms/83xx/misc.c > @@ -88,13 +88,6 @@ void __init mpc83xx_ipic_init_IRQ(void) > ipic_set_default_priority(); > } > > -#ifdef CONFIG_QUICC_ENGINE > -void __init mpc83xx_ipic_and_qe_init_IRQ(void) > -{ > - mpc83xx_ipic_init_IRQ(); > -} > -#endif /* CONFIG_QUICC_ENGINE */ > - > static const struct of_device_id of_bus_ids[] __initconst = { > { .type = "soc", }, > { .compatible = "soc", }, > diff --git a/arch/powerpc/platforms/83xx/mpc832x_mds.c b/arch/powerpc/platforms/83xx/mpc832x_mds.c > index 1c73af104d19..6fa5402ebf20 100644 > --- a/arch/powerpc/platforms/83xx/mpc832x_mds.c > +++ b/arch/powerpc/platforms/83xx/mpc832x_mds.c > @@ -101,7 +101,7 @@ define_machine(mpc832x_mds) { > .name = "MPC832x MDS", > .probe = mpc832x_sys_probe, > .setup_arch = mpc832x_sys_setup_arch, > - .init_IRQ = mpc83xx_ipic_and_qe_init_IRQ, > + .init_IRQ = mpc83xx_ipic_init_IRQ, > .get_irq = ipic_get_irq, > .restart = mpc83xx_restart, > .time_init = mpc83xx_time_init, > diff --git a/arch/powerpc/platforms/83xx/mpc832x_rdb.c b/arch/powerpc/platforms/83xx/mpc832x_rdb.c > index 87f68ca06255..622c625d5ce4 100644 > --- a/arch/powerpc/platforms/83xx/mpc832x_rdb.c > +++ b/arch/powerpc/platforms/83xx/mpc832x_rdb.c > @@ -219,7 +219,7 @@ define_machine(mpc832x_rdb) { > .name = "MPC832x RDB", > .probe = mpc832x_rdb_probe, > .setup_arch = mpc832x_rdb_setup_arch, > - .init_IRQ = mpc83xx_ipic_and_qe_init_IRQ, > + .init_IRQ = mpc83xx_ipic_init_IRQ, > .get_irq = ipic_get_irq, > .restart = mpc83xx_restart, > .time_init = mpc83xx_time_init, > diff --git a/arch/powerpc/platforms/83xx/mpc836x_mds.c b/arch/powerpc/platforms/83xx/mpc836x_mds.c > index 5b484da9533e..219a83ab6c00 100644 > --- a/arch/powerpc/platforms/83xx/mpc836x_mds.c > +++ b/arch/powerpc/platforms/83xx/mpc836x_mds.c > @@ -208,7 +208,7 @@ define_machine(mpc836x_mds) { > .name = "MPC836x MDS", > .probe = mpc836x_mds_probe, > .setup_arch = mpc836x_mds_setup_arch, > - .init_IRQ = mpc83xx_ipic_and_qe_init_IRQ, > + .init_IRQ = mpc83xx_ipic_init_IRQ, > .get_irq = ipic_get_irq, > .restart = mpc83xx_restart, > .time_init = mpc83xx_time_init, > diff --git a/arch/powerpc/platforms/83xx/mpc836x_rdk.c b/arch/powerpc/platforms/83xx/mpc836x_rdk.c > index b7119e443920..b4aac2cde849 100644 > --- a/arch/powerpc/platforms/83xx/mpc836x_rdk.c > +++ b/arch/powerpc/platforms/83xx/mpc836x_rdk.c > @@ -41,7 +41,7 @@ define_machine(mpc836x_rdk) { > .name = "MPC836x RDK", > .probe = mpc836x_rdk_probe, > .setup_arch = mpc836x_rdk_setup_arch, > - .init_IRQ = mpc83xx_ipic_and_qe_init_IRQ, > + .init_IRQ = mpc83xx_ipic_init_IRQ, > .get_irq = ipic_get_irq, > .restart = mpc83xx_restart, > .time_init = mpc83xx_time_init, > diff --git a/arch/powerpc/platforms/83xx/mpc83xx.h b/arch/powerpc/platforms/83xx/mpc83xx.h > index d343f6ce2599..f37d04332fc7 100644 > --- a/arch/powerpc/platforms/83xx/mpc83xx.h > +++ b/arch/powerpc/platforms/83xx/mpc83xx.h > @@ -72,11 +72,6 @@ extern int mpc837x_usb_cfg(void); > extern int mpc834x_usb_cfg(void); > extern int mpc831x_usb_cfg(void); > extern void mpc83xx_ipic_init_IRQ(void); > -#ifdef CONFIG_QUICC_ENGINE > -extern void mpc83xx_ipic_and_qe_init_IRQ(void); > -#else > -#define mpc83xx_ipic_and_qe_init_IRQ mpc83xx_ipic_init_IRQ > -#endif /* CONFIG_QUICC_ENGINE */ > > #ifdef CONFIG_PCI > extern void mpc83xx_setup_pci(void); > -- > 2.23.0 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel