From mboxrd@z Thu Jan 1 00:00:00 1970 From: Li Yang Subject: Re: [PATCH] arm64: dts: remove big-endian filed from IFC controller Date: Tue, 28 Aug 2018 13:38:23 -0500 Message-ID: References: <20180828065936.8040-1-prabhakar.kushwaha@nxp.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20180828065936.8040-1-prabhakar.kushwaha@nxp.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Prabhakar Kushwaha Cc: Mark Rutland , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Shawn Guo , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , Rob Herring List-Id: devicetree@vger.kernel.org On Tue, Aug 28, 2018 at 2:02 AM Prabhakar Kushwaha wrote: > > As per IFC binding, Absence of "little-endian" field causes registers > access in big-endian mode. > So no need to set explicit big-endian field IFC node for LS1043A and > LS1046A. > > Signed-off-by: Prabhakar Kushwaha > --- > arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi | 2 +- > arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi | 3 ++- > 2 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi > index b9f5d2ff4ff2..68af84a8ade8 100644 > --- a/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi > @@ -3,6 +3,7 @@ > * Device Tree Include file for Freescale Layerscape-1043A family SoC. > * > * Copyright 2014-2015 Freescale Semiconductor, Inc. > + * Copyright 2018 NXP > * > * Mingkai Hu > */ > @@ -280,7 +281,6 @@ > ifc: ifc@1530000 { > compatible = "fsl,ifc", "simple-bus"; > reg = <0x0 0x1530000 0x0 0x10000>; > - big-endian; > interrupts = <0 43 0x4>; > }; > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi > index 65ce1c3cb568..9f5acb4dfaf3 100644 > --- a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi > @@ -4,6 +4,8 @@ > * > * Copyright 2016 Freescale Semiconductor, Inc. > * > + * Copyright 2018 NXP > + * Probably better to align with the other files to not have empty line between copyright claims? > * Mingkai Hu > */ > > @@ -198,7 +200,6 @@ > ifc: ifc@1530000 { > compatible = "fsl,ifc", "simple-bus"; > reg = <0x0 0x1530000 0x0 0x10000>; > - big-endian; > interrupts = ; > }; > > -- > 2.14.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 From: leoyang.li@nxp.com (Li Yang) Date: Tue, 28 Aug 2018 13:38:23 -0500 Subject: [PATCH] arm64: dts: remove big-endian filed from IFC controller In-Reply-To: <20180828065936.8040-1-prabhakar.kushwaha@nxp.com> References: <20180828065936.8040-1-prabhakar.kushwaha@nxp.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, Aug 28, 2018 at 2:02 AM Prabhakar Kushwaha wrote: > > As per IFC binding, Absence of "little-endian" field causes registers > access in big-endian mode. > So no need to set explicit big-endian field IFC node for LS1043A and > LS1046A. > > Signed-off-by: Prabhakar Kushwaha > --- > arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi | 2 +- > arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi | 3 ++- > 2 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi > index b9f5d2ff4ff2..68af84a8ade8 100644 > --- a/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi > @@ -3,6 +3,7 @@ > * Device Tree Include file for Freescale Layerscape-1043A family SoC. > * > * Copyright 2014-2015 Freescale Semiconductor, Inc. > + * Copyright 2018 NXP > * > * Mingkai Hu > */ > @@ -280,7 +281,6 @@ > ifc: ifc at 1530000 { > compatible = "fsl,ifc", "simple-bus"; > reg = <0x0 0x1530000 0x0 0x10000>; > - big-endian; > interrupts = <0 43 0x4>; > }; > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi > index 65ce1c3cb568..9f5acb4dfaf3 100644 > --- a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi > @@ -4,6 +4,8 @@ > * > * Copyright 2016 Freescale Semiconductor, Inc. > * > + * Copyright 2018 NXP > + * Probably better to align with the other files to not have empty line between copyright claims? > * Mingkai Hu > */ > > @@ -198,7 +200,6 @@ > ifc: ifc at 1530000 { > compatible = "fsl,ifc", "simple-bus"; > reg = <0x0 0x1530000 0x0 0x10000>; > - big-endian; > interrupts = ; > }; > > -- > 2.14.1 >