From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-x22e.google.com (mail-wm0-x22e.google.com [IPv6:2a00:1450:400c:c09::22e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id EE10F1A0220 for ; Fri, 5 Feb 2016 10:07:19 +1100 (AEDT) Received: by mail-wm0-x22e.google.com with SMTP id r129so4057063wmr.0 for ; Thu, 04 Feb 2016 15:07:19 -0800 (PST) MIME-Version: 1.0 Sender: pku.leo@gmail.com In-Reply-To: <1454481372-10288-1-git-send-email-raghav@freescale.com> References: <1454481372-10288-1-git-send-email-raghav@freescale.com> Date: Thu, 4 Feb 2016 17:07:16 -0600 Message-ID: Subject: Re: [PATCH] mtd/ifc: Add support for IFC controller version 2.0 From: Li Yang To: Raghav Dogra Cc: linux-mtd@lists.infradead.org, linuxppc-dev , oss@buserror.net, prabhakar.kushwaha@nxp.com, Brian Norris , Jaiprakash Singh Content-Type: text/plain; charset=UTF-8 List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Wed, Feb 3, 2016 at 12:36 AM, Raghav Dogra wrote: > The new IFC controller version 2.0 has a different memory map page. > Upto IFC 1.4 PAGE size is 4 KB and from IFC2.0 PAGE size is 64KB. > This patch segregates the IFC global and runtime registers to appropriate > PAGE sizes. If the global registers and the runtime registers are so independent that they have to be on different page boundaries, it would make more sense for them to be defined as separate reg regions in the device tree at the very beginning. Then we would only need to change the device tree now and it would be future proof for any page size. > > Signed-off-by: Jaiprakash Singh > Signed-off-by: Raghav Dogra The patch cannot apply on latest 4.5-rc cleanly either. Otherwise, Acked-by: Li Yang > --- > This patch is the new version of following patch with changed title: > https://patchwork.ozlabs.org/patch/557391/ > > This patch is dependent on the > "drivers/memory: Add deep sleep support for IFC" patch: > https://patchwork.ozlabs.org/patch/564785/ > > drivers/memory/fsl_ifc.c | 250 +++++++++++++++++++++------------------- > drivers/mtd/nand/fsl_ifc_nand.c | 72 ++++++------ > include/linux/fsl_ifc.h | 48 +++++--- > 3 files changed, 202 insertions(+), 168 deletions(-) Regards, Leo