From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4FA79C433FE for ; Wed, 22 Sep 2021 20:19:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2B271610D1 for ; Wed, 22 Sep 2021 20:19:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236390AbhIVUVO (ORCPT ); Wed, 22 Sep 2021 16:21:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54052 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233380AbhIVUVN (ORCPT ); Wed, 22 Sep 2021 16:21:13 -0400 Received: from mail-qk1-x730.google.com (mail-qk1-x730.google.com [IPv6:2607:f8b0:4864:20::730]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C5947C061574 for ; Wed, 22 Sep 2021 13:19:42 -0700 (PDT) Received: by mail-qk1-x730.google.com with SMTP id i132so14397862qke.1 for ; Wed, 22 Sep 2021 13:19:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=dWG04tH8ZQ7gPjKUtd+hX/duqooCcZZ2VSN1tOuuz5k=; b=dtauWIWomSt7xfZQ6C6Lm/WKaRcTXvI5dEgP+WHYIn52J6eCV6dXwTKNjUSmjOtrru mavucHfKbDcoYu+xKDdpGwn4MDP3rd5C8CdKD2sYEpNec2UwkuGWGIuR2OmS1KuC8p8f 9KirbCX43ov5ZV4EECH7SNF++ejT/GLbLGPLsjFZF2PJfzAAJ0QQmqroKhi9ojgUMCQk ft4+D5KcBElXJ39czp+1z5FF3f7k6zUo3iNrFM+qqe1JpVYwJc/5BpWbLFXJL85167pW ccIiyGVBlm6wzD9ThqS2SilBHVIziYLRfxIYML1HOm1Uzkio1ahwitXAPP3S3PFSXVl9 GCtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=dWG04tH8ZQ7gPjKUtd+hX/duqooCcZZ2VSN1tOuuz5k=; b=I/pb3j9tk0jq6UTUedyidzEKPTVSv4vNHMneJCU2Uz/2EZJIS6qTTiBCA8i3RdC49r IM6GnT2QUVth/QMKo+sZveDCWgpYHEGvayfQ/DDsUVM9Uq1Dmxy0FApJ6rw66z5RhLlF dIzlZDg7gkg+ANXQBuQmMR35C5c5ZgdQ99vASpxVbPaMJERjk+8uXeRv43hbUeAW+2EM TPkrmobPQgaribH/HjjgIhSsGnGYbaOXkdUmQ84Q8Tgwqp5zqQnwrmX+9Yl/81B43L2e 2rAMxNeE3Vr6WoBGIZ/46zpKqP+hyGz7WQZqbCO2AvPVFWhoQhLHS04IWnvGJPRwQTi3 cQLA== X-Gm-Message-State: AOAM5334vmGpi+wpD8khoAgeo8ASwaV8gaE3MLIyqUtm360mck5q6Sqm m7ng8RXy+nZRgCaasfgR6pvDp6kdTtTPrN92AfI= X-Google-Smtp-Source: ABdhPJyDEsC/NHuUbFQwSMD4X/S9ZHm7zqsPZ5bIpJKEvIB03KJx81JCqj86QQj+BRLowiekNZ1W2eVYuP67JZ6q800= X-Received: by 2002:a25:bdc5:: with SMTP id g5mr1157340ybk.403.1632341981997; Wed, 22 Sep 2021 13:19:41 -0700 (PDT) MIME-Version: 1.0 References: <20210903160302.yh42vpkuob45dbpb@gilmour> <20210904091050.g5axxctgelciihjn@gilmour> <20210920144730.d7oabqfbx7pmyyfb@gilmour> <20210920154333.vunyxeshdb7jt5ka@gilmour> <20210920155350.h6624mt65vwg72p2@gilmour> <20210920171042.oq3ndp3ox4xv5odh@gilmour> <20210922095725.dk4vk42zb3kh7y6s@gilmour> In-Reply-To: From: Sudip Mukherjee Date: Wed, 22 Sep 2021 21:19:06 +0100 Message-ID: Subject: Re: Regression with mainline kernel on rpi4 To: Linus Torvalds Cc: Maxime Ripard , Emma Anholt , David Airlie , Daniel Vetter , Philipp Zabel , dri-devel , linux-kernel Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 22, 2021 at 7:23 PM Linus Torvalds wrote: > > On Wed, Sep 22, 2021 at 10:02 AM Sudip Mukherjee > wrote: > > > > > > Attached is a complete dmesg and also the decoded trace. > > This is done on 4357f03d6611 ("Merge tag 'pm-5.15-rc2' of > > git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm") > > drivers/gpu/drm/vc4/vc4_hdmi.c:1214 is > > tmp = (u64)(mode->clock * 1000) * n; > > in vc4_hdmi_set_n_cts(), which has apparently been inlined from > vc4_hdmi_audio_prepare() in vc4_hdmi.c:1398. > > So it looks like 'mode' is some offset off a NULL pointer. > > Which looks not impossible: > > 1207 struct drm_connector *connector = &vc4_hdmi->connector; > 1208 struct drm_crtc *crtc = connector->state->crtc; > 1209 const struct drm_display_mode *mode = > &crtc->state->adjusted_mode; > > looks like crtc->state perhaps might be NULL. I added some debugs to print the addresses, and I am getting: [ 38.813809] sudip crtc 0000000000000000 This is from struct drm_crtc *crtc = connector->state->crtc; connector and connector->state had valid addresses. [ 38.805302] sudip connector ffff000040bac578 [ 38.809779] sudip state ffff000057eb5400 This is the diff of the debug I added: diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/drivers/gpu/drm/vc4/vc4_hdmi.c index 4a1115043114..2a8f06948094 100644 --- a/drivers/gpu/drm/vc4/vc4_hdmi.c +++ b/drivers/gpu/drm/vc4/vc4_hdmi.c @@ -1205,11 +1205,20 @@ static void vc4_hdmi_audio_set_mai_clock(struct vc4_hdmi *vc4_hdmi, static void vc4_hdmi_set_n_cts(struct vc4_hdmi *vc4_hdmi, unsigned int samplerate) { struct drm_connector *connector = &vc4_hdmi->connector; - struct drm_crtc *crtc = connector->state->crtc; - const struct drm_display_mode *mode = &crtc->state->adjusted_mode; + struct drm_crtc *crtc; + struct drm_display_mode *mode; u32 n, cts; u64 tmp; + + pr_err("sudip connector %px\n", connector); + pr_err("sudip state %px\n", connector->state); + crtc = connector->state->crtc; + + pr_err("sudip crtc %px\n", crtc); + pr_err("sudip state %px\n", crtc->state); + pr_err("state mode %px\n", &crtc->state->adjusted_mode); + mode = &crtc->state->adjusted_mode; n = 128 * samplerate / 1000; tmp = (u64)(mode->clock * 1000) * n; do_div(tmp, 128 * samplerate); -- Regards Sudip From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D68BC433EF for ; Wed, 22 Sep 2021 20:19:45 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 11ED561019 for ; Wed, 22 Sep 2021 20:19:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 11ED561019 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4DD186EC71; Wed, 22 Sep 2021 20:19:44 +0000 (UTC) Received: from mail-qk1-x72e.google.com (mail-qk1-x72e.google.com [IPv6:2607:f8b0:4864:20::72e]) by gabe.freedesktop.org (Postfix) with ESMTPS id F0D126EC74 for ; Wed, 22 Sep 2021 20:19:42 +0000 (UTC) Received: by mail-qk1-x72e.google.com with SMTP id c7so14350826qka.2 for ; Wed, 22 Sep 2021 13:19:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=dWG04tH8ZQ7gPjKUtd+hX/duqooCcZZ2VSN1tOuuz5k=; b=dtauWIWomSt7xfZQ6C6Lm/WKaRcTXvI5dEgP+WHYIn52J6eCV6dXwTKNjUSmjOtrru mavucHfKbDcoYu+xKDdpGwn4MDP3rd5C8CdKD2sYEpNec2UwkuGWGIuR2OmS1KuC8p8f 9KirbCX43ov5ZV4EECH7SNF++ejT/GLbLGPLsjFZF2PJfzAAJ0QQmqroKhi9ojgUMCQk ft4+D5KcBElXJ39czp+1z5FF3f7k6zUo3iNrFM+qqe1JpVYwJc/5BpWbLFXJL85167pW ccIiyGVBlm6wzD9ThqS2SilBHVIziYLRfxIYML1HOm1Uzkio1ahwitXAPP3S3PFSXVl9 GCtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=dWG04tH8ZQ7gPjKUtd+hX/duqooCcZZ2VSN1tOuuz5k=; b=AT15SUq0SxHludokjTd6NxqDzbKOeJ/DGSlXd0o3HbWa0DUE1V13SJRaZ9AteNQZxL 7dB+SssYiy+/PeMl19x05uMGP4ybLxH/bXAq84lsMzUOfOyRgn4NZmCX4ZDN0S1XuFPb BBXg3HjRp+ZhcgnkxYCCB3W4qRca6LEmiAJSrLbKos5jZ2R8q16KU6RF9yqSO3Rtb/w0 Xmll84p889Z45BB9S7g0+/mHcumxy2yKi/Xs5UxXURNX9XVXRvDDPZve7NjGUEilLmF3 +oHLI/V8tG7yI/aN1BtBcvlWryB852SOVep/imzShD1c6+IY90XqBy1WS0ofx4vOIfai gkyA== X-Gm-Message-State: AOAM530E2jr9C9TdaDn43MTtW/KqueaoSOFi8g1149eYba1tEddUXkpi u6+G7gmRDbsYY2vlllCViun9E62xFkNAhCC78fw= X-Google-Smtp-Source: ABdhPJyDEsC/NHuUbFQwSMD4X/S9ZHm7zqsPZ5bIpJKEvIB03KJx81JCqj86QQj+BRLowiekNZ1W2eVYuP67JZ6q800= X-Received: by 2002:a25:bdc5:: with SMTP id g5mr1157340ybk.403.1632341981997; Wed, 22 Sep 2021 13:19:41 -0700 (PDT) MIME-Version: 1.0 References: <20210903160302.yh42vpkuob45dbpb@gilmour> <20210904091050.g5axxctgelciihjn@gilmour> <20210920144730.d7oabqfbx7pmyyfb@gilmour> <20210920154333.vunyxeshdb7jt5ka@gilmour> <20210920155350.h6624mt65vwg72p2@gilmour> <20210920171042.oq3ndp3ox4xv5odh@gilmour> <20210922095725.dk4vk42zb3kh7y6s@gilmour> In-Reply-To: From: Sudip Mukherjee Date: Wed, 22 Sep 2021 21:19:06 +0100 Message-ID: Subject: Re: Regression with mainline kernel on rpi4 To: Linus Torvalds Cc: Maxime Ripard , Emma Anholt , David Airlie , Daniel Vetter , Philipp Zabel , dri-devel , linux-kernel Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Wed, Sep 22, 2021 at 7:23 PM Linus Torvalds wrote: > > On Wed, Sep 22, 2021 at 10:02 AM Sudip Mukherjee > wrote: > > > > > > Attached is a complete dmesg and also the decoded trace. > > This is done on 4357f03d6611 ("Merge tag 'pm-5.15-rc2' of > > git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm") > > drivers/gpu/drm/vc4/vc4_hdmi.c:1214 is > > tmp = (u64)(mode->clock * 1000) * n; > > in vc4_hdmi_set_n_cts(), which has apparently been inlined from > vc4_hdmi_audio_prepare() in vc4_hdmi.c:1398. > > So it looks like 'mode' is some offset off a NULL pointer. > > Which looks not impossible: > > 1207 struct drm_connector *connector = &vc4_hdmi->connector; > 1208 struct drm_crtc *crtc = connector->state->crtc; > 1209 const struct drm_display_mode *mode = > &crtc->state->adjusted_mode; > > looks like crtc->state perhaps might be NULL. I added some debugs to print the addresses, and I am getting: [ 38.813809] sudip crtc 0000000000000000 This is from struct drm_crtc *crtc = connector->state->crtc; connector and connector->state had valid addresses. [ 38.805302] sudip connector ffff000040bac578 [ 38.809779] sudip state ffff000057eb5400 This is the diff of the debug I added: diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/drivers/gpu/drm/vc4/vc4_hdmi.c index 4a1115043114..2a8f06948094 100644 --- a/drivers/gpu/drm/vc4/vc4_hdmi.c +++ b/drivers/gpu/drm/vc4/vc4_hdmi.c @@ -1205,11 +1205,20 @@ static void vc4_hdmi_audio_set_mai_clock(struct vc4_hdmi *vc4_hdmi, static void vc4_hdmi_set_n_cts(struct vc4_hdmi *vc4_hdmi, unsigned int samplerate) { struct drm_connector *connector = &vc4_hdmi->connector; - struct drm_crtc *crtc = connector->state->crtc; - const struct drm_display_mode *mode = &crtc->state->adjusted_mode; + struct drm_crtc *crtc; + struct drm_display_mode *mode; u32 n, cts; u64 tmp; + + pr_err("sudip connector %px\n", connector); + pr_err("sudip state %px\n", connector->state); + crtc = connector->state->crtc; + + pr_err("sudip crtc %px\n", crtc); + pr_err("sudip state %px\n", crtc->state); + pr_err("state mode %px\n", &crtc->state->adjusted_mode); + mode = &crtc->state->adjusted_mode; n = 128 * samplerate / 1000; tmp = (u64)(mode->clock * 1000) * n; do_div(tmp, 128 * samplerate); -- Regards Sudip