From mboxrd@z Thu Jan  1 00:00:00 1970
From: Neal Cardwell <ncardwell@google.com>
Subject: Re: [PATCH net] tcp: restore autocorking
Date: Thu, 03 May 2018 14:48:53 +0000
Message-ID: <CADVnQy=yabdw=PBOmwvfEWGdxRtuQ7peFYA0tBGCMpSQqJt0cg@mail.gmail.com>
References: <20180503032513.210324-1-edumazet@google.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Cc: David Miller <davem@davemloft.net>,
        Netdev <netdev@vger.kernel.org>, mwenig@vmware.com,
        Eric Dumazet <eric.dumazet@gmail.com>
To: Eric Dumazet <edumazet@google.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-wr0-f170.google.com ([209.85.128.170]:46450 "EHLO
        mail-wr0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751276AbeECOtL (ORCPT
        <rfc822;netdev@vger.kernel.org>); Thu, 3 May 2018 10:49:11 -0400
Received: by mail-wr0-f170.google.com with SMTP id o2-v6so15005649wrj.13
        for <netdev@vger.kernel.org>; Thu, 03 May 2018 07:49:11 -0700 (PDT)
In-Reply-To: <20180503032513.210324-1-edumazet@google.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Wed, May 2, 2018 at 11:25 PM Eric Dumazet <edumazet@google.com> wrote:

> When adding rb-tree for TCP retransmit queue, we inadvertently broke
> TCP autocorking.

> tcp_should_autocork() should really check if the rtx queue is not empty.

...

> Fixes: 75c119afe14f ("tcp: implement rb-tree based retransmit queue")
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Reported-by: Michael Wenig <mwenig@vmware.com>
> Tested-by: Michael Wenig <mwenig@vmware.com>
> ---

Acked-by: Neal Cardwell <ncardwell@google.com>

Nice. Thanks, Eric!

neal