From mboxrd@z Thu Jan  1 00:00:00 1970
From: Neal Cardwell <ncardwell@google.com>
Subject: Re: [PATCH net] tcp: use current time in tcp_rcv_space_adjust()
Date: Wed, 6 Dec 2017 14:54:09 -0500
Message-ID: <CADVnQykwCUbhnDs=8h4dOqxwfbKm_V+=_bTYRWH8QW-jAB4d4Q@mail.gmail.com>
References: <1512587299.25033.11.camel@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Cc: David Miller <davem@davemloft.net>,
        netdev <netdev@vger.kernel.org>, Wei Wang <weiwan@google.com>,
        Yuchung Cheng <ycheng@google.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-wr0-f180.google.com ([209.85.128.180]:39884 "EHLO
        mail-wr0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752150AbdLFTyb (ORCPT
        <rfc822;netdev@vger.kernel.org>); Wed, 6 Dec 2017 14:54:31 -0500
Received: by mail-wr0-f180.google.com with SMTP id a41so5143301wra.6
        for <netdev@vger.kernel.org>; Wed, 06 Dec 2017 11:54:31 -0800 (PST)
In-Reply-To: <1512587299.25033.11.camel@gmail.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Wed, Dec 6, 2017 at 2:08 PM, Eric Dumazet <eric.dumazet@gmail.com> wrote:
> From: Eric Dumazet <edumazet@google.com>
>
> When I switched rcv_rtt_est to high resolution timestamps, I forgot
> that tp->tcp_mstamp needed to be refreshed in tcp_rcv_space_adjust()
>
> Using an old timestamp leads to autotuning lags.
>
> Fixes: 645f4c6f2ebd ("tcp: switch rcv_rtt_est and rcvq_space to high resolution timestamps")
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Cc: Wei Wang <weiwan@google.com>
> Cc: Neal Cardwell <ncardwell@google.com>
> Cc: Yuchung Cheng <ycheng@google.com>
> ---

Acked-by: Neal Cardwell <ncardwell@google.com>

neal