All of lore.kernel.org
 help / color / mirror / Atom feed
From: Neal Cardwell <ncardwell@google.com>
To: Eric Dumazet <edumazet@google.com>
Cc: "David S. Miller" <davem@davemloft.net>,
	netdev <netdev@vger.kernel.org>,
	Eric Dumazet <eric.dumazet@gmail.com>,
	Yuchung Cheng <ycheng@google.com>
Subject: Re: [PATCH net-next 2/2] tcp: add TCP_CC_INFO socket option
Date: Tue, 28 Apr 2015 21:00:06 -0400	[thread overview]
Message-ID: <CADVnQymQwo-teVfqos5M0yFVF_AZarv+BUQJRscz9kHs9x6scg@mail.gmail.com> (raw)
In-Reply-To: <1430263429-4069-3-git-send-email-edumazet@google.com>

On Tue, Apr 28, 2015 at 7:23 PM, Eric Dumazet <edumazet@google.com> wrote:
> Some Congestion Control modules can provide per flow information,
> but current way to get this information is to use netlink.
>
> Like TCP_INFO, let's add TCP_CC_INFO so that applications can
> issue a getsockopt() if they have a socket file descriptor,
> instead of playing complex netlink games.
>
> Sample usage would be :
>
>   union tcp_cc_info info;
>   socklen_t len = sizeof(info);
>
>   if (getsockopt(fd, SOL_TCP, TCP_CC_INFO, &info, &len) == -1)
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Cc: Yuchung Cheng <ycheng@google.com>
> Cc: Neal Cardwell <ncardwell@google.com>
> ---

Acked-by: Neal Cardwell <ncardwell@google.com>

A very useful facility. Thanks for putting this together, Eric!

neal

  reply	other threads:[~2015-04-29  1:00 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-28 23:23 [PATCH net-next 0/2] tcp: extend access to CC information Eric Dumazet
2015-04-28 23:23 ` [PATCH net-next 1/2] tcp: prepare CC get_info() access from getsockopt() Eric Dumazet
2015-04-29  0:58   ` Neal Cardwell
2015-04-29  7:55   ` Daniel Borkmann
2015-04-29 16:10   ` Yuchung Cheng
2015-04-29 22:12   ` David Miller
2015-04-29 22:40     ` Eric Dumazet
2015-04-29 23:20       ` [PATCH net-next] tcp_westwood: fix tcp_westwood_info() Eric Dumazet
2015-04-29 23:36         ` Neal Cardwell
2015-04-30  4:28         ` David Miller
2015-04-28 23:23 ` [PATCH net-next 2/2] tcp: add TCP_CC_INFO socket option Eric Dumazet
2015-04-29  1:00   ` Neal Cardwell [this message]
2015-04-29  8:17   ` Daniel Borkmann
2015-04-29 11:07     ` Eric Dumazet
2015-04-29 11:15       ` Daniel Borkmann
2015-04-29 16:15   ` Yuchung Cheng
2015-04-29 22:12   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CADVnQymQwo-teVfqos5M0yFVF_AZarv+BUQJRscz9kHs9x6scg@mail.gmail.com \
    --to=ncardwell@google.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=eric.dumazet@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=ycheng@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.