All of lore.kernel.org
 help / color / mirror / Atom feed
From: Neal Cardwell <ncardwell@google.com>
To: Gao Feng <gfree.wind@foxmail.com>
Cc: David Miller <davem@davemloft.net>,
	Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
	James Morris <jmorris@namei.org>,
	Patrick McHardy <kaber@trash.net>,
	Netdev <netdev@vger.kernel.org>, Gao Feng <fgao@ikuai8.com>
Subject: Re: [PATCH net 1/1] net: tcp: Don't increase the TCP_MIB_OUTRSTS when fail to transmit RST
Date: Thu, 6 Apr 2017 10:00:54 -0400	[thread overview]
Message-ID: <CADVnQymp9X3EwmiiocNHU8bQpg7Wb7FvGr4SduKjhLoTv35zMA@mail.gmail.com> (raw)
In-Reply-To: <1491485709-8269-1-git-send-email-gfree.wind@foxmail.com>

On Thu, Apr 6, 2017 at 9:35 AM,  <gfree.wind@foxmail.com> wrote:
> From: Gao Feng <fgao@ikuai8.com>
>
> When fail to transmit RST, don't increase TCP_MIB_OUTRSTS in func
> tcp_send_active_reset like the case that it only increases
> LINUX_MIB_TCPABORTFAILED when fail to alloc skb.
>
> Signed-off-by: Gao Feng <fgao@ikuai8.com>
> ---

I would be concerned that this is a change in the semantics of
TCP_MIB_OUTRSTS that might break user-space monitoring tools that rely
on the current semantics. Counting attempted RSTs could be an
important signal to monitor, and it could be quite bad if that signal
is lost or hidden because the machine is so overloaded that the
transmission of the RSTs fails.

Also it would seem to muddy the semantics a bit, since both
tcp_v4_send_reset() and tcp_v6_send_response() currently increment
TCP_MIB_OUTRSTS without regard to whether the transmit actually
succeeded or not.

neal

  reply	other threads:[~2017-04-06 14:01 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-06 13:35 [PATCH net 1/1] net: tcp: Don't increase the TCP_MIB_OUTRSTS when fail to transmit RST gfree.wind
2017-04-06 14:00 ` Neal Cardwell [this message]
2017-04-06 14:05   ` Gao Feng
2017-04-06 14:08     ` Neal Cardwell
2017-04-06 15:11       ` Gao Feng
2017-04-06 15:24       ` Eric Dumazet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CADVnQymp9X3EwmiiocNHU8bQpg7Wb7FvGr4SduKjhLoTv35zMA@mail.gmail.com \
    --to=ncardwell@google.com \
    --cc=davem@davemloft.net \
    --cc=fgao@ikuai8.com \
    --cc=gfree.wind@foxmail.com \
    --cc=jmorris@namei.org \
    --cc=kaber@trash.net \
    --cc=kuznet@ms2.inr.ac.ru \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.