From: Dimitri John Ledkov <dimitri.ledkov@canonical.com>
To: Leo Liang <ycliang@andestech.com>
Cc: U-Boot Mailing List <u-boot@lists.denx.de>
Subject: Re: [PATCH] qemu-riscv64_smode: fix extlinux (define preboot)
Date: Mon, 26 Jul 2021 11:20:49 +0100 [thread overview]
Message-ID: <CADWks+YMEkRf86kpeSQaSK539coikkGHf5Yyy6+DxwJNg6vRWg@mail.gmail.com> (raw)
In-Reply-To: <20210726075515.GD983@andestech.com>
On Mon, Jul 26, 2021 at 8:55 AM Leo Liang <ycliang@andestech.com> wrote:
>
> Hi Dimitri,
>
> On Sat, Jul 24, 2021 at 12:12:25AM +0800, Dimitri John Ledkov wrote:
> > Commit 37304aaf60bf ("Convert CONFIG_USE_PREBOOT and CONFIG_PREBOOT to
> > Kconfig") removed preboot commands in RISC-V targets and broke
> > extlinux support as reported by Fu Wei <wefu@redhat.com>.
> >
> > The patch finishes migration of CONFIG_USE_PREBOOT and CONFIG_REBOOT
> > to Kconfig.
>
> Could you add a "Fixes" tag and a "Reported-by" tag as suggested by Bin?
>
done in v2
> >
> > Signed-off-by: David Abdurachmanov <david.abdurachmanov@sifive.com>
> > Signed-off-by: Dimitri John Ledkov <dimitri.ledkov@canonical.com>
> > ---
> >
> > Original patch author is David Abdurachmanov
> >
> > Previously this was submitted in 2019
> > https://patchwork.ozlabs.org/project/uboot/patch/20190821190720.4286-1-david.abdurachmanov@sifive.com/
> >
> > Since then the sifive fu540 portion of this change was merged, but
> > not the qemu one.
> >
> > Submitting the qemu portion again. Without this change, qemu smode
> > cannot boot Ubuntu's riscv64 cloud images with extlinux.conf.
> >
> >
> > configs/qemu-riscv64_smode_defconfig | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/configs/qemu-riscv64_smode_defconfig b/configs/qemu-riscv64_smode_defconfig
> > index 0000564e41..cb674c6a75 100644
> > --- a/configs/qemu-riscv64_smode_defconfig
> > +++ b/configs/qemu-riscv64_smode_defconfig
> > @@ -14,3 +14,5 @@ CONFIG_CMD_NVEDIT_EFI=y
> > CONFIG_OF_PRIOR_STAGE=y
> > CONFIG_SYS_RELOC_GD_ENV_ADDR=y
> > CONFIG_DM_MTD=y
> > +CONFIG_USE_PREBOOT=y
> > +CONFIG_PREBOOT="setenv fdt_addr ${fdtcontroladdr}; fdt addr ${fdtcontroladdr};"
>
> The config option should be inserted using "make savedefconfig".
>
> e.g.
> $ make menuconfig
> choose the config option desired
> $ make savedefconfig
> $ cp defconfig configs/qemu-riscv64_smode_defconfig
>
done in v3
> Thanks!
>
> Best regards,
> Leo
> > --
> > 2.30.2
> >
--
Regards,
Dimitri.
prev parent reply other threads:[~2021-07-26 10:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-23 16:12 [PATCH] qemu-riscv64_smode: fix extlinux (define preboot) Dimitri John Ledkov
2021-07-26 7:55 ` Leo Liang
2021-07-26 10:20 ` Dimitri John Ledkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADWks+YMEkRf86kpeSQaSK539coikkGHf5Yyy6+DxwJNg6vRWg@mail.gmail.com \
--to=dimitri.ledkov@canonical.com \
--cc=u-boot@lists.denx.de \
--cc=ycliang@andestech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.