From: Zongyuan Li <zongyuan.li@smartx.com>
To: qemu-devel@nongnu.org
Cc: Igor Mitsyanko <i.mitsyanko@gmail.com>,
"open list:Exynos" <qemu-arm@nongnu.org>
Subject: Re: [PATCH v5 3/4] hw/intc/exynos4210: replace 'qemu_split_irq' in combiner and gic
Date: Sat, 2 Apr 2022 10:28:35 +0800 [thread overview]
Message-ID: <CADXGpufhJn9L4U_Y6gcdyzy1XMV3C5PM5T+T0ruaqvBnHicyhA@mail.gmail.com> (raw)
In-Reply-To: <CAFEAcA_rMuWkobjBoFJdYQqc=qvyUPrq9_-W+TkrNdTf+iBgsw@mail.gmail.com>
On Fri, Apr 1, 2022 at 9:35 PM Peter Maydell <peter.maydell@linaro.org> wrote:
>
> On Thu, 24 Mar 2022 at 18:16, Zongyuan Li <zongyuan.li@smartx.com> wrote:
> >
> > Signed-off-by: Zongyuan Li <zongyuan.li@smartx.com>
> > ---
> > hw/arm/exynos4210.c | 26 +++++++++++
> > hw/intc/exynos4210_combiner.c | 81 +++++++++++++++++++++++++++--------
> > hw/intc/exynos4210_gic.c | 36 +++++++++++++---
> > include/hw/arm/exynos4210.h | 11 ++---
> > include/hw/core/split-irq.h | 5 +--
> > 5 files changed, 126 insertions(+), 33 deletions(-)
>
> Looking at this patch, I think it's ended up quite complicated
> because the exynos4210 code as it stands today is doing
> some rather odd things with interrupts. I'm going to have a
> go at some refactoring patches which try to clean some of that
> oddness up into code more like what we'd write today, which
> should make getting rid of the use of qemu_split_irq() a bit easier.
Should we wait for the refactoring to be done and rebase this patch set on it,
or just remove exynos4210 related code? I'm glad to see if there's anything I
can help with the refactoring.
Thanks for your review.
Li
next prev parent reply other threads:[~2022-04-02 2:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-24 18:15 [PATCH v5 0/4] Replace 'qemu_irq_split' with 'TYPE_SPLIT_IRQ' Zongyuan Li
2022-03-24 18:15 ` [PATCH v5 1/4] hw/arm/realview: replace 'qemu_split_irq' " Zongyuan Li
2022-04-01 9:31 ` Peter Maydell
2022-03-24 18:15 ` [PATCH v5 2/4] hw/arm/stellaris: " Zongyuan Li
2022-04-01 9:32 ` Peter Maydell
2022-03-24 18:15 ` [PATCH v5 3/4] hw/intc/exynos4210: replace 'qemu_split_irq' in combiner and gic Zongyuan Li
2022-04-01 13:17 ` Damien Hedde
2022-04-01 13:35 ` Peter Maydell
2022-04-02 2:28 ` Zongyuan Li [this message]
2022-03-24 18:15 ` [PATCH v5 4/4] hw/core/irq: remove unused 'qemu_irq_split' function Zongyuan Li
2022-04-21 10:14 ` [PATCH v5 0/4] Replace 'qemu_irq_split' with 'TYPE_SPLIT_IRQ' Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADXGpufhJn9L4U_Y6gcdyzy1XMV3C5PM5T+T0ruaqvBnHicyhA@mail.gmail.com \
--to=zongyuan.li@smartx.com \
--cc=i.mitsyanko@gmail.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.