Re: [meta-oe][PATCH] add a storage I/O benchmark test suite

[Anders Roxell <anders.roxell@linaro.org>]

CCing in the package maintainer.

On Sun, 21 Oct 2018 at 17:10, Khem Raj <raj.khem@gmail.com> wrote:
>
> On Sun, Oct 21, 2018 at 12:29 AM Randy MacLeod
> <randy.macleod@windriver.com> wrote:
> >
> > On 10/19/18 10:54 AM, Anders Roxell wrote:
> > > Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
> > > ---
> > >   .../recipes-benchmark/s-suite/s-suite_git.bb  | 30 +++++++++++++++++++
> > >   1 file changed, 30 insertions(+)
> > >   create mode 100644 meta-oe/recipes-benchmark/s-suite/s-suite_git.bb
> > >
> > > diff --git a/meta-oe/recipes-benchmark/s-suite/s-suite_git.bb b/meta-oe/recipes-benchmark/s-suite/s-suite_git.bb
> > > new file mode 100644
> > > index 000000000000..77d172814065
> > > --- /dev/null
> > > +++ b/meta-oe/recipes-benchmark/s-suite/s-suite_git.bb
> > > @@ -0,0 +1,30 @@
> > > +SUMMARY = "Small collection of benchmarks for storage I/O"
> > > +LICENSE = "GPLv2"
> > > +LIC_FILES_CHKSUM = "file://COPYING;md5=b529aaa6a0c50f15d29f89609b5c22f3"
> > > +
> > > +SRCREV = "79698f645bfb28d0d966484ddad3a1efb562246d"
> > > +PV = "0.0+git${SRCPV}"
> > > +SRC_URI = "git://github.com/Algodev-github/S.git;protocol=https;branch=master"
> > > +
> > > +S = "${WORKDIR}/git"
> > > +
> > > +# installing in /opt/S-suite since the package has
> > > +# dependencies to the directory structure.
> > > +do_install() {
> > > +    install -d ${D}/opt/S-suite
> > > +    for i in $(find ${S}/* -type d); do
> > > +        install -d ${D}/opt/S-suite/$(basename $i)
> > > +        install -m0755 -p ${S}/$(basename $i)/* ${D}/opt/S-suite/$(basename $i)
> > > +    done
> > > +
> > > +    install -m0755 ${S}/config_params.sh ${D}/opt/S-suite
> > > +    install -m0755 ${S}/def_config_params.sh ${D}/opt/S-suite
> > > +}
> > > +
> > > +RDEPENDS_${PN} = "bash bc coreutils gawk g++ gcc fio libaio libaio-dev sysstat"
> > > +
> > > +FILES_${PN} = "/opt/S-suite/"
> > > +
> > > +# added to INSANE_SKIP since s-suite have an runtime
> > > +# dependency (RDEPENDS) on libaio-dev.
> > > +INSANE_SKIP_${PN} += "dev-deps"
> > >
> >
> > Thanks for the submission but from:
> >
> >     https://github.com/Algodev-github/S
> >
> >     "These benchmarks have been written just for internal use,
> >      and are more a yard than a well-finished work."
> >
> >
> > That doesn't lead to a lot of confidence that these suite will
> > be maintained for years. What's the value to meta-oe users to add
> > this recipe compared to something that has been around for years
> > if not decades such as Bonnie++:
> >     https://layers.openembedded.org/layerindex/recipe/864/
> >
>
> how I read this is that they have not made proper installation
> targets and its dependencies or letting user know of the dependencies
> which actually is not a problem with OE since both
> of these would be taken care of in the recipe with
> do_install and DEPENDS

Do you mean DEPENDS or RDEPENDS?

Cheers,
Anders