From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail-ed1-f44.google.com (mail-ed1-f44.google.com [209.85.208.44])
	(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 47936168
	for <llvm@lists.linux.dev>; Thu, 11 Nov 2021 08:26:44 +0000 (UTC)
Received: by mail-ed1-f44.google.com with SMTP id o8so21018020edc.3
        for <llvm@lists.linux.dev>; Thu, 11 Nov 2021 00:26:44 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linaro.org; s=google;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=BUA8cT1yNGUc7DNHm9M9jCLdwArLczgi/VVgmJMyKuw=;
        b=WD4t8nHEPj8jfQJ2PXumfYpqqhk/xWQKha1+7H9j+z/NWiUsvopX2M7GGVZwlP2zR1
         31+JgmrUgZ2Sil95OkdKdiTN2MPmXQNNIa+RfQUHedeT30XAwEIF55UGiI4Gh+x/JjNr
         /MAcHcLgz7YZ4ApS4LsBhT/2KxBtaIdor0t2/S9MfDJZLyJcWit2MgMlbhLd+oO3xXvN
         tzOidhK9yYdG6VIWAb4mol70Q2fI0vg3Xear+XvcC6r9Pu4MejS/FmEmK603p4/2BjcP
         MXVWtCLg95P+N6jOYLo4QXowewMVKNIY2WkDbNWWE8KXWEX277hxNXTkNDeV8/O6aLw8
         eOIA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=BUA8cT1yNGUc7DNHm9M9jCLdwArLczgi/VVgmJMyKuw=;
        b=mslyzCr+06ogQhNEiqdSkaoNxCzZC0o+8v//T9KvKKcl1ZYqoxtcaZd/rXHFpkANUO
         9mxU8NwSeRDUGcwXADqwkYIUvqn4iLwI1/TTwTtnDGXJRQ+OD/71FA8fHNl1Km+k4VE0
         1Lm/VfRYFWHKQYYMQtKeKwkWTX8fT4sZ3VcOs6LsLLI0X9KP16kIutCDqZhqVfw/o99z
         xu2u/v/iCemkxiNZB8h8kwiChgaBsUJS2yKB53IzfufRMA06Sg7vwiNnxqPAt5GEaYJA
         Jh6MCgGWu8sqk39gQyNV6f91ATvSZ9H2PkSB6/L4JpOOJS7Mr20xsLNufgpsa4Y8T3jW
         T/3w==
X-Gm-Message-State: AOAM531NUweUec623yyXCBnDBI1jGfIRneUrOyrobd7boN8NnCgIN9UC
	vCO+w9KBhtUlsqLVYme0jPM5+XMdDw6PpeOOyTQpHQ==
X-Google-Smtp-Source: ABdhPJyGyHbjogLeLt524wf5FjRZ2UBTmqsg3aU9e5sHbiRlTb+tWK8lhevxD8Or9lCYOyt8ZTGRTizAwj4jGSng2I8=
X-Received: by 2002:a17:906:a08d:: with SMTP id q13mr6923927ejy.465.1636619202419;
 Thu, 11 Nov 2021 00:26:42 -0800 (PST)
Precedence: bulk
X-Mailing-List: llvm@lists.linux.dev
List-Id: <llvm.lists.linux.dev>
List-Subscribe: <mailto:llvm+subscribe@lists.linux.dev>
List-Unsubscribe: <mailto:llvm+unsubscribe@lists.linux.dev>
MIME-Version: 1.0
References: <CAK8P3a3ZuL9TQbj+tGkdvRRmEv_jT3OvzmaoFKHwdw=5J1w_SA@mail.gmail.com>
 <20211110180359.2338349-1-anders.roxell@linaro.org> <CAKwvOdkoKvjecTfxbRwZ=BYirvy-Jq64pHtHuct8oWgExv1xPw@mail.gmail.com>
 <CAKwvOdnNKHJ++8vJS7WvaZX1aRZHk5uA7LP+S=ApSjRcU4QDkQ@mail.gmail.com>
In-Reply-To: <CAKwvOdnNKHJ++8vJS7WvaZX1aRZHk5uA7LP+S=ApSjRcU4QDkQ@mail.gmail.com>
From: Anders Roxell <anders.roxell@linaro.org>
Date: Thu, 11 Nov 2021 09:26:31 +0100
Message-ID: <CADYN=9JRazXg+eGT8NYG-XVTkyhkpoTRkQKm=d7zjYRYzjkpRg@mail.gmail.com>
Subject: Re: [PATCHv2] selftests: timens: exec: use 'labs()' over 'abs()'
To: Nick Desaulniers <ndesaulniers@google.com>
Cc: shuah@kernel.org, nathan@kernel.org, linux-kselftest@vger.kernel.org, 
	linux-kernel@vger.kernel.org, llvm@lists.linux.dev, 
	Arnd Bergmann <arnd@arndb.de>
Content-Type: text/plain; charset="UTF-8"

On Wed, 10 Nov 2021 at 21:11, Nick Desaulniers <ndesaulniers@google.com> wrote:
>
> On Wed, Nov 10, 2021 at 12:09 PM Nick Desaulniers
> <ndesaulniers@google.com> wrote:
> >
> > On Wed, Nov 10, 2021 at 10:04 AM Anders Roxell <anders.roxell@linaro.org> wrote:
> > >
> > > When building selftests/timens with clang, the compiler warn about the
> > > function abs() see below:
> > >
> > > exec.c:33:8: error: absolute value function 'abs' given an argument of type 'long' but has parameter of type 'int' which may cause truncation of value [-Werror,-Wabsolute-value]
> > >                         if (abs(tst.tv_sec - now.tv_sec) > 5)
> > >                             ^
> > > exec.c:33:8: note: use function 'labs' instead
> > >                         if (abs(tst.tv_sec - now.tv_sec) > 5)
> > >                             ^~~
> > >                             labs
> > >
> > > Rework to store the time difference in a 'long long' and pass that to
> > > llabs(), since the variable can be an 'int', 'long' or 'long long'
> > > depending on the architecture and C library.
> > >
> > > Suggested-by: Arnd Bergmann <arnd@arndb.de>
> > > Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
> >
> > Thanks for the patch!
> > Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
>
> ah, gmail doesn't do a great job at showing the subject when a v2 is
> sent in-reply-to.

oh right, sorry.

>  Should the oneline mention llabs rather than labs
> now?

You are correct, can this be changed when the patch gets applied or
should I send a v3?

Cheers,
Anders