From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57D8BC43214 for ; Thu, 2 Sep 2021 12:51:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 41233610CE for ; Thu, 2 Sep 2021 12:51:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344783AbhIBMwz (ORCPT ); Thu, 2 Sep 2021 08:52:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54206 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234290AbhIBMwx (ORCPT ); Thu, 2 Sep 2021 08:52:53 -0400 Received: from mail-ej1-x62e.google.com (mail-ej1-x62e.google.com [IPv6:2a00:1450:4864:20::62e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 50ECFC061757 for ; Thu, 2 Sep 2021 05:51:55 -0700 (PDT) Received: by mail-ej1-x62e.google.com with SMTP id lc21so4074405ejc.7 for ; Thu, 02 Sep 2021 05:51:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=oBtvw9RLZz5FiMU8tP1KGG7ayEexwXszGesiGUpyM7c=; b=CZV3QxQDYOZ4sA6RDYakDFAaxGnXwXVMjsjFysxH8aP03rp+JlkXUPc7WgK8FGpX/L SXGuMEp+ppKVLvddgbBX0ixeNJqxg4VSqP1TDRDBjvPQ5VKMCmLqqkl9AJZfBi3l5/7x FRcUlQdxgFS5T4X7fWcunJi/PnebZvrR12cgPxE/DLA+M3YhxO/lbDEoOyp+g2/LW1Jx DX6pC3l7XJYiWPp1IXI/Ac9M+08dGoMbdF+te/nB3LOheviQx5PNuf1FxfHa01E+xToK SritC5zqmjTg3cZs8yl/SSYVerMp9pqN7lPtFv7U2XR7zP4a0R1mkgHfAJGHK1UQZ/42 rIDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=oBtvw9RLZz5FiMU8tP1KGG7ayEexwXszGesiGUpyM7c=; b=WQxuIIkOkQjucm8MnQ0js16JAFjtLDHEYKwy5+59QWcWaDpj72nC4yqcjqYc/ND7sn le10YPhdfeLuD1kKuim0SASbCTThMUayLSKYt6iPgDthtL0Va4+BsJkFJEAtBc2CqKkq hHQjFDxfYTfngWIKPqy+YMuUqNukdU+pjlpgUWsfNDDBjcH4tlbUizzsc5+89a7LpozV 8urZrLHblUZ2Ly1WOrpDFlSEDwfKGQqgVEasrM+v00d6XKOn3dvlnaK/fJo7jKj7Hxjc K+mAiGVVuLPZuJtVN1bmh+Qs0QTJaf+twkreIB4ySOVVbI5Eum2iauACHQRfwrXrzika 1U4A== X-Gm-Message-State: AOAM5338Bdkj3FB1RtSezhLsMQXbAVr/WiCxu7pY+9rx1kvMlTjkv7Vt dtEm4O8xZpSUPohkyVSWBmf3t/GtDNfvNEi9dg07Vg== X-Google-Smtp-Source: ABdhPJygSZC8fluO7Inqdaqw8JmKePWM0x239rNniJ2NKvF8HoUFS95pa4d4JBGyUMUeWRE3aBaYUS/L2g/2y3bv5Us= X-Received: by 2002:a17:906:3a57:: with SMTP id a23mr3646914ejf.469.1630587113883; Thu, 02 Sep 2021 05:51:53 -0700 (PDT) MIME-Version: 1.0 References: <1621566204-37456-1-git-send-email-wangxingang5@huawei.com> <01314d70-41e6-70f9-e496-84091948701a@samsung.com> In-Reply-To: From: Anders Roxell Date: Thu, 2 Sep 2021 14:51:43 +0200 Message-ID: Subject: Re: [PATCH v4] iommu/of: Fix pci_request_acs() before enumerating PCI devices To: Robin Murphy Cc: Marek Szyprowski , Wang Xingang , Rob Herring , Will Deacon , joro@8bytes.org, helgaas@kernel.org, Rob Herring , Greg Kroah-Hartman , iommu@lists.linux-foundation.org, Linux Kernel Mailing List , linux-pci@vger.kernel.org, xieyingtai@huawei.com, "linux-arm-kernel@lists.infradead.org" , Linux-Next Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 1 Sept 2021 at 11:58, Robin Murphy wrote: > > On 2021-09-01 09:59, Marek Szyprowski wrote: > > On 21.05.2021 05:03, Wang Xingang wrote: > >> From: Xingang Wang > >> > >> When booting with devicetree, the pci_request_acs() is called after the > >> enumeration and initialization of PCI devices, thus the ACS is not > >> enabled. And ACS should be enabled when IOMMU is detected for the > >> PCI host bridge, so add check for IOMMU before probe of PCI host and call > >> pci_request_acs() to make sure ACS will be enabled when enumerating PCI > >> devices. > >> > >> Fixes: 6bf6c24720d33 ("iommu/of: Request ACS from the PCI core when > >> configuring IOMMU linkage") > >> Signed-off-by: Xingang Wang > > > > This patch landed in linux-next as commit 57a4ab1584e6 ("iommu/of: Fix > > pci_request_acs() before enumerating PCI devices"). Sadly it breaks PCI > > operation on ARM Juno R1 board (arch/arm64/boot/dts/arm/juno-r1.dts). It We've seen this on ARM Juno R2 boards too in the Linaro testfarm. The problem is that the device can't get the "SATA link up" while booting. see https://lkft.validation.linaro.org/scheduler/job/3416767#L577 When reverting this patch we are able to see the "SATA link up". Cheers, Anders From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91795C4320E for ; Thu, 2 Sep 2021 12:52:05 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2A9D9610CE for ; Thu, 2 Sep 2021 12:52:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 2A9D9610CE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id E993C42589; Thu, 2 Sep 2021 12:52:04 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id S6BheUWBDsbv; Thu, 2 Sep 2021 12:52:00 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp4.osuosl.org (Postfix) with ESMTPS id 80D7C42584; Thu, 2 Sep 2021 12:52:00 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 624EDC001A; Thu, 2 Sep 2021 12:52:00 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [IPv6:2605:bc80:3010::133]) by lists.linuxfoundation.org (Postfix) with ESMTP id E6CE0C000E for ; Thu, 2 Sep 2021 12:51:59 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id CFDF340707 for ; Thu, 2 Sep 2021 12:51:59 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp2.osuosl.org (amavisd-new); dkim=pass (2048-bit key) header.d=linaro.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id q87BzNBBBPg6 for ; Thu, 2 Sep 2021 12:51:55 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 Received: from mail-ej1-x62d.google.com (mail-ej1-x62d.google.com [IPv6:2a00:1450:4864:20::62d]) by smtp2.osuosl.org (Postfix) with ESMTPS id A7267406EC for ; Thu, 2 Sep 2021 12:51:55 +0000 (UTC) Received: by mail-ej1-x62d.google.com with SMTP id h9so4100612ejs.4 for ; Thu, 02 Sep 2021 05:51:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=oBtvw9RLZz5FiMU8tP1KGG7ayEexwXszGesiGUpyM7c=; b=CZV3QxQDYOZ4sA6RDYakDFAaxGnXwXVMjsjFysxH8aP03rp+JlkXUPc7WgK8FGpX/L SXGuMEp+ppKVLvddgbBX0ixeNJqxg4VSqP1TDRDBjvPQ5VKMCmLqqkl9AJZfBi3l5/7x FRcUlQdxgFS5T4X7fWcunJi/PnebZvrR12cgPxE/DLA+M3YhxO/lbDEoOyp+g2/LW1Jx DX6pC3l7XJYiWPp1IXI/Ac9M+08dGoMbdF+te/nB3LOheviQx5PNuf1FxfHa01E+xToK SritC5zqmjTg3cZs8yl/SSYVerMp9pqN7lPtFv7U2XR7zP4a0R1mkgHfAJGHK1UQZ/42 rIDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=oBtvw9RLZz5FiMU8tP1KGG7ayEexwXszGesiGUpyM7c=; b=kd4/ica5ufMYWNYlEIijoc2bctY9j8eCAatUHOJ3B0hkV4WFjz8ODpPa7SfFj6nK3b ClaZboR299r4YyPLGIZDCalLB1iFrFPL3UF5UgXyjQxUVal64Yx2SS1Fogyu1t1FFXOW WkJ/PLyd5BPyfY3PwOqvbJhqCKIYRURbdAmr1+39FH1bjNS54yPSUFcvzKHtk9Iy7JOF 38rGvw8K3HzhGMYUuicFCR3Q6dMB/HBjkGUv4FdNgnRn9AgM78OXFQLSKWRZqri5Lij9 AZe8c3xBffbgkskTxkacNYanwGOnbHmnD4couQt/yvO8YjCuS9kfJ1BBUH6Vh5wT36h6 gnmQ== X-Gm-Message-State: AOAM530LgguP0wiE9cCt25hoQ4mELQ2QgP0WkyAyGM9uIF1qO+AnwzEE wuGDJLh43W2hjWOHxWghojtduwcofgeUFiabVRa3WA== X-Google-Smtp-Source: ABdhPJygSZC8fluO7Inqdaqw8JmKePWM0x239rNniJ2NKvF8HoUFS95pa4d4JBGyUMUeWRE3aBaYUS/L2g/2y3bv5Us= X-Received: by 2002:a17:906:3a57:: with SMTP id a23mr3646914ejf.469.1630587113883; Thu, 02 Sep 2021 05:51:53 -0700 (PDT) MIME-Version: 1.0 References: <1621566204-37456-1-git-send-email-wangxingang5@huawei.com> <01314d70-41e6-70f9-e496-84091948701a@samsung.com> In-Reply-To: From: Anders Roxell Date: Thu, 2 Sep 2021 14:51:43 +0200 Message-ID: Subject: Re: [PATCH v4] iommu/of: Fix pci_request_acs() before enumerating PCI devices To: Robin Murphy Cc: xieyingtai@huawei.com, Rob Herring , Wang Xingang , Greg Kroah-Hartman , Linux Kernel Mailing List , iommu@lists.linux-foundation.org, Rob Herring , helgaas@kernel.org, Linux-Next Mailing List , linux-pci@vger.kernel.org, Will Deacon , "linux-arm-kernel@lists.infradead.org" X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" On Wed, 1 Sept 2021 at 11:58, Robin Murphy wrote: > > On 2021-09-01 09:59, Marek Szyprowski wrote: > > On 21.05.2021 05:03, Wang Xingang wrote: > >> From: Xingang Wang > >> > >> When booting with devicetree, the pci_request_acs() is called after the > >> enumeration and initialization of PCI devices, thus the ACS is not > >> enabled. And ACS should be enabled when IOMMU is detected for the > >> PCI host bridge, so add check for IOMMU before probe of PCI host and call > >> pci_request_acs() to make sure ACS will be enabled when enumerating PCI > >> devices. > >> > >> Fixes: 6bf6c24720d33 ("iommu/of: Request ACS from the PCI core when > >> configuring IOMMU linkage") > >> Signed-off-by: Xingang Wang > > > > This patch landed in linux-next as commit 57a4ab1584e6 ("iommu/of: Fix > > pci_request_acs() before enumerating PCI devices"). Sadly it breaks PCI > > operation on ARM Juno R1 board (arch/arm64/boot/dts/arm/juno-r1.dts). It We've seen this on ARM Juno R2 boards too in the Linaro testfarm. The problem is that the device can't get the "SATA link up" while booting. see https://lkft.validation.linaro.org/scheduler/job/3416767#L577 When reverting this patch we are able to see the "SATA link up". Cheers, Anders _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7AF73C4320E for ; Thu, 2 Sep 2021 12:54:20 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 401DB610CE for ; Thu, 2 Sep 2021 12:54:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 401DB610CE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xu/G6KfG3npcNQPZ5QzL/zbO/QT96hfn1gSyfAE1wVA=; b=N3Lp0XwmLfa04E gatpPeDi0pr7LGdE09T3uAUfieHYwZkD1Z+tu+muKhHijTciDerFVnI9Fb7r1M1aj5PiMGnetPwQU BOCHej08stEltD9VP0nqrSYKLRxKuEjQHem9jYcc8Odq7f8XtuK1aRuJpA5Xxs0QwXd45loYVOtoc V0nOs6ElWAls7gu+HrI3DGMy86S+onFkzd+A/PnYvf0f9+2Kd6eFfmYJnnn8HePu420EmKSF8au/l VR/lY9c6lO8KQQPu+Uf61PBJnnFJoKsFGCcvmeAK0cOjQ6sE/xKoFZqU4AS0aRHdKk5g6Nd6Ix5Ko 20LB7CZtdOa4dnG6yRGg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mLmCJ-009cgM-Q9; Thu, 02 Sep 2021 12:52:03 +0000 Received: from mail-ej1-x62c.google.com ([2a00:1450:4864:20::62c]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mLmCC-009cfV-OX for linux-arm-kernel@lists.infradead.org; Thu, 02 Sep 2021 12:52:00 +0000 Received: by mail-ej1-x62c.google.com with SMTP id i21so4102426ejd.2 for ; Thu, 02 Sep 2021 05:51:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=oBtvw9RLZz5FiMU8tP1KGG7ayEexwXszGesiGUpyM7c=; b=CZV3QxQDYOZ4sA6RDYakDFAaxGnXwXVMjsjFysxH8aP03rp+JlkXUPc7WgK8FGpX/L SXGuMEp+ppKVLvddgbBX0ixeNJqxg4VSqP1TDRDBjvPQ5VKMCmLqqkl9AJZfBi3l5/7x FRcUlQdxgFS5T4X7fWcunJi/PnebZvrR12cgPxE/DLA+M3YhxO/lbDEoOyp+g2/LW1Jx DX6pC3l7XJYiWPp1IXI/Ac9M+08dGoMbdF+te/nB3LOheviQx5PNuf1FxfHa01E+xToK SritC5zqmjTg3cZs8yl/SSYVerMp9pqN7lPtFv7U2XR7zP4a0R1mkgHfAJGHK1UQZ/42 rIDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=oBtvw9RLZz5FiMU8tP1KGG7ayEexwXszGesiGUpyM7c=; b=j/ypf9sYvLrWNROfyAeoSJqA0JmCo4mRRShFxjqHM3lsSarHDnQn3cpXD9u3cZD/Xi hMd/jkKBgEUezm6uo8O96S1ORg6MBkda/qjFPiWtgfmX3VerP1tlxFLdYsmtfWWD5OY6 KvdISdIr9or9gjwX+xnFROiXemCPe2lFC1wf5wJAHyJJx+EyeAe15gACoat9VeWvv6t+ nVw0tjltJqZYFZp59sBImbRi0xVOwLwNzCj8nAatiCal+44XKYVbbo+4V8QcYlH822E5 lHFN/QMLLri5Bw4OnogW16rviUAGNmZn6N6Dw0ezOAOWtr0IoTtnH1oCIwxy1o19Y+2C 0BiQ== X-Gm-Message-State: AOAM531F2QVwh/9uiEHLIMQRPACA4H5f1rebirCV90Bb14EAmM779NM8 B4dr0YV4fjdGFnztaWkfE5zTEYcQq0RWLsZrF1DgvA== X-Google-Smtp-Source: ABdhPJygSZC8fluO7Inqdaqw8JmKePWM0x239rNniJ2NKvF8HoUFS95pa4d4JBGyUMUeWRE3aBaYUS/L2g/2y3bv5Us= X-Received: by 2002:a17:906:3a57:: with SMTP id a23mr3646914ejf.469.1630587113883; Thu, 02 Sep 2021 05:51:53 -0700 (PDT) MIME-Version: 1.0 References: <1621566204-37456-1-git-send-email-wangxingang5@huawei.com> <01314d70-41e6-70f9-e496-84091948701a@samsung.com> In-Reply-To: From: Anders Roxell Date: Thu, 2 Sep 2021 14:51:43 +0200 Message-ID: Subject: Re: [PATCH v4] iommu/of: Fix pci_request_acs() before enumerating PCI devices To: Robin Murphy Cc: Marek Szyprowski , Wang Xingang , Rob Herring , Will Deacon , joro@8bytes.org, helgaas@kernel.org, Rob Herring , Greg Kroah-Hartman , iommu@lists.linux-foundation.org, Linux Kernel Mailing List , linux-pci@vger.kernel.org, xieyingtai@huawei.com, "linux-arm-kernel@lists.infradead.org" , Linux-Next Mailing List X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210902_055156_904617_5C25BBBB X-CRM114-Status: GOOD ( 17.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 1 Sept 2021 at 11:58, Robin Murphy wrote: > > On 2021-09-01 09:59, Marek Szyprowski wrote: > > On 21.05.2021 05:03, Wang Xingang wrote: > >> From: Xingang Wang > >> > >> When booting with devicetree, the pci_request_acs() is called after the > >> enumeration and initialization of PCI devices, thus the ACS is not > >> enabled. And ACS should be enabled when IOMMU is detected for the > >> PCI host bridge, so add check for IOMMU before probe of PCI host and call > >> pci_request_acs() to make sure ACS will be enabled when enumerating PCI > >> devices. > >> > >> Fixes: 6bf6c24720d33 ("iommu/of: Request ACS from the PCI core when > >> configuring IOMMU linkage") > >> Signed-off-by: Xingang Wang > > > > This patch landed in linux-next as commit 57a4ab1584e6 ("iommu/of: Fix > > pci_request_acs() before enumerating PCI devices"). Sadly it breaks PCI > > operation on ARM Juno R1 board (arch/arm64/boot/dts/arm/juno-r1.dts). It We've seen this on ARM Juno R2 boards too in the Linaro testfarm. The problem is that the device can't get the "SATA link up" while booting. see https://lkft.validation.linaro.org/scheduler/job/3416767#L577 When reverting this patch we are able to see the "SATA link up". Cheers, Anders _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel