All of lore.kernel.org
 help / color / mirror / Atom feed
From: Luka Kovacic <luka.kovacic@sartura.hr>
To: "Pali Rohár" <pali@kernel.org>
Cc: u-boot@lists.denx.de, Robert Marko <robert.marko@sartura.hr>,
	 Luka Perkov <luka.perkov@sartura.hr>,
	Marek Behun <marek.behun@nic.cz>,
	sr@denx.de,  sjg@chromium.org, patrick.delaunay@foss.st.com,
	xypron.glpk@gmx.de
Subject: Re: [PATCH v3 2/3] arm: mvebu: mvebu_armada-37xx: Define the loadaddr environment variable
Date: Fri, 13 Aug 2021 10:59:33 +0200	[thread overview]
Message-ID: <CADZsf3a1Tp77R05narAOjcMjWF36MJtoTaPPqtNO+dL2CZY1VQ@mail.gmail.com> (raw)
In-Reply-To: <20210813080846.njhskix45i7drlmg@pali>

Hello Pali,

On Fri, Aug 13, 2021 at 10:08 AM Pali Rohár <pali@kernel.org> wrote:
>
> On Friday 13 August 2021 01:39:37 Luka Kovacic wrote:
> > Add the loadaddr U-Boot environment variable, as this is available in
> > the stock Marvell U-Boot by default on Marvell Armada A37XX platforms.
>
> Hello Luka! Why is this change needed? Reason that it is in historic
> vendor U-Boot does not mean that it has to be also in new mainline
> version.
>
> I have already wrote some reasons in previous review thread:
> https://lore.kernel.org/u-boot/20210301150505.3iajeeufi7ahsnk3@pali/
>
> I think this change was needed when CONFIG_SYS_LOAD_ADDR was set to
> incorrect value, which is already fixed in mainline U-Boot.

This value is very useful when building custom Linux boot scripts.
Yesterday, I booted the board without this patch and there was no loadaddr
variable.

Do I understand this correctly? Are you saying that the value in the loadaddr
variable should be automatically inherited from CONFIG_SYS_LOAD_ADDR
even without this patch?

>
> > Signed-off-by: Luka Kovacic <luka.kovacic@sartura.hr>
> > Cc: Luka Perkov <luka.perkov@sartura.hr>
> > Cc: Robert Marko <robert.marko@sartura.hr>
> > ---
> >  include/configs/mvebu_armada-37xx.h | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/include/configs/mvebu_armada-37xx.h b/include/configs/mvebu_armada-37xx.h
> > index 8e8bcfa018..6901680e32 100644
> > --- a/include/configs/mvebu_armada-37xx.h
> > +++ b/include/configs/mvebu_armada-37xx.h
> > @@ -110,6 +110,7 @@
> >
> >  /* fdt_addr and kernel_addr are needed for existing distribution boot scripts */
> >  #define CONFIG_EXTRA_ENV_SETTINGS    \
> > +     "loadaddr=0x6000000\0"          \
> >       "scriptaddr=0x6d00000\0"        \
> >       "pxefile_addr_r=0x6e00000\0"    \
> >       "fdt_addr=0x6f00000\0"          \
> > --
> > 2.31.1
> >

Kind regards,
Luka

  reply	other threads:[~2021-08-13  8:59 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-12 23:39 [PATCH v3 0/3] Add support for the GST ESPRESSOBin-Ultra board Luka Kovacic
2021-08-12 23:39 ` [PATCH v3 1/3] arm: mvebu: mvebu_armada-37xx: Implement the mac command (Marvell hw_info) Luka Kovacic
2021-08-13  1:43   ` Marek Behún
2021-08-13  8:23   ` Pali Rohár
2021-08-13  9:23     ` Luka Kovacic
2021-08-13  9:41       ` Pali Rohár
2021-08-13  9:51         ` Luka Kovacic
2021-08-13 10:09           ` Pali Rohár
2021-08-13 10:16             ` Luka Kovacic
2021-08-13 10:29   ` Pali Rohár
2021-08-13 10:43     ` Luka Kovacic
2021-08-13 10:49       ` Pali Rohár
2021-08-12 23:39 ` [PATCH v3 2/3] arm: mvebu: mvebu_armada-37xx: Define the loadaddr environment variable Luka Kovacic
2021-08-13  8:08   ` Pali Rohár
2021-08-13  8:59     ` Luka Kovacic [this message]
2021-08-13  9:31       ` Pali Rohár
2021-08-13  9:33         ` Luka Kovacic
2021-08-13  9:42           ` Pali Rohár
2021-08-13 13:59   ` Pali Rohár
2021-08-16  8:21     ` Luka Kovacic
2021-08-16  8:22       ` Pali Rohár
2021-08-12 23:39 ` [PATCH v3 3/3] arm: mvebu: Initial ESPRESSOBin-Ultra board support Luka Kovacic
2021-08-13  8:14   ` Pali Rohár
2021-08-13  9:08     ` Luka Kovacic
2021-08-13  9:54       ` Pali Rohár
2021-08-13  9:58         ` Stefan Roese
2021-08-13 10:25           ` Luka Kovacic
2021-08-13 10:46             ` Pali Rohár
2021-09-24 18:30               ` Pali Rohár
2021-09-27  8:31                 ` Luka Kovacic
2021-08-13  9:27   ` Pali Rohár
2021-08-13 10:03     ` Luka Kovacic
2021-08-13 10:22       ` Pali Rohár
2021-08-13 10:33         ` Luka Kovacic
2021-08-13 10:59           ` Pali Rohár
2021-08-16  8:37             ` Luka Kovacic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CADZsf3a1Tp77R05narAOjcMjWF36MJtoTaPPqtNO+dL2CZY1VQ@mail.gmail.com \
    --to=luka.kovacic@sartura.hr \
    --cc=luka.perkov@sartura.hr \
    --cc=marek.behun@nic.cz \
    --cc=pali@kernel.org \
    --cc=patrick.delaunay@foss.st.com \
    --cc=robert.marko@sartura.hr \
    --cc=sjg@chromium.org \
    --cc=sr@denx.de \
    --cc=u-boot@lists.denx.de \
    --cc=xypron.glpk@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.