From mboxrd@z Thu Jan 1 00:00:00 1970 From: Duc Dang Subject: Defining polarity and trigger mode for static interrupts in _PRT Date: Wed, 24 Aug 2016 04:06:13 -0700 Message-ID: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: Received: from mail-ua0-f172.google.com ([209.85.217.172]:34647 "EHLO mail-ua0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754463AbcHXLHB (ORCPT ); Wed, 24 Aug 2016 07:07:01 -0400 Received: by mail-ua0-f172.google.com with SMTP id k90so21690767uak.1 for ; Wed, 24 Aug 2016 04:06:44 -0700 (PDT) Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Lorenzo Pieralisi , Rafael Wysocki Cc: linux-pci@vger.kernel.org, linux-acpi@vger.kernel.org, Marc Zyngier , patches [Resend in plain text mode] Hi Lorenzo, Rafael, ACPI 6.1 spec does not specify how to set interrupt polarity and trigger mode in _PRT when the interrupts are static (hardwired to specific interrupt inputs in interrupt controller). In current acpi_pci_irq_enable (drivers/acpi/pci_irq.c) implementation, by default the trigger mode is set to LEVEL_SENSITIVE, polarity is set to ACTIVE_LOW. This default setting won't work for ARM64 GICv2, GICv2m, GICv3 controllers and will cause failures in PCIe AER, PME services (on X-Gene platforms). Is there any way to specify polarity and trigger mode for static interrupts in _PRT? If not, can we introduce a _weak_ hook to specify default polarity and trigger mode for for ARM64 PCIe INTx in drivers/acpi/pci_irq.c? Regards, Duc Dang.