From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C16AC433DF for ; Wed, 27 May 2020 17:30:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EB8FD207CB for ; Wed, 27 May 2020 17:30:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=anholt-net.20150623.gappssmtp.com header.i=@anholt-net.20150623.gappssmtp.com header.b="mAXh/LKA" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387814AbgE0Ra6 (ORCPT ); Wed, 27 May 2020 13:30:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44596 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726487AbgE0Ra5 (ORCPT ); Wed, 27 May 2020 13:30:57 -0400 Received: from mail-lj1-x243.google.com (mail-lj1-x243.google.com [IPv6:2a00:1450:4864:20::243]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 323E0C03E97D for ; Wed, 27 May 2020 10:30:57 -0700 (PDT) Received: by mail-lj1-x243.google.com with SMTP id k5so29896946lji.11 for ; Wed, 27 May 2020 10:30:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=anholt-net.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=MXtUXHnihi65Qkky3QBg/wO8Z4FKZ8HK0jwFU/d0C1U=; b=mAXh/LKAKtst4Z3OgR5OvCltmndxuNEjZQX+8dipX11S4NVUuzI1BduWwJIOd+6DbB 6a+NxABiUGXEAf0RRGCvjxerV1sRnnXWb9tnLSD2EL0cWq62ZIoDDhmWb3h6DcFZKRnq vYqaWZiaXxv8mG5WFibpZalTRI7liMgwoPwfLPMs5bjBFbIiOiNdnugZKvOwMzZ6uSfX Vy6rNk6gQ584/+hDTLOf+SvZBSBIpqid54R/B5q4Kq+q9O1s9BbZ7hw3UWlJxyFPE8+o UZE1fx8or/NhVPUNdYyYiAIl2BUAVuY70wq7G5z+Y5QcQk6Lr81KS6MqXz1eHZwM3Q4k 6Jow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=MXtUXHnihi65Qkky3QBg/wO8Z4FKZ8HK0jwFU/d0C1U=; b=nte+ZUyxPdH+yC0iRKpTi6edREX9/OJZklRb5YNEhyZJYVWVssBGFo5ucIpetlz4up M1SgaI+LVrkZXLYR9XOeEieTEgXh5qAQQ6c2Hb3Q5U6IYTj/nqxurmYTLbTegUonlwVM rHGq0OOYqNvqsvGbCiPShs+tUFpvDHR1oqxGSFqU2e2ifJhK3zC9R6ROkeCxiAueHIQQ DrEoFggcRoJXesMq/LCcK2ZTzwvCnMzkhlQHb7uYOhNBXevRvL41IMTmIgwp5X3X2Q4N QhRFbsV5Ql3y4CzagGPijPzZSoLJ819DoiXtnD2duxpq/TQTRHmDhKUQ6XhSLaI4a4rq UCfg== X-Gm-Message-State: AOAM533EmE4hNI3pKYepHmpJ2pgIgkvwutYkiW9lDTqJShm+Y4v+DjRA LEu++pCZkn6vJeYKJaHepDvdRh4fo6RoBlEFni4GLg== X-Google-Smtp-Source: ABdhPJxLtTyXye6ERqUE6zRYmVzfg6k8wpZJsO3V9z/mvydFM0oASGA02J46IB8UgDa1+yhgHxpCV04mqchdroj6ayc= X-Received: by 2002:a2e:8ed3:: with SMTP id e19mr3799428ljl.367.1590600655617; Wed, 27 May 2020 10:30:55 -0700 (PDT) MIME-Version: 1.0 References: <2c6a651cac6359cb0244a40d3b7a14e72918f169.1590594512.git-series.maxime@cerno.tech> In-Reply-To: <2c6a651cac6359cb0244a40d3b7a14e72918f169.1590594512.git-series.maxime@cerno.tech> From: Eric Anholt Date: Wed, 27 May 2020 10:30:44 -0700 Message-ID: Subject: Re: [PATCH v3 040/105] drm/vc4: crtc: Turn pixelvalve reset into a function To: Maxime Ripard Cc: Nicolas Saenz Julienne , DRI Development , linux-rpi-kernel@lists.infradead.org, bcm-kernel-feedback-list@broadcom.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Dave Stevenson , Tim Gover , Phil Elwell Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 27, 2020 at 8:50 AM Maxime Ripard wrote: > > The driver resets the pixelvalve FIFO in a number of occurences without > always using the same sequence. > > Since this will be critical for BCM2711, let's move that sequence to a > function so that we are consistent. > > Signed-off-by: Maxime Ripard Patch 34-40 also r-b. Going to take a little break, this is a lot to try to process at once. Hopefully you can merge reviewed stuff to drm-misc and shorten the series. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7DA3C433E0 for ; Wed, 27 May 2020 17:31:04 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 905552075A for ; Wed, 27 May 2020 17:31:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="tcVgIRdr"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=anholt-net.20150623.gappssmtp.com header.i=@anholt-net.20150623.gappssmtp.com header.b="mAXh/LKA" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 905552075A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=anholt.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=b7F9dPIHc3ziqA+g2cxALEbQQ5vN873YHXJ7u9jAYy8=; b=tcVgIRdrA1KOZT SY6biMB85OCbiH+gy6fNlADqa6oXeaynWqXNweD6jhhnOKuCPFqgihLxd50X7qnQNKw+ELImYI7yO LVIwJZrmO0XWdPdW6BE8kj5tWYcmV8tsQF5CZgRSWv1SVZ8rKQaLcESwpkzcQrdL5FVvR11a0mVQR rSQz1K4mxC/pCc1p3o0Ls49xxvc0Nzl9zcjjijnmbh7vNOzFej4xgihpqVrWBD3sfDcAZB4x0kTOC qCqgpJepPUmrHFdYSt9f7ePyTKmVCm1PgVzJkfYm/C3vWp2K4yh6LeajUCHd0+iLbJ8yAZCvbAJUo og1XF8XrBDvINn9GMJiA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jdztQ-0007fv-2w; Wed, 27 May 2020 17:31:04 +0000 Received: from mail-lj1-x244.google.com ([2a00:1450:4864:20::244]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jdztJ-0007Zz-MT for linux-arm-kernel@lists.infradead.org; Wed, 27 May 2020 17:30:59 +0000 Received: by mail-lj1-x244.google.com with SMTP id z13so20264291ljn.7 for ; Wed, 27 May 2020 10:30:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=anholt-net.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=MXtUXHnihi65Qkky3QBg/wO8Z4FKZ8HK0jwFU/d0C1U=; b=mAXh/LKAKtst4Z3OgR5OvCltmndxuNEjZQX+8dipX11S4NVUuzI1BduWwJIOd+6DbB 6a+NxABiUGXEAf0RRGCvjxerV1sRnnXWb9tnLSD2EL0cWq62ZIoDDhmWb3h6DcFZKRnq vYqaWZiaXxv8mG5WFibpZalTRI7liMgwoPwfLPMs5bjBFbIiOiNdnugZKvOwMzZ6uSfX Vy6rNk6gQ584/+hDTLOf+SvZBSBIpqid54R/B5q4Kq+q9O1s9BbZ7hw3UWlJxyFPE8+o UZE1fx8or/NhVPUNdYyYiAIl2BUAVuY70wq7G5z+Y5QcQk6Lr81KS6MqXz1eHZwM3Q4k 6Jow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=MXtUXHnihi65Qkky3QBg/wO8Z4FKZ8HK0jwFU/d0C1U=; b=WLhL0X9VrcRSExwG440GNAvasGuQzCRmWPm+8mF5z+a7oy3ouEqTJiwnOPj86EZ+CX 345npNDCgXLMHZy4C3wge35KZaTPRjLXOKBqsNsQRmwO3ddNbs1CiMwdGVA5EnnHdI7e umCyhMqlntQunXKPzU3c8oVa/sXYPDf9egGbF1ffdAQ/xT51HO9VujIiw8VkRxz6oOL/ n48ACUsdV0CxPTMoMO71mNwlLR9rf90qvwixXbxFb1wJD49RRNT/zAIeI37dWzHR+x/6 n3qqhiIVujij7Z/p0JXSK5Xa9OLBJZsMOvKBOEAZx0g/rpZsyuJ+DyqMA1ZEAqBaV1y5 4+gw== X-Gm-Message-State: AOAM532VTPMINEnqBYM78GKYGv7+rrfqUM2E5Zyx5L7C1myYwkAgYurn 5016U+UzjdGUQJLlrzJUpqVcaKfOqQZFyP7I70w6aA== X-Google-Smtp-Source: ABdhPJxLtTyXye6ERqUE6zRYmVzfg6k8wpZJsO3V9z/mvydFM0oASGA02J46IB8UgDa1+yhgHxpCV04mqchdroj6ayc= X-Received: by 2002:a2e:8ed3:: with SMTP id e19mr3799428ljl.367.1590600655617; Wed, 27 May 2020 10:30:55 -0700 (PDT) MIME-Version: 1.0 References: <2c6a651cac6359cb0244a40d3b7a14e72918f169.1590594512.git-series.maxime@cerno.tech> In-Reply-To: <2c6a651cac6359cb0244a40d3b7a14e72918f169.1590594512.git-series.maxime@cerno.tech> From: Eric Anholt Date: Wed, 27 May 2020 10:30:44 -0700 Message-ID: Subject: Re: [PATCH v3 040/105] drm/vc4: crtc: Turn pixelvalve reset into a function To: Maxime Ripard X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200527_103057_767795_494CFD4D X-CRM114-Status: GOOD ( 11.66 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tim Gover , Dave Stevenson , linux-kernel@vger.kernel.org, DRI Development , bcm-kernel-feedback-list@broadcom.com, Nicolas Saenz Julienne , Phil Elwell , linux-arm-kernel@lists.infradead.org, linux-rpi-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, May 27, 2020 at 8:50 AM Maxime Ripard wrote: > > The driver resets the pixelvalve FIFO in a number of occurences without > always using the same sequence. > > Since this will be critical for BCM2711, let's move that sequence to a > function so that we are consistent. > > Signed-off-by: Maxime Ripard Patch 34-40 also r-b. Going to take a little break, this is a lot to try to process at once. Hopefully you can merge reviewed stuff to drm-misc and shorten the series. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4814C433E0 for ; Wed, 27 May 2020 17:30:59 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8D5FD2075A for ; Wed, 27 May 2020 17:30:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=anholt-net.20150623.gappssmtp.com header.i=@anholt-net.20150623.gappssmtp.com header.b="mAXh/LKA" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8D5FD2075A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=anholt.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A103C6E370; Wed, 27 May 2020 17:30:58 +0000 (UTC) Received: from mail-lj1-x242.google.com (mail-lj1-x242.google.com [IPv6:2a00:1450:4864:20::242]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4806D6E370 for ; Wed, 27 May 2020 17:30:57 +0000 (UTC) Received: by mail-lj1-x242.google.com with SMTP id b6so29970720ljj.1 for ; Wed, 27 May 2020 10:30:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=anholt-net.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=MXtUXHnihi65Qkky3QBg/wO8Z4FKZ8HK0jwFU/d0C1U=; b=mAXh/LKAKtst4Z3OgR5OvCltmndxuNEjZQX+8dipX11S4NVUuzI1BduWwJIOd+6DbB 6a+NxABiUGXEAf0RRGCvjxerV1sRnnXWb9tnLSD2EL0cWq62ZIoDDhmWb3h6DcFZKRnq vYqaWZiaXxv8mG5WFibpZalTRI7liMgwoPwfLPMs5bjBFbIiOiNdnugZKvOwMzZ6uSfX Vy6rNk6gQ584/+hDTLOf+SvZBSBIpqid54R/B5q4Kq+q9O1s9BbZ7hw3UWlJxyFPE8+o UZE1fx8or/NhVPUNdYyYiAIl2BUAVuY70wq7G5z+Y5QcQk6Lr81KS6MqXz1eHZwM3Q4k 6Jow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=MXtUXHnihi65Qkky3QBg/wO8Z4FKZ8HK0jwFU/d0C1U=; b=uTmYHTWxUBB4zYddbMJKFH62fi6FkfozXBHJQ7B9IA+GOsHTQ95V/syWe99CpstmrE 8ubUT5Ol/yc9K/k8Y9S2EsFvuSt2LE060Pbz92Wf/LQYXOHsPXf/BO7o5MsP/cxRdI9L im+iw3bIQAxhtsA4b+LZpn9KnqfYcgxL/WuoLDIrOssPgWVVLQVbBDIqwXQkK30IAIaQ liLSDs0g6xmytYovMSPQBFaDU+7mgEQP8LapdO9vpFhxHyRWSkRItqlTu6H+w2p6mX+j sd3Di4Q9IGaiEVggrzmM/fouRNkh3l/k8rKYtk+QGoPKPISzcHcoBClxiVb0m/RytmUl OJxw== X-Gm-Message-State: AOAM532ABAuD8MqtKQgnF8yrKPO5zTeFj2r/16yeKgA1pcQFbDbMBHxv f/G7EqA360lAxX1IJ1DbTesFeeimHwwstxJtkkjjig== X-Google-Smtp-Source: ABdhPJxLtTyXye6ERqUE6zRYmVzfg6k8wpZJsO3V9z/mvydFM0oASGA02J46IB8UgDa1+yhgHxpCV04mqchdroj6ayc= X-Received: by 2002:a2e:8ed3:: with SMTP id e19mr3799428ljl.367.1590600655617; Wed, 27 May 2020 10:30:55 -0700 (PDT) MIME-Version: 1.0 References: <2c6a651cac6359cb0244a40d3b7a14e72918f169.1590594512.git-series.maxime@cerno.tech> In-Reply-To: <2c6a651cac6359cb0244a40d3b7a14e72918f169.1590594512.git-series.maxime@cerno.tech> From: Eric Anholt Date: Wed, 27 May 2020 10:30:44 -0700 Message-ID: Subject: Re: [PATCH v3 040/105] drm/vc4: crtc: Turn pixelvalve reset into a function To: Maxime Ripard X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tim Gover , Dave Stevenson , linux-kernel@vger.kernel.org, DRI Development , bcm-kernel-feedback-list@broadcom.com, Nicolas Saenz Julienne , Phil Elwell , linux-arm-kernel@lists.infradead.org, linux-rpi-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Wed, May 27, 2020 at 8:50 AM Maxime Ripard wrote: > > The driver resets the pixelvalve FIFO in a number of occurences without > always using the same sequence. > > Since this will be critical for BCM2711, let's move that sequence to a > function so that we are consistent. > > Signed-off-by: Maxime Ripard Patch 34-40 also r-b. Going to take a little break, this is a lot to try to process at once. Hopefully you can merge reviewed stuff to drm-misc and shorten the series. _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel