From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A42E4C433DF for ; Wed, 27 May 2020 16:33:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6EC492084C for ; Wed, 27 May 2020 16:33:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=anholt-net.20150623.gappssmtp.com header.i=@anholt-net.20150623.gappssmtp.com header.b="XqQQSknD" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391245AbgE0Qd5 (ORCPT ); Wed, 27 May 2020 12:33:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35670 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390679AbgE0Qd5 (ORCPT ); Wed, 27 May 2020 12:33:57 -0400 Received: from mail-lf1-x142.google.com (mail-lf1-x142.google.com [IPv6:2a00:1450:4864:20::142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A61ADC05BD1E for ; Wed, 27 May 2020 09:33:56 -0700 (PDT) Received: by mail-lf1-x142.google.com with SMTP id c21so14847846lfb.3 for ; Wed, 27 May 2020 09:33:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=anholt-net.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=4R64lQECAezSIekk6lfrKMmFFora0mq1CFEKW++lIpo=; b=XqQQSknDXgHqnwyIRF1WdjWReCla6ArE+ipVeGU+Y0Fs7zp+DK2ItCI09Dq7gx/Dyj hJf8C7JzYXLFFiEFPSIdtpTmPXi2couBReRwKrfpziAgeR25ImfBTsGCqZ0900Sg420V z/54ca6O8t7uoH9d/pihKqLAZOuKmtUV7Yi6dH5K8BbubPM8Tvv2W8Pxcgdx5oaFi4dZ hDRBsfqV/wQ0coxuFblYgulLkwiWqgTgOJw/n3rvVaXBhvE5H8wI2VlOwvKt27ojlEeO vURwwXQwETHDoE/k0iaYAURYW/tVRFO8RSQLJtspA+gHvGUH0NqUsG7wshy4+xfs7f5W 2WJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=4R64lQECAezSIekk6lfrKMmFFora0mq1CFEKW++lIpo=; b=BPMLb3iwE4ckCIPO6sGVmbQ5DCSe2nRMZ/3/xHcJzJ2OHLz7oIYvnsVULrSEnJtOGo og1XGl5qltihhbDZuE75yTnmDYemrcTfCsXXhscKmJDBU6ufmVvU99wol1oS/ss2AmhG AubmHLxQqSbU00W2g7bQMHYK1vCku/QX1Ta2wp+vKwlTVFzOKvYrxiTncAxPpCKm6pXK c62HL4ipV+dXMqzY3fecwz8DvkLOJyLfqifib2gGQlHRhjX12+yhzI3mNdxuIFkJ1U/i NZR3N7JXxbOjG+7lzJdzNbDhaB8P5vw2toWjoPhxsvnOtOzCH/THkKrlynK+p140hldi eAhg== X-Gm-Message-State: AOAM533Gr7oce6cSCO1FZRKkafqZQL5MaLWiUsaTIvOcJF9C0LBtT+Kt bHViI9TiZMAuxAvqrDVSlJr58Gzyc9YDq4VAlrMNfw== X-Google-Smtp-Source: ABdhPJzJGyZZ6OFZilVkNjwkWI14qi3Sk9vJd3/Q9ngB/1XlT/NI9vsgFlwoXIDHHg0zMevhGY3B/9Qh957nmNFRnN4= X-Received: by 2002:a19:f813:: with SMTP id a19mr3516133lff.212.1590597235190; Wed, 27 May 2020 09:33:55 -0700 (PDT) MIME-Version: 1.0 References: <1aaadf9a5176591c891622cb00b0c50f42e569dc.1590594512.git-series.maxime@cerno.tech> In-Reply-To: <1aaadf9a5176591c891622cb00b0c50f42e569dc.1590594512.git-series.maxime@cerno.tech> From: Eric Anholt Date: Wed, 27 May 2020 09:33:44 -0700 Message-ID: Subject: Re: [PATCH v3 015/105] drm/vc4: hvs: Boost the core clock during modeset To: Maxime Ripard Cc: Nicolas Saenz Julienne , DRI Development , linux-rpi-kernel@lists.infradead.org, bcm-kernel-feedback-list@broadcom.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Dave Stevenson , Tim Gover , Phil Elwell Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 27, 2020 at 8:49 AM Maxime Ripard wrote: > > In order to prevent timeouts and stalls in the pipeline, the core clock > needs to be maxed at 500MHz during a modeset on the BCM2711. Like, the whole system's core clock? How is it reasonable for some device driver to crank the system's core clock up and back down to some fixed-in-the-driver frequency? Sounds like you need some sort of opp thing here. Patch 13,14 r-b. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D41DC433E1 for ; Wed, 27 May 2020 16:41:38 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1D35120873 for ; Wed, 27 May 2020 16:41:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ky+sX2t/"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=anholt-net.20150623.gappssmtp.com header.i=@anholt-net.20150623.gappssmtp.com header.b="XqQQSknD" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1D35120873 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=anholt.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=C0qEXpq5BxWASWAnt4GYQArwrN5/FG9/48K/Gcjdhc0=; b=ky+sX2t/JNR59U VAJEpACdabSavX9CAS+Ypp8QgMVU2omfgthq+GTjGH6Czsa+LyoZhRjrq6qOg12sUy5iffpLfTzSE B99xLoZ60N/DTt6ltuiuXi99WP6ew40dhAM90DapMd8cPNUDmtEm26Fu0wQr/riFzXNXEXRzEVzD+ 3SC9Bkt6trK4N8aX/6HdiWczQ509TJztKIKdeMoKeLZiEP+3zyGx1syVQJ+49BSpHnJFgwgeKjD3p DPuB6+85kncxIGd3plB9WsygzFg6h+CqIhkqW9a36JsbelYTtI5/ezkvUHmf+W4w4o7ZYMkOYJuKt yGTGVj/QO/Sbw7ohl+9A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jdz7Y-0005O4-Te; Wed, 27 May 2020 16:41:36 +0000 Received: from mail-lf1-x142.google.com ([2a00:1450:4864:20::142]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jdz09-0002Qq-1h for linux-arm-kernel@lists.infradead.org; Wed, 27 May 2020 16:33:58 +0000 Received: by mail-lf1-x142.google.com with SMTP id r125so14803293lff.13 for ; Wed, 27 May 2020 09:33:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=anholt-net.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=4R64lQECAezSIekk6lfrKMmFFora0mq1CFEKW++lIpo=; b=XqQQSknDXgHqnwyIRF1WdjWReCla6ArE+ipVeGU+Y0Fs7zp+DK2ItCI09Dq7gx/Dyj hJf8C7JzYXLFFiEFPSIdtpTmPXi2couBReRwKrfpziAgeR25ImfBTsGCqZ0900Sg420V z/54ca6O8t7uoH9d/pihKqLAZOuKmtUV7Yi6dH5K8BbubPM8Tvv2W8Pxcgdx5oaFi4dZ hDRBsfqV/wQ0coxuFblYgulLkwiWqgTgOJw/n3rvVaXBhvE5H8wI2VlOwvKt27ojlEeO vURwwXQwETHDoE/k0iaYAURYW/tVRFO8RSQLJtspA+gHvGUH0NqUsG7wshy4+xfs7f5W 2WJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=4R64lQECAezSIekk6lfrKMmFFora0mq1CFEKW++lIpo=; b=WalcuG1C1PRDK1w85R4mp6jSv81mSHvn9vkb2Iy4uymXY1npXcwwrw4t2mHxvSlvWW 8amLjVboASu2NjIjzsJnYLbC0GbVy+XTdVgMrm7vH4DoVo4V3fp+XIqxDHrF/Kj3KfyV pbjSw6+IZcBlegg1qOmcSX2HVAW2Rms6YQ6bZZIOn+kxqd3zg7u0shu1/KtWsYO18/XH YesXLsZQY/NpMBF8i6aF/il/Wm1rOxDav7vXtro3hQp9qtKdgcLAvCphxnNPehKmvXjb TZ3mZPH/RsMPiePJgfPVdnZjo9YwLsO4Wj6MOAenoqzpi5a28gSfmilV2hrApSlTQvfG WWwQ== X-Gm-Message-State: AOAM532UipqCF79sA2EK51ZBqO+ROF6+siJ1aUke23ZmWKP4OJo5/UXe 1ZCXbu1+xd26kskIrNE11YFhyZQt5pwmMISn2Nkk3A== X-Google-Smtp-Source: ABdhPJzJGyZZ6OFZilVkNjwkWI14qi3Sk9vJd3/Q9ngB/1XlT/NI9vsgFlwoXIDHHg0zMevhGY3B/9Qh957nmNFRnN4= X-Received: by 2002:a19:f813:: with SMTP id a19mr3516133lff.212.1590597235190; Wed, 27 May 2020 09:33:55 -0700 (PDT) MIME-Version: 1.0 References: <1aaadf9a5176591c891622cb00b0c50f42e569dc.1590594512.git-series.maxime@cerno.tech> In-Reply-To: <1aaadf9a5176591c891622cb00b0c50f42e569dc.1590594512.git-series.maxime@cerno.tech> From: Eric Anholt Date: Wed, 27 May 2020 09:33:44 -0700 Message-ID: Subject: Re: [PATCH v3 015/105] drm/vc4: hvs: Boost the core clock during modeset To: Maxime Ripard X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200527_093357_126417_3289C1BC X-CRM114-Status: UNSURE ( 9.94 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tim Gover , Dave Stevenson , linux-kernel@vger.kernel.org, DRI Development , bcm-kernel-feedback-list@broadcom.com, Nicolas Saenz Julienne , Phil Elwell , linux-arm-kernel@lists.infradead.org, linux-rpi-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, May 27, 2020 at 8:49 AM Maxime Ripard wrote: > > In order to prevent timeouts and stalls in the pipeline, the core clock > needs to be maxed at 500MHz during a modeset on the BCM2711. Like, the whole system's core clock? How is it reasonable for some device driver to crank the system's core clock up and back down to some fixed-in-the-driver frequency? Sounds like you need some sort of opp thing here. Patch 13,14 r-b. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2665C433E0 for ; Wed, 27 May 2020 16:33:58 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A6C9E20890 for ; Wed, 27 May 2020 16:33:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=anholt-net.20150623.gappssmtp.com header.i=@anholt-net.20150623.gappssmtp.com header.b="XqQQSknD" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A6C9E20890 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=anholt.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 21FE76E071; Wed, 27 May 2020 16:33:58 +0000 (UTC) Received: from mail-lf1-x143.google.com (mail-lf1-x143.google.com [IPv6:2a00:1450:4864:20::143]) by gabe.freedesktop.org (Postfix) with ESMTPS id B876B6E071 for ; Wed, 27 May 2020 16:33:56 +0000 (UTC) Received: by mail-lf1-x143.google.com with SMTP id x22so14843323lfd.4 for ; Wed, 27 May 2020 09:33:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=anholt-net.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=4R64lQECAezSIekk6lfrKMmFFora0mq1CFEKW++lIpo=; b=XqQQSknDXgHqnwyIRF1WdjWReCla6ArE+ipVeGU+Y0Fs7zp+DK2ItCI09Dq7gx/Dyj hJf8C7JzYXLFFiEFPSIdtpTmPXi2couBReRwKrfpziAgeR25ImfBTsGCqZ0900Sg420V z/54ca6O8t7uoH9d/pihKqLAZOuKmtUV7Yi6dH5K8BbubPM8Tvv2W8Pxcgdx5oaFi4dZ hDRBsfqV/wQ0coxuFblYgulLkwiWqgTgOJw/n3rvVaXBhvE5H8wI2VlOwvKt27ojlEeO vURwwXQwETHDoE/k0iaYAURYW/tVRFO8RSQLJtspA+gHvGUH0NqUsG7wshy4+xfs7f5W 2WJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=4R64lQECAezSIekk6lfrKMmFFora0mq1CFEKW++lIpo=; b=Lpd/f+GNleYxHLs2htRa6YuoImljwqE45oNjZG+ZylOG/VgrP0wQ1iQsQE7o4G6vN1 4209Ivxr2dt49yiGbBpEh7rOIgdMYzyMhqDD4d5E/ZCdiKvYSgG2/Sjq3ZacRG9FrnaY KQd0oqnXyhclNaOBXEHjSg57USZi6DQPlQ2vTW2C69DRTCY3f1ljVEa8YQe64AJJAO96 Q4YXXVNRyxd8D5nWOUiKrwinVEiGG/C6qJWmwmRiltSTO76nzFtx2vTG8Ib7Gy3CvMze nSKNcL0rlPy9NY4xw4QFpBcI4WIlXZB5uvoUlyTZG3Mx1Ush7za25Kucigak1LwF4/Ir ntjg== X-Gm-Message-State: AOAM5326oqA/98YzXSfh5TwdfPoJCI+/1K+TfUK9Qk/9IqKBkg5/oWpd ltTPpJxR7toqU/q2HcJeoOKcVAl5H8ZMMqsDpA0HLQ== X-Google-Smtp-Source: ABdhPJzJGyZZ6OFZilVkNjwkWI14qi3Sk9vJd3/Q9ngB/1XlT/NI9vsgFlwoXIDHHg0zMevhGY3B/9Qh957nmNFRnN4= X-Received: by 2002:a19:f813:: with SMTP id a19mr3516133lff.212.1590597235190; Wed, 27 May 2020 09:33:55 -0700 (PDT) MIME-Version: 1.0 References: <1aaadf9a5176591c891622cb00b0c50f42e569dc.1590594512.git-series.maxime@cerno.tech> In-Reply-To: <1aaadf9a5176591c891622cb00b0c50f42e569dc.1590594512.git-series.maxime@cerno.tech> From: Eric Anholt Date: Wed, 27 May 2020 09:33:44 -0700 Message-ID: Subject: Re: [PATCH v3 015/105] drm/vc4: hvs: Boost the core clock during modeset To: Maxime Ripard X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tim Gover , Dave Stevenson , linux-kernel@vger.kernel.org, DRI Development , bcm-kernel-feedback-list@broadcom.com, Nicolas Saenz Julienne , Phil Elwell , linux-arm-kernel@lists.infradead.org, linux-rpi-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Wed, May 27, 2020 at 8:49 AM Maxime Ripard wrote: > > In order to prevent timeouts and stalls in the pipeline, the core clock > needs to be maxed at 500MHz during a modeset on the BCM2711. Like, the whole system's core clock? How is it reasonable for some device driver to crank the system's core clock up and back down to some fixed-in-the-driver frequency? Sounds like you need some sort of opp thing here. Patch 13,14 r-b. _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel