From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D702BC43331 for ; Fri, 3 Apr 2020 17:35:55 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9787520737 for ; Fri, 3 Apr 2020 17:35:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=anholt-net.20150623.gappssmtp.com header.i=@anholt-net.20150623.gappssmtp.com header.b="QGH0XZa8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9787520737 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=anholt.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0D75C6EC44; Fri, 3 Apr 2020 17:35:55 +0000 (UTC) Received: from mail-lj1-x241.google.com (mail-lj1-x241.google.com [IPv6:2a00:1450:4864:20::241]) by gabe.freedesktop.org (Postfix) with ESMTPS id DD3A16EC43 for ; Fri, 3 Apr 2020 17:35:53 +0000 (UTC) Received: by mail-lj1-x241.google.com with SMTP id q19so7741849ljp.9 for ; Fri, 03 Apr 2020 10:35:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=anholt-net.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=POas12dpN7kN9O3srxn75BiKgA8osyRtABWdm9UHIdc=; b=QGH0XZa85F7gf6EtUQ+4zpN0bu7F0YRNIXn5DUG9yPM2ZMXOo1+dzNBiANe3tWY3Qu D+k0DuazWhGnHb3+bsPxVPijdtPmfQLrBbXmzcqQVZtFU5atW7YvlAo2a1RVi8hDgY7f mqr13el7xCdyZ7DIfyOGqsYkzNCsPt1Qd28GOzaK3BTaMKgw+7PZDqH2euCFXtVxGbhk wvPNWa9rET83eVFUnTP/I4dRWg5dMqROJu1Kwii5Am3mDwLUo24qnGlbKhtbk9XgykCJ XDlpDAHVJcm3FMxOIcs/xr0FLwiTSIzoWFxWXBt3J5rbCBQy9WrTgr5v9D700wXEKX5T 5cFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=POas12dpN7kN9O3srxn75BiKgA8osyRtABWdm9UHIdc=; b=d6rI+pMeah5qk0EN0JC04eqwhiVILx4SsIhlj1Y37YoJOC5UUjuRjTkvxoMrVEzoei eyu0LFHNVZIJMNTDXTdtoQa6M9HWfQPL+mv65n5hI81qVu7Xjfn8vN06rP9CDCYsPUl0 RUvc9Cn9vQoRdveaU7tTcwF45kFfNch+LyZ/xHZ/Qbd9e+Jgka6Jk2qgYnV56+gt8s0L YfqtTN/Aje/y9fd2UQ+04CPaNR/YhdzytQBb1AWlJYV9zA2psZpNmFZXErtEmEFIORfo 7SpBQXrn86mnhaHxY1V1ukHOvhhAPuXdW/bCQ5/TihU4I/L1N8TAAsxy3Mk31cn70ord RZ6w== X-Gm-Message-State: AGi0Pubg2Nl42f3eLNE9irEfxU7OKKwEhm9TBROcW7LVZFz0zAFBBNAa swZKxFuIMOZuPg6PHN3e5h0NL3v0dGU4OV4jzpRuxQ== X-Google-Smtp-Source: APiQypKMP/RnXTRfLKJD2UC+5Cd91AUzB1nOA2FDBNy5pLCNrQf05sW9Pa++XaIoH4z8MExARwbhTV032DovHlZyPsc= X-Received: by 2002:a2e:7004:: with SMTP id l4mr5617327ljc.55.1585935352328; Fri, 03 Apr 2020 10:35:52 -0700 (PDT) MIME-Version: 1.0 References: <20200403135828.2542770-1-daniel.vetter@ffwll.ch> <20200403135828.2542770-14-daniel.vetter@ffwll.ch> In-Reply-To: <20200403135828.2542770-14-daniel.vetter@ffwll.ch> From: Eric Anholt Date: Fri, 3 Apr 2020 10:35:40 -0700 Message-ID: Subject: Re: [PATCH 13/44] drm/v3d: Delete v3d_dev->dev To: Daniel Vetter X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Vetter , Intel Graphics Development , DRI Development Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Fri, Apr 3, 2020 at 6:58 AM Daniel Vetter wrote: > > We already have it in v3d_dev->drm.dev with zero additional pointer > chasing. Personally I don't like duplicated pointers like this > because: > - reviewers need to check whether the pointer is for the same or > different objects if there's multiple > - compilers have an easier time too > > But also a bit a bikeshed, so feel free to ignore. > > Signed-off-by: Daniel Vetter > Cc: Eric Anholt a-b. _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3AC3EC2BA15 for ; Fri, 3 Apr 2020 17:35:57 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DF54E20737 for ; Fri, 3 Apr 2020 17:35:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=anholt-net.20150623.gappssmtp.com header.i=@anholt-net.20150623.gappssmtp.com header.b="QGH0XZa8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DF54E20737 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=anholt.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6BBF66EC45; Fri, 3 Apr 2020 17:35:55 +0000 (UTC) Received: from mail-lj1-x243.google.com (mail-lj1-x243.google.com [IPv6:2a00:1450:4864:20::243]) by gabe.freedesktop.org (Postfix) with ESMTPS id EE1B36EC44 for ; Fri, 3 Apr 2020 17:35:53 +0000 (UTC) Received: by mail-lj1-x243.google.com with SMTP id f20so7837683ljm.0 for ; Fri, 03 Apr 2020 10:35:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=anholt-net.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=POas12dpN7kN9O3srxn75BiKgA8osyRtABWdm9UHIdc=; b=QGH0XZa85F7gf6EtUQ+4zpN0bu7F0YRNIXn5DUG9yPM2ZMXOo1+dzNBiANe3tWY3Qu D+k0DuazWhGnHb3+bsPxVPijdtPmfQLrBbXmzcqQVZtFU5atW7YvlAo2a1RVi8hDgY7f mqr13el7xCdyZ7DIfyOGqsYkzNCsPt1Qd28GOzaK3BTaMKgw+7PZDqH2euCFXtVxGbhk wvPNWa9rET83eVFUnTP/I4dRWg5dMqROJu1Kwii5Am3mDwLUo24qnGlbKhtbk9XgykCJ XDlpDAHVJcm3FMxOIcs/xr0FLwiTSIzoWFxWXBt3J5rbCBQy9WrTgr5v9D700wXEKX5T 5cFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=POas12dpN7kN9O3srxn75BiKgA8osyRtABWdm9UHIdc=; b=AYBwQT9oS6qQlYPXhTlOqAnhZJGhMfhDNKJlue9eZWGBl10Uq+hmF/2SSrDssPy28h p+g8ynFdRC+57kA4zoH8AvVRPFtL3UdrfpKjAgATL6bf+ShBSGf+cBS/QZzkA6d69ebT GAi5SWsZ1WRxgTnH/DPRZMFNDdedAiY01bBFmfLHGPriEuzdUrxvi8sdgsU3ha9lb3Jz GKkm+kl2kZDc1N4wBJCn/vasROctPNuBliG+GqTCyRrqczcfcNQV2afLirYqOOyghMV2 XJ+TDaSZRSUbUkCuRqAfHGTTvmRJvXVP9L6sjKsNKpVnVyNpmLxLamz8O0Kltyoa+Pj7 ameQ== X-Gm-Message-State: AGi0PuZphxkHaaFqMNcbWT1iE6TkcSHc5uiLTPKt10/T5i0VepFolJfm dwgfGdX8zRVA2glxLt2YlbdyKsoHZIHSxg9wqd3/7w== X-Google-Smtp-Source: APiQypKMP/RnXTRfLKJD2UC+5Cd91AUzB1nOA2FDBNy5pLCNrQf05sW9Pa++XaIoH4z8MExARwbhTV032DovHlZyPsc= X-Received: by 2002:a2e:7004:: with SMTP id l4mr5617327ljc.55.1585935352328; Fri, 03 Apr 2020 10:35:52 -0700 (PDT) MIME-Version: 1.0 References: <20200403135828.2542770-1-daniel.vetter@ffwll.ch> <20200403135828.2542770-14-daniel.vetter@ffwll.ch> In-Reply-To: <20200403135828.2542770-14-daniel.vetter@ffwll.ch> From: Eric Anholt Date: Fri, 3 Apr 2020 10:35:40 -0700 Message-ID: To: Daniel Vetter Subject: Re: [Intel-gfx] [PATCH 13/44] drm/v3d: Delete v3d_dev->dev X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Vetter , Intel Graphics Development , DRI Development Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Fri, Apr 3, 2020 at 6:58 AM Daniel Vetter wrote: > > We already have it in v3d_dev->drm.dev with zero additional pointer > chasing. Personally I don't like duplicated pointers like this > because: > - reviewers need to check whether the pointer is for the same or > different objects if there's multiple > - compilers have an easier time too > > But also a bit a bikeshed, so feel free to ignore. > > Signed-off-by: Daniel Vetter > Cc: Eric Anholt a-b. _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx