All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Scull <ascull@google.com>
To: Tom Rini <trini@konsulko.com>
Cc: "U-Boot Mailing List" <u-boot@lists.denx.de>,
	"Simon Glass" <sjg@chromium.org>, "Bin Meng" <bmeng.cn@gmail.com>,
	"Alistair Delva" <adelva@google.com>,
	"Keir Fraser" <keirf@google.com>,
	"Pierre-Clément Tosi" <ptosi@google.com>
Subject: Re: [PATCH 00/11] virtio: Harden and test vring
Date: Tue, 12 Apr 2022 23:49:12 +0100	[thread overview]
Message-ID: <CADcWuH28RzyLNct=yOu83x3yLvPk_YDB_MWUkOuPv5g1cxiL-g@mail.gmail.com> (raw)
In-Reply-To: <20220412181048.GA434359@bill-the-cat>

On Tue, 12 Apr 2022 at 19:10, Tom Rini <trini@konsulko.com> wrote:
>
> On Thu, Mar 31, 2022 at 10:09:38AM +0000, Andrew Scull wrote:
>
> > Continuing the theme of making the virtio code resilient against
> > corruption of the buffers shared with the device, this series focusses
> > on the vring. This series is simpler and more self-contained than the
> > series for virtio-pci!
> >
> > It follows the example of Linux by keeping a private copy of the
> > descriptors and metadata for state tracking and only ever writing to the
> > descriptors that are shared with the device.
> >
> > I was able to test these hardening steps in the sandbox by simulating
> > device writes to the queues. I was also looking into testing the device
> > drivers against a simulated device but the lack of an API to access the
> > virtqueues meant this ended up being a hack. I've included that hack and
> > the at the end of the series as an RFC.
> >
> > Andrew Scull (11):
> >   virtio_ring: Merge identical variables
> >   virtio_ring: Add helper to attach vring descriptor
> >   virtio_ring: Maintain a shadow copy of descriptors
> >   virtio_ring: Check used descriptors are chain heads
> >   dm: test: virtio: Test the virtio ring
> >   virtio: sandbox: Fix device features bitfield
> >   test: dm: virtio: Test notify before del_vqs
> >   virtio: sandbox: Bind RNG rather than block device
> >   test: dm: virtio: Test virtio device driver probing
> >   virtio: rng: Check length before copying
> >   RFC: test: dm: virtio: Test virtio-rng with faked device
>
> What does this series depend on?  I got a failure to build on sandbox:
> https://source.denx.de/u-boot/u-boot/-/jobs/422500#L104

Problem is from the final, RFC, patch on SPL where CONFIG_DM_RNG is
not set so `dm_rng_read` isn't defined. I don't really understand the
difference with SPL just yet, but I expect CONFIG_DM_RNG can be set.
But in the meantime, it's also fine to drop that final patch from the
series.

  reply	other threads:[~2022-04-12 22:49 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-31 10:09 [PATCH 00/11] virtio: Harden and test vring Andrew Scull
2022-03-31 10:09 ` [PATCH 01/11] virtio_ring: Merge identical variables Andrew Scull
2022-04-07  7:03   ` Heinrich Schuchardt
2022-04-11 18:35     ` Simon Glass
2022-03-31 10:09 ` [PATCH 02/11] virtio_ring: Add helper to attach vring descriptor Andrew Scull
2022-04-11 18:35   ` Simon Glass
2022-03-31 10:09 ` [PATCH 03/11] virtio_ring: Maintain a shadow copy of descriptors Andrew Scull
2022-04-11 18:35   ` Simon Glass
2022-03-31 10:09 ` [PATCH 04/11] virtio_ring: Check used descriptors are chain heads Andrew Scull
2022-04-11 18:35   ` Simon Glass
2022-03-31 10:09 ` [PATCH 05/11] dm: test: virtio: Test the virtio ring Andrew Scull
2022-04-11 18:35   ` Simon Glass
2022-03-31 10:09 ` [PATCH 06/11] virtio: sandbox: Fix device features bitfield Andrew Scull
2022-04-11 18:35   ` Simon Glass
2022-03-31 10:09 ` [PATCH 07/11] test: dm: virtio: Test notify before del_vqs Andrew Scull
2022-04-11 18:35   ` Simon Glass
2022-03-31 10:09 ` [PATCH 08/11] virtio: sandbox: Bind RNG rather than block device Andrew Scull
2022-04-07  7:20   ` Heinrich Schuchardt
2022-04-07 10:16     ` Andrew Scull
2022-04-11 18:35       ` Simon Glass
2022-03-31 10:09 ` [PATCH 09/11] test: dm: virtio: Test virtio device driver probing Andrew Scull
2022-04-11 18:35   ` Simon Glass
2022-03-31 10:09 ` [PATCH 10/11] virtio: rng: Check length before copying Andrew Scull
2022-04-06 14:18   ` Pierre-Clément Tosi
2022-04-07 10:09     ` Andrew Scull
2022-04-11 18:35   ` Simon Glass
2022-03-31 10:09 ` [PATCH 11/11] RFC: test: dm: virtio: Test virtio-rng with faked device Andrew Scull
2022-04-11 18:35   ` Simon Glass
2022-04-12 10:33     ` Andrew Scull
2022-04-12 18:10 ` [PATCH 00/11] virtio: Harden and test vring Tom Rini
2022-04-12 22:49   ` Andrew Scull [this message]
2022-04-12 23:11     ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CADcWuH28RzyLNct=yOu83x3yLvPk_YDB_MWUkOuPv5g1cxiL-g@mail.gmail.com' \
    --to=ascull@google.com \
    --cc=adelva@google.com \
    --cc=bmeng.cn@gmail.com \
    --cc=keirf@google.com \
    --cc=ptosi@google.com \
    --cc=sjg@chromium.org \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.