From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf0-f44.google.com (mail-lf0-f44.google.com [209.85.215.44]) by mail.openembedded.org (Postfix) with ESMTP id 5AECE60657 for ; Sat, 24 Oct 2015 22:17:53 +0000 (UTC) Received: by lfaz124 with SMTP id z124so114912753lfa.1 for ; Sat, 24 Oct 2015 15:17:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=66JYOqJdnfCNimTreohwknUnnLop3O7/EI49/MSdKg8=; b=hNw7ibfWfJ+8B7Eb0C2oJrbWWyTu6I8tYdewtQi0W7MHfTQx8egvqmiW0IupE6htRB HF52vOTVyN19F73dSEe71+NP2bCGUadCkjr7K1ybG/VEtKRlpTvS56G8Ls03oLOkFPhn i3G9Y0I2SjzS3KUVE+5TbjIrWyRd0vI0zWm2P7FK2GDWPcG9/g2dkGOjHqOzeGZy3orY 9xbjMmNB4BmW5Isw4T27RhjR6qFIK6jQxYFyHk6dYglvmoQNCUpDAsReSEN5Rg5BImeR yhn77cdoA8TD5VdTbfHeB3xLQlhA0RZSlrYnw+x0HDx0PzTb/It65vTCQZdkWrQKodQY 6Xpg== X-Gm-Message-State: ALoCoQmv+rTh0/njBQauMYnkH6Ekema1rJS9f/hsGTmwLM1vAUUllqMky50GbhUZojvrDijPM0RE MIME-Version: 1.0 X-Received: by 10.112.17.105 with SMTP id n9mr14671392lbd.78.1445725072501; Sat, 24 Oct 2015 15:17:52 -0700 (PDT) Received: by 10.112.5.162 with HTTP; Sat, 24 Oct 2015 15:17:52 -0700 (PDT) Received: by 10.112.5.162 with HTTP; Sat, 24 Oct 2015 15:17:52 -0700 (PDT) In-Reply-To: References: <1445620687-9578-1-git-send-email-jpuhlman@mvista.com> Date: Sat, 24 Oct 2015 15:17:52 -0700 Message-ID: From: Jeremy Puhlman To: Jens Rehsack Cc: openembedded-core@lists.openembedded.org Subject: Re: [PATCH] Perl: Use CC version not $Config(gccversion) X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 24 Oct 2015 22:17:54 -0000 Content-Type: multipart/alternative; boundary=001a11c3bfee63e0d00522e11922 --001a11c3bfee63e0d00522e11922 Content-Type: text/plain; charset=UTF-8 On Oct 24, 2015 5:15 AM, "Jens Rehsack" wrote: > > > > Am 23.10.2015 um 19:18 schrieb Jeremy Puhlman : > > > > Get version data from querying $CC rather then > > $Config(gccversion) which comes from running version of > > perl. Since perl-native is not likely compiled by gcc > > 5 at this point, it will never trigger the required > > fixes for gcc 5. > > > > [YOCTO #8367] > > > > Signed-off-by: Jeremy Puhlman > > --- > > .../perl/perl/perl-errno-generation-gcc5.patch | 23 ++++++++++++++++++++++ > > meta/recipes-devtools/perl/perl_5.22.0.bb | 1 + > > 2 files changed, 24 insertions(+) > > create mode 100644 meta/recipes-devtools/perl/perl/perl-errno-generation-gcc5.patch > > > > diff --git a/meta/recipes-devtools/perl/perl/perl-errno-generation-gcc5.patch b/meta/recipes-devtools/perl/perl/perl-errno-generation-gcc5.patch > > new file mode 100644 > > index 0000000..efbc55d > > --- /dev/null > > +++ b/meta/recipes-devtools/perl/perl/perl-errno-generation-gcc5.patch > > @@ -0,0 +1,23 @@ > > +Upstream-Status:Inappropriate [embedded specific] > > Did you ask p5-porters? > > I strongly suggest to open an RT for 2 reasons: > > 1) Let the people know that I'm not the only one encountering problems with the way they deal situation Yeah we have been having fun cross compiling perl since 2000, lots of fun. > 2) Those tickets enlighten over time. > > Cross-compiling is not restricted to embedded. > > The patch self looks more than sane and I'm happy to support it when reported (so tell me the ticket number or put me on CC when creating the ticket). Is there a specific mailing list? > > +The upstream code assumes that the compiler version used to compiler miniperl/perl-native > > +is the same as the one being used to build the perl binary. Since most people are not running > > +systems with gcc 5, it is unlikely that it will work on any supported host. Switch out gccversion > > +for the version extracted from $CC --version. > > + > > +--- perl-5.22.0/ext/Errno/Errno_pm.PL 2015-10-19 18:01:20.622143786 -0400 > > ++++ perl-5.22.0-fixed/ext/Errno/Errno_pm.PL 2015-10-19 17:50:35.662137367 -0400 > > +@@ -224,9 +224,12 @@ > > + > > + { # BeOS (support now removed) did not enter this block > > + # invoke CPP and read the output > > ++ my $compiler = $ENV{'CC'}; > > ++ my $compiler_out = `$compiler --version`; > > ++ my @compiler_version = split / /,$compiler_out; > > + > > + my $inhibit_linemarkers = ''; > > +- if ($Config{gccversion} =~ /\A(\d+)\./ and $1 >= 5) { > > ++ if (@compiler_version[2] =~ /\A(\d+)\./ and $1 >= 5) { > > + # GCC 5.0 interleaves expanded macros with line numbers breaking > > + # each line into multiple lines. RT#123784 > > + $inhibit_linemarkers = ' -P'; > > diff --git a/meta/recipes-devtools/perl/perl_5.22.0.bb b/meta/recipes-devtools/perl/perl_5.22.0.bb > > index 3ce7849..66e074d 100644 > > --- a/meta/recipes-devtools/perl/perl_5.22.0.bb > > +++ b/meta/recipes-devtools/perl/perl_5.22.0.bb > > @@ -62,6 +62,7 @@ SRC_URI += " \ > > file://ext-ODBM_File-hints-linux.pl-link-libgdbm_compat.patch \ > > file://ext-ODBM_File-t-odbm.t-fix-the-path-of-dbmt_common.p.patch \ > > file://perl-PathTools-don-t-filter-out-blib-from-INC.patch \ > > + file://perl-errno-generation-gcc5.patch \ > > " > > > > # Fix test case issues > > -- > > 2.6.2 > > Cheers > -- > Jens Rehsack - rehsack@gmail.com > --001a11c3bfee63e0d00522e11922 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable


On Oct 24, 2015 5:15 AM, "Jens Rehsack" <rehsack@gmail.com> wrote:
>
>
> > Am 23.10.2015 um 19:18 schrieb Jeremy Puhlman <jpuhlman@mvista.com>:
> >
> > Get version data from querying $CC rather then
> > $Config(gccversion) which comes from running version of
> > perl. Since perl-native is not likely compiled by gcc
> > 5 at this point, it will never trigger the required
> > fixes for gcc 5.
> >
> > [YOCTO #8367]
> >
> > Signed-off-by: Jeremy Puhlman <jpuhlman@mvista.com>
> > ---
> > .../perl/perl/perl-errno-generation-gcc5.patch=C2=A0 =C2=A0 =C2= =A0| 23 ++++++++++++++++++++++
> > meta/recipes-devtools/perl/perl= _5.22.0.bb=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 |=C2=A0 1 +
> > 2 files changed, 24 insertions(+)
> > create mode 100644 meta/recipes-devtools/perl/perl/perl-errno-gen= eration-gcc5.patch
> >
> > diff --git a/meta/recipes-devtools/perl/perl/perl-errno-generatio= n-gcc5.patch b/meta/recipes-devtools/perl/perl/perl-errno-generation-gcc5.p= atch
> > new file mode 100644
> > index 0000000..efbc55d
> > --- /dev/null
> > +++ b/meta/recipes-devtools/perl/perl/perl-errno-generation-gcc5.= patch
> > @@ -0,0 +1,23 @@
> > +Upstream-Status:Inappropriate [embedded specific]
>
> Did you ask p5-porters?
>
> I strongly suggest to open an RT for 2 reasons:
>
> 1) Let the people know that I'm not the only one encountering prob= lems with the way they deal situation

Yeah we have been having fun cross compiling perl since 2000= , lots of fun.

> 2) Those tickets enlighten over time.
>
> Cross-compiling is not restricted to embedded.
>
> The patch self looks more than sane and I'm happy to support it wh= en reported (so tell me the ticket number or put me on CC when creating the= ticket).

Is there a specific mailing list?
> > +The upstream code assumes that the compiler version used to comp= iler miniperl/perl-native
> > +is the same as the one being used to build the perl binary. Sinc= e most people are not running
> > +systems with gcc 5, it is unlikely that it will work on any supp= orted host. Switch out gccversion
> > +for the version extracted from $CC --version.
> > +
> > +--- perl-5.22.0/ext/Errno/Errno_pm.PL=C2=A0 =C2=A0 =C2=A0 =C2=A0= 2015-10-19 18:01:20.622143786 -0400
> > ++++ perl-5.22.0-fixed/ext/Errno/Errno_pm.PL=C2=A0 2015-10-19 17:= 50:35.662137367 -0400
> > +@@ -224,9 +224,12 @@
> > +
> > +=C2=A0 =C2=A0 =C2=A0{=C2=A0 =C2=A0 =C2=A0 =C2=A0# BeOS (support = now removed) did not enter this block
> > +=C2=A0 =C2=A0 =C2=A0# invoke CPP and read the output
> > ++=C2=A0 =C2=A0 =C2=A0 =C2=A0 my $compiler =3D $ENV{'CC'}= ;
> > ++=C2=A0 =C2=A0 =C2=A0 =C2=A0 my $compiler_out =3D `$compiler --v= ersion`;
> > ++=C2=A0 =C2=A0 =C2=A0 =C2=A0 my @compiler_version =3D split / /,= $compiler_out;
> > +
> > +=C2=A0 =C2=A0 =C2=A0my $inhibit_linemarkers =3D '';
> > +-=C2=A0 =C2=A0 if ($Config{gccversion} =3D~ /\A(\d+)\./ and $1 &= gt;=3D 5) {
> > ++=C2=A0 =C2=A0 if (@compiler_version[2] =3D~ /\A(\d+)\./ and $1 = >=3D 5) {
> > +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0# GCC 5.0 interleaves expanded= macros with line numbers breaking
> > +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0# each line into multiple line= s. RT#123784
> > +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0$inhibit_linemarkers =3D '= -P';
> > diff --git a/meta/recipes-devtools/perl/perl_5.22.0.bb b/meta/recipes-devtools/perl/perl_5.22.0.bb
> > index 3ce7849..66e074d 100644
> > --- a/meta/recipes-devtools/perl/perl_5.22.0.bb
> > +++ b/meta/recipes-devtools/perl/perl_5.22.0.bb
> > @@ -62,6 +62,7 @@ SRC_URI +=3D " \
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0file://ext-ODBM_File-hints-linux= .pl-link-libgdbm_compat.patch \
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0file://ext-ODBM_File-t-odbm.t-fi= x-the-path-of-dbmt_common.p.patch \
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0file://perl-PathTools-don-t-filt= er-out-blib-from-INC.patch \
> > +=C2=A0 =C2=A0 =C2=A0 =C2=A0 file://perl-errno-generation-gcc5.pa= tch \
> > "
> >
> > # Fix test case issues
> > --
> > 2.6.2
>
> Cheers
> --
> Jens Rehsack - rehsack@gmail.com<= /a>
>

--001a11c3bfee63e0d00522e11922--