From: Sughosh Ganu <sughosh.ganu@linaro.org>
To: u-boot@lists.denx.de
Subject: [PATCH] fsp: Move and rename fsp_types.h file
Date: Mon, 14 Dec 2020 10:38:43 +0530 [thread overview]
Message-ID: <CADg8p94nFZD99ikGz-xUGKNN7N2vAkBCXFM_W3JsWcuu0=aRyg@mail.gmail.com> (raw)
In-Reply-To: <CAPnjgZ3LJN2yaOLqwhiq=gvKOCubHtapj8DUw44A=01-ucQrTQ@mail.gmail.com>
hi Simon,
On Sat, 12 Dec 2020 at 21:10, Simon Glass <sjg@chromium.org> wrote:
> Hi Sughosh,
>
> On Fri, 11 Dec 2020 at 03:06, Sughosh Ganu <sughosh.ganu@linaro.org>
> wrote:
> >
> > The fsp_types.h header file contains macros for building signatures of
> > different widths. These signature macros are architecture agnostic,
> > and can be used in all places which use signatures in a data
> > structure. Move and rename the fsp_types.h under the common include
> > header.
> >
> > Signed-off-by: Sughosh Ganu <sughosh.ganu@linaro.org>
> > ---
> >
> > Build tested for cougarcanyon2 board which builds the
> > relevant fsp code.
> >
> > arch/x86/include/asm/fsp/fsp_support.h | 3 ++-
> > .../asm/fsp/fsp_types.h => include/signature_types.h | 6 +++---
>
> How about just signatures.h ?
>
Ok. Will change.
> > 2 files changed, 5 insertions(+), 4 deletions(-)
> > rename arch/x86/include/asm/fsp/fsp_types.h =>
> include/signature_types.h (94%)
> >
> > diff --git a/arch/x86/include/asm/fsp/fsp_support.h
> b/arch/x86/include/asm/fsp/fsp_support.h
> > index 29e511415c..7651a0dac0 100644
> > --- a/arch/x86/include/asm/fsp/fsp_support.h
> > +++ b/arch/x86/include/asm/fsp/fsp_support.h
> > @@ -11,10 +11,11 @@
> > #include <asm/fsp/fsp_fv.h>
> > #include <asm/fsp/fsp_hob.h>
> > #include <asm/fsp/fsp_infoheader.h>
> > -#include <asm/fsp/fsp_types.h>
> > #include <asm/fsp_arch.h>
> > #include <asm/fsp/fsp_azalia.h>
> >
> > +#include <signature_types.h>
>
> Can you put that at the top, as we normally put asm headers below common
> ones.
>
Sure, I will re-arrange. Thanks for your review.
-sughosh
next prev parent reply other threads:[~2020-12-14 5:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-11 10:06 [PATCH] fsp: Move and rename fsp_types.h file Sughosh Ganu
2020-12-12 15:40 ` Simon Glass
2020-12-14 5:08 ` Sughosh Ganu [this message]
2020-12-22 2:16 ` Bin Meng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADg8p94nFZD99ikGz-xUGKNN7N2vAkBCXFM_W3JsWcuu0=aRyg@mail.gmail.com' \
--to=sughosh.ganu@linaro.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.