Re: [RESEND RFC PATCH 03/10] FWU: Add metadata structure and functions for accessing metadata

From: Sughosh Ganu <sughosh.ganu@linaro.org>
To: Simon Glass <sjg@chromium.org>
Cc: u-boot@lists.denx.de,
	Patrick Delaunay <patrick.delaunay@foss.st.com>,
	 Patrice Chotard <patrice.chotard@foss.st.com>,
	Heinrich Schuchardt <xypron.glpk@gmx.de>,
	 Alexander Graf <agraf@csgraf.de>, Bin Meng <bmeng.cn@gmail.com>,
	Peng Fan <peng.fan@nxp.com>,
	AKASHI Takahiro <takahiro.akashi@linaro.org>,
	Ilias Apalodimas <ilias.apalodimas@linaro.org>,
	 Jose Marinho <jose.marinho@arm.com>,
	Grant Likely <grant.likely@arm.com>,
	 Jason Liu <jason.hui.liu@nxp.com>
Subject: Re: [RESEND RFC PATCH 03/10] FWU: Add metadata structure and functions for accessing metadata
Date: Wed, 1 Dec 2021 12:12:11 +0530	[thread overview]
Message-ID: <CADg8p95PU8CY+C=u35j1Hh2L6rxEdFCF6XacVBFzcAHXENdcMA@mail.gmail.com> (raw)
In-Reply-To: <CAPnjgZ0ESQuZybn+=WTz5GCmc-COOGNPgdsRLEmJYuHDsh8i9g@mail.gmail.com>

hi Simon,

On Wed, 1 Dec 2021 at 11:56, Simon Glass <sjg@chromium.org> wrote:

> Hi,
>
> On Thu, 25 Nov 2021 at 00:13, Sughosh Ganu <sughosh.ganu@linaro.org>
> wrote:
> >
> > In the FWU Multi Bank Update feature, the information about the
> > updatable images is stored as part of the metadata, which is stored on
> > a dedicated partition. Add the metadata structure, and functions to
> > access the metadata. These are generic API's, and implementations can
> > be added based on parameters like how the metadata partition is
> > accessed and what type of storage device houses the metadata.
> >
> > Signed-off-by: Sughosh Ganu <sughosh.ganu@linaro.org>
> > ---
> >  include/fwu_metadata.h         | 125 +++++++++++++++
> >  lib/fwu_updates/fwu_metadata.c | 275 +++++++++++++++++++++++++++++++++
> >  2 files changed, 400 insertions(+)
> >  create mode 100644 include/fwu_metadata.h
> >  create mode 100644 lib/fwu_updates/fwu_metadata.c
>
> What is this, please? Could you add a link to the docs in the commit
> message and something in doc/ as well?
>

This is implementation of the FWU[1] specification from Arm. Some aspects
of the DependableBoot[2] specification are also implemented. I had put
pointers to the document in the cover letter[3]. I have not added any
documentation yet, since this is a rfc. Will do so once the initial reviews
are completed. Hope that is fine.

-sughosh

[1] - https://developer.arm.com/documentation/den0118/a
[2] -
https://staging-git.codelinaro.org/linaro/firmware-dual-banked-updates/test
[3] - https://lists.denx.de/pipermail/u-boot/2021-November/468232.html

>
> Regards,
> Simon
>