From mboxrd@z Thu Jan  1 00:00:00 1970
From: Sughosh Ganu <sughosh.ganu@linaro.org>
Date: Sun, 10 May 2020 16:50:12 +0530
Subject: [PATCH 5/8] efi_loader: Make the pkcs7 header parsing function an
 extern
In-Reply-To: <20200508005124.GC31466@laputa>
References: <20200430173630.15608-1-sughosh.ganu@linaro.org>
 <20200430173630.15608-6-sughosh.ganu@linaro.org>
 <20200507073416.GF3330@laputa>
 <CADg8p96NLD2AteN6uf=wjYpxc+4X_hABO4xsdC3urPTi14K3XA@mail.gmail.com>
 <20200508005124.GC31466@laputa>
Message-ID: <CADg8p96PV=LHOh7afdPV=LieDed6DJq3d8d2JnjqNDCAsaqe2w@mail.gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Fri, 8 May 2020 at 06:21, Akashi Takahiro <takahiro.akashi@linaro.org>
wrote:

> On Thu, May 07, 2020 at 04:48:30PM +0530, Sughosh Ganu wrote:
> > On Thu, 7 May 2020 at 13:04, Akashi Takahiro <takahiro.akashi@linaro.org
> >
> > wrote:
> >
> > > On Thu, Apr 30, 2020 at 11:06:27PM +0530, Sughosh Ganu wrote:
> > > > The pkcs7 header parsing functionality is pretty generic, and can be
> > > > used by other features like capsule authentication. Make the function
> > > > as an extern, also changing it's name to efi_parse_pkcs7_header.
> > >
> > > The patch itself is fine to me, but is "pkcs7 header" a common term?
> > >
> >
> > I haven't come across it in any other code base. I used it since in the
> > concept of a capsule, the signature is prepended to the capsule payload.
> If
> > you can think of a better name, please suggest so. I will change it in
> the
> > next version.
>
> Simply, efi_parse_pkcs7_signature()?
>
> In addition, please update the function description, which still
> mentions "variable."
>

Ok. Will change.

-sughosh