All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Golubovsky <golubovsky@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] Added package v86d which provides a real-mode helper for uvesafb driver.
Date: Tue, 8 May 2012 23:47:57 -0400	[thread overview]
Message-ID: <CADiAo4+U+dz3YBPRh7T6ArwCsm5YivzdmnXDs5nV+_fCoGphZg@mail.gmail.com> (raw)
In-Reply-To: <20120509034511.GA26002@sapphire.tkos.co.il>

Baruch,

On Tue, May 8, 2012 at 11:45 PM, Baruch Siach <baruch@tkos.co.il> wrote:
> Hi Dmitry,
>
> Two more comments.
>> +
>> +ifeq ($(BR2_i386),y)
>> + ? ? x86emu = n
>> +endif
>> +
>> +ifeq ($(BR2_x86_64),y)
>> + ? ? x86emu = y
>> +endif
>
> We generally use capitals for variable names. Also, this can be shortened to
>
> ? ?X86EMU = $(if $(BR2_i386),n,y)

This is a local variable - still uppercase?

>
> But you don't used the CFLAGS variable. Please correct the comment.

Right, I'll correct this.

Thanks.

-- 
Dmitry Golubovsky

Anywhere on the Web

  reply	other threads:[~2012-05-09  3:47 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-09  1:19 [Buildroot] [PATCH] Added package v86d which provides a real-mode helper for uvesafb driver Dmitry
2012-05-09  3:45 ` Baruch Siach
2012-05-09  3:47   ` Dmitry Golubovsky [this message]
2012-05-09  4:32     ` Baruch Siach
  -- strict thread matches above, loose matches on Subject: below --
2012-07-18 21:17 Dmitry
2012-07-17  3:17 Dmitry
2012-07-17  8:01 ` Thomas Petazzoni
2012-07-17  9:38   ` Dmitry Golubovsky
2012-05-14  3:50 Dmitry
2012-05-09 10:41 Dmitry
2012-05-11 22:39 ` Arnout Vandecappelle
2012-05-12  5:01   ` Dmitry Golubovsky
2012-05-12 14:30     ` Arnout Vandecappelle
2012-05-09 10:32 Dmitry
2012-05-09 10:35 ` Baruch Siach
2012-05-07  3:29 Dmitry
2012-05-07  3:58 ` Baruch Siach
2012-05-07 10:31   ` Dimitry Golubovsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CADiAo4+U+dz3YBPRh7T6ArwCsm5YivzdmnXDs5nV+_fCoGphZg@mail.gmail.com \
    --to=golubovsky@gmail.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.