From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 264AECCA479 for ; Thu, 21 Jul 2022 09:31:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232385AbiGUJbq (ORCPT ); Thu, 21 Jul 2022 05:31:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33802 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232465AbiGUJbo (ORCPT ); Thu, 21 Jul 2022 05:31:44 -0400 Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0FD9680529; Thu, 21 Jul 2022 02:31:42 -0700 (PDT) Received: by mail-wm1-x333.google.com with SMTP id p26-20020a1c545a000000b003a2fb7c1274so2928785wmi.1; Thu, 21 Jul 2022 02:31:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=CqoqFDcKzQdjJafb6yVEzJIruLZ/32AbmJegq9jmsDE=; b=YAkXHOcznZLGmCMQ1RWcJzQ3Z/GteinQw/AfYqo5ctFERCkDoFahq79y6Y0pwx44gl GLoaT+TWNd0oMAh4jyhZmDSdFHC/Zftc1EEUiFnzxuN6N1LpjDVSm9lKMqXV2EhRL0Ry G079IVg2a7gAS5xznVv2gq67UufdW4WSzlQZ9DXRqk91zH4iPyHriQNKu1M+wNlTEo1n 2zA0wZW0tNCpwEP/8UlLssY+QSaTfOjTnzVQJG4SXW9SEcPXN7mdEmbdei940aVuSXGZ guttcy1i/xfOMU5uu8eMfPDPGBLtmZOrxqajlos3sDC8OOgUFvJKwBYbuLu6PcMURAyn KT6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=CqoqFDcKzQdjJafb6yVEzJIruLZ/32AbmJegq9jmsDE=; b=TKMOepghT0oAhdKPVW/ErTaiGtAXmt5ygOmv9fb8c30WaruO1TSPY5qqqKen4jFVyq bPVWVDhhPU6zHalL10ut2+BtS2j+P4hCOeE6Rs90clh98HtWlh8bb17EZHHZH15x+W6t 3ToPrZFxrCNtMmCjNu3neqZ27KjRl9pgzEiYACONgxLF8wNX/Pw1/DT6nWqDeHmC/XQa zZQxFn1lGYFOL3vGVyyfAS7GthaAuGnZ1glzK8HG8Yl/AuE4XXRJ5Sk3hlBIlOCtDIcl amLFpxCWoXFn0WOMEFGNewraWaI4wBLARRnf+DbtT3sGFnTmaJM4L0SmbqFsi8hzdaHL 8gEw== X-Gm-Message-State: AJIora+pJ//BMvTDtgjCvysMywj4VUEx2spwg8aHwXB4O8tzkyOpyI/+ 733K2FVB3zrLKjLHIdfAm+psbDQ6Q2oyMg9bTALEYNYoRtY= X-Google-Smtp-Source: AGRyM1uth3ZszQR4Y69c6/F2fcYkQehI7TUvzonlMhEKjh0dv2rEa6EpJ0tm1xDP06OICuKvouAgditDjMYoi6Y6Kko= X-Received: by 2002:a05:600c:2110:b0:3a3:1a69:aa7b with SMTP id u16-20020a05600c211000b003a31a69aa7bmr7190128wml.186.1658395901183; Thu, 21 Jul 2022 02:31:41 -0700 (PDT) MIME-Version: 1.0 References: <20220715112607.591-1-peterwu.pub@gmail.com> <20220715112607.591-12-peterwu.pub@gmail.com> <20220720094510.GA29755@cyhuang-hp-elitebook-840-g3.rt> In-Reply-To: From: ChiYuan Huang Date: Thu, 21 Jul 2022 17:31:29 +0800 Message-ID: Subject: Re: [PATCH v5 11/13] leds: mt6370: Add MediaTek MT6370 current sink type LED Indicator support To: Andy Shevchenko Cc: ChiaEn Wu , Lee Jones , Daniel Thompson , Jingoo Han , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Matthias Brugger , Sebastian Reichel , Chunfeng Yun , Greg Kroah-Hartman , Jonathan Cameron , Lars-Peter Clausen , Liam Girdwood , Mark Brown , Guenter Roeck , "Krogerus, Heikki" , Helge Deller , ChiaEn Wu , Alice Chen , cy_huang , dri-devel , Linux LED Subsystem , devicetree , linux-arm Mailing List , "moderated list:ARM/Mediatek SoC support" , Linux Kernel Mailing List , Linux PM , USB , linux-iio , "open list:FRAMEBUFFER LAYER" , szuni chen Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org ChiYuan Huang =E6=96=BC 2022=E5=B9=B47=E6=9C=8820=E6= =97=A5 =E9=80=B1=E4=B8=89 =E4=B8=8B=E5=8D=885:48=E5=AF=AB=E9=81=93=EF=BC=9A > > ChiYuan Huang =E6=96=BC 2022=E5=B9=B47=E6=9C=8820=E6= =97=A5 =E9=80=B1=E4=B8=89 =E4=B8=8B=E5=8D=885:45=E5=AF=AB=E9=81=93=EF=BC=9A > > > > On Fri, Jul 15, 2022 at 08:29:42PM +0200, Andy Shevchenko wrote: > > > On Fri, Jul 15, 2022 at 1:29 PM ChiaEn Wu wro= te: > > > > > > > > From: ChiYuan Huang > > > > > > > > The MediaTek MT6370 is a highly-integrated smart power management I= C, > > > > which includes a single cell Li-Ion/Li-Polymer switching battery > > > > charger, a USB Type-C & Power Delivery (PD) controller, dual > > > > Flash LED current sources, a RGB LED driver, a backlight WLED drive= r, > > > > a display bias driver and a general LDO for portable devices. > > > > > > > > In MediaTek MT6370, there are four channel current-sink RGB LEDs th= at > > > > support hardware pattern for constant current, PWM, and breath mode= . > > > > Isink4 channel can also be used as a CHG_VIN power good indicator. > > > > > > ... > > > > > > > + This driver can also be built as a module. If so the modu= le > > > > > > so, the > > > > > > > + will be called "leds-mt6370.ko". > > > > > > No ".ko". > > > > > > Why did you ignore these comments? Please go and fix _everywhere_ in > > > your series. > > > It's basically the rule of thumb, if the reviewer gives a comment > > > against an occurrence of something, go through entire series and chec= k > > > if there are other places like commented one and address them all. > > > > > > ... > > > > > > > + * Author: Alice Chen > > > > > > Strange, the commit message doesn't have a corresponding SoB, why? > > > > > Yes, there're two authors Alice and me. > > I'll correct it in next. > > > ... > > > > > > > +#define MT6370_PWM_DUTY 31 > > > > +#define MT6372_PMW_DUTY 255 > > > > > > Looks like these are limits by hardware? > > > Check with the datasheet if (BIT(x) - 1) makes more sense here. > > > > > > ... > > > > > > > + switch (led_no) { > > > > + case MT6370_LED_ISNK1: > > > > + sel_field =3D F_LED1_DUTY; > > > > + break; > > > > + case MT6370_LED_ISNK2: > > > > + sel_field =3D F_LED2_DUTY; > > > > + break; > > > > + case MT6370_LED_ISNK3: > > > > + sel_field =3D F_LED3_DUTY; > > > > + break; > > > > + default: > > > > + sel_field =3D F_LED4_DUTY; > > > > > > Missed break; > > > > > > > + } > > > > > > ... > > > > > > > + switch (led_no) { > > > > + case MT6370_LED_ISNK1: > > > > + sel_field =3D F_LED1_FREQ; > > > > + break; > > > > + case MT6370_LED_ISNK2: > > > > + sel_field =3D F_LED2_FREQ; > > > > + break; > > > > + case MT6370_LED_ISNK3: > > > > + sel_field =3D F_LED3_FREQ; > > > > + break; > > > > + default: > > > > + sel_field =3D F_LED4_FREQ; > > > > > > Ditto. > > > > > > > + } > > > > > > ... > > > > > > > + switch (led_no) { > > > > + case MT6370_LED_ISNK1: > > > > + case MT6370_LED_ISNK2: > > > > + case MT6370_LED_ISNK3: > > > > + *base =3D MT6370_REG_RGB1_TR + led_no * 3; > > > > + break; > > > > + default: > > > > + *base =3D MT6370_REG_RGB_CHRIND_TR; > > > > > > Ditto. > > > It seems you dropped them for all switch-cases. It's not goot, please > > > restore them back. > > > > > > > + } > > > > > > ... > > > > > > > + u8 val[P_MAX_PATTERNS / 2] =3D {0}; > > > > > > { } should suffice > > > > > > > > In the above range selector, we use the 'logic or' to generate the > typo, it's 'below'. > > pattern values. > > Ah, found in c11 standard 6.7.9 item 21 It is the same as 'static storage duration'. I will follow your comment to revise it. Thanks. > > If to change it from '{0} to '{ }', is it correct? > > > > + /* > > > > + * Pattern list > > > > + * tr1: byte 0, b'[7: 4] > > > > + * tr2: byte 0, b'[3: 0] > > > > + * tf1: byte 1, b'[7: 4] > > > > + * tf2: byte 1, b'[3: 0] > > > > + * ton: byte 2, b'[7: 4] > > > > + * toff: byte 2, b'[3: 0] > > > > + */ > > > > + for (i =3D 0; i < P_MAX_PATTERNS; i++) { > > > > + curr =3D pattern + i; > > > > + > > > > + sel_range =3D i =3D=3D P_LED_TOFF ? R_LED_TOFF : R_= LED_TRFON; > > > > + > > > > + linear_range_get_selector_within(priv->ranges + sel= _range, > > > > + curr->delta_t, &se= l); > > > > + > > > > + val[i / 2] |=3D sel << (4 * ((i + 1) % 2)); > > > > + } > > > > + > > > > + memcpy(pattern_val, val, 3); > > > > + return 0; > > > > +} > > > > > > ... > > > > > > > +out: > > > > > > out_unlock: > > > > > > > + mutex_unlock(&priv->lock); > > > > + > > > > + return ret; > > > > > > ... > > > > > > > +out: > > > > > > Ditto. And so on. > > > > > > > + mutex_unlock(&priv->lock); > > > > + > > > > + return ret; > > > > > > ... > > > > > > > + sub_led =3D devm_kzalloc(priv->dev, > > > > + sizeof(*sub_led) * MC_CHANNE= L_NUM, > > > > + GFP_KERNEL); > > > > > > NIH devm_kcalloc(). Also check if you really need zeroed data. > > > > > Ok, and after the check, I also need to add one line to set the intensi= ty to 0. > > > > + if (!sub_led) > > > > + return -ENOMEM; > > > > > > ... > > > > > > > + ret =3D fwnode_property_read_u32(child, "co= lor", &color); > > > > + if (ret) { > > > > + dev_err(priv->dev, > > > > + "led %d, no color specified= \n", > > > > + led->index); > > > > + return ret; > > > > > > return dev_err_probe(...) ; ? > > > > > > Ditto for many places in your entire series. > > > > > > > + } > > > > > > ... > > > > > > > + priv =3D devm_kzalloc(&pdev->dev, > > > > + struct_size(priv, leds, count), GFP_KER= NEL); > > > > > > At least one parameter can be placed on the previous line. > > > > > > > + if (!priv) > > > > + return -ENOMEM; > > > > > > -- > > > With Best Regards, > > > Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DDAF7C43334 for ; Thu, 21 Jul 2022 09:31:44 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0424C18B1E0; Thu, 21 Jul 2022 09:31:44 +0000 (UTC) Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [IPv6:2a00:1450:4864:20::334]) by gabe.freedesktop.org (Postfix) with ESMTPS id 224B42B103 for ; Thu, 21 Jul 2022 09:31:43 +0000 (UTC) Received: by mail-wm1-x334.google.com with SMTP id ay11-20020a05600c1e0b00b003a3013da120so2912236wmb.5 for ; Thu, 21 Jul 2022 02:31:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=CqoqFDcKzQdjJafb6yVEzJIruLZ/32AbmJegq9jmsDE=; b=YAkXHOcznZLGmCMQ1RWcJzQ3Z/GteinQw/AfYqo5ctFERCkDoFahq79y6Y0pwx44gl GLoaT+TWNd0oMAh4jyhZmDSdFHC/Zftc1EEUiFnzxuN6N1LpjDVSm9lKMqXV2EhRL0Ry G079IVg2a7gAS5xznVv2gq67UufdW4WSzlQZ9DXRqk91zH4iPyHriQNKu1M+wNlTEo1n 2zA0wZW0tNCpwEP/8UlLssY+QSaTfOjTnzVQJG4SXW9SEcPXN7mdEmbdei940aVuSXGZ guttcy1i/xfOMU5uu8eMfPDPGBLtmZOrxqajlos3sDC8OOgUFvJKwBYbuLu6PcMURAyn KT6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=CqoqFDcKzQdjJafb6yVEzJIruLZ/32AbmJegq9jmsDE=; b=1t3NfRPzxl0Ti4NasA+4ChOms6yg4MGSVRIxXbmB/6W3samX5d+H56zMzWvE9Ik9At QXHTZsM84b0UdpG7jdnTjTL4xcUjk9Hg7FAdjZoPgpphCaVT6nBNgZ9xFnUln0HwjzlK IEwm5DGIiPf5XgOwtvsuy+wwyZ6PxO1t7UaYOR96C/i/D1Oknqx8IzWlCijz2wCaQcVs kZbhm70xDbqz/ZR8oMUZbIPTdUQmVZjwrlvz1QK0jmrsOsDgMgoGNoHcDBd1kU2OMy1S 5Da6Ci/y6iQElrPuKggs9gJvRRWeI2DtoH/3EgKBA41t3XOoERdVJUMXQyywR8A9Ng96 x6gA== X-Gm-Message-State: AJIora8uYnvZpXaT0HmSl/MlOI0oA4OKvgZcYXNGsPJfS5NdgcKv7ysU 9Rsy1bZS3rPmUminx1dcWBREV7bp+jFOkhU1qX0= X-Google-Smtp-Source: AGRyM1uth3ZszQR4Y69c6/F2fcYkQehI7TUvzonlMhEKjh0dv2rEa6EpJ0tm1xDP06OICuKvouAgditDjMYoi6Y6Kko= X-Received: by 2002:a05:600c:2110:b0:3a3:1a69:aa7b with SMTP id u16-20020a05600c211000b003a31a69aa7bmr7190128wml.186.1658395901183; Thu, 21 Jul 2022 02:31:41 -0700 (PDT) MIME-Version: 1.0 References: <20220715112607.591-1-peterwu.pub@gmail.com> <20220715112607.591-12-peterwu.pub@gmail.com> <20220720094510.GA29755@cyhuang-hp-elitebook-840-g3.rt> In-Reply-To: From: ChiYuan Huang Date: Thu, 21 Jul 2022 17:31:29 +0800 Message-ID: Subject: Re: [PATCH v5 11/13] leds: mt6370: Add MediaTek MT6370 current sink type LED Indicator support To: Andy Shevchenko Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "open list:FRAMEBUFFER LAYER" , "Krogerus, Heikki" , Pavel Machek , Alice Chen , linux-iio , dri-devel , Liam Girdwood , cy_huang , Krzysztof Kozlowski , Lee Jones , Linux LED Subsystem , Daniel Thompson , Helge Deller , Rob Herring , Chunfeng Yun , Guenter Roeck , devicetree , Linux PM , szuni chen , Mark Brown , "moderated list:ARM/Mediatek SoC support" , Matthias Brugger , ChiaEn Wu , linux-arm Mailing List , Jingoo Han , USB , Sebastian Reichel , Linux Kernel Mailing List , ChiaEn Wu , Greg Kroah-Hartman , Jonathan Cameron Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" ChiYuan Huang =E6=96=BC 2022=E5=B9=B47=E6=9C=8820=E6= =97=A5 =E9=80=B1=E4=B8=89 =E4=B8=8B=E5=8D=885:48=E5=AF=AB=E9=81=93=EF=BC=9A > > ChiYuan Huang =E6=96=BC 2022=E5=B9=B47=E6=9C=8820=E6= =97=A5 =E9=80=B1=E4=B8=89 =E4=B8=8B=E5=8D=885:45=E5=AF=AB=E9=81=93=EF=BC=9A > > > > On Fri, Jul 15, 2022 at 08:29:42PM +0200, Andy Shevchenko wrote: > > > On Fri, Jul 15, 2022 at 1:29 PM ChiaEn Wu wro= te: > > > > > > > > From: ChiYuan Huang > > > > > > > > The MediaTek MT6370 is a highly-integrated smart power management I= C, > > > > which includes a single cell Li-Ion/Li-Polymer switching battery > > > > charger, a USB Type-C & Power Delivery (PD) controller, dual > > > > Flash LED current sources, a RGB LED driver, a backlight WLED drive= r, > > > > a display bias driver and a general LDO for portable devices. > > > > > > > > In MediaTek MT6370, there are four channel current-sink RGB LEDs th= at > > > > support hardware pattern for constant current, PWM, and breath mode= . > > > > Isink4 channel can also be used as a CHG_VIN power good indicator. > > > > > > ... > > > > > > > + This driver can also be built as a module. If so the modu= le > > > > > > so, the > > > > > > > + will be called "leds-mt6370.ko". > > > > > > No ".ko". > > > > > > Why did you ignore these comments? Please go and fix _everywhere_ in > > > your series. > > > It's basically the rule of thumb, if the reviewer gives a comment > > > against an occurrence of something, go through entire series and chec= k > > > if there are other places like commented one and address them all. > > > > > > ... > > > > > > > + * Author: Alice Chen > > > > > > Strange, the commit message doesn't have a corresponding SoB, why? > > > > > Yes, there're two authors Alice and me. > > I'll correct it in next. > > > ... > > > > > > > +#define MT6370_PWM_DUTY 31 > > > > +#define MT6372_PMW_DUTY 255 > > > > > > Looks like these are limits by hardware? > > > Check with the datasheet if (BIT(x) - 1) makes more sense here. > > > > > > ... > > > > > > > + switch (led_no) { > > > > + case MT6370_LED_ISNK1: > > > > + sel_field =3D F_LED1_DUTY; > > > > + break; > > > > + case MT6370_LED_ISNK2: > > > > + sel_field =3D F_LED2_DUTY; > > > > + break; > > > > + case MT6370_LED_ISNK3: > > > > + sel_field =3D F_LED3_DUTY; > > > > + break; > > > > + default: > > > > + sel_field =3D F_LED4_DUTY; > > > > > > Missed break; > > > > > > > + } > > > > > > ... > > > > > > > + switch (led_no) { > > > > + case MT6370_LED_ISNK1: > > > > + sel_field =3D F_LED1_FREQ; > > > > + break; > > > > + case MT6370_LED_ISNK2: > > > > + sel_field =3D F_LED2_FREQ; > > > > + break; > > > > + case MT6370_LED_ISNK3: > > > > + sel_field =3D F_LED3_FREQ; > > > > + break; > > > > + default: > > > > + sel_field =3D F_LED4_FREQ; > > > > > > Ditto. > > > > > > > + } > > > > > > ... > > > > > > > + switch (led_no) { > > > > + case MT6370_LED_ISNK1: > > > > + case MT6370_LED_ISNK2: > > > > + case MT6370_LED_ISNK3: > > > > + *base =3D MT6370_REG_RGB1_TR + led_no * 3; > > > > + break; > > > > + default: > > > > + *base =3D MT6370_REG_RGB_CHRIND_TR; > > > > > > Ditto. > > > It seems you dropped them for all switch-cases. It's not goot, please > > > restore them back. > > > > > > > + } > > > > > > ... > > > > > > > + u8 val[P_MAX_PATTERNS / 2] =3D {0}; > > > > > > { } should suffice > > > > > > > > In the above range selector, we use the 'logic or' to generate the > typo, it's 'below'. > > pattern values. > > Ah, found in c11 standard 6.7.9 item 21 It is the same as 'static storage duration'. I will follow your comment to revise it. Thanks. > > If to change it from '{0} to '{ }', is it correct? > > > > + /* > > > > + * Pattern list > > > > + * tr1: byte 0, b'[7: 4] > > > > + * tr2: byte 0, b'[3: 0] > > > > + * tf1: byte 1, b'[7: 4] > > > > + * tf2: byte 1, b'[3: 0] > > > > + * ton: byte 2, b'[7: 4] > > > > + * toff: byte 2, b'[3: 0] > > > > + */ > > > > + for (i =3D 0; i < P_MAX_PATTERNS; i++) { > > > > + curr =3D pattern + i; > > > > + > > > > + sel_range =3D i =3D=3D P_LED_TOFF ? R_LED_TOFF : R_= LED_TRFON; > > > > + > > > > + linear_range_get_selector_within(priv->ranges + sel= _range, > > > > + curr->delta_t, &se= l); > > > > + > > > > + val[i / 2] |=3D sel << (4 * ((i + 1) % 2)); > > > > + } > > > > + > > > > + memcpy(pattern_val, val, 3); > > > > + return 0; > > > > +} > > > > > > ... > > > > > > > +out: > > > > > > out_unlock: > > > > > > > + mutex_unlock(&priv->lock); > > > > + > > > > + return ret; > > > > > > ... > > > > > > > +out: > > > > > > Ditto. And so on. > > > > > > > + mutex_unlock(&priv->lock); > > > > + > > > > + return ret; > > > > > > ... > > > > > > > + sub_led =3D devm_kzalloc(priv->dev, > > > > + sizeof(*sub_led) * MC_CHANNE= L_NUM, > > > > + GFP_KERNEL); > > > > > > NIH devm_kcalloc(). Also check if you really need zeroed data. > > > > > Ok, and after the check, I also need to add one line to set the intensi= ty to 0. > > > > + if (!sub_led) > > > > + return -ENOMEM; > > > > > > ... > > > > > > > + ret =3D fwnode_property_read_u32(child, "co= lor", &color); > > > > + if (ret) { > > > > + dev_err(priv->dev, > > > > + "led %d, no color specified= \n", > > > > + led->index); > > > > + return ret; > > > > > > return dev_err_probe(...) ; ? > > > > > > Ditto for many places in your entire series. > > > > > > > + } > > > > > > ... > > > > > > > + priv =3D devm_kzalloc(&pdev->dev, > > > > + struct_size(priv, leds, count), GFP_KER= NEL); > > > > > > At least one parameter can be placed on the previous line. > > > > > > > + if (!priv) > > > > + return -ENOMEM; > > > > > > -- > > > With Best Regards, > > > Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 56227C433EF for ; Thu, 21 Jul 2022 09:32:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=z2BeS3VwAEKbAClTRdiMUhK0VwGEz+Pgbs//kkK+wmg=; b=oqKe971YylKy+0 8WfLN8vpMPNdlUD5NzyxY81SXFps9X7VHVIICwME1a9RzSCa2adO+KwB0gDxQ7ndFUFTyMiVXQ8sJ apOzJ6QVTaY7jw0KB07vxnh0Nd7s4yf0aJ6WlVfrEVxd/oQKgXsjTsJCMgCpoGrg9c3MwV89/2rPK Cy7NxB2DCmYRM82vIwPShX69XC1z/3p6IC8J+C+N7TouixNBh+DpzEOvDrCGPBS1EcRCVgNn4/VtR PQhSY9sXSL+P6C4qPl+pasgWSuVqzS7MwOtyfMctcaaujpDqBuVtw9RaGGDt2QfMHdUkYHOFcipVr L2KhEsBsTUzWyIsGPMbQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oESX4-003MHM-1v; Thu, 21 Jul 2022 09:31:46 +0000 Received: from mail-wm1-x333.google.com ([2a00:1450:4864:20::333]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oESX0-003MAy-UU; Thu, 21 Jul 2022 09:31:44 +0000 Received: by mail-wm1-x333.google.com with SMTP id x23-20020a05600c179700b003a30e3e7989so503797wmo.0; Thu, 21 Jul 2022 02:31:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=CqoqFDcKzQdjJafb6yVEzJIruLZ/32AbmJegq9jmsDE=; b=YAkXHOcznZLGmCMQ1RWcJzQ3Z/GteinQw/AfYqo5ctFERCkDoFahq79y6Y0pwx44gl GLoaT+TWNd0oMAh4jyhZmDSdFHC/Zftc1EEUiFnzxuN6N1LpjDVSm9lKMqXV2EhRL0Ry G079IVg2a7gAS5xznVv2gq67UufdW4WSzlQZ9DXRqk91zH4iPyHriQNKu1M+wNlTEo1n 2zA0wZW0tNCpwEP/8UlLssY+QSaTfOjTnzVQJG4SXW9SEcPXN7mdEmbdei940aVuSXGZ guttcy1i/xfOMU5uu8eMfPDPGBLtmZOrxqajlos3sDC8OOgUFvJKwBYbuLu6PcMURAyn KT6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=CqoqFDcKzQdjJafb6yVEzJIruLZ/32AbmJegq9jmsDE=; b=jiGqyIUS+XqdWtXZF7VEdM8MWXgGUTlBzmd/RJjUKA3hY+2qisVeSe7zzT1BPtMvnd nI9XLxBFhB9npamVRuHvAQnf9t0lDZYU4GYzOt/PKnqJDMKxUgHGg7mubdPRJiCk6zU8 8MbtdNbRdytgoW/kt9yIv9r9j9ouZ8yrMqTYyGgQFPeEfnfOCgfUzwk+F5QAytBwk2+R dXHPVdbeU1G/mPnoioVGsbXrSi2pUv0giLz52/ad1x8iRvr8L+rnoAlVpudScaL8Jug1 kiZBPHf66KbrNCsUGhRw0KqZyZt49BdOYFKFagpeZWuPQmIHEpr7TpT3YrS2rL53YFkg MCVQ== X-Gm-Message-State: AJIora8G7+C4Ki6cuSpS+P5DzfoRxUTJ23aNOX088zUH0jnQ6OmZHJ5W l5cKPoI4/3ecFaIk3/hmzIkbYCsMTIjW+5AtZ4w= X-Google-Smtp-Source: AGRyM1uth3ZszQR4Y69c6/F2fcYkQehI7TUvzonlMhEKjh0dv2rEa6EpJ0tm1xDP06OICuKvouAgditDjMYoi6Y6Kko= X-Received: by 2002:a05:600c:2110:b0:3a3:1a69:aa7b with SMTP id u16-20020a05600c211000b003a31a69aa7bmr7190128wml.186.1658395901183; Thu, 21 Jul 2022 02:31:41 -0700 (PDT) MIME-Version: 1.0 References: <20220715112607.591-1-peterwu.pub@gmail.com> <20220715112607.591-12-peterwu.pub@gmail.com> <20220720094510.GA29755@cyhuang-hp-elitebook-840-g3.rt> In-Reply-To: From: ChiYuan Huang Date: Thu, 21 Jul 2022 17:31:29 +0800 Message-ID: Subject: Re: [PATCH v5 11/13] leds: mt6370: Add MediaTek MT6370 current sink type LED Indicator support To: Andy Shevchenko Cc: ChiaEn Wu , Lee Jones , Daniel Thompson , Jingoo Han , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Matthias Brugger , Sebastian Reichel , Chunfeng Yun , Greg Kroah-Hartman , Jonathan Cameron , Lars-Peter Clausen , Liam Girdwood , Mark Brown , Guenter Roeck , "Krogerus, Heikki" , Helge Deller , ChiaEn Wu , Alice Chen , cy_huang , dri-devel , Linux LED Subsystem , devicetree , linux-arm Mailing List , "moderated list:ARM/Mediatek SoC support" , Linux Kernel Mailing List , Linux PM , USB , linux-iio , "open list:FRAMEBUFFER LAYER" , szuni chen X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220721_023143_035677_A402B73B X-CRM114-Status: GOOD ( 40.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Q2hpWXVhbiBIdWFuZyA8dTAwODQ1MDBAZ21haWwuY29tPiDmlrwgMjAyMuW5tDfmnIgyMOaXpSDp gLHkuIkg5LiL5Y2INTo0OOWvq+mBk++8mgo+Cj4gQ2hpWXVhbiBIdWFuZyA8dTAwODQ1MDBAZ21h aWwuY29tPiDmlrwgMjAyMuW5tDfmnIgyMOaXpSDpgLHkuIkg5LiL5Y2INTo0NeWvq+mBk++8mgo+ ID4KPiA+IE9uIEZyaSwgSnVsIDE1LCAyMDIyIGF0IDA4OjI5OjQyUE0gKzAyMDAsIEFuZHkgU2hl dmNoZW5rbyB3cm90ZToKPiA+ID4gT24gRnJpLCBKdWwgMTUsIDIwMjIgYXQgMToyOSBQTSBDaGlh RW4gV3UgPHBldGVyd3UucHViQGdtYWlsLmNvbT4gd3JvdGU6Cj4gPiA+ID4KPiA+ID4gPiBGcm9t OiBDaGlZdWFuIEh1YW5nIDxjeV9odWFuZ0ByaWNodGVrLmNvbT4KPiA+ID4gPgo+ID4gPiA+IFRo ZSBNZWRpYVRlayBNVDYzNzAgaXMgYSBoaWdobHktaW50ZWdyYXRlZCBzbWFydCBwb3dlciBtYW5h Z2VtZW50IElDLAo+ID4gPiA+IHdoaWNoIGluY2x1ZGVzIGEgc2luZ2xlIGNlbGwgTGktSW9uL0xp LVBvbHltZXIgc3dpdGNoaW5nIGJhdHRlcnkKPiA+ID4gPiBjaGFyZ2VyLCBhIFVTQiBUeXBlLUMg JiBQb3dlciBEZWxpdmVyeSAoUEQpIGNvbnRyb2xsZXIsIGR1YWwKPiA+ID4gPiBGbGFzaCBMRUQg Y3VycmVudCBzb3VyY2VzLCBhIFJHQiBMRUQgZHJpdmVyLCBhIGJhY2tsaWdodCBXTEVEIGRyaXZl ciwKPiA+ID4gPiBhIGRpc3BsYXkgYmlhcyBkcml2ZXIgYW5kIGEgZ2VuZXJhbCBMRE8gZm9yIHBv cnRhYmxlIGRldmljZXMuCj4gPiA+ID4KPiA+ID4gPiBJbiBNZWRpYVRlayBNVDYzNzAsIHRoZXJl IGFyZSBmb3VyIGNoYW5uZWwgY3VycmVudC1zaW5rIFJHQiBMRURzIHRoYXQKPiA+ID4gPiBzdXBw b3J0IGhhcmR3YXJlIHBhdHRlcm4gZm9yIGNvbnN0YW50IGN1cnJlbnQsIFBXTSwgYW5kIGJyZWF0 aCBtb2RlLgo+ID4gPiA+IElzaW5rNCBjaGFubmVsIGNhbiBhbHNvIGJlIHVzZWQgYXMgYSBDSEdf VklOIHBvd2VyIGdvb2QgaW5kaWNhdG9yLgo+ID4gPgo+ID4gPiAuLi4KPiA+ID4KPiA+ID4gPiAr ICAgICAgICAgVGhpcyBkcml2ZXIgY2FuIGFsc28gYmUgYnVpbHQgYXMgYSBtb2R1bGUuIElmIHNv IHRoZSBtb2R1bGUKPiA+ID4KPiA+ID4gc28sIHRoZQo+ID4gPgo+ID4gPiA+ICsgICAgICAgICB3 aWxsIGJlIGNhbGxlZCAibGVkcy1tdDYzNzAua28iLgo+ID4gPgo+ID4gPiBObyAiLmtvIi4KPiA+ ID4KPiA+ID4gV2h5IGRpZCB5b3UgaWdub3JlIHRoZXNlIGNvbW1lbnRzPyBQbGVhc2UgZ28gYW5k IGZpeCBfZXZlcnl3aGVyZV8gaW4KPiA+ID4geW91ciBzZXJpZXMuCj4gPiA+IEl0J3MgYmFzaWNh bGx5IHRoZSBydWxlIG9mIHRodW1iLCBpZiB0aGUgcmV2aWV3ZXIgZ2l2ZXMgYSBjb21tZW50Cj4g PiA+IGFnYWluc3QgYW4gb2NjdXJyZW5jZSBvZiBzb21ldGhpbmcsIGdvIHRocm91Z2ggZW50aXJl IHNlcmllcyBhbmQgY2hlY2sKPiA+ID4gaWYgdGhlcmUgYXJlIG90aGVyIHBsYWNlcyBsaWtlIGNv bW1lbnRlZCBvbmUgYW5kIGFkZHJlc3MgdGhlbSBhbGwuCj4gPiA+Cj4gPiA+IC4uLgo+ID4gPgo+ ID4gPiA+ICsgKiBBdXRob3I6IEFsaWNlIENoZW4gPGFsaWNlX2NoZW5AcmljaHRlay5jb20+Cj4g PiA+Cj4gPiA+IFN0cmFuZ2UsIHRoZSBjb21taXQgbWVzc2FnZSBkb2Vzbid0IGhhdmUgYSBjb3Jy ZXNwb25kaW5nIFNvQiwgd2h5Pwo+ID4gPgo+ID4gWWVzLCB0aGVyZSdyZSB0d28gYXV0aG9ycyBB bGljZSBhbmQgbWUuCj4gPiBJJ2xsIGNvcnJlY3QgaXQgaW4gbmV4dC4KPiA+ID4gLi4uCj4gPiA+ Cj4gPiA+ID4gKyNkZWZpbmUgTVQ2MzcwX1BXTV9EVVRZICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAzMQo+ID4gPiA+ICsjZGVmaW5lIE1UNjM3Ml9QTVdfRFVUWSAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgMjU1Cj4gPiA+Cj4gPiA+IExvb2tzIGxpa2UgdGhlc2UgYXJlIGxp bWl0cyBieSBoYXJkd2FyZT8KPiA+ID4gQ2hlY2sgd2l0aCB0aGUgZGF0YXNoZWV0IGlmIChCSVQo eCkgLSAxKSBtYWtlcyBtb3JlIHNlbnNlIGhlcmUuCj4gPiA+Cj4gPiA+IC4uLgo+ID4gPgo+ID4g PiA+ICsgICAgICAgc3dpdGNoIChsZWRfbm8pIHsKPiA+ID4gPiArICAgICAgIGNhc2UgTVQ2Mzcw X0xFRF9JU05LMToKPiA+ID4gPiArICAgICAgICAgICAgICAgc2VsX2ZpZWxkID0gRl9MRUQxX0RV VFk7Cj4gPiA+ID4gKyAgICAgICAgICAgICAgIGJyZWFrOwo+ID4gPiA+ICsgICAgICAgY2FzZSBN VDYzNzBfTEVEX0lTTksyOgo+ID4gPiA+ICsgICAgICAgICAgICAgICBzZWxfZmllbGQgPSBGX0xF RDJfRFVUWTsKPiA+ID4gPiArICAgICAgICAgICAgICAgYnJlYWs7Cj4gPiA+ID4gKyAgICAgICBj YXNlIE1UNjM3MF9MRURfSVNOSzM6Cj4gPiA+ID4gKyAgICAgICAgICAgICAgIHNlbF9maWVsZCA9 IEZfTEVEM19EVVRZOwo+ID4gPiA+ICsgICAgICAgICAgICAgICBicmVhazsKPiA+ID4gPiArICAg ICAgIGRlZmF1bHQ6Cj4gPiA+ID4gKyAgICAgICAgICAgICAgIHNlbF9maWVsZCA9IEZfTEVENF9E VVRZOwo+ID4gPgo+ID4gPiBNaXNzZWQgYnJlYWs7Cj4gPiA+Cj4gPiA+ID4gKyAgICAgICB9Cj4g PiA+Cj4gPiA+IC4uLgo+ID4gPgo+ID4gPiA+ICsgICAgICAgc3dpdGNoIChsZWRfbm8pIHsKPiA+ ID4gPiArICAgICAgIGNhc2UgTVQ2MzcwX0xFRF9JU05LMToKPiA+ID4gPiArICAgICAgICAgICAg ICAgc2VsX2ZpZWxkID0gRl9MRUQxX0ZSRVE7Cj4gPiA+ID4gKyAgICAgICAgICAgICAgIGJyZWFr Owo+ID4gPiA+ICsgICAgICAgY2FzZSBNVDYzNzBfTEVEX0lTTksyOgo+ID4gPiA+ICsgICAgICAg ICAgICAgICBzZWxfZmllbGQgPSBGX0xFRDJfRlJFUTsKPiA+ID4gPiArICAgICAgICAgICAgICAg YnJlYWs7Cj4gPiA+ID4gKyAgICAgICBjYXNlIE1UNjM3MF9MRURfSVNOSzM6Cj4gPiA+ID4gKyAg ICAgICAgICAgICAgIHNlbF9maWVsZCA9IEZfTEVEM19GUkVROwo+ID4gPiA+ICsgICAgICAgICAg ICAgICBicmVhazsKPiA+ID4gPiArICAgICAgIGRlZmF1bHQ6Cj4gPiA+ID4gKyAgICAgICAgICAg ICAgIHNlbF9maWVsZCA9IEZfTEVENF9GUkVROwo+ID4gPgo+ID4gPiBEaXR0by4KPiA+ID4KPiA+ ID4gPiArICAgICAgIH0KPiA+ID4KPiA+ID4gLi4uCj4gPiA+Cj4gPiA+ID4gKyAgICAgICBzd2l0 Y2ggKGxlZF9ubykgewo+ID4gPiA+ICsgICAgICAgY2FzZSBNVDYzNzBfTEVEX0lTTksxOgo+ID4g PiA+ICsgICAgICAgY2FzZSBNVDYzNzBfTEVEX0lTTksyOgo+ID4gPiA+ICsgICAgICAgY2FzZSBN VDYzNzBfTEVEX0lTTkszOgo+ID4gPiA+ICsgICAgICAgICAgICAgICAqYmFzZSA9IE1UNjM3MF9S RUdfUkdCMV9UUiArIGxlZF9ubyAqIDM7Cj4gPiA+ID4gKyAgICAgICAgICAgICAgIGJyZWFrOwo+ ID4gPiA+ICsgICAgICAgZGVmYXVsdDoKPiA+ID4gPiArICAgICAgICAgICAgICAgKmJhc2UgPSBN VDYzNzBfUkVHX1JHQl9DSFJJTkRfVFI7Cj4gPiA+Cj4gPiA+IERpdHRvLgo+ID4gPiBJdCBzZWVt cyB5b3UgZHJvcHBlZCB0aGVtIGZvciBhbGwgc3dpdGNoLWNhc2VzLiBJdCdzIG5vdCBnb290LCBw bGVhc2UKPiA+ID4gcmVzdG9yZSB0aGVtIGJhY2suCj4gPiA+Cj4gPiA+ID4gKyAgICAgICB9Cj4g PiA+Cj4gPiA+IC4uLgo+ID4gPgo+ID4gPiA+ICsgICAgICAgdTggdmFsW1BfTUFYX1BBVFRFUk5T IC8gMl0gPSB7MH07Cj4gPiA+Cj4gPiA+IHsgfSBzaG91bGQgc3VmZmljZQo+ID4gPgo+ID4gPgo+ ID4gSW4gdGhlIGFib3ZlIHJhbmdlIHNlbGVjdG9yLCB3ZSB1c2UgdGhlICdsb2dpYyBvcicgdG8g Z2VuZXJhdGUgdGhlCj4gdHlwbywgaXQncyAnYmVsb3cnLgo+ID4gcGF0dGVybiB2YWx1ZXMuCj4g PgpBaCwgZm91bmQgaW4gYzExIHN0YW5kYXJkIDYuNy45IGl0ZW0gMjEKSXQgaXMgdGhlIHNhbWUg YXMgJ3N0YXRpYyBzdG9yYWdlIGR1cmF0aW9uJy4KSSB3aWxsIGZvbGxvdyB5b3VyIGNvbW1lbnQg dG8gcmV2aXNlIGl0LgpUaGFua3MuCj4gPiBJZiB0byBjaGFuZ2UgaXQgZnJvbSAnezB9IHRvICd7 IH0nLCBpcyBpdCBjb3JyZWN0Pwo+ID4gPiA+ICsgICAgICAgLyoKPiA+ID4gPiArICAgICAgICAq IFBhdHRlcm4gbGlzdAo+ID4gPiA+ICsgICAgICAgICogdHIxOiBieXRlIDAsIGInWzc6IDRdCj4g PiA+ID4gKyAgICAgICAgKiB0cjI6IGJ5dGUgMCwgYidbMzogMF0KPiA+ID4gPiArICAgICAgICAq IHRmMTogYnl0ZSAxLCBiJ1s3OiA0XQo+ID4gPiA+ICsgICAgICAgICogdGYyOiBieXRlIDEsIGIn WzM6IDBdCj4gPiA+ID4gKyAgICAgICAgKiB0b246IGJ5dGUgMiwgYidbNzogNF0KPiA+ID4gPiAr ICAgICAgICAqIHRvZmY6IGJ5dGUgMiwgYidbMzogMF0KPiA+ID4gPiArICAgICAgICAqLwo+ID4g PiA+ICsgICAgICAgZm9yIChpID0gMDsgaSA8IFBfTUFYX1BBVFRFUk5TOyBpKyspIHsKPiA+ID4g PiArICAgICAgICAgICAgICAgY3VyciA9IHBhdHRlcm4gKyBpOwo+ID4gPiA+ICsKPiA+ID4gPiAr ICAgICAgICAgICAgICAgc2VsX3JhbmdlID0gaSA9PSBQX0xFRF9UT0ZGID8gUl9MRURfVE9GRiA6 IFJfTEVEX1RSRk9OOwo+ID4gPiA+ICsKPiA+ID4gPiArICAgICAgICAgICAgICAgbGluZWFyX3Jh bmdlX2dldF9zZWxlY3Rvcl93aXRoaW4ocHJpdi0+cmFuZ2VzICsgc2VsX3JhbmdlLAo+ID4gPiA+ ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjdXJyLT5k ZWx0YV90LCAmc2VsKTsKPiA+ID4gPiArCj4gPiA+ID4gKyAgICAgICAgICAgICAgIHZhbFtpIC8g Ml0gfD0gc2VsIDw8ICg0ICogKChpICsgMSkgJSAyKSk7Cj4gPiA+ID4gKyAgICAgICB9Cj4gPiA+ ID4gKwo+ID4gPiA+ICsgICAgICAgbWVtY3B5KHBhdHRlcm5fdmFsLCB2YWwsIDMpOwo+ID4gPiA+ ICsgICAgICAgcmV0dXJuIDA7Cj4gPiA+ID4gK30KPiA+ID4KPiA+ID4gLi4uCj4gPiA+Cj4gPiA+ ID4gK291dDoKPiA+ID4KPiA+ID4gb3V0X3VubG9jazoKPiA+ID4KPiA+ID4gPiArICAgICAgIG11 dGV4X3VubG9jaygmcHJpdi0+bG9jayk7Cj4gPiA+ID4gKwo+ID4gPiA+ICsgICAgICAgcmV0dXJu IHJldDsKPiA+ID4KPiA+ID4gLi4uCj4gPiA+Cj4gPiA+ID4gK291dDoKPiA+ID4KPiA+ID4gRGl0 dG8uIEFuZCBzbyBvbi4KPiA+ID4KPiA+ID4gPiArICAgICAgIG11dGV4X3VubG9jaygmcHJpdi0+ bG9jayk7Cj4gPiA+ID4gKwo+ID4gPiA+ICsgICAgICAgcmV0dXJuIHJldDsKPiA+ID4KPiA+ID4g Li4uCj4gPiA+Cj4gPiA+ID4gKyAgICAgICAgICAgICAgIHN1Yl9sZWQgPSBkZXZtX2t6YWxsb2Mo cHJpdi0+ZGV2LAo+ID4gPiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IHNpemVvZigqc3ViX2xlZCkgKiBNQ19DSEFOTkVMX05VTSwKPiA+ID4gPiArICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBHRlBfS0VSTkVMKTsKPiA+ID4KPiA+ID4gTklIIGRl dm1fa2NhbGxvYygpLiBBbHNvIGNoZWNrIGlmIHlvdSByZWFsbHkgbmVlZCB6ZXJvZWQgZGF0YS4K PiA+ID4KPiA+IE9rLCBhbmQgYWZ0ZXIgdGhlIGNoZWNrLCBJIGFsc28gbmVlZCB0byBhZGQgb25l IGxpbmUgdG8gc2V0IHRoZSBpbnRlbnNpdHkgdG8gMC4KPiA+ID4gPiArICAgICAgICAgICAgICAg aWYgKCFzdWJfbGVkKQo+ID4gPiA+ICsgICAgICAgICAgICAgICAgICAgICAgIHJldHVybiAtRU5P TUVNOwo+ID4gPgo+ID4gPiAuLi4KPiA+ID4KPiA+ID4gPiArICAgICAgICAgICAgICAgICAgICAg ICByZXQgPSBmd25vZGVfcHJvcGVydHlfcmVhZF91MzIoY2hpbGQsICJjb2xvciIsICZjb2xvcik7 Cj4gPiA+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgaWYgKHJldCkgewo+ID4gPiA+ICsgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgZGV2X2Vycihwcml2LT5kZXYsCj4gPiA+ID4gKyAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICJsZWQgJWQsIG5vIGNvbG9yIHNw ZWNpZmllZFxuIiwKPiA+ID4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgbGVkLT5pbmRleCk7Cj4gPiA+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBy ZXR1cm4gcmV0Owo+ID4gPgo+ID4gPiByZXR1cm4gZGV2X2Vycl9wcm9iZSguLi4pIDsgPwo+ID4g Pgo+ID4gPiBEaXR0byBmb3IgbWFueSBwbGFjZXMgaW4geW91ciBlbnRpcmUgc2VyaWVzLgo+ID4g Pgo+ID4gPiA+ICsgICAgICAgICAgICAgICAgICAgICAgIH0KPiA+ID4KPiA+ID4gLi4uCj4gPiA+ Cj4gPiA+ID4gKyAgICAgICBwcml2ID0gZGV2bV9remFsbG9jKCZwZGV2LT5kZXYsCj4gPiA+ID4g KyAgICAgICAgICAgICAgICAgICAgICAgICAgIHN0cnVjdF9zaXplKHByaXYsIGxlZHMsIGNvdW50 KSwgR0ZQX0tFUk5FTCk7Cj4gPiA+Cj4gPiA+IEF0IGxlYXN0IG9uZSBwYXJhbWV0ZXIgY2FuIGJl IHBsYWNlZCBvbiB0aGUgcHJldmlvdXMgbGluZS4KPiA+ID4KPiA+ID4gPiArICAgICAgIGlmICgh cHJpdikKPiA+ID4gPiArICAgICAgICAgICAgICAgcmV0dXJuIC1FTk9NRU07Cj4gPiA+Cj4gPiA+ IC0tCj4gPiA+IFdpdGggQmVzdCBSZWdhcmRzLAo+ID4gPiBBbmR5IFNoZXZjaGVua28KCl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJu ZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRw Oi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK