Re: [PATCH] regulator: rt5033: Use linear ranges to map all voltage selection

From: ChiYuan Huang <u0084500@gmail.com>
To: Mark Brown <broonie@kernel.org>
Cc: Axel Lin <axel.lin@ingics.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	LKML <linux-kernel@vger.kernel.org>,
	ChiYuan Huang <cy_huang@richtek.com>
Subject: Re: [PATCH] regulator: rt5033: Use linear ranges to map all voltage selection
Date: Tue, 6 Jul 2021 14:32:41 +0800	[thread overview]
Message-ID: <CADiBU39oN-OeHnw8xgJY21YX_uDyXBNRZPC8maG79fF806hLyw@mail.gmail.com> (raw)
In-Reply-To: <20210705165255.GD4574@sirena.org.uk>

Mark Brown <broonie@kernel.org> 於 2021年7月6日 週二 上午12:53寫道：
>
> On Fri, Jul 02, 2021 at 11:47:50PM +0800, ChiYuan Huang wrote:
> > ChiYuan Huang <u0084500@gmail.com> 於 2021年7月1日 週四 下午1:53寫道：
> > > Axel Lin <axel.lin@ingics.com> 於 2021年7月1日 週四 下午12:41寫道：
>
> > > From the regulator register in probe, it will get the current voltage
> > > from the IC.
> > > If the vout sel is not is over N_VOLTAGES, it will return the error number.
>
> > > But as I think it's the side effect to change the vout step num.
> > > To use the linear range is just to guarantee all vout sel range are included.
>
> > > That's my initial thoughts.
>
> >    Like as you said,  the first revision is from 2014.
> > It is almost EOL for this product.
> > To fix this seems redundant.
>
> Even if something is old it's still posible that people can use it, and
> if someone's done the work to fix it then why not?

Got it, I'll send the v2 patch to fix it.
Thanks.